[00:56:47] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/423817 [00:57:44] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/423817 (owner: Eileen) [00:58:39] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/423817 (owner: Eileen) [01:02:22] !log update civicrm - civicrm revision changed from d6855cd281 to 7010f0f5d6, config revision is 3b900436c9 [01:02:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:16:41] https://www.stuff.co.nz/technology/digital-living/99079476/12-craziest-conspiracy-theories-on-the-internet [02:49:11] nice sprint fodder... [02:50:52] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add yearly totals to WMF donor table - https://phabricator.wikimedia.org/T186165#4103047 (Eileenmcnaughton) Update - I've realised the reason for joining in the transactions is to get the refunds... [03:12:37] (PS1) Ejegg: WIP: bad code retry tests for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/423830 (https://phabricator.wikimedia.org/T176502) [03:18:44] /nick ejegg|away [03:21:57] derpppp [03:28:59] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, FR-Ingenico, FR-WMF-Audit, Unplanned-Sprint-Work: Ingenico audit download failing with auth error - https://phabricator.wikimedia.org/T191375#4103097 (Ejegg) [04:29:19] (PS1) Eileen: Add extension for reporting on possible fraudsters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/423831 (https://phabricator.wikimedia.org/T187262) [04:57:34] (PS2) Eileen: Add extension for reporting on possible fraudsters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/423831 (https://phabricator.wikimedia.org/T187262) [12:17:07] (Draft2) Umherirrender: Fix typo in word string [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423894 [13:09:06] (PS1) Umherirrender: Add missing use for namespace Wikimedia\Rdbms [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423906 [13:18:53] (PS2) Umherirrender: Add missing use for namespace Wikimedia\Rdbms [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423906 [13:20:39] (CR) Umherirrender: Add missing use for namespace Wikimedia\Rdbms (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423906 (owner: Umherirrender) [14:19:25] Wikimedia-Fundraising: IE11: dsk lg PTF opens immediately on banner load w/o amount selection - https://phabricator.wikimedia.org/T191417#4104692 (spatton) [14:27:20] Wikimedia-Fundraising: Chrome, Firefox, IE: dsk sm above infobox in certain languages - https://phabricator.wikimedia.org/T191419#4104738 (spatton) [14:38:54] Wikimedia-Fundraising: IE11 dsk sm: below 1390px in certain articles/languages, big jump on step 2 - https://phabricator.wikimedia.org/T191422#4104790 (spatton) [14:47:29] fr-tech ooh, we might just have to upgrade our python stuff to python3 [14:47:41] python 2, it turns out, doesn't support TLS1.1 [14:47:50] and new we can't get our Ingenico audit files [14:47:52] wat [14:48:00] :o [14:48:05] *now [14:48:17] so.... lemme see what that'll involve [14:48:24] that seems insane [14:48:33] aren't they still releasing new python 2 versions? [14:49:11] https://bugs.python.org/issue16692 [14:50:12] "Is there any chance of this being backported to Python 2.7?" "No, sorry. 2.7 only gets bug fixes." [14:50:21] https://docs.python.org/2/library/ssl.html#ssl.PROTOCOL_TLSv1_2 [14:50:30] oh hey [14:50:38] that sounds nicer [14:51:25] i'm almost disappointed, some reason to actually kill python 2 would be amazing [14:51:32] :) [14:51:37] yeah, I was a little excited [14:51:55] I think the syslog handler in 3 is less damaged too [14:57:36] Fundraising Dash, Fundraising-Backlog: Spike: allow dash to work with any campaign - https://phabricator.wikimedia.org/T191425#4104874 (DStrine) [15:01:07] Fundraising Dash, Fundraising-Backlog: Spike: allow dash to work with any campaign - https://phabricator.wikimedia.org/T191425#4104874 (Ejegg) The logic is mostly there for variable dates and target revenues. We'd have to make the country filters configurable, and store the different configurations in th... [15:11:35] cwd dang, no python-paramiko in jesse-backports [15:15:42] for python 3? [15:17:10] python 2 [15:17:22] but I'm not sure that's actually the component that we'd need to upgrade [15:17:35] (or even if it really was a TLS version problem) [15:18:53] oh gotcha [15:20:09] ejegg: my guess would be it uses system openssl [15:20:57] i would be pretty surprised if it was a TLS thing unless there is some specific lib pinned [15:20:58] the listing talks about it using SSH2 'as an alternative to SSL' [15:21:02] https://pypi.python.org/pypi/paramiko/1.15.0 [15:21:09] so... not sure what that means [15:21:39] but anyway, our downloader script definitely uses paramiko.transport [15:21:43] TLS1.1 is 12 years old [15:21:51] i would be surprised if we are running anything that doens't support it [15:21:54] nice [15:22:21] ok, I should look into credentials [15:30:10] Fundraising-Backlog, Wikimedia-Fundraising: Move fundraising support pages to donate.wikimedia.org - https://phabricator.wikimedia.org/T189668#4105120 (Pcoombe) a:Pcoombe [15:32:27] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", an... - https://phabricator.wikimedia.org/T186883#4105127 [15:35:14] strange, on Chrome dev tools I had to check "Hide data URLs" to see the event log request in the network tab [15:37:39] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", an... - https://phabricator.wikimedia.org/T186883#4105150 [15:43:48] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4105172 (CCogdill_WMF) Apologies for not replying on this yesterday. As 8am is pretty early... [15:44:02] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", an... - https://phabricator.wikimedia.org/T186883#4105173 [15:48:13] ejegg: whatever is going on here is pretty bewildering https://github.com/paramiko/paramiko/blob/master/paramiko/transport.py#L99-L101 [15:48:56] cwd yah, I was bumbling around in that code for a while and not feeling very enlightened [15:50:26] i see a bunch of cipher names but not a lot of...complicated math [15:50:43] and then it looks like it uses openssh [15:51:38] cwd so, I copied the key from /etc/fundraising/globalcollect-audit.yaml to my .ssh/config/_rsa [15:51:49] and I was able to generate a matching pubkey [15:51:58] which I want to send in a tech support ticket [15:52:10] but when I try to sftp from the command line with debug flags [15:52:30] I see a bunch of messages: key_load_public: invalid format [15:53:18] then when they keys are listed with their fingerprints I see it as 'nil' [15:53:28] key: /home/ejegg/.ssh/_rsa ((nil)), explicit [15:53:55] It doesn't have the Proc-Type or DEK-Info headers I see in some other key files [15:54:01] but I'm not sure how to add those [15:54:23] or if the absence of those might have made the pubkey I generated invalid [15:54:25] (PS1) AndyRussG: Add EventLogging beacon for all pageviews [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/423952 (https://phabricator.wikimedia.org/T185933) [16:24:42] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4105350 (mepps) Thursday morning is fine with me! I would run the refunds around 8:30/9am ES... [16:25:36] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4105351 (CCogdill_WMF) Sorry, can we do 8am *PST*? I won't be up to send the emails at my 5:... [16:26:46] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4105357 (mepps) @CCogdill_WMF See above. I would also mention in the email that we are going... [16:52:49] fr-tech, did we update civicrm sometime recently? [16:53:12] not super recently jgleeson, but we did update drupal, why? [16:53:50] having issues on vagrant loading civi [16:54:12] jgleeson: feb 14th we updated to 4.7.31 [16:54:21] what kind of issues? [16:54:30] white screen [16:54:36] gonna dig into it now [16:54:42] try browsing to /civicrm/upgrade too [16:55:00] Your database has already been upgraded to CiviCRM 4.7.21 [16:55:16] hmm, that's not quite current [16:56:25] jgleeson does the civicrm folder have the latest code? [16:59:06] just updated the submodules within crm [16:59:19] although the logs look old [16:59:38] civi feb and drupal nov [16:59:46] what's the last commit in civicrm? [17:00:49] should be something like 605691749039d5 [17:01:00] 'Update phpWord per merged to master' [17:01:03] Feb 27 [17:01:14] yep got that [17:01:17] hmm [17:01:25] and drupal was November [17:01:30] drupal should have something newer [17:02:08] ooh, weird, there's a Nov 2016 patch at the head of drupal [17:02:23] but below that is the Mar 28th 2018 security patch [17:02:50] is that "Re-apply WMF patches" tops for you too? [17:04:28] yeah I see that also [17:04:55] I also navigated to /civicrm/upgrade since updating and that failed [17:05:10] gonna see if I can work out what's up, looks vagrant specific [17:05:37] XenoRyet are you using the latest version of civicrm ok on vagrant? [17:06:51] Let me take a look. [17:07:02] It's been a while since I did a destroy and rebuild though. [17:07:29] I'm on master crm which pulled in [17:07:32] Entering 'civicrm' [17:07:33] commit 605691749039d575be4ce3eaf3c87c44b9f07afc [17:07:39] Entering 'drupal' [17:07:39] commit 9ca6a4c683deb7ad055a3fd8749759a9128ee50d [17:07:45] and since then, having issues [17:08:05] looks perms related [17:08:35] Actually XenoRyet it might be worth leaving it alone if your current checkout is working [17:09:01] until I can confirm whether it's my setup only or something wider [17:09:08] Heh, yea maybe I just won't touch it for now... ;-) [17:09:12] :) [17:18:59] fundraising-tech-ops: frdev access for rschoenbaechler - https://phabricator.wikimedia.org/T191446#4105679 (cwdent) [17:33:00] (CR) Ejegg: "Looks pretty good, just a couple questions!" (3 comments) [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/423952 (https://phabricator.wikimedia.org/T185933) (owner: AndyRussG) [17:39:09] fr-tech: any (last minute) scrum of scrums news? [17:39:22] None here. [17:39:24] ejegg: nothing here, thanks :) [17:41:43] nope~ [17:46:27] (CR) Nuria: [C: -1] Add EventLogging beacon for all pageviews (3 comments) [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/423952 (https://phabricator.wikimedia.org/T185933) (owner: AndyRussG) [18:04:02] fr-tech, it looks like the offending process is within wmf_civicrm_update_7615 relating to civi/drupal not running on vagrant [18:04:27] the update within wmf_civicrm_update_7615(), specifically civicrm_api3('extension', 'install', array('key' => 'org.wikimedia.geocoder')); fails [18:05:14] the internal exception complains about a missing column in an sql statement, Unknown column 'module_data' in 'field list' [18:07:11] that field, 'module_data' is expected within civicrm_menu [18:07:25] but isn't present for some reason, will see if I can track down where it came in [18:09:37] upgrade_4_7_25 [18:09:47] CRM-20927 - Add column to 'civicrm_menu' for additional metadata", 'addColumn', [18:09:47] 'civicrm_menu', 'module_data', "text COMMENT 'All other menu metadata not stored in other fields'" [18:19:38] fr-tech, worked out the vagrant issue and successfully updated local version of drupal and civicrm [18:19:50] Nice [18:19:53] XenoRyet, if you pull in the latest submodule updates to the crm project [18:21:38] and then run `sudo chown -R www-data:vagrant /vagrant/srv/org.wikimedia.civicrm/drupal/sites/default/files/civicrm/templates_c/` [18:22:59] you should then be able to browse to http://crm.local.wmftest.net:8080/civicrm/upgrade and then to http://crm.local.wmftest.net:8080/update.php [18:23:37] looks like civi tries to clear a load of template files prior to updating and fails due to perms [18:24:09] ok, back to the api explorer :) [18:45:57] Wikimedia-Fundraising-Banners, Browser-Support-Internet-Explorer: IE11 dsk sm: below 1390px in certain articles/languages, big jump on step 2 - https://phabricator.wikimedia.org/T191422#4106010 (Pcoombe) [18:47:50] Wikimedia-Fundraising-Banners: Chrome, Firefox, IE: dsk sm above infobox in certain languages - https://phabricator.wikimedia.org/T191419#4106011 (Pcoombe) [18:47:52] Wikimedia-Fundraising-Banners, Browser-Support-Internet-Explorer: IE11: dsk lg PTF opens immediately on banner load w/o amount selection - https://phabricator.wikimedia.org/T191417#4106012 (Pcoombe) [19:01:25] (CR) Thiemo Kreuz (WMDE): [C: 2] Fix typo in word string [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423894 (owner: Umherirrender) [19:06:48] (Merged) jenkins-bot: Fix typo in word string [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423894 (owner: Umherirrender) [19:07:00] !log re-enabled thank you mailer [19:07:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:09:31] (PS3) Umherirrender: Add missing use for namespace Wikimedia\Rdbms [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423906 [19:14:38] (CR) Thiemo Kreuz (WMDE): Add missing use for namespace Wikimedia\Rdbms (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423906 (owner: Umherirrender) [19:28:14] (CR) Umherirrender: Add missing use for namespace Wikimedia\Rdbms (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423906 (owner: Umherirrender) [20:27:06] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, Unplanned-Sprint-Work: Option to enforce CSP on banner previews and flag errors - https://phabricator.wikimedia.org/T190100#4063031 (Ejegg) p:Triage>High a:... [20:33:28] (CR) Ejegg: [C: -1] "Oops, there may be a better way to do this! Looks like we can set a 'tokenize' option on the initial createHostedPayment call instead, and" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [20:41:36] ejegg, would we get the token back from the createHostedPayment call? [20:41:51] so that we could add it to the queue as we're doing currently [20:42:18] if not it might change my implementation of the recurring handling [20:42:46] jgleeson: I think it will come back from the hostedPaymentStatusResponse [20:43:08] but I'm pretty sure we'll end up putting it in the same place [20:43:31] that is, I'm pretty sure we don't get a token until the donor has submitted their details [20:44:55] https://epayments-api.developer-ingenico.com/s2sapi/v1/en_US/java/hostedcheckouts/get.html#hostedcheckouts-get-response-200 [20:45:06] I see a 'tokens' key [20:45:19] yep, that's where i'd expect it [20:45:24] just about to try in the sandbox [20:45:25] would there ever be more than one? [20:45:41] that could make things tricky [20:45:45] I'm having a hard time figuring out why [20:45:51] hope we can assume just one [20:46:04] it'll already be a little tricky doing the unstaging with the array value [20:46:18] oh, but we may have handled that case before [20:46:23] ok, here goes [20:46:28] gl [20:49:05] oh cool, it got flattened to a single value [20:49:10] just need to tweak the mapping [20:49:39] (CR) Mepps: "Ejegg, should I wait for another patch on this?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [20:57:02] ejegg, mepps civicrm_contribution_recur has a processor_id and a payment_processor_id field. What is the former? [20:57:37] ooh, weird [20:57:57] (CR) Ejegg: [C: -1] "@mepps yes please, coming right up!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [20:58:01] jgleeson i think one is the type of processor (paypal, ingenico) and one is the specific instance but that's based on ejegg's notes so i might be wrong [20:58:24] @_@ [20:59:16] it looks like we default to '1' for processor_id within wmf_civicrm_message_contribution_recur_insert [21:00:01] (PS9) Ejegg: Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) [21:01:35] (PS10) Ejegg: Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) [21:06:05] (CR) Ejegg: "@mepps ok, ready for review." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [21:12:29] (CR) Ejegg: [C: -1] "oops, looks like a couple more fields to add...." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [21:21:03] (PS2) Jgleeson: WIP insert records (mostly dummy) for processors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/421663 (https://phabricator.wikimedia.org/T165695) (owner: Ejegg) [21:21:05] (PS1) Jgleeson: WIP: handle ingenico payment tokens within QueueConsumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424141 [21:21:10] (CR) jerkins-bot: [V: -1] WIP insert records (mostly dummy) for processors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/421663 (https://phabricator.wikimedia.org/T165695) (owner: Ejegg) [21:21:16] (CR) jerkins-bot: [V: -1] WIP: handle ingenico payment tokens within QueueConsumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424141 (owner: Jgleeson) [21:22:58] I really need to configure PhpStorm to play nice with drupal [21:24:13] bye all! [21:28:54] (PS11) Ejegg: Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) [21:35:47] the processor_id is really an identifier from the payment processor - in whatever format they use [21:38:00] not sure how much to make of it but the last round of seed emails have wound up in my 'junk' folder [21:52:04] (PS12) Ejegg: Ingenico: tokenize recurring payments [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421190 (https://phabricator.wikimedia.org/T163953) [21:55:29] (PS1) Ejegg: Ingenico: Create non-hosted payment (i.e. from token) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/424150 (https://phabricator.wikimedia.org/T163953) [21:55:55] oops, I thought we had already added that call to SmashPig! [21:56:22] (CR) jerkins-bot: [V: -1] Ingenico: Create non-hosted payment (i.e. from token) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/424150 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [22:01:52] (PS2) Ejegg: Ingenico: Create non-hosted payment (i.e. from token) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/424150 (https://phabricator.wikimedia.org/T163953) [22:02:17] (CR) jerkins-bot: [V: -1] Ingenico: Create non-hosted payment (i.e. from token) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/424150 (https://phabricator.wikimedia.org/T163953) (owner: Ejegg) [22:04:24] (PS3) Ejegg: Ingenico: Create non-hosted payment (i.e. from token) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/424150 (https://phabricator.wikimedia.org/T163953) [22:12:09] (PS1) Ejegg: WIP create payment from token [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/424152 [22:12:21] ok, gonna relocate while it's not raining... [23:29:13] ejegg: I'm looking at moving that do_not_solicit field over [23:29:38] the thing is I think I need to a) create the new field first & b) have triggers re-done by ops at that point in time [23:30:45] hmm - maybe that's not the problem I thought - I was worrying about a) name in civicrm_custom_field is unique & b) renaming the column would be a slow query BUT I guess name is not directly tied to column [23:33:11] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", an... - https://phabricator.wikimedia.org/T186883#4107143