[00:16:52] eileen: sorry! [00:17:12] I was afk and forgot to change status [00:18:59] ok, so the steps are: 0) stop everything 1) create new custom field in 'communications' 2) update triggers 3) copy over data 4) drop old field 5) update triggers again [00:19:03] ? [00:19:14] or... I guess the first trigger update could drop the one on the old field too [00:24:58] doesn't seem too bad! [00:24:59] ejegg: right - I guess so [00:25:47] just trying to create patches now [00:28:25] the thing is the name of the custom field needs to be moved but I think it's 'ok' [00:29:29] ALso - I am leaning a bit towards just creating the fields in the first instance - that way ops can stand down & the data move can happen outside an outage & then the drop can be later [00:57:30] (PS3) Eileen: Add extension for reporting on possible fraudsters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/423831 (https://phabricator.wikimedia.org/T187262) [00:57:55] (PS4) Eileen: Add extension for reporting on possible fraudsters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/423831 (https://phabricator.wikimedia.org/T187262) [01:04:33] (Abandoned) Eileen: WIP start looking at fraud reports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/419654 (owner: Eileen) [01:12:05] (PS1) Eileen: Add new do_not_solicit field as additional view only field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424178 [01:12:46] (PS5) Eileen: Add extension for reporting on possible fraudsters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/423831 (https://phabricator.wikimedia.org/T187262) [01:16:13] (PS1) Eileen: Add donor totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424179 (https://phabricator.wikimedia.org/T186168) [01:16:24] (CR) jerkins-bot: [V: -1] Add new do_not_solicit field as additional view only field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424178 (owner: Eileen) [01:20:28] (CR) jerkins-bot: [V: -1] Add donor totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424179 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [02:22:49] (PS2) Eileen: Add new do_not_solicit field as additional view only field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424178 [02:27:47] (PS2) Eileen: Add donor totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424179 (https://phabricator.wikimedia.org/T186168) [02:55:52] (PS1) Eileen: Apply drupal formatting to wmf_dates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424184 [02:55:54] (PS1) Eileen: Let's not create so many years of date fields in advance. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424185 [03:15:40] (PS1) Eileen: Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 [03:15:42] (PS1) Eileen: Finally drop old do_not_solicit field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424187 [04:14:06] (PS3) Eileen: Add donor totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424179 (https://phabricator.wikimedia.org/T186168) [04:15:57] (CR) jerkins-bot: [V: -1] Add donor totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424179 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [04:57:03] (PS4) Eileen: Add donor totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424179 (https://phabricator.wikimedia.org/T186168) [04:57:57] (PS2) Eileen: Apply drupal formatting to wmf_dates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424184 [04:58:16] (PS2) Eileen: Let's not create so many years of date fields in advance. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424185 [04:59:04] formatting only patch if anyone wants to CR https://gerrit.wikimedia.org/r/#/c/424184/ [04:59:18] (CR) jerkins-bot: [V: -1] Add donor totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424179 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [05:01:44] (PS5) Eileen: Add donor totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424179 (https://phabricator.wikimedia.org/T186168) [05:08:34] (PS1) Eileen: Process eq as a report op [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/424191 [05:45:52] (PS1) Eileen: Use list of enabled extensions to track in install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424199 (https://phabricator.wikimedia.org/T187262) [05:45:54] (PS1) Eileen: Enable fraud report. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424200 (https://phabricator.wikimedia.org/T187262) [11:50:12] (PS4) Thiemo Kreuz (WMDE): Add missing use for namespace Wikimedia\Rdbms [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423906 (owner: Umherirrender) [11:50:17] (CR) Thiemo Kreuz (WMDE): [C: 2] Add missing use for namespace Wikimedia\Rdbms [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423906 (owner: Umherirrender) [13:20:44] (PS2) Jgleeson: WIP: handle ingenico payment tokens within QueueConsumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424141 [13:20:55] (CR) jerkins-bot: [V: -1] WIP: handle ingenico payment tokens within QueueConsumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424141 (owner: Jgleeson) [13:22:35] (PS3) Jgleeson: WIP: handle ingenico payment tokens within QueueConsumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424141 [13:22:46] (CR) jerkins-bot: [V: -1] WIP: handle ingenico payment tokens within QueueConsumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424141 (owner: Jgleeson) [13:27:05] ejegg, eileen explained last night that the processor_id within the civicrm_contribution_recur table is the external payment processor reference, which I think we also store as trxn_id [13:27:32] ok, that sounds reasonable [13:27:44] just looking at your code now [13:27:56] I'm just testing a transaction [13:27:58] using it [13:28:43] also, I set my ide coding styles to drupal but there's still some weirdness going on with spacing and new line formatting here: https://gerrit.wikimedia.org/r/#/c/424141/3/sites/all/modules/wmf_civicrm/recurring.inc@66 [13:29:18] oh, with the else keywords on new lines? [13:29:51] that and the use of 4 spaces over 2 for tabs [13:30:43] I also checked here https://www.drupal.org/docs/develop/standards/coding-standards#indenting [13:30:53] huh, well it doesn't look too bad to fix [13:32:12] should we be using more than 2 spaces for tabs in the wmf drupal code? [13:32:22] looks like 4 is used in some places [13:33:36] oh, I think 2 is what we've been reformatting stuff to [13:33:48] note that we haven't yet reformatted all of the files [13:34:40] ah ok, that makes sense. I wanna steer clear of aggressive partial file reformatting [13:35:07] It might make more sense to just reformat the whole file, once style is confirmed [13:35:10] jgleeson: so far, if we're editing something that hasn't been reformatted yet [13:35:28] we'll generally add a preliminary patch to reformat all the files we're going to touch [13:35:39] git it [13:35:41] so someone can code review that with e.g. git log -p -w [13:35:41] got it* [13:35:44] hehe [13:36:00] bitten by the git bug [13:36:07] :) [13:37:13] I've been really impressed by the civi API explorer [13:37:27] lots of good work gone into that to help adopters [13:56:58] ejegg, do have a few minutes to jump on a chat? I wanted to talk through some of my assumptions around the recurring payments code and get your thoughts on how to test for non-ingenico scenarios [14:04:05] jgleeson: sure, one sec and i'll be in the usual chat [14:05:35] jgleeson: ok, i'm in the chat [14:05:55] so, you want to make sure you're not breaking the code for old globalcollect and paypal? [14:58:51] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4108947 (mepps) @CCogdill_WMF just saw your message. Everything is ready to go now, just nee... [14:59:33] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4108950 (mepps) Actually, I saw your note this morning :) so didn't run anything. But I only... [15:19:20] fr-tech: here's a little patch to delay thank you letters an hour for imported donations [15:19:23] https://gerrit.wikimedia.org/r/423799 [15:19:32] I don't think it'll slow down that query by much [15:36:32] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", and... - https://phabricator.wikimedia.org/T185933#4109098 [15:37:55] I'm a little patch, short and stout, here is my handle, here is my spout [15:38:38] Sorry, we just finished watching West Side Story last night, everything has music to it now [15:41:18] lol [15:41:42] AndyRussG, have you seen the greatest showman? [15:41:57] jgleeson: no, never heard of it [15:42:26] oh really, it's a new one I think [15:42:44] Roxy watched it recently and enjoyed it, it's another musical [15:42:52] based on the circus, or the guy who invented the circus [15:43:21] oh cool [15:43:27] I'll check it out, thx!! [15:45:19] yeah apparently it's fun for all ages! [15:45:43] which reminds me, there's a circus in town here and I haven't been to a circus for about 15 years [15:54:49] (PS4) Jgleeson: WIP: handle ingenico payment tokens within QueueConsumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424141 [15:54:59] (CR) jerkins-bot: [V: -1] WIP: handle ingenico payment tokens within QueueConsumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424141 (owner: Jgleeson) [16:30:06] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", and... - https://phabricator.wikimedia.org/T185933#3929004 [17:10:56] ejegg, I've been trying to make the recurring branch merge-able but it looks like XenoRyet has claimed wmf_civicrm update 7635 here https://github.com/wikimedia/wikimedia-fundraising-crm/commit/c16fef523a64d3d9fe06b69adb08d70e1de7225b which runs into this https://gerrit.wikimedia.org/r/#/c/421663/2/sites/all/modules/wmf_civicrm/wmf_civicrm.install . Do you want me to bump up the upgrade version and resubmit? [17:15:21] Fundraising-Backlog, FR-Adyen: Adyen audit wobble: 3/16 refunds & chargeback not in Civi - https://phabricator.wikimedia.org/T190594#4109613 (MBeat33) We're seeing more recent cases where Ingenico & Civi are diverging. In some cases we manually refunded the most recent of a recurring donation, and it app... [17:19:08] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog: Ingenico audit wobble? March 13 refunds not in Civi - https://phabricator.wikimedia.org/T190098#4109637 (MBeat33) We're seeing more recent cases where Ingenico & Civi are diverging. In some cases we manually refunded the most recen... [17:31:21] jgleeson: ok, should be fine just to renumber it, right? [17:32:05] I think so [17:32:23] I'll try it and run the update again [17:32:43] I just tested the globalcollect recurring with the new recurring stuff and it went through fine [17:33:02] do you think that's enough or should I try out paypal express for good measure ? [17:34:31] jgleeson: if it's not too much trouble, that would be great [17:34:43] actually, I'll renumber that one - it was my patch [17:35:04] I guess I can un-WIP it anyway [17:36:15] is there a system to the update increments, looks like the latest ones bump up by 5 [17:37:10] yeah, we were doing 10s [17:37:21] but I started doing some 5s for really minor ones [17:37:26] cool [17:37:27] and that seems to have caught on [17:37:48] I think the '7' at the start is supposed to be a reference to drupal 7 [17:37:51] dunno [17:38:21] https://api.drupal.org/api/drupal/modules%21system%21system.api.php/function/hook_update_N/7.x [17:38:24] looks that way [17:42:14] (PS3) Ejegg: Insert records (mostly dummy) for processors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/421663 (https://phabricator.wikimedia.org/T165695) [17:42:36] oops, problems with the payment_processor_type_id... ^^^ needs another fix [17:47:24] what's the problem ejegg? I don't see anything [17:47:48] jenkins seems to like it [17:48:09] if I run it locally, I get 'payment_processor_type_id is not valid : adyen' [17:48:17] ahhh [17:48:45] for some reason i have a hard time debugging stuff run via drush updb [17:48:58] i think it starts a couple of intermediate processes [17:49:36] yeah xdebug is a lifesaver for debugging drush [17:50:17] although can be tricky to remember how to do it, after not doing it for a while [17:50:46] I should write it down and stick it on my whiteboard, save me 10 minutes of digging around each time heh [17:51:47] ahh, for the updb command, if I do drush -v -v updb, it outputs the command line of the intermediate thing [17:52:16] and then I can run that with debugging [17:53:01] nice [17:55:43] I think php added it's own debugger a few version back [17:55:47] pdpdg? [17:56:13] https://phpdbg.room11.org/introduction.html [17:58:15] whoa [17:59:57] ah, looks like the IDE crowd haven't taken to it https://youtrack.jetbrains.com/issue/WI-21414 [18:02:42] ejegg, I just remembered I still haven't patched the ct_id bug you found here https://phabricator.wikimedia.org/T190871 [18:05:17] (PS4) Ejegg: Insert records (mostly dummy) for processors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/421663 (https://phabricator.wikimedia.org/T165695) [18:05:26] jgleeson: oh right, that one [18:05:35] Let me look into that some more [18:06:33] well, PS4 gets all the records created, there's just one annoying bug, maybe in the paymentprocessor api [18:06:49] that creates the records with is_active=NULL [18:07:18] ejegg, is there a place to find test env gateway urls? I'm sure I've seen it somewhere... my bookmarks are failing me [18:07:52] ah it was this https://www.mediawiki.org/wiki/Fundraising_tech#Documents [18:09:57] jgleeson: ah, also on frpm1001, in the settings dir [18:10:07] there should be some sandbox credentials [18:10:16] in payments-wiki-test or the like [18:10:37] awesome [18:10:55] I'll route out the paypalexpress url and credentials first thing tomorrow [18:11:00] I'm calling it a day [18:11:03] bye all! [18:36:41] (PS5) Ejegg: Insert records (mostly dummy) for processors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/421663 (https://phabricator.wikimedia.org/T165695) [18:41:02] (CR) Ejegg: "dang, now this is only creating Adyen + the paypal ones... what's up with that? caching?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/421663 (https://phabricator.wikimedia.org/T165695) (owner: Ejegg) [18:54:16] (PS6) Ejegg: Insert records (mostly dummy) for processors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/421663 (https://phabricator.wikimedia.org/T165695) [18:54:59] (CR) Ejegg: "Aha, I had been calling the get with null name for all but the paypal ones.... no caching weirdness at all. This is ready for review!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/421663 (https://phabricator.wikimedia.org/T165695) (owner: Ejegg) [22:26:08] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, FR-Astropay, MediaWiki-extensions-DonationInterface: Update API address for d*Local - https://phabricator.wikimedia.org/T187809#4110476 (Ejegg) a:Ejegg [22:59:59] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", and... - https://phabricator.wikimedia.org/T185933#4110581 [23:32:55] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", and... - https://phabricator.wikimedia.org/T185933#4110675