[04:06:38] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", and... - https://phabricator.wikimedia.org/T185933#4110922 [05:25:39] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", and... - https://phabricator.wikimedia.org/T185933#4110982 [08:26:23] (PS5) Umherirrender: Add missing use for namespace Wikimedia\Rdbms [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423906 [08:27:14] (CR) Umherirrender: "I have removed the interface change and the depending on, because there is no need to wait on the core change here for the addition of use" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423906 (owner: Umherirrender) [08:38:36] (CR) Thiemo Kreuz (WMDE): [C: 2] Add missing use for namespace Wikimedia\Rdbms [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423906 (owner: Umherirrender) [08:48:39] (Merged) jenkins-bot: Add missing use for namespace Wikimedia\Rdbms [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/423906 (owner: Umherirrender) [10:59:34] (PS1) Umherirrender: Fix parameter docs [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/424563 [12:40:11] PROBLEM - check_puppetrun on pay-lvs2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [12:45:11] PROBLEM - check_puppetrun on payments1004 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [12:45:12] RECOVERY - check_puppetrun on pay-lvs2001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [12:50:11] PROBLEM - check_puppetrun on frbackup2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [12:50:11] RECOVERY - check_puppetrun on payments1004 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [12:50:39] grr. puppet-- [12:55:11] PROBLEM - check_puppetrun on frbackup2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [13:00:11] RECOVERY - check_puppetrun on frbackup2001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [14:35:05] Fundraising-Backlog, MediaWiki-extensions-Other, Documentation: Create https://www.mediawiki.org/wiki/Extension:FundraisingTranslateWorkflow - https://phabricator.wikimedia.org/T167996#4112191 (Umherirrender) [14:42:41] (PS1) Ejegg: Update dLocal api address [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/424604 (https://phabricator.wikimedia.org/T187809) [14:43:26] fr-tech anyone around to review that ^^^ ? [14:43:37] i can take a look ejegg [14:43:44] Thanks! [14:44:01] this is related to the email pats sent around yesterday [14:49:29] (CR) Mepps: [C: 1] "This looks good and pretty straightforward, but do you have documentation on the sandbox url? I couldn't .find that in the email" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/424604 (https://phabricator.wikimedia.org/T187809) (owner: Ejegg) [14:50:12] (CR) Mepps: [C: 1] "I also wonder if long-term (not now) we should change the AstroPay namespace to dlocal." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/424604 (https://phabricator.wikimedia.org/T187809) (owner: Ejegg) [14:54:33] mepps I got the sandbox url from here: https://dlocal.com/documentation.php?sec=full-api#environment [14:54:50] but it looks like there might actually be more to do :( [14:55:03] now that I read it closer [14:55:36] there seems to be a different subdomain for the txn functions and for the status functions in the live environment [14:55:57] ah snap, and we should make sure that's all whitelisted [14:56:03] ok, more to do.... [15:38:30] ejegg: so wrt csp, you're pretty sure you want to go with a global config variable setting the exact header contents, I guess? [15:38:44] Seems okok for a temporary solution [15:39:10] doesn't quite feel right for the long term, mebbe I'm wrong tho [15:39:15] Is that what core is doing? [15:41:03] AndyRussG: nope, core is calculating it based on a whole bunch of other settings [15:42:40] hmmm ok [15:43:26] do you think there's any substance to my gut saying don't put header content in a config var? [15:43:49] https://gerrit.wikimedia.org/r/#/c/253969/35/includes/ContentSecurityPolicy.php line 160 [15:44:22] * AndyRussG scans rule book [15:45:09] K that looks pretty involved [15:46:40] yeah... I was reluctant to copy it all [15:48:27] ejegg: what's the counterargument to just making the CN config variable boolean, and the header string a constant or something? [15:48:44] I'm ok with leaving it as is if u think that's best, btw :) [15:49:06] AndyRussG: the header string will include a ton of wikipedia-specific domains [15:49:56] ejegg: ah ok I see... So it won't be just the "default-src data: blob: 'unsafe-inline' 'unsafe-eval' 'self';" suggested in the README [15:50:23] I guess that suggestion is aimed at local dev/testing, no? [15:50:26] not if we want to allow images from commons, maps from maps, etc [15:50:41] mmm [15:51:07] k gotcha :) [16:14:34] Wikimedia-Fundraising-Banners, I18n, RTL: RTL issues in fundraising banners - https://phabricator.wikimedia.org/T188416#4112470 (Pcoombe) Thanks @schoenbaechler, I'll work on integrating these into current best. For the inputs, Amir assured us previously that amount and email inputs should always be... [16:19:39] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect: need new ct_id after successful donation - https://phabricator.wikimedia.org/T190871#4112479 (XenoRyet) a:jgleeson>XenoRyet [18:12:56] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4112836 (MBeat33) Is cid=2835935 one of the batch of PayPal subscriptions that were canceled... [18:21:24] Fundraising-Backlog, FR-PayPal-ExpressCheckout: Paypal EC orphan rectifier fails with validation failure - https://phabricator.wikimedia.org/T191654#4112864 (Ejegg) [19:11:12] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Remove unused code for banner preview in banner editor - https://phabricator.wikimedia.org/T161907#4112962 (Base) Can this task be reversed to actually add a banner preview while editing? When creating banners... [19:18:42] XenoRyet: did you see MBeat's last question on https://phabricator.wikimedia.org/T190854 ? Did you check in the csv files? [19:24:40] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, FR-Astropay, MediaWiki-extensions-DonationInterface, Patch-For-Review: Update API address for d*Local - https://phabricator.wikimedia.org/T187809#4113009 (Ejegg) conflict between email and new dev page (https://dlocal.c... [19:29:24] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, FR-Ingenico, FR-WMF-Audit, Unplanned-Sprint-Work: Ingenico audit download failing with auth error - https://phabricator.wikimedia.org/T191375#4103097 (Ejegg) Open>Resolved a:Ejegg Nothing to worry about, it... [19:31:00] ejegg: I'll see what I can find. [19:43:45] brb, gotta pick up food for the family [20:30:09] PROBLEM - check_puppetrun on samarium is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [20:35:09] PROBLEM - check_puppetrun on samarium is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [20:40:09] RECOVERY - check_puppetrun on samarium is OK: OK: Puppet is currently enabled, last run 17 seconds ago with 0 failures [20:48:56] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4113276 (XenoRyet) This was in the batch, and the email was included in the list of subscrip... [21:06:42] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4113306 (MBeat33) Thanks, @XenoRyet I-KE204H5HF8WU is another one PayPal did not get, so I... [21:44:10] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4113399 (XenoRyet) @MBeat33 I'll poke around and see what I can find, but I think @mepps was... [22:01:39] (CR) AndyRussG: "Just a few minor things:" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/420754 (https://phabricator.wikimedia.org/T190100) (owner: Ejegg) [22:25:22] (CR) Ejegg: "Thanks for the review! I'll add the FIXME to the code. If you find those docs, please let me know. I was just going by the hook closest to" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/420754 (https://phabricator.wikimedia.org/T190100) (owner: Ejegg) [23:46:40] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4113661 (MBeat33) Thanks, @XenoRyet [23:53:36] (CR) Legoktm: [C: 2] Fix parameter docs [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/424563 (owner: Umherirrender)