[04:05:11] PROBLEM - check_procs on frdev1001 is CRITICAL: PROCS CRITICAL: 1230 processes [04:10:11] RECOVERY - check_procs on frdev1001 is OK: PROCS OK: 278 processes [04:25:11] PROBLEM - check_procs on frdev1001 is CRITICAL: PROCS CRITICAL: 1289 processes [04:30:11] RECOVERY - check_procs on frdev1001 is OK: PROCS OK: 286 processes [14:16:22] Fundraising-Backlog, fundraising-tech-ops: Alert fatigue: "frdev1001/check_procs is CRITICAL" - https://phabricator.wikimedia.org/T191798#4116823 (cwdent) [14:59:06] morningz [15:01:24] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, and 8 others: Mediawiki namespace pages, including CentralNotice banners, are slow to sa... - https://phabricator.wikimedia.org/T158084#4117129 [15:06:30] hi fr-tech! [15:06:36] Fundraising Sprint Deferential Equations, Fundraising Sprint English Cuisine, Fundraising Sprint Far Beer, Fundraising Sprint Gondwanaland Reunification Engine, and 8 others: Mediawiki namespace pages, including CentralNotice banners, are slow to sa... - https://phabricator.wikimedia.org/T158084#4117167 [15:06:37] ejegg: hey :) [15:06:49] hey ejegg AndyRussG :) [15:06:55] hi AndyRussG jgleeson mepps ! [15:08:39] ejegg, I'm not sure if mepps is around [15:08:54] she messaged me a little earlier saying james wasn't too keen on her being on her laptop [15:09:05] so I think she's hopped off to look after him [15:09:11] oh right, I see her email now [15:11:42] cwd / Jeff_Green I just got confirmation of two new IP addresses for d*Local's API [15:11:53] made a ticket for the whitelist update: https://phabricator.wikimedia.org/T191669 [15:12:00] sounds good [15:12:17] unfortunately I didn't think about the IP addresses till pretty close to the deadline, this coming weekend :( [15:12:33] ok [15:12:42] i can make our changes shortly, but then it's up to net ops [15:12:49] thanks! [15:12:52] but usually that's not more than a day [15:12:56] in my experience [15:13:00] nice [15:13:17] well, fortunately we're not doing any big fundraising in latin america right now [15:43:49] jgleeson: hi! :) [15:48:26] nick jgleeson|away [15:48:27] ah, everytime [16:51:40] (PS2) AndyRussG: Add EventLogging beacon for all pageviews [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/423952 (https://phabricator.wikimedia.org/T185933) [17:48:38] (CR) Ejegg: "Code looks correct, just a couple questions on naming" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424178 (owner: Eileen) [17:50:50] (CR) Ejegg: "Want to squash the totals code from the parent patch into this one?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424179 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [17:52:07] (CR) Ejegg: [C: 2] Apply drupal formatting to wmf_dates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424184 (owner: Eileen) [17:52:26] (CR) Ejegg: [C: 2] Let's not create so many years of date fields in advance. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424185 (owner: Eileen) [17:56:34] (Merged) jenkins-bot: Apply drupal formatting to wmf_dates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424184 (owner: Eileen) [17:57:03] (Merged) jenkins-bot: Let's not create so many years of date fields in advance. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424185 (owner: Eileen) [17:57:52] fr-tech I got confirmation on the api endpoint URLs, this is ready for +2: https://gerrit.wikimedia.org/r/424604 [17:58:14] (deployment will need to wait for this firewall change: https://phabricator.wikimedia.org/T191669) [17:58:21] lemme note that... [18:00:00] is https://api.dlocal.com/ only accessible to specific ips ? [18:00:02] (PS2) Ejegg: Update dLocal api address [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/424604 (https://phabricator.wikimedia.org/T187809) [18:00:58] jgleeson: the whitelist that needs updating is on our side, the list of IPs that payments is allowed to contact [18:01:14] ahhh I see [18:01:25] ok, gonna grab some grub... [18:02:41] mepps: One more minute then I'll be in our checkin [18:03:10] XenoRyet: I won’t be there—James isn’t up for video calls [18:03:36] Oh, ok. No worries then. I didn't have much anyway. Hope James feels better soon. [18:21:18] (CR) Jgleeson: "looks good to me!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/424604 (https://phabricator.wikimedia.org/T187809) (owner: Ejegg) [18:45:05] ejegg, I'm still struggling to simulate the IPN notification. Current status is that I can hit the PayPal listener locally, but the payload doesn't appear to be getting picked up. I'm wondering if I need to wrap it in something.. or maybe add some additional headers to the request? [18:45:30] jgleeson: shoot, sorry, I guess you could just put it right in the queue [18:45:37] jobs-paypal [18:45:44] should take the same format [18:46:01] so just drop a message on that redis queue ? [18:46:02] ooh, right, because the listener DOES post back to the verification service [18:46:14] jgleeson: yep, the redis queue [18:46:32] ok cool, what should I then use to consume/process/persist to civi? [18:46:47] or is that a pre-req to the other script [18:48:01] one sec, looking up the command to process the jobs-paypal queue [18:49:58] /usr/bin/php /srv/www/org/wikimedia/listeners/SmashPig/Maintenance/QueueJobRunner.php --queue jobs-paypal --config-node paypal [18:50:11] jgleeson: ^^ [18:50:49] anyway, THAT job should normalize the IPN format to recurring queue format [18:51:01] and then you'll run the recurring queue consumer in drush [18:51:21] drush rqc [18:58:51] thanks! [19:06:40] (CR) Ejegg: [C: 2] "Code looks great. Can't wait to see this in production!" [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/423952 (https://phabricator.wikimedia.org/T185933) (owner: AndyRussG) [19:08:28] (Merged) jenkins-bot: Add EventLogging beacon for all pageviews [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/423952 (https://phabricator.wikimedia.org/T185933) (owner: AndyRussG) [19:14:49] ejegg: thx! [19:31:27] (CR) AndyRussG: "Thanks much, all... @Nuria the point about the sampling seems really important... Fortunately, for this patch, sampling is just to make in" (5 comments) [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/423952 (https://phabricator.wikimedia.org/T185933) (owner: AndyRussG) [19:38:48] Fundraising-Backlog: Give John Bennet a full tour of fr-tech systems - https://phabricator.wikimedia.org/T191833#4118189 (DStrine) [19:41:20] (PS5) Ejegg: Emit CSP headers on banner previews [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/420754 (https://phabricator.wikimedia.org/T190100) [19:44:32] (PS6) Ejegg: Emit CSP headers on banner previews [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/420754 (https://phabricator.wikimedia.org/T190100) [21:17:57] ejegg, it looks like the QueueConsumer checks for the presence of a key "php-message-class" here https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/8132ebaf18365ceaf7e5c4f90ebb0390ca21d6bf/Core/QueueConsumers/JobQueueConsumer.php#L20 but that field isn't present in either of the samples messages, e.g. https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/master/PaymentProviders/PayPal/Tests/Data/recurring [21:17:57] _payment.json [21:18:02] https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/master/PaymentProviders/PayPal/Tests/Data/recurring_payment.json * [21:22:10] I can see in one of the tests, a mention of 'payload' so I'm wondering whether the sample message body should go within payload [21:27:02] ok I think i've got it [21:27:27] the php-message-class is added here: https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/8132ebaf18365ceaf7e5c4f90ebb0390ca21d6bf/Core/Jobs/RunnableJob.php#L15 [21:27:57] jgleeson: shoot, sorry [21:28:03] was on the phone with Lenovo [21:28:13] sounds like you figured it out, though? [21:28:31] and the $job->payload property is then set here https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/8132ebaf18365ceaf7e5c4f90ebb0390ca21d6bf/PaymentProviders/PayPal/Listener.php#L41 [21:28:52] argh, that's right. And it's all kinds of escaped [21:29:03] sorry to lead you astray like that [21:29:30] I think so! np at all, it's actually been a really good learning exercise to understand what's going on within SmashPig! [21:30:01] well at least some good came of it! [21:30:27] you making progress with your laptop battery? [21:32:31] kept getting disconnected, gonna try again from the apartment later [21:35:15] ejegg: did you have a problem battery?? [21:35:29] i never did the recall [21:35:32] well i did it myself [21:36:40] cwd I got it inspected and the tech said my battery was fine [21:36:46] tightened up a few screws [21:37:04] but in the month or so since, the battery life has gone down to like 5 min [21:37:11] whoa [21:37:24] any heat issues? [21:37:27] so... wondering if the tech messed it up somehow [21:37:31] no, no heat issues [21:37:42] maybe just a sensor problem? [21:37:59] freaky [21:38:08] those batteries are scary [21:55:08] (PS3) Eileen: Add new do_not_solicit field as additional view only field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424178 [22:01:45] (PS4) Eileen: Add new do_not_solicit field as additional view only field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424178 [22:03:46] (CR) Eileen: "I've removed the addition of additional total fields for this & just adding the new do_not_solicit field. The patch as it is is near insta" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424178 (owner: Eileen) [22:19:40] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add yearly totals to WMF donor table - https://phabricator.wikimedia.org/T186165#4118767 (Eileenmcnaughton) a:Eileenmcnaughton [22:27:25] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4118790 (MBeat33) @XenoRyet @mepps cid=22340511 Transaction ID I-EJLMB2VCY7G2 is another o... [22:27:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Improve ability to retrieve donor overviews from CiviCRM - https://phabricator.wikimedia.org/T191849#4118791 (Eileenmcnaughton) [22:29:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Export to pdf does not work on contact detail reprot - https://phabricator.wikimedia.org/T190873#4118803 (Eileenmcnaughton) [22:29:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Improve ability to retrieve donor overviews from CiviCRM - https://phabricator.wikimedia.org/T191849#4118802 (Eileenmcnaughton) [22:30:07] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", an... - https://phabricator.wikimedia.org/T186883#4118804 [22:30:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Improve ability to retrieve donor overviews from CiviCRM - https://phabricator.wikimedia.org/T191849#4118791 (Eileenmcnaughton) [22:30:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi notes field is not WYSIWYG - https://phabricator.wikimedia.org/T190872#4118806 (Eileenmcnaughton) [22:30:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add export to word to Contact detail report - https://phabricator.wikimedia.org/T191850#4118808 (Eileenmcnaughton) [22:31:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Move transaction ID field down for check donations - https://phabricator.wikimedia.org/T191851#4118819 (LeanneS)