[00:00:27] (PS1) Eileen: Fix missing email fails threshold field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425724 (https://phabricator.wikimedia.org/T187262) [00:01:32] (PS2) Eileen: Fix missing email fails threshold field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425724 (https://phabricator.wikimedia.org/T187262) [00:03:45] (CR) jerkins-bot: [V: -1] Fix missing email fails threshold field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425724 (https://phabricator.wikimedia.org/T187262) (owner: Eileen) [00:04:04] (PS1) Eileen: Submodule update on CiviCRM 1b92ac7 Process eq as a report op [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425725 [00:04:18] (CR) jerkins-bot: [V: -1] Submodule update on CiviCRM 1b92ac7 Process eq as a report op [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425725 (owner: Eileen) [00:04:47] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/424191 (owner: Eileen) [00:08:47] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425724 (https://phabricator.wikimedia.org/T187262) (owner: Eileen) [00:09:12] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425725 (owner: Eileen) [00:09:16] (CR) jerkins-bot: [V: -1] Process eq as a report op [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/424191 (owner: Eileen) [00:09:18] (CR) Eileen: [C: 2] Submodule update on CiviCRM 1b92ac7 Process eq as a report op [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425725 (owner: Eileen) [00:09:29] (CR) jerkins-bot: [V: -1] Submodule update on CiviCRM 1b92ac7 Process eq as a report op [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425725 (owner: Eileen) [00:09:32] (CR) jerkins-bot: [V: -1] Submodule update on CiviCRM 1b92ac7 Process eq as a report op [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425725 (owner: Eileen) [00:11:17] (CR) jerkins-bot: [V: -1] Fix missing email fails threshold field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425724 (https://phabricator.wikimedia.org/T187262) (owner: Eileen) [00:15:13] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425724 (https://phabricator.wikimedia.org/T187262) (owner: Eileen) [00:15:34] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/424191 (owner: Eileen) [00:16:29] (CR) Ejegg: [C: 2] Process eq as a report op [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/424191 (owner: Eileen) [00:23:14] (Merged) jenkins-bot: Process eq as a report op [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/424191 (owner: Eileen) [00:23:52] (CR) Ejegg: [C: 2] "Looking good (along with the follow-on email threshold patch). Nice convenience links & formatting!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/423831 (https://phabricator.wikimedia.org/T187262) (owner: Eileen) [00:28:07] (Merged) jenkins-bot: Add extension for reporting on possible fraudsters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/423831 (https://phabricator.wikimedia.org/T187262) (owner: Eileen) [00:30:31] (CR) Eileen: [C: 2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425725 (owner: Eileen) [00:31:35] (PS1) Eileen: add additional enabled modules to the list [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425728 [00:35:36] (Merged) jenkins-bot: Submodule update on CiviCRM 1b92ac7 Process eq as a report op [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425725 (owner: Eileen) [01:00:56] (CR) Ejegg: [C: 2] "Hooray, less copypasta!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424199 (https://phabricator.wikimedia.org/T187262) (owner: Eileen) [01:01:16] (CR) Ejegg: [C: 2] Enable fraud report. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424200 (https://phabricator.wikimedia.org/T187262) (owner: Eileen) [01:01:28] (CR) Ejegg: [C: 2] Fix missing email fails threshold field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425724 (https://phabricator.wikimedia.org/T187262) (owner: Eileen) [01:01:51] (CR) Ejegg: [C: 2] add additional enabled modules to the list [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425728 (owner: Eileen) [01:05:07] (Merged) jenkins-bot: Use list of enabled extensions to track in install [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424199 (https://phabricator.wikimedia.org/T187262) (owner: Eileen) [01:05:39] (Merged) jenkins-bot: Enable fraud report. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424200 (https://phabricator.wikimedia.org/T187262) (owner: Eileen) [01:05:42] (Merged) jenkins-bot: Fix missing email fails threshold field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425724 (https://phabricator.wikimedia.org/T187262) (owner: Eileen) [01:06:58] (Merged) jenkins-bot: add additional enabled modules to the list [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425728 (owner: Eileen) [01:11:03] (PS7) Eileen: Add donor totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424179 (https://phabricator.wikimedia.org/T186168) [01:11:05] (PS8) Eileen: Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) [01:12:13] (CR) jerkins-bot: [V: -1] Add donor totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424179 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [01:14:19] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/425735 [01:15:31] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/425735 (owner: Eileen) [01:16:24] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/425735 (owner: Eileen) [01:34:38] !log civicrm revision changed from 07bade75a2 to b3326dbf70, config revision is 853fcc9111 (deploy wmffraud report) [01:34:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [05:37:58] (PS1) Eileen: Update triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425748 [05:41:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Bug in trigger creation from recent upgrade is causing civicrm_mailing.modified_date to be inappropriately updated - https://phabricator.wikimedia.org/T192051#4125928 (Eileenmcnaughton) [07:05:10] PROBLEM - check_procs on frdev1001 is CRITICAL: PROCS CRITICAL: 1066 processes [07:10:10] RECOVERY - check_procs on frdev1001 is OK: PROCS OK: 279 processes [11:48:54] (PS12) Jgleeson: Updates to handle recurring payment tokens within contributions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424141 [11:57:26] (PS13) Jgleeson: Updates to handle recurring payment tokens within contributions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424141 [12:04:26] (CR) Jgleeson: "I'm torn whether to break the test out into its own Test Case as it covers a lot of ground, or leave it in the existing RecurringTest file" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424141 (owner: Jgleeson) [13:16:06] ejegg|away, let's chat about recurring when you're online. https://gerrit.wikimedia.org/r/#/c/424141/ is passing now so I think it would be a good time to discuss support for other processors and how we want to proceed with respect to this task. [13:26:46] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Write script to charge Ingenico recurring donations - https://phabricator.wikimedia.org/T170973#3449407 (jgleeson) @Ejegg can we chat about this to see if it's something... [14:53:58] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Bug in trigger creation from recent upgrade is causing civicrm_mailing.modified_date to be inappropriately updated - https://phabricator.wikimedia.org/T192051#4127145 (DStri... [14:55:28] fr-tech, could someone briefly explain to me how the logging works across drupal/civicrm please? [15:02:07] Hmmm sorry not sure there [15:02:34] I think it's going in the db [15:02:39] but wanted to confirm for sure [16:02:25] AndyRussG: ejegg|away meeting? [16:02:34] dstrine: coming! [16:42:00] fr-tech, I forgot to add, I'm still adding to the puppet patch I was going to push up to fix a few vagrant permission issues. Hopefully in the next few days I'll have closed off most of the test related environment issues. [16:42:36] that also only applies to people on vagrant, which I know isn't a big list [16:43:08] jgleeson: here's what eileen was suggesting as an example for the recurring using smashpig: https://github.com/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/blob/master/api/v3/Job/ProcessRecurring.php [16:43:58] that whole extension is basically doing what we want to do, wrapping a multiprocessor payments library for use as a civi extension [16:44:58] nice! [16:45:03] will take a look [16:48:59] ejegg, so we would write the pay method [16:49:09] to integrate directly with SmashPig? [16:49:20] jgleeson: yeah, exactly [16:49:39] well, I'm still figuring out just how much of the core code is relevant [16:50:24] anyway, I should have some skeleton WIP up later today [16:50:34] might not be much more than the boilerplate.... [16:51:28] just looking at the extension naming conventions for 'pay' here https://github.com/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/blob/master/api/v3/PaymentProcessor/Pay.php [16:51:45] looks like you just build up the function names from what I can see [16:51:53] I haven't look at civicrm extensions before [16:52:01] so excuse the stating of the obvious [16:52:33] there's a bunch of stuff that onflicts with the smashpig design [16:52:47] ....probably the mistaken parts of the smashpig design... [16:53:26] but for example, the UI to store all the processor credentials and urls in Civi [16:54:02] would duplicate the single set of config files we're trying to use for smashpig across all its uses [16:54:50] I see [16:55:21] I'm presuming the forms are populated from a db, and we can't swap out the data source? [16:55:40] assuming* [16:57:57] We can use hooks to mess with those forms in all sorts of ways [16:59:02] and if we wanted to, we could use the config override functions of SmashPig to use the values from the forms in place of the stuff in the files [16:59:41] hmm would that mean SP would be reading from the civi db? [16:59:58] Well, only for functions within Civi [17:00:11] i think we shouldn't worry about that part for now [17:00:37] maybe just override those pages enough to put a 'these are not the settings you're looking for' message in [17:01:05] and focus on using civi APIs to do the monthly donation scheduling [17:01:18] with my limited knowledge so far, it feels like Smashpig is the more natural place for credentials and account config [17:01:40] but in our 'pay' method call smashpig methods that will know all about the accounts on their own [17:01:44] yeah, exactly [17:01:57] but facading that data to other libraries and tools makes sense [17:02:45] do we have a precedent for something like a SmashPig datasource within civi? [17:03:03] no, not yet [17:03:04] that plays nice with the civi models interface [17:03:25] (I'm guessing they use models) [17:03:36] just the queueing stuff [17:03:53] that is, SmashPig handles queuing, including the damaged message table [17:04:15] where messages live while waiting for retry, or when discarded as totally dead [17:04:25] and that table is browseable in Civi [17:04:35] just using drupal table stuffs [17:04:46] not even a full fledged entity [17:06:01] can you link me to where that happens? so I can have a look how the layers come together [17:06:12] heh, it's not pretty... [17:06:22] I'm interested in what bootstrapping smashpig needs [17:06:29] ah, that's also a bit annoying [17:06:34] in that use case [17:07:08] just a sec, lemme find those lines [17:09:13] on an unrelated note, this would have been a conference ticket price I would of been happy with, https://civicrm.org/civicon/uk-2017 [17:09:22] £55 early bird! [17:10:21] https://github.com/wikimedia/wikimedia-fundraising-crm/blob/master/sites/all/modules/wmf_common/wmf_common.module#L140 [17:10:27] jgleeson: nice price! [17:10:54] ok, so in wmf_common.module there's a lot of standard drupal code for doing db queries and dumping the result into tables [17:11:15] it just happens to be querying a table that's populated by SmashPig's queue processing logic [17:11:46] The re-queueing stuff IS handled by smashpig: [17:12:15] https://github.com/wikimedia/wikimedia-fundraising-crm/blob/master/sites/all/modules/wmf_common/wmf_common.module#L407 [17:12:42] QueueWrapper::push and DamagedDatabase::get()->deleteMessage [17:13:15] and for that, we've got a function to do the SmashPig bootstrapping: https://github.com/wikimedia/wikimedia-fundraising-crm/blob/master/sites/all/modules/wmf_common/wmf_common.module#L431 [17:20:58] from what I can see, the Smashpig boostrapping isn't that complicated [17:21:11] nah, could be worse [17:22:15] so is the SmashPig Context a little like the registry pattern style of config which you just call from anywhere that needs to use it [17:24:33] right [17:25:42] did you ever used Zend Framework? [17:25:45] use* [17:26:08] nope, have you? [17:28:47] yeah, I spent a few years using that across jobs after the MVC boom. ZF was the popular choice at the time due to the backing of the parent company. It relied heavily of patterns like Registry. I'd guess lots of the design choices were inspired by this book https://martinfowler.com/eaaCatalog/index.html [17:30:55] could do worse! [17:31:07] brb [17:32:41] yeah the book is a classic, the patterns overview really helped me throughout my career too [17:32:48] ...back to the extension, which looks doable! I'm intrigued to see what you come up with in the WIP patch. [18:28:02] fr-tech, looks like there's a civicrm event in san-fran next month. https://civicrm.org/civicamp/sf-bay-area-2018 [18:30:15] ejegg|food, I found an even better conference price for the uk https://civicrm.org/civicrm/event/info?reset=1&id=1155 £25! [18:32:27] dstrine, one of the sessions at the London Civicamp next month is 'GDPR for Charities' session or the 'Managing Data' session, which might give some perspective on how others are dealing with it [18:34:54] ooh, sounds extra-relevant! [18:41:33] yeah I knew about the one near here but I won't be able to go [18:53:46] (PS9) Ejegg: Insert records (mostly dummy) for processors [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/421663 (https://phabricator.wikimedia.org/T165695) [18:53:52] ^^^ just rebased because the last one was deployed and we need the schema version higher ^^^ [18:54:51] but... maybe we don't want those dummy ones after all! [18:56:34] @_@ [19:03:39] jgleeson: nah, it's fine to use the dummy ones for no [19:03:41] w [19:03:50] cool [19:04:04] we can update them to point to real-er classes if we go the civi extension route [19:21:26] (PS14) Jgleeson: Updates to handle recurring payment tokens within contributions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424141 [19:21:53] reapplied my patch over the latest [19:22:53] ejegg, what are you thoughts on this test https://gerrit.wikimedia.org/r/#/c/424141/14/sites/all/modules/wmf_civicrm/tests/phpunit/RecurringTest.php@95 [19:23:15] I'm torn between breaking it into smaller parts (which might require a new test case file) [19:23:19] and leaving it be [19:24:24] actually I guess the case is just 'Recurring' [19:24:28] looking [19:26:20] damn. opening gerrrit seems to have killed the old lappy [19:26:28] oh no! [19:27:30] maybe it was a bad idea to use a cheap flash drivw as enceypted swap? can't tell if it's swappiness yhat locks the thing up [19:30:56] shop status page says waiting for part, maybe i'll pick up the battery-less lappy... [19:36:30] yeah, think i'll do that. this old one is pretty frustrating [19:38:55] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog: Ingenico audit wobble? March 13 refunds not in Civi - https://phabricator.wikimedia.org/T190098#4128075 (MBeat33) There are two Ingenico refunds that... [20:48:04] nice! they say the battery has jst arrived. hopefully i'll have the machine back within the hour [21:43:24] @AndyRussG [21:43:29] whats the difference between [22:05:27] ejegg: do you know where a list of the CN status codes sit? [22:07:06] yeah, let me see... [22:09:14] Seddon: https://www.mediawiki.org/wiki/Extension:CentralNotice/Statuses,_reasons_and_status_codes [22:46:19] woohoo, back on the x1 lappy! [22:46:30] with a fresh new battery :) [23:01:57] ejegg: I still haven't had mine to be checked [23:02:55] Seddon: so, I had mine checked a couple months back and the tech said it was A-OK, just tightened some screws putting it back in. [23:03:23] Well, a few weeks after that the battery life went down to near zero, and when I took a look the battery was getting bulgy [23:03:35] so I dunno if the tech messed it up [23:03:44] but I'm really glad I called when I ded [23:03:46] *did [23:04:07] just a week before the 1 year battery warrantee was up [23:09:19] heading out for now, probs back later