[00:33:56] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, and... - https://phabricator.wikimedia.org/T189617#4134962 [00:34:33] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi notes field is not WYSIWYG - https://phabricator.wikimedia.org/T190872#4086188 (Eileenmcnaughton) I've taken a quick look at this & it isn't as simple as I thought. Th... [00:34:59] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi notes field is not WYSIWYG - https://phabricator.wikimedia.org/T190872#4134965 (Eileenmcnaughton) a:Eileenmcnaughton [08:55:14] (PS1) Eileen: Add location hunt for civicrm_settings_location.php so we can put it in sites dir [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/427079 [15:10:10] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4136300 (MBe... [16:49:43] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, and... - https://phabricator.wikimedia.org/T189617#4136753 [17:00:00] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/427174 [17:00:16] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/427174 (owner: Ejegg) [17:04:33] (PS1) Ejegg: Update DonationInterface for deploy [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/427175 [17:10:00] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/427174 (owner: Ejegg) [17:16:38] (CR) Ejegg: [C: 2] Update DonationInterface for deploy [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/427175 (owner: Ejegg) [17:25:38] (Merged) jenkins-bot: Update DonationInterface for deploy [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/427175 (owner: Ejegg) [17:27:36] !log updated payments-wiki from 320a6c2600 to 4a8aada491 [17:27:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:32:23] Fundraising Sprint Gravity wasn't always this pushy, Fundraising-Backlog, FR-Astropay, MediaWiki-extensions-DonationInterface, and 2 others: Update API address for d*Local - https://phabricator.wikimedia.org/T187809#4136896 (Ejegg) This seems to be working fine. I deployed the settings changed an... [17:32:46] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, FR-Astropay, and 3 others: Update API address for d*Local - https://phabricator.wikimedia.org/T187809#4136898 (Ejegg) [17:44:47] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4136977 (CCogdill_WMF) Bumping this! We are doing a series of newsletter tests with Chapters this quarter and it is really important for us to have ac... [17:49:03] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4137007 (Dzahn) Open>stalled [19:00:42] dstrine i'll be in the chat in 2 min [19:42:36] (PS1) Ejegg: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/427197 [19:43:05] AndyRussG: Does that look like too much to ask for in evening SWAT? ^^^^ [19:43:36] very little actual change [19:44:33] but it might be nice to get the code out first, while we figure out the exact CSP header we'll need [19:44:47] oh hey, we might as well deploy the settings change to beta! [19:45:55] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: Option to enforce CSP on banner previews and fla... - https://phabricator.wikimedia.org/T190100#4137519 [19:46:30] (PS1) Jgleeson: WIP - Mapper component to help transform standard Smashpig messages to provider requests. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427198 [19:46:51] (CR) jerkins-bot: [V: -1] WIP - Mapper component to help transform standard Smashpig messages to provider requests. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427198 (owner: Jgleeson) [19:48:08] ejegg: they probably wouldn't want it on SWAT... for the no-ops we could put it on the train, no? [19:55:09] https://arstechnica.com/gadgets/2018/04/intel-microsoft-to-use-gpu-to-scan-memory-for-malware/ [20:00:45] (Abandoned) Ejegg: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/427197 (owner: Ejegg) [20:02:22] (PS1) Ejegg: Merge branch master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/427204 [20:03:38] Fundraising-Backlog: Create a test system to check banners using CSP headers on banner changes - https://phabricator.wikimedia.org/T191915#4137550 (DStrine) [20:03:44] ok AndyRussG, ^^^ is just the no-ops up till the commit before CSP [20:23:49] ejegg: hmmm... interesting... sorry to be picky, can't we just cherry-pick the CSP thing for the SWAT? or is it conflict-y? [20:24:22] oh hm, I'll see [20:24:24] then after that we could merge whatever esle is there [20:24:37] ejegg: K thanks for looking at this!!! :) [20:25:01] apologies for being silly about these silly rules [20:25:09] seems to cherry-pick fine [20:25:17] (PS1) Ejegg: Emit CSP headers on banner previews [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/427235 (https://phabricator.wikimedia.org/T190100) [20:26:13] ejegg: okok... aaaarg doesn't it automagically add a "cherry-picked from" thingy in the commit msg? [20:26:37] oh, I guess that's only if you do it via gerrit UI. I'll redo it thataway [20:26:59] or just add it via commit --amend [20:26:59] (PS2) Jgleeson: WIP - Mapper component to help transform standard Smashpig messages to provider requests. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427198 [20:27:22] ejegg, it looks like I committed some blank updates to unrelated files so I've just reset them and repushed [20:27:23] (CR) jerkins-bot: [V: -1] WIP - Mapper component to help transform standard Smashpig messages to provider requests. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427198 (owner: Jgleeson) [20:27:26] I'll try to make a beta-cluster version of the config change and send up a patch for that [20:27:42] u ok with restricting scripts for that to meta.wikimedia.org? [20:27:52] (for prod, and equivalent for beta clust) [20:28:28] (PS2) Ejegg: Emit CSP headers on banner previews [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/427235 (https://phabricator.wikimedia.org/T190100) [20:28:45] I can't think of any other *.wikimedia.org domain that you'd be pulling scripts into a banner form... [20:29:03] AndyRussG: Ah, unfortunately it applies to everything on the page [20:29:29] ejegg: yeah but also the page shouldn't bring scripts in from eleswhere, no? load.php goes to meta.wikimedia.org [20:30:02] let's see... we do bring in images from upload, but we can put that in img-src if we want to be really granular [20:30:23] meta is the domain for the login check too, right? [20:30:32] (PS3) Jgleeson: WIP - Mapper component to help transform standard Smashpig messages to provider requests. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427198 [20:30:50] (CR) jerkins-bot: [V: -1] WIP - Mapper component to help transform standard Smashpig messages to provider requests. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427198 (owner: Jgleeson) [20:32:08] ah hmm interesting question [20:32:20] jgleeson: I like the reusability of that Mapper component [20:32:22] though you're not gonna preview a banner on a login page [20:32:54] ejegg, yeah I'm hoping it will be useful in a few use cases [20:32:54] AndyRussG: right, I was wondering about the central auth [20:33:37] jgleeson: we do need to be able to create nested arrays though. Not seeing how it handles that, at first glance [20:33:44] hmmm but that's just when u login, no? [20:34:11] not sure how that works but I imagine it's all server-side, but still I don't think it's a problem for viewing meta wiki articles when you preview a banner [20:34:15] AndyRussG: if you're logged in via central auth and then visit a page on a different wiki, it figures out that you're logged in somehow [20:34:32] lemme look at the requests for a fresh wikiview [20:34:33] true [20:34:41] hmmm [20:35:10] ejegg, would we be ok describing the arrays in this type of map format and then dropping in the params to be mapped using the convention in the file e.g. https://gerrit.wikimedia.org/r/#/c/427198/3/PaymentProviders/Ingenico/Maps/createPayment.yaml [20:35:24] s/arrays/nested arrays/ [20:35:52] ahh. cool, I get it [20:36:19] So, I may have forgotten to point out another thing from DonationInterface [20:36:27] which is the concept of 'Transformers' [20:36:54] in case we need to format certain values differently for different APIs [20:37:04] Ingenico is actually a perfect example [20:37:15] in that they expect the amounts to be formatted in minor units [20:37:40] it could definitely work with the mapper [20:37:52] ejegg: k I'm wrong! when logged-out, a script comes in from commons [20:38:03] I see, so we'd like to parse types to different formats? [20:38:09] like dates & currency [20:38:12] AndyRussG: ooh, commons? [20:38:17] https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-LanguageSelect.js&action=raw&ctype=text/javascript [20:38:29] jgleeson: yeah, those are a couple examples [20:38:44] I think the way we're doing it in DonationInterface is pretty good, actually [20:38:53] okay cool, I'll take a look [20:38:58] and see if I can port it across [20:39:06] We have a config file for each gateway that lists class names [20:39:37] I guess for new we could just leave it at *.wikimedia.org then [20:39:41] and we instantiate each class that implements StagingHelper [20:40:42] then use each one's stageData method to format the data to send [20:41:06] We do something similar with data coming back from the gateway, just looking for UnstagingHelper implementations [20:49:12] This looks like a good example ejegg https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/gateway_common/DonorLanguage.php [20:51:31] which is also extended here https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/globalcollect_gateway/IngenicoLanguage.php [20:51:45] jgleeson yep, totally [20:51:51] I'll have a think how I can work that in [20:52:02] also relevant to Ingenico: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/gateway_common/AmountInCents.ph [20:52:35] jgleeson that part feels like a separate patch, don't you think? [20:52:55] yeah it feels like a MapperTransformer or something alike [20:53:10] naming things is hard though [20:53:16] so I'll get it functioning first [20:53:24] I'm terrible at naming things :) [20:57:18] :) one of the hardest problems in programming! [21:01:00] calling it a day. catch you all tomorrow fr-tech! [21:20:43] fr-tech ejegg so ok if we push out the CSP thing tomorrow in the "morning SWAT" (10:00-11:00 am Pacific Time)? I'm sure we can have the config change ready by then [21:20:55] AndyRussG: sure, sounds good. [21:21:20] ejegg: cool thx! [21:21:23] Just looking at the config repo trying to see how to do beta-only changes [21:21:41] (just suggesting that time 'cause I know I can be around to watch the deploy) [21:21:51] yep, that time works for me too [21:22:03] ejegg: there's a separate file for configs that are different from prod [21:22:39] I see an 'InitialiseSettings-labs.php' file [21:23:08] yeah also CommonSettings-labs.php [21:24:04] so whichever it goes in in prod, it goes in the equivalent one for beta clust [21:24:33] got it [21:26:15] ok, looks like it has to go in CommonSettings.php [21:26:46] well, CommonSettings-labs [21:27:37] I think both the prod and beta cluster settings can go in the same commit [21:31:58] Hmm, maybe we should turn it on in beta first? [21:37:25] ejegg: I think by merging the change to master in the config repo it goes out to beta, so we can test it there? Not sure how deploy works for config changes, there might be some automagic mechanism there, tho surely less immediate [21:38:14] ok, cool [21:38:53] so... I'm tempted to just stick *.wmflabs.org in the beta config [21:39:13] yeah agreed [21:39:15] https://meta.wikimedia.beta.wmflabs.org/wiki/Special:SiteMatrix [21:39:33] or even *.beta.wmflabs.org [21:39:40] ah, seems it's loading stuff from upload too [21:39:49] hummm [21:40:00] oh cool, SiteMatrix! [21:40:17] ejegg: we could have all the same sites allowed as in production, and just add *.beta.wmflabs.org [21:40:46] ok [21:41:59] hmmm yeah also dewiki on beta loads a thingy from meta [21:42:11] normal-meta? [21:43:12] yep [21:43:14] https://meta.wikimedia.org/w/index.php?title=MediaWiki:Wikiminiatlas.js&action=raw&ctype=text/javascript&smaxage=21600&maxage=86400 [21:43:42] hrrrmmm? what's with the test-wiki CentralNotice settings in prod? [21:44:00] Mmmm? [21:44:07] test-wiki is a production wiki [21:44:18] oh weird, got it [21:44:21] it's like what we had before the beta cluster got real [21:44:35] just a normal wiki, on the main cluster, but used for testing [21:44:40] first thing on the train [21:45:06] ahhhh, and so that one points to itself instead of meta for CN admin [21:45:28] yep [21:45:38] it self-meta-izes [21:46:07] hmm, nother novel setting: CNReporterDomains [21:47:32] wat: Special:CNReporter comment "Null endpoint. This is a workaround to simplify analytics." [21:48:19] looks like it's meant to be included as a tracking iframe [21:49:56] ...sorry, getting distracted [21:50:04] back to the CSP header [21:51:14] ejegg: them weeds need trimmin' [21:53:31] ejegg: https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Step_3:_configuration_and_other_prep_work [21:54:19] https://wikitech.wikimedia.org/wiki/Heterogeneous_deployment#In_your_own_repo_via_gerrit [21:54:32] I guess it's expected that the +2 will come from someone in ops [21:55:11] Or hmmm maybe not [21:55:14] " In general if you're not in operations you should make changes to a local copy of this repository (as explained in How to do a configuration change#In your own repo via gerrit), submit them for gerrit review with a -1 comment to avoid early deployment, then during your deployment window (often SWAT) +2 them and get them on the deployment host." [21:55:18] (from the first link) [21:55:58] got it [21:56:03] ejegg: are we making the config for the header only target meta? [21:56:45] it's possible to preview banners anywhere, but the links in the admin interface go to meta [21:56:53] I guess it makes sense to enable everywhere [21:56:55] Don't people usually preview banners on enwkiki? [21:57:12] I bet people do, yeah [21:57:18] and elsewhere too, surely [21:57:41] I think there are enough little interface differences that people want to see their banners in situ [21:58:24] yeah agreed [21:58:46] also of note (from the same link above): "configuration files are not tied to releases — there is no 1.27.0-wmf.1 branch for configuration. This means you cannot commit a configuration change and have it "roll out" across wikis on the release train, it has to work with all branches in use." [22:00:09] also of interest: https://wikitech.wikimedia.org/wiki/Configuration_files [22:00:18] cool, good to know but shouldn't have any bearing on this particular one [22:00:42] yepyep [22:02:01] yeah [22:02:13] hmmm that doc looks a tad outdated [22:02:22] (pre-extension registration) [22:03:46] fundraising-tech-ops: Reload civi mysql triggers - https://phabricator.wikimedia.org/T192411#4137806 (cwdent) [22:05:51] oh hey, all those HideUrl domains need to go in the list [22:07:02] ejegg: aren't they there already? [22:07:16] Ah, so they are [22:07:39] ah okok cool [22:16:06] AndyRussG: so... this look right? https://gerrit.wikimedia.org/r/427273 [22:16:28] ejegg: checking it out now :) [22:18:20] ejegg: I guess instead of putting the gerrit link in the comment, maybe the related core CSP task id? [22:19:43] k [22:20:12] other than that looks great! [22:20:54] ejegg: hmmm [22:21:18] If the change shouldn't be +2'd until the time of the SWAT deploy, then I guess we do need a separate beta cluster change [22:21:21] aaaaaaarg [22:21:28] sorrrrrrry [22:21:34] hmmm anyway just gonna check [22:21:59] ok, no worries, I'll split [22:22:01] em up [22:24:56] OK, here's mr. beta-only patch: https://gerrit.wikimedia.org/r/427273 [22:25:25] oops, I totally clobbered the other one [22:26:12] how'd it go XenoRyet ? [22:26:55] Passed with a 91.4% I'm now officially a Certified ScrumMaster. [22:27:03] congrats! [22:27:10] XenoRyet: yay! [22:27:19] Thanks! [22:28:22] ejegg: just confirmed that's how it works for beta changes and prod changes [22:28:34] (check ur backscroll in #wikimedia-releng) [22:29:32] the only detail is that the beta cluster change should also be synced in production just to keep things consistent [22:30:05] OK, cool. So does that mean we need to wait to +2 the beta-only thing till a deploy slot? [22:33:27] or do you want to go ahead and +2 it now? [22:33:40] ejegg: if I understand correctly, we can +2 the beta thing ahead of time [22:33:46] and they'll both get synced during the deploy [22:33:49] ejegg: u bet! [22:33:56] k, great! Do you want to do the honors? [22:35:41] Thanks :) [22:36:05] ejegg: likewise! :) [22:36:15] if u like I can also take care of booking the SWATspot [22:36:38] Oh sure, that would be great [22:37:02] K I'll do that in a little while :) (Gotta order some food and walk the dog...) [22:37:41] Let's also wait to +2 the cherry-pick to wmf_deploy, just in case it could cause any confusion for other deploys between then and now, k? [22:37:48] k [22:37:59] I can also test the beta cluster setup in a bit [22:39:09] just poking at it now [22:40:18] hmm, not seeing the header yet on https://meta.wikimedia.beta.wmflabs.org/w/index.php?title=FOOO22&banner=fundraising_test_2018_02_07_mob_sm&uselang=en&force=1 [22:40:39] ahh, but it's like a 10 minute refresh cycle or something, right? [22:42:55] oh neat, it's a post-merge build step [22:44:23] ejegg: yeah something like that [22:45:36] yeah not seeing it just yet.... [22:52:22] ejegg: seeing it now! [22:52:40] If you've previewed and not seen it before (when it was still going out) make sure you preview on a different article [22:53:08] Not sure how long the varnish cache lasts on the beta cluster, but it'll latch onto the banner URL param [22:53:27] (recall this goes on the base HTML which normally is cached for a long time) [22:54:28] ah yeah [22:55:36] cool cool, there are the headers! [22:56:11] and no alert on the innocent banner content [22:56:25] lessee about a naughty one [22:56:31] wow that central auth really does go woosh client-side [22:56:50] just logged in on beta cluster with the network tab open [22:56:54] woosh, huh? [22:57:36] as in, a cookie storm that makes the CN hide cookies look like a spring cookie breeze [22:57:50] ahahah [22:58:40] back in a while... [23:07:48] ejegg|afk: btw the header doesn't only warn, also actually blocks resources... that's what we wanted, right? [23:08:42] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, and... - https://phabricator.wikimedia.org/T189617#4137900 [23:17:05] Fundraising Sprint Elevators were never intended to go down, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-CiviCRM-dedupe-FY2017/18, Epic: Epic: Can the engage import dedupe on import? - https://phabricator.wikimedia.org/T181090#4137932 (Eileenmcnaughton) [23:17:08] Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, and... - https://phabricator.wikimedia.org/T189617#4137931 [23:20:13] AndyRussG: yeah, I wanted it to trigger the error event [23:20:38] ejegg|afk: right but it also actually does block the content [23:20:41] which is good, I think! [23:20:45] yep! [23:20:56] make that breakage maximally visible [23:21:00] ejegg|afk: works as expected https://meta.wikimedia.beta.wmflabs.org/w/index.php?title=Translation:Mavetuna&banner=TestFooBanner_6&uselang=en&force=1 [23:21:19] (I should revert the banner change soon, but if u'd like to see it in action...) [23:22:02] hehe, nice 'facebookcontainerextension.jpg' [23:22:08] ejegg|afk: it has been requested that we actually deploy the beta cluster patch now, since it's confusing for deployers to have undeployed config changes that are merged into master [23:22:10] :) [23:22:19] and it can trigger alerts infact [23:24:34] ok, so just log on to tin, git update, and sync-file ? [23:24:39] oh right, not tin anymore [23:25:08] (PS1) Eileen: Re-add settings_location.php [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/427279 [23:26:09] ejegg|afk: so I'm going to look at those total fields again now - just wanting to check we are happy conceptually [23:26:11] ejegg|afk: there's other people on there doing config changes infact, and officially it's a SWAT deploy slot. I just added the beta cluster change to that [23:26:35] AndyRussG: ah great, thanks! [23:26:48] I think if someone else is already pushing out config changes, it's easy just to add this in too [23:26:54] ejegg: thank u 2 :) [23:27:10] eileen: yes! Just so long as we're totally clear on what a fiscal year is :) [23:27:36] I think the main thing I need to do is write unit tests & perhaps analyse the refunds a bit more - although I think the refunds can be after too [23:27:53] ie. I feel like there is relatively little difference & they will follow [23:28:01] yeah [23:28:38] I think this change - https://gerrit.wikimedia.org/r/#/c/424186/ can go out any time although I might batch it & probably need to stop queues [23:30:14] & this one https://gerrit.wikimedia.org/r/#/c/427279/ I can get leanne's signatures working in a cludgey way once this is out (issue is that she needs to use a url that is a file path & will not show on her screen but she will be running) [23:30:41] ie sites/all/modules/filename.jpg not http://.../sites/all/modules [23:30:58] Yeah, batching that would be nice. Let's see, is that also swapping the new field to writable? [23:31:36] it's only 20k records but still batching is better I think [23:31:52] doesn't fix writable [23:31:56] ah, ok [23:32:12] so we'd want to do that pretty soon after copying the data over, huh? [23:32:20] in terms of taking queues down (e.g for 20-30 mins to run it) I guess I just need to check with Caitlin & Sam? [23:32:33] yeah I'll change it to do the write-only change in that commit [23:33:04] 20-30 min of queue outage is usually not something folks would notice [23:33:31] ok - only if they are watching for incoming at that moment [23:33:35] yeah [23:34:01] I'll fix that commit to batch & do view only now [23:34:11] cool! [23:35:13] there is also a trigger problem here - https://github.com/civicrm/civicrm-core/pull/11984 which I think is low impact but will put into our q [23:44:13] oh wow, that's a weird one [23:50:29] cwd I need to plan an outage (for about an hour ) to add some DB fields & indexes - I am a bit flakely next week (now I think about it tomorrow would have been perfect) but Mon next week would work or else I guess we can just make a time & I'll make it work or else the following week. (I'm moving around next week for kids karate comp in south island) [23:50:39] so mostly will be on mobile broadband [23:54:28] ejegg|afk: K the beta cluster change is now no-op-ily synced to prod