[00:00:35] eileen: does the new field have a default '0' ? [00:00:52] Since it's marked required, I'd be leary of replacing 0s with NULLs [00:01:40] ejegg: well just for speed I've dropped non 1 values from the update [00:01:54] also DB size I guess - don [00:02:05] t create rows that are non-informational [00:02:39] but won't that mean the next time ppl edit any contact they'll have to manually choose 'no' even if they already did for the old field? [00:04:15] is it required ? it should have 0 as a default & be non-required [00:05:01] dang it IS [00:05:15] yeah, the old one was too [00:05:23] but didn't have a default.... [00:05:29] not sure why we did that [00:05:39] let's change it [00:06:07] I'd support that, but we should let people know [00:06:24] just in case someone had a reason for it [00:07:23] so staging didn't complain about the CustomField create calls? [00:09:38] (PS13) Eileen: Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) [00:09:50] it did - but not on the command line :-( [00:10:39] huh? where did it then? [00:11:02] I mean - this works [00:11:03] drush cvapi CustomField.create id=155 name=do_not_solicit_new is_view10 is_required=1 [00:11:17] ahhh [00:11:46] wait, that should be totally equivalent, huh? [00:11:46] trying again on staging [00:11:54] should be… [00:13:35] gonna do a mysql instead [00:15:53] (PS14) Eileen: Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) [00:18:09] (CR) jerkins-bot: [V: -1] Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [00:18:23] ejegg: well that worked & now the field is editable [00:23:15] hmm, ok [00:23:33] maybe some php caching? [00:24:23] I found it maybe [00:24:25] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [00:24:32] if ($op == 'create') { [00:24:32] if (!isset($params['column_name'])) { [00:24:35] ... [00:26:14] (CR) jerkins-bot: [V: -1] Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [00:27:26] DB Error: Syntax error ??? [00:28:00] ahh, 7670 shouldn't be part of the initial install [00:28:14] or.... [00:28:29] no, doesn't matter, you do account for the old field not existing [00:28:49] so what's that syntax error jenkins is just now hitting? [00:29:26] ohhh, 'is_required' = 0 [00:29:40] bad ticks [00:31:44] ug [00:32:22] (PS15) Eileen: Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) [00:32:54] ok... [00:32:54] (PS16) Eileen: Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) [00:34:06] backticks for all! [00:34:48] (CR) jerkins-bot: [V: -1] Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [00:35:09] it's a backtick orgy [00:36:02] what now? [00:37:42] no idea! [00:38:16] honestly tempted to just do the last update manually! [00:39:17] (PS17) Eileen: Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) [00:39:23] pulled the line out to verify it passes without [00:39:25] well shoot, I STILL get DB Constraint Violation - custom_group_id should possibly be marked as mandatory [00:39:33] but not a syntax error [00:39:47] do you get that on the prior lin? [00:40:50] (PS18) Eileen: Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) [00:41:20] eileen: yeah, on the other api create [00:42:28] ok both via sql now [00:42:44] (CR) jerkins-bot: [V: -1] Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [00:42:46] that one works for me! [00:43:26] (PS19) Eileen: Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) [00:44:41] wait, why did you just put that create API call back in? [00:46:23] err, wait, just never deleted it [00:46:58] (PS20) Eileen: Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) [00:47:07] fixed I think [00:47:29] Yes! [00:48:36] halelujah [00:49:01] yay - now go tests [00:49:03] (CR) Ejegg: [C: 2] Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [00:49:41] ejegg: so to deploy - just turn of sched jobs via process-control commit? [00:51:11] yeah! [00:51:26] we could be selective, but it's easy enough to turn 'em all off and then on again [00:53:48] (Merged) jenkins-bot: Transfer data to new custom field (deploy AFTER triggers re-established) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424186 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [00:57:38] ok pushed an off-job commit [01:02:40] (PS1) Eileen: Temporarily disable field add to re-order actions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/427574 [01:02:57] actually ejegg need to do this [01:02:58] https://gerrit.wikimedia.org/r/#/c/427574/ [01:03:33] (PS2) Eileen: Temporarily disable field add to re-order actions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/427574 [01:03:39] hrm? [01:04:31] ahh, I was wondering why that got put in between the do_not_solicit patches [01:05:14] well it was going to go after if we had to do it during the outage [01:05:18] but we don't now [01:05:21] (CR) Ejegg: [C: 2] Temporarily disable field add to re-order actions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/427574 (owner: Eileen) [01:09:52] (Merged) jenkins-bot: Temporarily disable field add to re-order actions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/427574 (owner: Eileen) [01:13:00] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment + 8c53e8077596fe296518e6449c2cecdda2720669 Apply drupal formatting to refundTest + 613d9cfc6957cb66f474aa2aa0dffde73eeea755 Add donor totals fields + cfb0f7a [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/427575 [01:13:43] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment + 8c53e8077596fe296518e6449c2cecdda2720669 [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/427575 (owner: Eileen) [01:15:55] !log civicrm revision changed from 0ac27e7c0d to b1e7ccfc4d, config revision is 49f5ba45e8 [01:16:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:20:43] all done [01:26:07] (PS1) Eileen: Re-enable update 7675 now 7670 is deployed [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/427578 [01:26:24] (PS18) Eileen: Add triggers to manage yearly totals & associated custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425219 (https://phabricator.wikimedia.org/T186168) [01:27:02] ejegg: so just the tricky one now https://gerrit.wikimedia.org/r/#/c/425219/ [01:37:29] (CR) Ejegg: [C: 2] Re-enable update 7675 now 7670 is deployed [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/427578 (owner: Eileen) [01:37:48] (one more trivial one for a warmup) [01:39:13] :-) [01:42:09] (Merged) jenkins-bot: Re-enable update 7675 now 7670 is deployed [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/427578 (owner: Eileen) [02:01:51] (CR) Krinkle: "The diff is from HistoryTest.php, that was previously not on the list, but is now auto-discovered and run. Yay for it still passing after " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/303261 (https://phabricator.wikimedia.org/T142120) (owner: Reedy) [02:02:12] (CR) Krinkle: [C: -1] "(Merge conflict)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/303261 (https://phabricator.wikimedia.org/T142120) (owner: Reedy) [02:15:24] eileen: want to walk me through a little bit of the trigger stuff? [02:20:35] ejegg: yes - can I do in 40 mins though? [02:21:02] eileen: actually, i figured out the things that were confusing me 5 min ago [02:21:18] will ask again in 40 if I still have questions [02:21:31] ejegg: cool - wish that worked with my kids [02:25:39] sorry, it's getting pretty late here, I'm going to have to pick this up tomorrow [02:30:01] oh bother, we should update the silverpop export to use the new do_not_solicit field [02:31:45] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Update silverpop export to use new do_not_solicit field - https://phabricator.wikimedia.org/T192517#4141682 (Ejegg) [02:31:59] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Update silverpop export to use new do_not_solicit field - https://phabricator.wikimedia.org/T192517#4141693 (Ejegg) p:Triage>High [04:58:23] (PS1) Eileen: Change to new table for do_not_solicit field [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/427591 [10:19:15] (PS9) Reedy: Remove 'UnitTestList' hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/303261 (https://phabricator.wikimedia.org/T142120) [10:20:22] (PS10) Reedy: Remove 'UnitTestList' hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/303261 (https://phabricator.wikimedia.org/T142120) [10:49:26] hey there [10:50:31] can anyone tell me if there is an official button or banner i would use on my websites to link people to the wiki donation page ? [11:07:40] Guest24362: not currently [11:07:52] Guest24362: but it's a cool idea [11:29:42] ok thank you [14:19:59] !log re-enabled queue jobs [14:20:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [14:38:43] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: Consider some initial steps for infrastructure for banner history data crunching - https://phabricator.wikimedia.org/T120057#4142834 (AndyRussG) I think this task may still be relevant, though we might update to look at what syste... [14:57:13] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Browser-Support-Google-Chrome, Patch-For-Review: Multiselects in Special:CentralNotice sometimes load incorrectly - https://phabricator.wikimedia.org/T74421#4142886 (AndyRussG) Has anyone seen this issue recently? I wonder if it might have... [15:01:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Show banners based on BH and local time of day - https://phabricator.wikimedia.org/T170561#3435279 (AndyRussG) A more complete version of this would be to create some client-side (and privacy-respecting) JS that reads client-side BH and also takes... [15:02:24] hey ejegg, thanks for resolving that issue [15:06:29] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner History: Record in log when hide cookies are set, and the reason - https://phabricator.wikimedia.org/T192558#4142924 (AndyRussG) [15:07:10] updating my 'puter... Hopefully it'll still work after that! [15:08:05] sure thing jgleeson [15:08:08] I've been suspending and un-suspending w/ out rebooting for like 3 weeks... Some of these desktop apps don't take so well to that, I guess... [15:08:41] ooh, someone's got sublime stability! [15:08:47] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4142938 (JBennett) What's the data? From our clicktracking efforts what will we be collecting? [15:08:56] I still get some lockups when unplugging my USB monitor [15:12:35] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", an... - https://phabricator.wikimedia.org/T186883#4142960 [15:12:55] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history: record in log when the log was sent the servers - https://phabricator.wikimedia.org/T124328#4142963 (AndyRussG) [15:32:49] awww that's rough [15:44:09] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [Epic] Banner history improvements - https://phabricator.wikimedia.org/T192564#4143072 (AndyRussG) [15:52:11] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner History: Record in log when hide cookies are set, and the reason - https://phabricator.wikimedia.org/T192558#4143127 (AndyRussG) [15:52:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Show banners based on BH and local time of day - https://phabricator.wikimedia.org/T170561#4143128 (AndyRussG) [15:52:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history: record in log when the log was sent the servers - https://phabricator.wikimedia.org/T124328#4143130 (AndyRussG) [15:52:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history: Record count of pageviews when the user didn't get a campaign - https://phabricator.wikimedia.org/T113815#4143131 (AndyRussG) [15:52:23] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [Epic] Banner history improvements - https://phabricator.wikimedia.org/T192564#4143126 (AndyRussG) [15:52:46] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4143132 (CCogdill_WMF) We're collecting click engagement off fundraising emails (actual fundraising appeals, or informational newsletter emails) that... [15:54:52] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history data additions - https://phabricator.wikimedia.org/T170559#4143136 (AndyRussG) [15:55:45] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history data additions: time zone and country - https://phabricator.wikimedia.org/T170559#3435246 (AndyRussG) [15:55:58] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history data additions: timezone and country - https://phabricator.wikimedia.org/T170559#3435246 (AndyRussG) [15:56:36] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history data additions: timezone and country - https://phabricator.wikimedia.org/T170559#3435246 (AndyRussG) [15:57:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history data infrastructure - https://phabricator.wikimedia.org/T170560#4143145 (AndyRussG) [15:57:40] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history data additions: timezone and country - https://phabricator.wikimedia.org/T170559#4143146 (AndyRussG) [15:57:43] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history: log banner close events - https://phabricator.wikimedia.org/T124330#4143147 (AndyRussG) [15:57:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [Epic] Banner history improvements - https://phabricator.wikimedia.org/T192564#4143144 (AndyRussG) [15:58:28] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history data infrastructure - https://phabricator.wikimedia.org/T170560#3435262 (AndyRussG) [16:05:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner history data infrastructure - https://phabricator.wikimedia.org/T170560#4143189 (AndyRussG) [16:05:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Spike: Spike: Consider some initial steps for infrastructure for banner history data crunching - https://phabricator.wikimedia.org/T120057#4143191 (AndyRussG) [16:08:58] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Update silverpop export to use new do_not_solicit field - https://phabricator.wikimedia.org/T192517#4141682 (mepps) a:Ejegg>mepps [16:15:12] (CR) Jforrester: [C: 2] Remove 'UnitTestList' hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/303261 (https://phabricator.wikimedia.org/T142120) (owner: Reedy) [16:20:34] (Merged) jenkins-bot: Remove 'UnitTestList' hook [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/303261 (https://phabricator.wikimedia.org/T142120) (owner: Reedy) [16:25:31] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Update silverpop export to use new do_not_solicit field - https://phabricator.wikimedia.org/T192517#4143257 (Ejegg) To test this locally, you'll need a settin... [16:27:56] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Update silverpop export to use new do_not_solicit field - https://phabricator.wikimedia.org/T192517#4143264 (Ejegg) Dang. We need to add a whole nother sectio... [16:31:01] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Update silverpop export to use new do_not_solicit field - https://phabricator.wikimedia.org/T192517#4143282 (Ejegg) Instructions copied to https://www.mediawi... [16:36:32] cwd we're going to have to deploy an update to the python tools sometime soon so the silverpop_export uses the new do_not_solicit column [16:36:53] and I forget if we got all the new config deployed for the logging [16:37:10] hi XenoRyet [16:37:27] Hey there. [16:37:46] Sorry I missed standup, Marek's teacher wanted to talk for a while. [16:37:54] I'll email around an up date in a bit here. [16:38:13] Also, apparently uncafinated enough that I thought update was two words... [16:38:17] did you want any help with T190871 ? [16:38:17] T190871: Ingenico Connect: need new ct_id after successful donation - https://phabricator.wikimedia.org/T190871 [16:39:07] Na, I pretty much got it, I just keep getting sidetracked before I finish it out. It's my focus this morning though, I'll have something up soon. [16:39:21] k, ping me when you want some review [16:39:35] Will do [16:42:50] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: Update silverpop export to use new do_not_solicit field - https://phabricator.wikimedia.org/T192517#4143316 (Ejegg) Oops mepps, looks like eileen beat us to i... [16:43:39] Jeff_Green: can you tell me if the yaml files puppet pushes to /etc/fundraising all have a hefty 'logging' chunk at the top yet? [16:44:59] if not, I've got some fragments in my homedir on frpm to prepend [16:45:12] PROBLEM - check_puppetrun on alnitak is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): User[prometheus] [16:46:54] !log disabled banner impressions loader in order to run backfill mode [16:47:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:50:12] PROBLEM - check_puppetrun on alnitak is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): User[prometheus] [16:51:35] ejegg: sec [16:55:12] RECOVERY - check_puppetrun on alnitak is OK: OK: Puppet is currently enabled, last run 25 seconds ago with 0 failures [16:56:29] !log re-enabled banner impressions loader [16:56:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:56:45] pcoombe: OK, the banner impressions from 1AM till now should be in the db [16:58:21] oops, spoke too soon, that's still running [16:58:48] Fundraising-Backlog: Issue Report: Queue Consumer Offline 04-19-2018 - https://phabricator.wikimedia.org/T192573#4143415 (jgleeson) [16:58:50] landing pages are all set, banner imps are 2/3 caught up [17:00:26] Fundraising-Backlog: Issue Report: Queue Consumer Offline 04-19-2018 - https://phabricator.wikimedia.org/T192573#4143437 (jgleeson) Open>Resolved [17:01:04] pcoombe: ok, for real this time: banner impressions and landing page hits are all caught up [17:01:27] Fundraising-Backlog: Issue Report: Queue Consumer Offline 04-19-2018 - https://phabricator.wikimedia.org/T192573#4143415 (jgleeson) [17:03:27] the only yaml file that has a logging block is SmashPig.yaml [17:05:36] ejegg: ^^^ [17:06:31] Jeff_Green: ok, let's add those to the 4 config files that need them [17:06:59] the fragments are in my homedir on frpm, in a folder called toolslogging [17:15:52] ejegg: ok that's merged, it will apply over the next 10 min [17:19:35] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog, Patch-For-Review: Refund the unintended recurring donations from the tests pre big english - https://phabricator.wikimedia.org/T190854#4143519 (Xen... [17:20:09] thanks Jeff_Green [17:26:56] ejegg, are there any good canidates for core transformers we'd like in SmashPig... or are there any in our new ingenico integration we'd like to add to the createPayment request? I've finished the work to transform but now wondering how to test without making some TestTransformers [17:30:58] jgleeson: yeah, we do need the AmountInCents, at least [17:34:22] thanks! [17:34:47] Fundraising-Backlog, Epic: [EPIC] Banner history post launch - https://phabricator.wikimedia.org/T112923#1650175 (AndyRussG) New epic for the current round of possible improvements: {T192564} [17:37:59] gonna eat a bit, but I won't be far from the keyboard [17:44:02] Fundraising-Backlog, fundraising-tech-ops: frdev access for rschoenbaechler - https://phabricator.wikimedia.org/T191446#4143633 (cwdent) Date: Thu, 19 Apr 2018 03:15:19 +0200 From: Lisa Seitz Gruwell To: Casey Dentinger Subject: Re: rsch... [17:46:24] (PS1) Jgleeson: WIP - Added Mapper Transformer behaviour [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427723 [17:47:34] ejegg|food, feels like we should make an optimus prime one also, for good measure :) [17:52:59] (PS2) Jgleeson: WIP - Added Mapper Transformer behaviour [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427723 [17:53:18] (CR) jerkins-bot: [V: -1] WIP - Added Mapper Transformer behaviour [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427723 (owner: Jgleeson) [17:54:11] ah, I know what that is [17:54:31] my 'ComingSoonTransformer' doesn't exist .. yet [17:55:06] I'll fill that in tomorrow with the AmountInCents Transformer [17:55:19] fr-tech, I'm calling it a day. Have a great evening all, catch you tomorrow! [18:04:24] Fundraising-Backlog: Pivot and Analytics access for all FR-Tech - https://phabricator.wikimedia.org/T181629#3796522 (Nuria) These tools require different levels of access, please file access per user. Pivot just requires and ldap user (no ssh keys) both hive and swat require shell access so likely pms and fo... [19:06:01] (CR) Mepps: [C: 2] Change to new table for do_not_solicit field [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/427591 (owner: Eileen) [19:07:13] (Merged) jenkins-bot: Change to new table for do_not_solicit field [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/427591 (owner: Eileen) [19:12:20] Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising Sprint Elevators were never intended to go down, Fundraising Sprint Fhabricator is spelled with an "F", an... - https://phabricator.wikimedia.org/T186883#4143880 [19:30:18] ok fr-tech I'm going to try to deploy a tools update [19:30:27] crossing my fingers and hoping logging still works! [19:31:15] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/427769 [19:32:12] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/427769 (owner: Ejegg) [19:32:19] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/427769 (owner: Ejegg) [19:33:06] !log updated fundraising python tools from 626fe02a9f to 0c50f9e38f [19:33:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:34:25] well that didn't work [19:36:03] Fundraising-Backlog: Pivot and Analytics access for all FR-Tech - https://phabricator.wikimedia.org/T181629#4143974 (AndyRussG) >>! In T181629#4143681, @Nuria wrote: > These tools require different levels of access, please file access per user. Pivot just requires and ldap user (no ssh keys) both hive and sw... [19:43:30] Fundraising-Backlog: Pivot and Analytics access for all FR-Tech - https://phabricator.wikimedia.org/T181629#4144001 (Nuria) You can close the ticket then, every engineer then, will need to apply for access as it is granted per user. [19:51:49] Fundraising-Backlog: Issue Report: Queue Consumer Offline 04-19-2018 - https://phabricator.wikimedia.org/T192573#4144038 (Eileenmcnaughton) Dang I DID turn them back on - did I miss a step? I'm sure it asked me about restarting the services - so I must have actually pushed the change! [19:52:54] ejegg: I can talk triggers now if you want (although not voice etc as am in a car … passenger seat) [20:13:17] eileen: in a bit, just working out the new logging for the python tools so we can deploy that silverpop update [20:14:44] eileen so the code looks good, and the triggers that are generated seem correct [20:15:30] I'm just leary of getting rid of the special logic that we added to deal with weird refunds [20:15:46] till we know where we're still making those [20:25:57] Fundraising Sprint Tom Waits, fundraising-tech-ops, Fr-tech-archived-from-FY-2015/16, Unplanned-Sprint-Work: Paypal IPN log is not replicated to log server? - https://phabricator.wikimedia.org/T113323#4144133 (Ejegg) [20:25:59] Fundraising-Backlog: Legacy PayPal IPN listener should syslog - https://phabricator.wikimedia.org/T113386#4144131 (Ejegg) Open>declined Legacy PayPal IPN listener can RIP. Now using SmashPig like all the rest. [20:27:17] Fundraising Sprint Ivory Tower Defense Games, Fundraising Sprint turtles that are robotic that destroy the whole world with their foot, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: DonationInterface should log client-si... - https://phabricator.wikimedia.org/T121800#4144134 [20:39:54] ejegg: yeah - I guess my thinking is that when we fix those the triggers will update [20:39:57] and also [20:40:11] I think what we are doing now is OK after looking through the tests [20:40:24] basically the RefundTest kinda goes through it [20:40:35] ok [20:40:47] If we have a $50 contribution & it is refunded we change the status to refunded [20:40:50] well, lemme bang on it a bit more locally [20:41:01] & then we create an auxillary transaction for the balance [20:42:06] ejegg: for testing - you can alter a value in the setting table & the trigger sql will load when you do a system flush (drush cvapi System.flush trigger=1) - less painful than loading the sql your self [20:42:14] (if you have to do more than once etc) [20:42:43] eileen: ah, also you can just turn logging off and back on, right? [20:42:59] That seemed to at least hit the triggerInfo code [20:43:10] though I haven't checked the actual db state [20:53:07] yeah, got 'em in there fine [20:55:09] ejegg: yep turning logging on & off is the same effect (slightly slower arguably) [20:56:01] ejegg: BTW I could SWEAR I turned queues back on (despite all evidence to the contrary - I feel like S Spicer talkin about inauguration crowd sizes now!) [20:56:17] eileen: hehe [20:56:30] no worries, jgleeson says it was a good learning experience [20:57:16] even if you forget the 'git push', the eventual rsync_blaster will ask if you want to 'restart services' [20:57:29] by 'restart services' it just means regenerate the crontab [20:57:41] which may end up looking exactly like the old crontab [20:58:41] just going to get a feel for the number of contacts we're going to export with different values [21:04:58] ah ejegg yeah that would explain it - ie not doing the git push but doing all the other steps... [21:13:09] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog: Ingenico audit wobble? March 13 refunds not in Civi - https://phabricator.wikimedia.org/T190098#4062989 (mepps) I found the refund that got mapped to... [21:13:26] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising-Backlog: Ingenico audit wobble? March 13 refunds not in Civi - https://phabricator.wikimedia.org/T190098#4144366 (mepps) a:mepps [21:57:19] (CR) Ejegg: [C: 2] "OK, I'm convinced! I made some temp tables using the new logic, and spot checked a dozen or so where the new logic's last_donation_date wa" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425219 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [22:01:52] (Merged) jenkins-bot: Add triggers to manage yearly totals & associated custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/425219 (https://phabricator.wikimedia.org/T186168) (owner: Eileen) [22:20:37] feeling better XenoRyet ? [22:20:49] A bit, yea. [22:21:09] Headache is still hanging around, but trying to get some stuff done anyway. [23:01:18] XenoRyet: i'll be around for a few more min - if you've got any Qs related to the ct_id thing, now's your chance! [23:02:18] Na, I'm good. Just messing around with my debugger checking stuff. [23:03:14] ok [23:09:13] (PS11) Ejegg: Drush script to fill totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/427319 (owner: Eileen) [23:15:55] (CR) Ejegg: [C: -1] "Looks pretty good, just an error with the drush_print args at the end." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/427319 (owner: Eileen)