[14:28:11] mornin fr-tech [14:42:02] (PS3) Jgleeson: WIP - Added Mapper Transformer behaviour [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427723 [15:03:32] (PS12) Ejegg: Drush script to fill totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/427319 (https://phabricator.wikimedia.org/T186165) (owner: Eileen) [15:03:51] fr-tech I just did a minor touch-up on an eileen patch - anyone want to cross-check and approve? ^^ [15:04:02] (CR) Ejegg: [C: 1] Drush script to fill totals fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/427319 (https://phabricator.wikimedia.org/T186165) (owner: Eileen) [15:36:04] (PS3) Ejegg: Civix stub for SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) [15:36:31] (CR) jerkins-bot: [V: -1] Civix stub for SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) (owner: Ejegg) [15:56:00] crap, the Silverpop export failed last night [15:56:05] that needs fixin [15:59:51] also, those paypal orphans are getting pretty noisy [16:02:01] fr-tech, coming! [16:02:23] I'm the only one in the call right now [17:38:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: can we export all of a donor's data? - https://phabricator.wikimedia.org/T192677#4146534 (DStrine) [17:39:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: can we export all of a donor's data from Civi? - https://phabricator.wikimedia.org/T192677#4146544 (DStrine) [18:00:06] (PS4) Jgleeson: WIP - Added Mapper Transformer behaviour [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427723 [18:01:53] hey ejegg|food & mepps. The mapper transformers patch turned out to be a bigger than expected so I'm gonna submit that as a patch alone, and add the ingenico specific transformer as it's own patch also so it's easier to review. I'm conscious the mapper (which they both sit on) also hasn't gone through code review yet so I don't wanna get to comfy building lots of stuff on top of it [18:03:00] sorry that's not clear [18:03:23] s/ingenico specific transformer/Donation Inteface Amount Class/ [18:03:34] interface :( [18:04:20] but to summarise, there's now two patches, the mapper here: https://gerrit.wikimedia.org/r/#/c/427198/ and the mapper transformers here: https://gerrit.wikimedia.org/r/#/c/427723/ [18:05:02] ... with a third to follow for the stuff from DI we need (https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/gateway_common/Amount.php) [18:07:30] fr-tech, I'm wrapping up. Have a great weekend all!!!!! [18:38:12] dstrine fr-tech quick sanity check for a silly Phabby non-convention: Including the name of a general topic (like CentralNotice or Banner History) as the first word in the title of a Phab task--good or bad? [18:38:24] I keep doing it but maybe that's what tags are for [18:51:36] AndyRussG: I don't think it matters. [18:51:49] The task title character limit is huge [18:52:15] one should just get to the point as soon as possible in the task title so its easy to read [18:53:59] (PS1) Mepps: Add installment number to refund_id [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427946 [18:54:34] (CR) jerkins-bot: [V: -1] Add installment number to refund_id [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427946 (owner: Mepps) [18:55:05] (PS2) Mepps: Add installment number to refund_id [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427946 [18:57:08] ejegg ^^ [19:01:22] mepps taking a look [19:02:46] (PS3) Ejegg: Add installment number to refund_id [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427946 (owner: Mepps) [19:02:54] (CR) Ejegg: [C: 2] Add installment number to refund_id [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427946 (owner: Mepps) [19:03:21] (Merged) jenkins-bot: Add installment number to refund_id [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427946 (owner: Mepps) [19:04:58] Fundraising-Backlog, FR-Email: Spike: How to export specific users' email data - https://phabricator.wikimedia.org/T192675#4146798 (CCogdill_WMF) I wonder if the work Eileen has done in migrating IBM mailing activities to Civi is enough? What are you looking for specifically? [19:07:54] (PS1) Ejegg: Add missing db prefix [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/427950 [19:08:07] mepps: feel like looking at that one? ^^^ [19:08:24] I'm comfortable just merging and deploying if you're busy [19:10:10] dstrine: okok [19:10:36] aaarg Phabricator just ate my long beautifool task description [19:10:48] that does it! I'm spelling it with a "F" from now on [19:15:48] lol [19:17:59] Ffafrifafof [19:21:23] AndyRussG: do you have a really short yubikey? [19:21:28] ;) [19:26:00] Fundraising-Backlog: CentralNotice: Truer random selection in JS - https://phabricator.wikimedia.org/T192685#4146869 (AndyRussG) [19:29:59] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Truer random selection in JS - https://phabricator.wikimedia.org/T192685#4146887 (AndyRussG) [19:30:02] dstrine: 8p [19:32:33] (CR) AndyRussG: "Follow-up on Math.random() issue (in CentralNotice): T192685. Thanks!!!!!" [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/423952 (https://phabricator.wikimedia.org/T185933) (owner: AndyRussG) [19:36:58] (CR) Nuria: "Sorry, I do not understand what you mean, usages of math.random should be removed and replaced in this patch regardless of other patches." [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/423952 (https://phabricator.wikimedia.org/T185933) (owner: AndyRussG) [19:37:56] (CR) Ejegg: [C: 2] "Bit late for that... this patch is merged and deployed :)" [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/423952 (https://phabricator.wikimedia.org/T185933) (owner: AndyRussG) [19:40:56] (CR) AndyRussG: "> Sorry, I do not understand what you mean, usages of math.random should be removed and replaced in this patch regardless of other patches" [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/423952 (https://phabricator.wikimedia.org/T185933) (owner: AndyRussG) [20:05:54] (PS4) Ejegg: Civix stub for SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) [20:06:19] (CR) jerkins-bot: [V: -1] Civix stub for SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) (owner: Ejegg) [20:06:24] mepps do you have any idea what it takes to make the api bit show up in that patch ^^ [20:06:53] I haven't hardly changed anything from the omnipay version of the api/v3/Job folder [20:07:38] but every time I run it just to step through and figure out what params are missing [20:08:54] I get this in the job log: Failure, Error message: API (Job, process_smashpig_recurring) does not exist (join the API team and implement it!) [20:09:50] it's just the function name, right? [20:09:57] I cleared the drupal cache [20:16:24] grrr, so frustrating. [20:16:50] well, I'mma deploy that silverpop fix before it gets any later [20:16:58] (CR) Ejegg: [C: 2] Add missing db prefix [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/427950 (owner: Ejegg) [20:17:28] (Merged) jenkins-bot: Add missing db prefix [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/427950 (owner: Ejegg) [20:19:49] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/428004 [20:20:08] (CR) Ejegg: [C: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/428004 (owner: Ejegg) [20:20:14] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/428004 (owner: Ejegg) [20:23:29] !log updated fundraising python tools from 0c50f9e38f to 7c5c7a5f9e [20:23:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:49:26] (PS14) Ejegg: Capture Adyen payments missing pending messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/319489 (https://phabricator.wikimedia.org/T149861) [21:50:20] fr-tech this is the more complicated solution, but it would have prevented those stuck adyen payments from yesterday ^^^ [21:50:32] I'll put up a patch for the simpler solution too [22:10:56] ohhh man [22:11:04] freaking naming convention fail [22:11:30] The darn thing was looking for ProcessSmashpigRecurring.php [22:11:37] and not ProcessSmashPigRecurring.php [22:11:57] thank you 'MagicFunctionProvider' [22:12:52] mepps: I found it ^^^ [22:22:53] arr, and now I see why eileen's omnipay extension has those extra bits for retrieving payment processors [22:23:02] that part seems like it's missing from core [22:38:01] Fundraising-Backlog, FR-Smashpig: Queue retry logic shouldn't use original enqueued date - https://phabricator.wikimedia.org/T192692#4147170 (Ejegg) [22:40:48] hmm, maybe we SHOULD just write an omnipay adapter for SmashPig [22:47:42] (PS1) Ejegg: Use a new field to track retry count instead of age [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/428032 (https://phabricator.wikimedia.org/T192692) [22:51:55] OK, that's the simpler solution to the issue with Adyen yesterday ^^^ [23:09:36] (PS5) Ejegg: Civix stub for SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) [23:09:57] (CR) jerkins-bot: [V: -1] Civix stub for SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) (owner: Ejegg) [23:31:12] so long fr-tech! [23:36:24] ejegg weird I only just got notified of your pings!