[05:33:03] (PS13) Eileen: Use post hook rather than triggers for original amount / currency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429098 [05:37:45] (CR) jerkins-bot: [V: -1] Use post hook rather than triggers for original amount / currency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429098 (owner: Eileen) [06:40:45] (PS14) Eileen: Use post hook rather than triggers for original amount / currency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429098 [06:44:21] (CR) jerkins-bot: [V: -1] Use post hook rather than triggers for original amount / currency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429098 (owner: Eileen) [06:53:50] (PS15) Eileen: Use post hook rather than triggers for original amount / currency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429098 [06:58:21] (CR) jerkins-bot: [V: -1] Use post hook rather than triggers for original amount / currency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429098 (owner: Eileen) [07:00:25] (PS16) Eileen: Use post hook rather than triggers for original amount / currency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429098 [14:47:03] Fundraising-Backlog: Help to deploy new Thank you email in Dutch (with updated tax copy) - https://phabricator.wikimedia.org/T193228#4168110 (jrobell) Thank you @Pcoombe ! I think the Dutch version will be fine for know as I am assuming making the Thank you letter country specific is a much bigger task? I th... [14:56:33] Hi all.. heading into early meetings but I'm wondering if anyone could look at updating the NL thank you email if you have time before our standup: https://phabricator.wikimedia.org/T193228 I believe these changes will help DS [15:18:54] cwd / Jeff_Green can we get more deadlock info in the db logs? [15:19:03] Specifically, do we have this enabled? [15:19:09] https://mariadb.com/kb/en/library/xtradbinnodb-server-system-variables/#innodb_print_all_deadlocks [15:19:35] i'll check in a bit [15:20:51] thanks! [15:25:18] i'm pretty sure we already have that enabled [15:26:43] ah, great, in that case i oughtta look through those [15:27:07] might give some insight into what the heck is happening with the nightly failstorm [15:27:28] from the civi logs it looks like a double constraint vio [15:27:36] i.e. insert contact, get id [15:27:47] try to insert contrib, but contact id is now invalid [15:28:00] STILL GET contrib id (?!?!?!) [15:28:14] yikes [15:28:20] yeah it should be on everywhere [15:28:24] try to insert wmf_contrib_extra, THAT's when we get a blowup on constraint violation [15:28:54] so... we have some checks in the civi code to see if Civi has intentionally rolled back anything [15:28:58] and those aren't firing [15:29:20] hmm, recurring GC failmail? ut-oh [15:29:44] oh hey, that same darn constraint vio [15:30:03] fr-tech any interest in making those rgc insert failures easier to re-queue? [15:30:08] pretty simple patch: [15:30:22] https://gerrit.wikimedia.org/r/429118 [15:32:43] dstrine: sure, ty email update should be simple [15:33:03] fr-tech anyone want to run through how to do that? ^^^ [15:36:16] dstrine: oh hey, that 'Dear Donor' bit is still untranslated [15:38:19] ejegg: can you comment on the task exactly what you are seeing? [15:40:30] pcoombe already pointed it out, and jrobell says she's checking on it [16:08:42] i can look at that patch ejegg [16:09:25] thanks! [16:09:33] (CR) Mepps: [C: 2] Recurring GC job sends queue message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429118 (owner: Ejegg) [16:47:05] mepps thanks again! There's a parent patch that just does drupal style reformatting [16:47:12] https://gerrit.wikimedia.org/r/429117 [16:47:25] (Abandoned) Ejegg: Merge branch master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/427204 (owner: Ejegg) [16:47:36] (CR) Mepps: [C: 2] Reformat rgc.module and tests to drupal standard [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429117 (owner: Ejegg) [16:48:07] ejegg: oh yeah let's update that and trainify it this week, sound good? [16:48:30] AndyRussG: yes, let's! [16:52:19] (Merged) jenkins-bot: Reformat rgc.module and tests to drupal standard [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429117 (owner: Ejegg) [16:52:19] (Merged) jenkins-bot: Recurring GC job sends queue message [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429118 (owner: Ejegg) [16:53:42] ejegg: :) [17:24:47] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4168747 (cwdent) SSL certs are what allow your browser to show you a green bar and guarantee that if you see that, you are talking to the Wikimedia Fo... [17:25:20] Fundraising-Backlog: Help to deploy new Thank you email in Dutch (with updated tax copy) - https://phabricator.wikimedia.org/T193228#4168748 (jrobell) I have updated the missing "Dear donor" in Dutch and re-published the letter. Should be good to go! [17:27:06] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4168760 (Ejegg) cwdent we formerly had silverpop-hosted urls in the email links, and lots of people thought they were phishing spam [17:28:52] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4168775 (CCogdill_WMF) We used a Silverpop URL for a few months and got enough complaints from donors that our Donor Services team asked us to turn cl... [18:31:06] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog: [Spike] Plan ingress system to use with new Kafka topic for landing page and impression dat... - https://phabricator.wikimedia.org/T192839#4169022 [18:47:27] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4169093 (cwdent) @Ejegg @CCogdill_WMF ok scratch that idea :) [19:17:18] (CR) Jgleeson: "Thanks for the feedback! I've added some comments where I think we might need some more conversation and applied updates suggested for the" (4 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427198 (owner: Jgleeson) [19:18:53] (CR) Jgleeson: Add new Mapper component. Add createPayment.yaml map for ingenico createPayment call. (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427198 (owner: Jgleeson) [19:29:06] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog: [Spike] Plan ingress system to use with new Kafka topic for landing page and impression dat... - https://phabricator.wikimedia.org/T192839#4169228 [19:38:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice - CSP overreach - https://phabricator.wikimedia.org/T193332#4169307 (Ejegg) Also: check if the report-only version of the header still lets us catch the sources [19:40:20] Fundraising-Backlog: Help to deploy new Thank you email in Dutch (with updated tax copy) - https://phabricator.wikimedia.org/T193228#4163494 (DStrine) [19:42:56] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Rash of errors consuming donations queue - https://phabricator.wikimedia.org/T192977#4169319 (DStrine) [19:43:13] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog: Help to deploy new Thank you email in Dutch (with updated tax copy) - https://phabricator.wikimedia.org/T193228#4169322 (DStrine) [19:45:19] Fundraising-Backlog: JSON->CSV tool for Pats - https://phabricator.wikimedia.org/T192956#4169332 (DStrine) [21:13:10] eileen: I think that 'contact_id is invalid : ' is a red herring [21:13:55] basically, I think _civicrm_api3_validate_foreign_keys is being called AFTER the rollback [21:30:55] (PS1) Ejegg: Catch rollbacks between contrib and post hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429987 (https://phabricator.wikimedia.org/T192977) [21:32:26] ejegg ohhhh [21:54:42] (PS2) Eileen: Commit regenerated triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/428544 [21:59:47] (PS1) Eileen: Commit regenerated triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429990 [22:07:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Excessive modified_date triggers locking civicrm_contact - https://phabricator.wikimedia.org/T193446#4169801 (Ejegg) [22:15:12] (PS17) Ejegg: Use post hook rather than triggers for original amount / currency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429098 (owner: Eileen) [22:15:25] (CR) Ejegg: [C: 2] Use post hook rather than triggers for original amount / currency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429098 (owner: Eileen) [22:17:03] cwd we'd like to deploy ^^^ soon - it'll involve a short job disablement and a trigger update [22:17:35] looking [22:22:55] ejegg: i don't see any changes to triggers? [22:23:42] (Abandoned) Eileen: Commit regenerated triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/428544 (owner: Eileen) [22:23:54] cwd - we have a change to roll out [22:24:01] which changes triggers a bit [22:24:18] (Merged) jenkins-bot: Use post hook rather than triggers for original amount / currency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429098 (owner: Eileen) [22:24:20] & will hopefully address those new failmails [22:24:34] (need to roll out a code change concurrent with trigger change) [22:29:40] ok gotcha [22:30:47] i guess as long as the jobs are disabled there's a very low % chance of anything going seriously wrong [22:36:25] (PS1) Eileen: Revert change to exclude contribution extra from trigger join [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429997 [22:36:55] (CR) Ejegg: [C: 2] Revert change to exclude contribution extra from trigger join [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429997 (owner: Eileen) [22:37:23] (PS1) Eileen: Pass skipRecentView from a couple of places for (v minor) speed up [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429998 [22:38:52] (CR) Ejegg: [C: 2] Pass skipRecentView from a couple of places for (v minor) speed up [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429998 (owner: Eileen) [22:39:11] cwd yep that's the case - if any issues then a revert is the plan [22:39:36] I guess ideally we'd do it later when people are mostly off - but also ideally when us 3 are still around [22:40:09] (Abandoned) Eileen: Commit regenerated triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429990 (owner: Eileen) [22:40:14] yeah that happens pretty frequently [22:40:47] i'm going to hit the grocery store soon but could probably be around later if it's urgent [22:41:18] (PS4) Ejegg: API call to tokenize old GC recurring [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/421665 (https://phabricator.wikimedia.org/T169357) [22:41:44] (Merged) jenkins-bot: Revert change to exclude contribution extra from trigger join [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429997 (owner: Eileen) [22:45:22] (Merged) jenkins-bot: Pass skipRecentView from a couple of places for (v minor) speed up [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429998 (owner: Eileen) [22:48:22] (PS1) Eileen: Improve deadlock error [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/430002 [22:48:45] cwd it's not super urgent - since failmails started last week [22:49:20] but def needs to be in the next day or 2 [22:50:20] eileen: ok, will you be around in a couple hours? [22:52:52] cwd yes [23:08:34] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog, and 4 others: Update API address f... - https://phabricator.wikimedia.org/T187809#3986510 [23:10:55] (CR) Ejegg: Improve deadlock error (2 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/430002 (owner: Eileen) [23:11:15] eileen: cool, i will check back and if stuff looks good we can run the file [23:22:42] (CR) Ejegg: [C: -1] "Maybe catch the error up in the CRM wrapper layer?" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/428940 (https://phabricator.wikimedia.org/T191654) (owner: Mepps) [23:24:46] (PS2) Eileen: Improve deadlock error [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/430002 [23:25:06] (CR) Eileen: "Updates submitted" (2 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/430002 (owner: Eileen) [23:37:14] (CR) Ejegg: [C: 2] Improve deadlock error [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/430002 (owner: Eileen) [23:41:52] (Merged) jenkins-bot: Improve deadlock error [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/430002 (owner: Eileen)