[00:02:04] (CR) XenoRyet: [C: 2] Query for updating contributions mistakenly marked refunded [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429097 (https://phabricator.wikimedia.org/T190098) (owner: Mepps) [00:02:12] Yea, looks ok to me [00:02:25] Anyway, gotta run and pick up the kid. Catch you tomorrow. [00:06:48] (Merged) jenkins-bot: Query for updating contributions mistakenly marked refunded [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429097 (https://phabricator.wikimedia.org/T190098) (owner: Mepps) [00:07:43] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/431680 [00:07:44] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/431680 (owner: Ejegg) [00:08:32] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/431680 (owner: Ejegg) [00:12:12] !log updated CiviCRM from 9752607052 to 81e54c850d [00:12:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:12:49] ok, running that update [00:13:20] d'oh, missing params [00:47:10] (PS4) Eileen: Add bitpay import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) [00:47:12] (PS1) Eileen: Trigger update - allow NULL trxn_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431683 (https://phabricator.wikimedia.org/T186165) [00:47:18] (CR) jerkins-bot: [V: -1] Add bitpay import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) (owner: Eileen) [00:47:24] (CR) jerkins-bot: [V: -1] Trigger update - allow NULL trxn_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431683 (https://phabricator.wikimedia.org/T186165) (owner: Eileen) [00:47:29] ejegg: cwd - trigger update is [00:47:56] https://gerrit.wikimedia.org/r/#/c/431683/ [00:48:11] dang - [00:48:37] (PS2) Eileen: Trigger update - allow NULL trxn_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431683 (https://phabricator.wikimedia.org/T186165) [00:48:49] ok - that's better :-) [00:53:33] (PS5) Eileen: Add bitpay import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) [00:54:55] ejegg: [00:54:57] (PS6) Eileen: Add bitpay import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) [00:55:21] just fixed bitpay to bitcoin - do you think that is all that is needed for now? (Until we get new data in) [00:59:51] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: assess GDPR civi extension and try to export all of a donor's data from Civi - https://phabricator.wikimedia.org/T192677#4146534 (Eileenmcnaughton) I've put this in 'done' since... [01:07:17] thanks eileen, taking a look [01:07:41] and yeah, I think that's as good as we can do with the CSV [01:08:30] (CR) Ejegg: [C: 2] Trigger update - allow NULL trxn_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431683 (https://phabricator.wikimedia.org/T186165) (owner: Eileen) [01:10:10] eileen: oh shoot, one other little thing with bitpay - I don't think we want to set no_thank_you [01:10:30] we DO send out TY letters for coinbase imports, I'm pretty sure [01:13:00] (Merged) jenkins-bot: Trigger update - allow NULL trxn_id [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431683 (https://phabricator.wikimedia.org/T186165) (owner: Eileen) [01:14:01] (CR) Ejegg: [C: -1] "one more tweak for the default vals" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) (owner: Eileen) [01:15:31] ejegg: ah - that was copied from 'others' [01:16:24] (PS7) Eileen: Add bitpay import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) [01:16:24] ok - removed [01:17:06] thanks! There was one more comment in there about making payment_method match coinbase too [01:17:18] ejegg: re setting payment_method - any idea why we do that? Payment Method is normally a psuedonym for payment instrument [01:17:41] the comment in Coinbase says it makes its way into contribution_tracking [01:17:47] ah ok [01:18:17] (CR) Ejegg: [C: 1] "Dang, shoulda tested this on staging before merging :(" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/429097 (https://phabricator.wikimedia.org/T190098) (owner: Mepps) [01:18:19] (PS8) Eileen: Add bitpay import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) [01:18:20] ok - changed it [01:20:54] eileen: hmm, it's not showing up in the file format selector, dang hardcoded list! [01:21:17] offline2civicrm.module [01:21:46] dumbly, needs to be added to TWO hardcoded lists [01:22:00] ejegg: bugger - let me look [01:22:02] gonna run a quick errand, but I'll take another look in 20-30 min [01:23:03] ejegg|afk: updated [01:54:12] (PS9) Eileen: Add bitpay import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) [01:56:09] (PS10) Eileen: Add bitpay import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) [02:58:58] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog, Patch-For-Review: Adapt Druid banenr_activity jobs to EventLogging-based impression recording - https://phabricator.wikimedia.org/T186048#4189098 (AndyRussG) > There are two fields that in Druid that we can't current... [03:08:24] (CR) Ejegg: [C: 2] "Looks good!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) (owner: Eileen) [03:08:30] (PS11) Ejegg: Add bitpay import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) (owner: Eileen) [03:13:12] (CR) Ejegg: [C: 2] Add bitpay import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) (owner: Eileen) [03:17:38] (Merged) jenkins-bot: Add bitpay import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430286 (https://phabricator.wikimedia.org/T192953) (owner: Eileen) [03:50:03] (PS1) Ejegg: Reformat WmfException [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431694 [03:50:05] (PS1) Ejegg: No more magic strings for WmfException [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431695 [03:53:07] eileen: thanks for the inspiration on that one ^^^ [03:54:54] (CR) jerkins-bot: [V: -1] No more magic strings for WmfException [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431695 (owner: Ejegg) [03:55:58] phooey [03:56:09] well that'll get stale fast [03:57:27] ejegg|away: ah we need to get them merged before ANYTHING changes [04:00:33] (CR) Eileen: [C: 2] Reformat WmfException [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431694 (owner: Ejegg) [04:01:50] not sure why that test is failing, but it's super late here... I'll have to fix it up in the morning [04:04:58] (Merged) jenkins-bot: Reformat WmfException [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431694 (owner: Ejegg) [07:00:18] PROBLEM - check_procs on frdev1001 is CRITICAL: PROCS CRITICAL: 1731 processes [07:05:13] RECOVERY - check_procs on frdev1001 is OK: PROCS OK: 273 processes [14:55:56] Wikimedia-Fundraising-Banners, Browser-Support-Internet-Explorer: IE11: dsk lg PTF opens immediately on banner load w/o amount selection - https://phabricator.wikimedia.org/T191417#4190866 (Pcoombe) It appears that something is triggering the `input` event on `#frb-amt-other-input` and hence the `frb.upd... [15:05:15] RECOVERY - Host rigel is UP: PING OK - Packet loss = 0%, RTA = 37.89 ms [15:18:42] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/431766 [15:19:03] (PS1) Mepps: Fetch messages from DamagedDatabase [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431767 (https://phabricator.wikimedia.org/T190098) [15:20:29] hellosies [15:21:03] fr-tech ^ gonna +2 the merge to deploy accumulated CN stuff for today's train [15:22:21] (just a merge for deploy, so supposedly self+2'ing is allowed, pls lmk if anyone sees anything amiss there, tho! :) ) [15:31:01] (CR) AndyRussG: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/431766 (owner: AndyRussG) [15:35:34] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/431766 (owner: AndyRussG) [15:44:32] (PS3) Mepps: WIP: Ingenico ct_id fix. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/431676 (https://phabricator.wikimedia.org/T190871) (owner: XenoRyet) [15:45:11] jgleeson can you take a look at XenoRyet's WIP ^^ [16:09:46] mepps, will do [16:13:09] mepps, is this a finished patch? It's marked as WIP [16:13:43] i don't think so jgleeson, but i'm curious what it's doing and if you can support XenoRyet on closing it out [16:14:16] ok cool, I'll do the end-to-end test before, and after to see if it patches the bug [16:14:57] it's been a while since I looked at this particular one [16:15:47] THe basic idea of it was that the finalize functions do properly clear the session the way we need, but the call to session_addDonorData was undoing that. [16:16:28] I haven't run the test end to end though. [16:16:56] it was a tricky one to recreate if I remember correctly [16:36:16] jgleeson: I was able to test it pretty easily just using the back button from the Thank You page [16:50:07] ejegg, my setup is a little funky [16:50:24] for me, the thank you page loads in the portal iframe [16:50:27] oh? [16:50:37] shoot, that's not right! [16:50:41] so I ended up just refreshing the page [16:50:59] and prior to working that out, I was clearing the session in chrome tools to do a clean comparison [16:51:08] but managed to recreate it in the end [16:51:13] weird, i wonder why the framebuster thing doesn't work? [16:51:38] I'll email you what I get [16:51:41] this is under the default vagrant setup? [16:51:45] although, sometimes it works as expected [16:51:49] huh [16:51:49] yup [16:54:15] yeah I've been meaning to fix it, emailed you over what happens [16:54:34] XenoRyet, mepps, looks like the bug is still there! [16:54:50] I'll step through it to see if I can see anything [17:01:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviMail default email - https://phabricator.wikimedia.org/T194183#4191353 (LeanneS) [17:08:25] (CR) Jgleeson: Ported Mapper Transformer behaviour from DI. (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427723 (owner: Jgleeson) [17:09:01] (PS11) Jgleeson: Ported Mapper Transformer behaviour from DI. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427723 [18:11:19] (CR) Ejegg: [C: 2] Ported Mapper Transformer behaviour from DI. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427723 (owner: Jgleeson) [18:11:44] (Merged) jenkins-bot: Ported Mapper Transformer behaviour from DI. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/427723 (owner: Jgleeson) [18:22:08] (PS13) Ejegg: WIP: SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) [18:54:42] (PS1) Ejegg: Fix typo, use 'description' as normalized param [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431819 [19:05:58] mepps: is there a Civi setting for organization name somewhere? [19:06:57] I'd like to include a generic 'Monthly donation to %1' localization string in the smashpig civi extn [19:09:27] aha, found it [19:10:13] (PS1) Jgleeson: Added support for compound placeholder map values [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431820 [19:13:44] (PS2) Jgleeson: Added support for compound placeholder map values [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431820 [19:14:02] (CR) jerkins-bot: [V: -1] Added support for compound placeholder map values [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431820 (owner: Jgleeson) [19:15:36] (PS3) Jgleeson: Added support for compound placeholder map values [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431820 [19:26:18] (PS4) Jgleeson: Added support for compound placeholder map values [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431820 [19:29:55] (PS14) Ejegg: WIP: SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) [20:04:54] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog: Edit bitpay page inside their console - https://phabricator.wikimedia.org/T192790#4192051 (Ejegg) Open>Resolved [20:05:00] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Rash of errors consuming donations queue - https://phabricator.wikimedia.org/T192977#4192052 (Ejegg) Open>Resolved [20:05:10] Fundraising Sprint Judgement Suspenders, Fundraising Sprint Loose Lego Carpeting, Fundraising-Backlog, FR-Ingenico, and 4 others: Epic: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#4192054 (Ejegg) [20:05:12] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog, and 3 others: Store recurring toke... - https://phabricator.wikimedia.org/T165695#4192053 [20:05:59] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog, and 2 others: Add yearly totals to... - https://phabricator.wikimedia.org/T186165#4192056 [20:09:34] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: assess GDPR civi extension and try to export all of a donor's data from Civi - https://phabricator.wikimedia.org/T192677#4192070 (Eileenmcnaughton) anonymise - ip address needs t... [20:11:52] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: assess GDPR civi extension and try to export all of a donor's data from Civi - https://phabricator.wikimedia.org/T192677#4192077 (DStrine) Open>Resolved [20:12:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Try to get anonymise extension working for civi - https://phabricator.wikimedia.org/T194209#4192080 (Eileenmcnaughton) [20:15:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Update CiviCRM to latest point version - https://phabricator.wikimedia.org/T194210#4192099 (Eileenmcnaughton) [20:22:00] eileen: i18n in Civi looks like it is all about the current user's display language [20:22:24] not very usable for batch things that have to localize for lots of different contacts [20:28:25] ejegg: what are you trying to translate - sounds about right [20:28:56] want to add a "Monthly donation to %1" string [20:32:29] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint J 2018, Fundraising-Backlog, Patch-For-Review: Adapt Druid banenr_activity jobs to EventLogging-based impression recording - https://phabricator.wikimedia.org/T186048#4192153 (DStrine) [20:32:46] Fundraising Sprint J 2018, Fundraising-Backlog: Cancel & refund the remaining unintended recurring donations from Big EN - https://phabricator.wikimedia.org/T192958#4192156 (DStrine) [20:32:53] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint J 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create bitpay import - https://phabricator.wikimedia.org/T192953#4192157 (DStrine) [20:33:04] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint J 2018, Fundraising-Backlog: [Spike] Plan ingress system to use with new Kafka topic for ... - https://phabricator.wikimedia.org/T192839#4192158 [20:33:08] Fundraising Sprint J 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Update CiviCRM to latest point version - https://phabricator.wikimedia.org/T194210#4192159 (DStrine) [20:33:11] Fundraising Sprint J 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Try to get anonymise extension working for civi - https://phabricator.wikimedia.org/T194209#4192160 (DStrine) [20:33:17] Fundraising Sprint J 2018, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice - CSP overreach - https://phabricator.wikimedia.org/T193332#4192161 (DStrine) [20:33:23] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint J 2018, Fundraising-Backlog: 2 fundraising tech grafana dashboards broken - https://phabricator.wikimedia.org/T193056#4192162 (DStrine) [20:33:32] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint J 2018, and 3 others: Ingenico Conne... - https://phabricator.wikimedia.org/T190871#4192163 [20:33:55] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint J 2018, and 2 others: Ingenico audit... - https://phabricator.wikimedia.org/T190098#4192164 [20:35:02] Fundraising Sprint Fhabricator is spelled with an "F", Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, ... - https://phabricator.wikimedia.org/T189613#4192171 [20:35:07] Fundraising Sprint J 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: add Partner field to summary section in donor record - https://phabricator.wikimedia.org/T185048#4192172 (DStrine) [20:35:14] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T178930#4192173 [20:35:50] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint J 2018, Fundraising-Backlog, and 2 others: Write script to charge Ingenico recurring dona... - https://phabricator.wikimedia.org/T170973#4192176 [20:35:57] Fundraising Sprint Fhabricator is spelled with an "F", Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, ... - https://phabricator.wikimedia.org/T163953#4192177 [20:46:39] ejegg, I pushed an update to support our compound values in map files here https://gerrit.wikimedia.org/r/#/c/431820/ [20:46:50] Do you want me to pull down your civi patch first thing tomorrow and give it a go? [20:47:00] I know it's WIP [20:47:12] but guess it would be good in advance of our chat [20:47:20] thanks, I'll take a look [20:47:24] and yeah, please go ahead [20:47:31] also, XenoRyet|food I'll spend some time digging into the ct_id patch bug [20:47:33] you'll want to run drush updb after pulling it down [20:47:41] ok cool, will do [20:48:12] mmm, then you'll need to set a recurring payment due to today to run it [20:48:20] i'll add a note to the commit message [20:48:30] thanks [20:53:49] dstrine: did u say we should merge in the other CSP thing (the one mentioning silverpop)? I was gonna comment asking for more info [20:54:26] AndyRussG: I decided not to merge them since they may be slightly different [20:54:28] (PS6) Jgleeson: Added manual test cli script for Ingenico createPayment call [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/428945 [20:55:04] dstrine: ok thx :) [20:55:44] (PS7) Jgleeson: Added manual test cli script for Ingenico createPayment call [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/428945 [20:57:58] fr-tech: in other bastion news Jeff_Green and papaul got rigel back to life so it is now stretch, you will get some hollering about host verification [20:58:09] but go ahead and do the delete command it prints [20:58:12] jgleeson: little typo fix: https://gerrit.wikimedia.org/r/431819 [20:58:12] Fundraising-Backlog, Wikimedia-Fundraising-Banners: CSP would break "Remind me later" functionality - https://phabricator.wikimedia.org/T194019#4186039 (AndyRussG) Ah ok... Which banner is this happening on? (Just wanted to check exactly how the link is working in the page...) Thanks!!! :) [20:58:20] thanks for the heads-up cwd [20:58:37] you betcha [20:58:58] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint Junebugs prefer July , Fundraising-Backlog: 2 fundraising tech grafana dashboards broken - https://phabricator.wikimedia.org/T193056#4192255 (jgleeson) Fixed by ops [20:59:14] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint Junebugs prefer July , Fundraising-Backlog: 2 fundraising tech grafana dashboards broken - https://phabricator.wikimedia.org/T193056#4192256 (jgleeson) Open>Resolved [21:02:53] (CR) Jgleeson: [C: 2] Fix typo, use 'description' as normalized param [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431819 (owner: Ejegg) [21:02:54] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising-Backlog, and 2 others: Add yearly totals to... - https://phabricator.wikimedia.org/T186165#4192281 [21:03:11] fundraising-tech-ops: re-image rigel as stretch - https://phabricator.wikimedia.org/T194062#4192283 (cwdent) @ayounsi rigel is now running as stretch, I'll wait to close till that's reverted [21:03:17] (Merged) jenkins-bot: Fix typo, use 'description' as normalized param [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431819 (owner: Ejegg) [21:03:29] thanks! [21:03:50] (PS8) Jgleeson: Added manual test cli script for Ingenico createPayment call [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/428945 [21:04:27] (PS5) Jgleeson: Added support for compound placeholder map values [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431820 [21:04:58] ejegg, good spot! sorry :| [21:05:22] merged and I rebased the two patches I pushed earlier [21:06:01] cool, cool [21:06:22] g'night fr-tech. Catch you all tomorrow! [21:16:58] fundraising-tech-ops: re-image rigel as stretch - https://phabricator.wikimedia.org/T194062#4192334 (ayounsi) Open>Resolved Reverted. [21:19:08] fundraising-tech-ops, Patch-For-Review: DNS name for new fundraising bastion - https://phabricator.wikimedia.org/T193178#4192338 (Jgreen) Open>Resolved a:Jgreen done [21:26:59] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/431993 [21:32:58] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/431993 (owner: Eileen) [21:33:54] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/431993 (owner: Eileen) [21:36:52] !log civicrm revision changed from 81e54c850d to d9d412e496, config revision is 96fbded693 [21:36:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:37:12] cwd updated trigger script to load is at sites/all/modules/wmf_civicrm/scripts/4.7.trigger.mysql [21:37:16] (CR) Ejegg: [C: 2] "Looks good!" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431820 (owner: Jgleeson) [21:37:40] (Merged) jenkins-bot: Added support for compound placeholder map values [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431820 (owner: Jgleeson) [21:38:44] eileen: ok [21:44:09] cwd should I add a phab to load it or will you just do it? [21:44:47] Fundraising-Backlog, fundraising-tech-ops: Refresh civicrm triggers - https://phabricator.wikimedia.org/T194218#4192465 (cwdent) [21:45:08] eileen: heh ^ [21:45:26] it's not totally rote [21:49:08] cwd thx [21:49:50] it's not urgent because the sorts of contacts that would be missed are oddball ones anyway that they won't miss them not being in their searches [21:50:10] ok cool [21:50:17] i will get to it before long [21:51:52] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint Junebugs prefer July , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create bitpay import - https://phabricator.wikimedia.org/T192953#4155097 (Eileenmcnaughton) Open>Resolved [21:54:21] (CR) Ejegg: [C: 2] Added manual test cli script for Ingenico createPayment call [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/428945 (owner: Jgleeson) [21:54:49] (Merged) jenkins-bot: Added manual test cli script for Ingenico createPayment call [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/428945 (owner: Jgleeson) [21:56:21] sigh [21:56:24] kernel updates again [21:56:55] all the boxen need rebootin? [21:57:32] yeah [21:57:36] i just did it last week [21:57:37] wheee [21:57:46] critical bug? [21:59:15] proooooobably not' [21:59:18] for us anyway [22:04:07] Fundraising-Backlog, fundraising-tech-ops, Operations, Traffic: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561#4192548 (cwdent) The problems I see are: - content served over http - weak DH supported (https://weakdh.org/) resulting in "B" grade from Qualys I d... [22:09:49] (PS2) Ejegg: Fetch messages from DamagedDatabase [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431767 (https://phabricator.wikimedia.org/T190098) (owner: Mepps) [22:10:00] (CR) Ejegg: [C: 2] Fetch messages from DamagedDatabase [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431767 (https://phabricator.wikimedia.org/T190098) (owner: Mepps) [22:10:26] (Merged) jenkins-bot: Fetch messages from DamagedDatabase [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/431767 (https://phabricator.wikimedia.org/T190098) (owner: Mepps) [22:15:05] (PS2) Ejegg: Use a new field to track retry count instead of age [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/428032 (https://phabricator.wikimedia.org/T192692) [22:16:24] (PS1) Ejegg: Try again to fix refunds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/432006 (https://phabricator.wikimedia.org/T190098) [22:16:31] XenoRyet: that refund fix didn't take last night [22:16:50] the create api had some dumb require fields, even with the id given [22:16:59] so I'mma try ^^^ on the staging db [22:17:08] Sounds good [22:17:20] I'll take a look at the patch. Let me know how the staging test goes. [22:19:03] XenoRyet: you know how to deploy stuff to civi staging? [22:19:30] I did it once forever ago [22:19:42] It's basically just git [22:20:02] Yea, that's what I remember. Just checkout the branch you want. [22:23:39] ah damn, that didn't work on staging, looks like the hardcoded db names blocked that [22:26:54] (PS2) Ejegg: Try again to fix refunds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/432006 (https://phabricator.wikimedia.org/T190098) [22:28:37] (PS3) Ejegg: Try again to fix refunds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/432006 (https://phabricator.wikimedia.org/T190098) [22:31:30] well, the db names are good now, but it looks like it still wants the missing keys: financial_type_id, total_amount, contact_id [22:31:38] guess we'll have to fetch and update, bummer [22:32:32] oh wait, or pull those all in from the initial query! [22:36:34] XenoRyet: what's the latest on the ct_id bug? are you just waiting for code review? [22:37:29] Jack said it didn't work when he tried it, though he didn't get 'round to seeing why yet. [22:38:08] I was going to look through it again today, then try to snag him in the morning to go over it. [22:57:32] XenoRyet: but it's working for you locally? [22:58:02] Also, want to add a test? [22:59:58] Yea, a test would be a good idea. I'll work on that. [23:01:50] XenoRyet: are you familiar with the existing tests that use fake session stuff? There should be one that simulates a couple txns in the same session [23:02:29] Yea, I saw that one in there. It's actually one of the ones I was using to try to debug. [23:03:09] OK, cool [23:03:25] testResetOnGatewaySwitch is the one I was going to suggest [23:03:45] Cool, I'll look at that. [23:06:01] Though do you have the settings to connect to the test environment? Mine got wiped out last time I futzed with vagrant too much and I can't find them again. [23:06:58] Been just using the tests to step though the functions instead of actually hitting ingenico [23:07:12] XenoRyet: I think they're on the deploy server [23:07:39] I looked around there, but I couldn't seem to find them. [23:07:42] let me look again. [23:07:51] in the setting repo [23:08:14] under SmashPig/snadbox-config/ingenico [23:09:04] Oh, it goes in SmashPig now? [23:09:16] cool [23:12:13] yep, that's the plan, move all the setting over so as not to duplicate! [23:12:29] Yea, I remember that plan now. [23:15:05] (PS4) Ejegg: Try again to fix refunds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/432006 (https://phabricator.wikimedia.org/T190098) [23:17:23] woot! [23:17:33] XenoRyet: PS4 seems to be working on staging [23:17:35] ^^^ [23:17:43] Cool, I'll take a quick look. [23:19:51] (CR) XenoRyet: [C: 2] Try again to fix refunds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/432006 (https://phabricator.wikimedia.org/T190098) (owner: Ejegg) [23:23:10] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/432015 [23:23:18] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/432015 (owner: Ejegg) [23:24:09] (Merged) jenkins-bot: Try again to fix refunds [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/432006 (https://phabricator.wikimedia.org/T190098) (owner: Ejegg) [23:24:16] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/432015 (owner: Ejegg) [23:25:51] !log updated CiviCRM from d9d412e496 to 4ff35ad4bb [23:25:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:27:23] ok, running the fix again [23:55:51] Alright, heading out. See everyone tomorrow.