[00:25:59] dstrine-away: if you are around in 30 mins can we talk GDPR ? [00:27:19] Fundraising-Backlog: Creating a new record without email - https://phabricator.wikimedia.org/T195266#4221597 (Eileenmcnaughton) We altered this on the call @MBeat33 FYI Now email is optional for new org & website is also there as an optional field. @NNichols I guess you want email optional on individual t... [01:33:06] cwd: yep there's a wee JS bug there [01:34:04] Basically when you set the impression sample rate manually using the URL param, it doesn't munge it to a number properly [01:34:25] So when sending that data point on the event, it's sent as a string, but the schema has it as a number [01:34:29] so the schema doesn't validate it [01:34:53] and it doesn't come down the normal Kafka pipe but rather is shunted into the invalid schema pipe [01:35:10] I'll make a task and put up a patch :) [01:49:12] AndyRussG: great! guessing my firefox thing is something else...i'll keep an eye on it [01:50:50] cwd: yeah exactly.... what exact version of FF do you have? [01:51:45] AndyRussG: ff 60 [01:52:21] ublock, noscript, and privacy badger but all allowed for these pages [02:52:03] cwd: ok cool thx! minor version numbers? I was gonna try and download the exact same version, to see if I could reproduce [02:52:49] It could be a regression of the old bug that hid calls to sendBeacon from the Network tab in previous versions [02:52:56] mmm that's my first guess [03:07:42] Fundraising-Backlog: Testing infrastructure for EventLogging ingress of banner impression and landing page data - https://phabricator.wikimedia.org/T195259#4221635 (AndyRussG) I think this involves: - a test Kafkatee instance, - a test database, and - a test DjangoBannerStats job and config to slurp up the f... [03:35:32] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Some URL params break EventLogging impression schema - https://phabricator.wikimedia.org/T195276#4221676 (AndyRussG) [03:36:02] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Epic: [Epic] Kafkatee changes - https://phabricator.wikimedia.org/T183978#4221688 (AndyRussG) [03:36:04] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Some URL params break EventLogging impression schema - https://phabricator.wikimedia.org/T195276#4221687 (AndyRussG) [03:55:42] (PS1) AndyRussG: Convert numerical URL parameters to numbers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/434433 (https://phabricator.wikimedia.org/T195276) [03:57:01] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Some URL params break EventLogging impression schema - https://phabricator.wikimedia.org/T195276#4221693 (AndyRussG) [06:08:30] o/ [14:54:44] fundraising-tech-ops, Operations, ops-codfw: Interface errors on pfw3a-codfw:xe-0/0/17 - https://phabricator.wikimedia.org/T195216#4222516 (Papaul) a:Papaul>ayounsi optic replaced [15:08:46] hi fr-tech! [15:08:52] hi ejegg! [15:08:57] welcome back [15:09:05] thanks! how's it going? [15:09:10] ejegg: hellosie-os! [15:09:21] it's okok [15:09:26] how was ur trip? [15:09:32] really nice [15:10:23] besides checking out barcelona and valencia, i got to work on the commons android app with turkish and japanese volunteers [15:10:44] and we actually had something ready and working in time for the final presentation [15:12:09] ejegg: wooo congrats! :) [15:12:31] :) thanks [15:12:35] sounds like lots of fun [15:12:58] for sure [15:13:46] * ejegg winces at inbox size [15:14:21] fr-tech before I dive into that mail, what's on the top of everyone's list for today? [15:15:32] hmm ejegg i'm going to look at the latest audit logs, there's been some missing txns lately [15:15:54] any pattern discernable so far? [15:16:20] nope, not that i noticed... [15:16:35] globalcollect? [15:16:51] yes [15:17:07] ok, lmk if you want to talk through that live [15:17:19] but then i mostly had the order ids and they werne't in civi so it was hard to notice a pattern: https://phabricator.wikimedia.org/T194296 [15:17:51] i was able to get a list of all the ones that are supposed to be missing [15:18:15] from the console, or the audit files? [15:19:37] lots of smashpig failmail 5/11, guess that was the ingenico test? [15:20:09] hmm, backscroll indicates jgleeson applied a fix for that [15:23:58] audit files [15:24:10] cool, I guess that was just logspam, no donor-facing errors? [15:33:50] fundraising-tech-ops, Operations, ops-codfw: Interface errors on pfw3a-codfw:xe-0/0/17 - https://phabricator.wikimedia.org/T195216#4222651 (ayounsi) Open>Resolved node0 back to being master. [15:35:35] ejegg: been poiking at Kafka EL with cwd, actually just found a bug in the client-side JS, made a patch: https://phabricator.wikimedia.org/T195276 [15:36:00] thanks AndyRussG, I'll take a look [15:36:03] mebbe we could push it out via a swatty-ploy [15:36:07] :) [15:36:14] thx likewise! [15:36:19] the new pipeline is almost working [15:36:27] cwd: cool beans! [15:36:37] over tls now too [15:37:50] cwd: just in case it's at all useful, here's a task: https://phabricator.wikimedia.org/T195259 [15:37:59] (pls feel free to ignor if it's wrong or anything) [15:38:18] that looks right to me [15:39:02] :) [15:40:47] (CR) Ejegg: [C: -1] "instead of checking for falsiness, let's check if parseFloat returns NaN so we can pass zero" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/434433 (https://phabricator.wikimedia.org/T195276) (owner: AndyRussG) [15:40:59] ejegg: also seems there were changes to CI and I'm no longer sure all our tests and linters are running... I'd want to check that before deploying https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/2996/console [15:41:13] ejegg: ^ NaN is falsy [15:41:15] 'quibble' definitely sounds new [15:41:21] ahhh right [15:41:24] AndyRussG: but so is zero! [15:41:25] we can't pass ' [15:41:27] aaarg [15:41:29] aaarg aaarg [15:41:35] aaarg / 0 [15:41:35] hah, no worries [15:42:14] heh so much for late-night speed coding [15:42:52] hmm, so we definitely had 3 tests running on eg https://gerrit.wikimedia.org/r/409976 [15:43:10] did all of those get combined into the 'quibble' thing? [15:43:33] huh, and jenkins menu now has an 'open blue ocean' thing [15:44:02] also a "this code should walk the plank" hotkey [15:44:05] jk [15:44:36] hehe [15:44:54] well, there's some selenium stauff happening [15:45:10] but all I see so far is core tests [15:46:00] oh hey, there's some ext.centralNotice stuff [15:46:17] yeah, looks like those are still running and passing! [15:47:37] ejegg: including jslduck/linters and qunit? [15:47:42] https://genius.com/The-last-poets-time-lyrics [15:48:25] damn [15:48:25] AndyRussG: ahh, not seeing jsduck [15:48:37] though I'm not sure if that's exactly what's used now [15:48:53] just the ext.centralNotice.*.tests [15:49:08] hmmm ok thats better than naught [15:49:52] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, FR-Ingenico: Ingenico audit wobble? iDEAL donations not in Civi May 1-3 - https://phabricator.wikimedia.org/T194296#4222683 (MBeat33) @mepps I did a little digging. It appears the iDEALs not reaching Civi actually began on 4/30. I exported... [15:51:55] ejegg just checked as of last night there were still 5326 missing transactions [15:53:37] it looks like they just stopped at some point ejegg if you look at the issue ^^ [15:53:53] i've seen something about chmod failing [15:56:24] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, FR-Ingenico: Ingenico audit wobble? iDEAL donations not in Civi May 1-3 - https://phabricator.wikimedia.org/T194296#4222710 (mepps) @Ejegg I'm seeing this error in the logs: 2018-05-22 01:00:14,200 ERROR chmod(): Operation not permitted... [16:08:20] mepps wow, that's a lot [16:08:38] chmod failing is a red herring [16:08:45] that's been going on forever [16:09:07] is it a problem? [16:10:29] cwd I don't think so [16:10:42] probably something we could remove in the code [16:10:51] cool [16:11:02] the audit files seem to be moving from incoming to completed just fine [16:12:51] mepps so we have no iDEAL donations at all in Civi after 4/30? [16:14:55] that's what MBeat says, is there a way to search for them? [16:15:13] mepps sure, it should be there as a payment instrument [16:15:27] we probably have some after then, i think it’s more of a gap, ejegg [16:15:44] ok, got it [16:17:19] hi XenoRyet ! [16:17:21] MBeat have you noticed any commonalities between the missing payments? [16:17:22] How's it going? [16:18:08] mepps, nothing other than that it seemed to start between those 2 transactions in the task [16:21:21] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, FR-Ingenico: Ingenico audit wobble? iDEAL donations not in Civi May 1-3 - https://phabricator.wikimedia.org/T194296#4222755 (MBeat33) I just looked in Civi for when the iDEALS began appearing again, and the earliest I could find was | 201... [16:26:46] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog: Cancel & refund the remaining unintended recurring donations from Big EN - https://phabricator.wikimedia.org/T192958#4222773 (XenoRyet) I've added B1718_120218_en6C_ipd_p1_lg_frm_cnt.no-LP.rcc to the current batch and rerun the queries for GC.... [16:36:23] Fundraising-Backlog: Unable to attach Word docs in note section - https://phabricator.wikimedia.org/T195309#4222818 (NNichols) [16:39:06] Fundraising-Backlog: Back fill middle names on display - https://phabricator.wikimedia.org/T195311#4222850 (NNichols) [16:49:41] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, FR-Ingenico: Ingenico audit wobble? iDEAL donations not in Civi May 1-3 - https://phabricator.wikimedia.org/T194296#4222906 (Ejegg) Looking at 9805352916 - so far: confirmed still not in Civi confirmed exists in audit file: wx1.00000065702... [17:00:49] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, FR-Ingenico: Ingenico audit wobble? iDEAL donations not in Civi May 1-3 - https://phabricator.wikimedia.org/T194296#4222968 (Ejegg) Huh, there seems to be logic in the audit parser to add 1 to the final date for the logrotate stuff, which... [17:02:23] Fundraising-Backlog: Creating a new record without email - https://phabricator.wikimedia.org/T195266#4222976 (NNichols) @Eileenmcnaughton Correct we would want this optional for individuals as well. [17:05:44] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, FR-Ingenico: Ingenico audit wobble? iDEAL donations not in Civi May 1-3 - https://phabricator.wikimedia.org/T194296#4222987 (CCogdill_WMF) @mbeat33 that seems significant... Are you saying that only donations from 4/30 - 5/1 were impacted,... [17:08:56] (PS2) AndyRussG: Convert numerical URL parameters to numbers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/434433 (https://phabricator.wikimedia.org/T195276) [17:09:03] ejegg: ^ :) [17:10:24] Hi dstrine :) [17:10:57] ^ quick bugfix for EventLogging JS FYI [17:11:00] AndyRussG: hey I have been on line. I keep forgetting to change my nick [17:11:07] AndyRussG: ok [17:11:14] ah yeah I know the feeling [17:11:20] :) [17:11:32] it's in the sprink [17:29:11] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, FR-Ingenico: Ingenico audit wobble? iDEAL donations not in Civi May 1-3 - https://phabricator.wikimedia.org/T194296#4223006 (Ejegg) Think this might be it: a bug specifically affecting audit entries on the last day of the month: https://g... [17:29:18] mepps aha! ^^^ [17:29:27] going to relocate, then work on a fix [17:29:38] ahh [17:29:42] cool [17:36:21] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, FR-Ingenico: Ingenico audit wobble? iDEAL donations not in Civi May 1-3 - https://phabricator.wikimedia.org/T194296#4223012 (MBeat33) @CCogdill_WMF @MNoorWMF > Are you saying that only donations from 4/30 - 5/1 were impacted.. As far as... [18:01:41] ejegg: ^ actually on second thought, pls hold off on the CR. I'm gonna fix the issue flagged by the TODO comment, since I'm there already, and I think fixing it'll be useful when were Kafakatetesting [18:01:43] thx! [18:02:55] (CR) AndyRussG: [C: -2] "Actually we should also fix the TODO issue flagged here, gonna do that" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/434433 (https://phabricator.wikimedia.org/T195276) (owner: AndyRussG) [18:03:59] (PS1) Ejegg: Audit: fix date comparison for last day of month [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434543 (https://phabricator.wikimedia.org/T194296) [18:04:08] AndyRussG: ok, cool, enjoy! [18:04:26] mepps: OK, that patch should fix it: https://gerrit.wikimedia.org/r/434543 [18:04:58] fr-tech or anyone else that wants to review a silly date bugfix ^^^ [18:05:13] ejegg: thanks, gonna down a tall glass of minor TODO soda with ice then :) [18:06:12] though first gotta walk the wog, he's on the verge of exhaustion from lack of walking [18:38:47] hrmmm there's gotta be an elegant solution for that teensy bit of code [18:45:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Unable to attach Word docs in note section - https://phabricator.wikimedia.org/T195309#4223120 (DStrine) [19:21:27] (CR) Mepps: [C: 2] Audit: fix date comparison for last day of month [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434543 (https://phabricator.wikimedia.org/T194296) (owner: Ejegg) [19:25:49] (Merged) jenkins-bot: Audit: fix date comparison for last day of month [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434543 (https://phabricator.wikimedia.org/T194296) (owner: Ejegg) [19:39:26] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe script error? losing email addresses in recent merges - https://phabricator.wikimedia.org/T194662#4223299 (Eileenmcnaughton) updated query SELECT retained_contact.contact_id, count(a.id) as c,... [19:51:01] Fundraising-Backlog: make a mini test plan and switch over to new thank you page - https://phabricator.wikimedia.org/T195329#4223354 (DStrine) [20:06:03] (PS3) AndyRussG: Convert numerical URL parameters to numbers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/434433 (https://phabricator.wikimedia.org/T195276) [20:08:00] (CR) jerkins-bot: [V: -1] Convert numerical URL parameters to numbers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/434433 (https://phabricator.wikimedia.org/T195276) (owner: AndyRussG) [20:08:03] (CR) AndyRussG: Convert numerical URL parameters to numbers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/434433 (https://phabricator.wikimedia.org/T195276) (owner: AndyRussG) [20:10:20] Fundraising-Backlog: Help switch over foundation pages to donate wiki - https://phabricator.wikimedia.org/T193663#4223390 (DStrine) [20:12:06] (PS4) AndyRussG: Convert numerical URL parameters to numbers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/434433 (https://phabricator.wikimedia.org/T195276) [20:12:38] Fundraising-Backlog: Creating a new record without email - https://phabricator.wikimedia.org/T195266#4223399 (DStrine) Open>Resolved [20:16:08] Fundraising Sprint Fhabricator is spelled with an "F", Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, ... - https://phabricator.wikimedia.org/T163953#4223407 [20:16:21] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Try to get anonymise extension working for civi - https://phabricator.wikimedia.org/T194209#4192080 (Eileenmcnaughton) Open>Resolved [20:20:35] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/434565 [20:22:49] (CR) Ejegg: [C: 2] Audit: fix date comparison for last day of month [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434543 (https://phabricator.wikimedia.org/T194296) (owner: Ejegg) [20:22:59] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/434565 (owner: Ejegg) [20:24:31] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/434565 (owner: Ejegg) [20:28:57] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Back fill middle names on display - https://phabricator.wikimedia.org/T195311#4222850 (DStrine) [20:39:11] (PS1) Ejegg: Delete old GlobalCollect audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434597 [20:41:05] Fundraising Sprint Junebugs prefer July, Fundraising Sprint K 2018, Fundraising-Backlog: Cancel & refund the remaining unintended recurring donations from Big EN - https://phabricator.wikimedia.org/T192958#4223494 (DStrine) [20:41:17] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint Junebugs prefer July, Fundraising Sprint K 2018, Fundraising-Backlog: [Spike] Plan in... - https://phabricator.wikimedia.org/T192839#4223496 [20:41:23] Fundraising Sprint K 2018, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: enable Force Merge Selected Duplicates for new DS-Admin permissions level - https://phabricator.wikimedia.org/T193674#4223497 (DStrine) [20:41:27] Fundraising Sprint K 2018, Fundraising-Backlog: Help switch over foundation pages to donate wiki - https://phabricator.wikimedia.org/T193663#4223498 (DStrine) [20:41:34] Fundraising Sprint Junebugs prefer July, Fundraising Sprint K 2018, Fundraising-Backlog, FR-Ingenico, Patch-For-Review: Ingenico audit wobble? iDEAL donations not in Civi May 1-3 - https://phabricator.wikimedia.org/T194296#4223499 (DStrine) [20:41:52] Fundraising Sprint Junebugs prefer July, Fundraising Sprint K 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Update CiviCRM to latest point version - https://phabricator.wikimedia.org/T194210#4223501 (DStrine) [20:42:02] Fundraising Sprint K 2018, Fundraising-Backlog: make a mini test plan and switch over to new thank you page - https://phabricator.wikimedia.org/T195329#4223502 (DStrine) [20:42:05] Fundraising Sprint K 2018, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Back fill middle names on display - https://phabricator.wikimedia.org/T195311#4223503 (DStrine) [20:42:10] Fundraising Sprint Junebugs prefer July, Fundraising Sprint K 2018, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Recover lost data from 'same-moment-merges' - https://phabricator.wikimedia.org/T194699#4223505 (DStrine) [20:42:12] Fundraising Sprint Junebugs prefer July, Fundraising Sprint K 2018, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: Some URL params break EventLogging impression schema - https://phabricator.wikimedia.org/T195276#4223504 (DStrine) [20:42:14] Fundraising Sprint Junebugs prefer July, Fundraising Sprint K 2018, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi dedupe script error? losing email addresses in recent merges - https://phabricator.wikimedia.org/T194662#4223506 (DStrine) [20:42:41] Fundraising Sprint K 2018, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico We don't have an order status after doing a GET_ORDERSTATUS. - https://phabricator.wikimedia.org/T194517#4223510 (DStrine) [20:42:49] Fundraising Sprint Junebugs prefer July, Fundraising Sprint K 2018, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice - CSP overreach - https://phabricator.wikimedia.org/T193332#4223512 (DStrine) [20:43:03] Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint Junebugs prefer July, and 3 others:... - https://phabricator.wikimedia.org/T190098#4223513 [20:43:05] Fundraising Sprint Fhabricator is spelled with an "F", Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, ... - https://phabricator.wikimedia.org/T189613#4223514 [20:43:19] Fundraising Sprint Junebugs prefer July, Fundraising Sprint K 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: add Partner field to summary section in donor record - https://phabricator.wikimedia.org/T185048#4223515 (DStrine) [20:43:35] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People... - https://phabricator.wikimedia.org/T178930#4223517 [20:43:44] Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint Junebugs prefer July, Fundraising Sprint K 2018, and 3 others: Write script to charge Ing... - https://phabricator.wikimedia.org/T170973#4223518 [20:43:47] Fundraising Sprint K 2018, Fundraising-Backlog, FR-Ingenico, FR-Smashpig, Fr-Ingenico-integration_2017-18: Create Ingenico orphan rectifier maintenance script - https://phabricator.wikimedia.org/T163949#4223519 (DStrine) [21:04:28] fr-tech is it too late to change 'hide' to 'lurk' in the sprint title? [21:04:47] ejegg: ok by me :) [21:12:32] !log updated CiviCRM from 5b8c868a00 to 4d797fc592 [21:12:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:13:45] ejegg: btw not sure if I mentioned in the meeting, a new patch is there for the EL JS bug [21:14:04] interestingly, a linter did catch issues in one of the patch sets [21:14:15] (PS3) [21:14:18] https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/3062/console [21:14:31] However, in the CI log for the patch set that passes, I don't see where it's run [21:14:38] https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/3063/consoleFull [21:15:19] I guess I should ask releng [21:25:20] AndyRussG: yeah, that is strange. [21:25:24] looking at the new PS [21:25:37] thx!!!!!! [21:26:18] I omitted the same fix for recordImpressionSampleRate since I imagine that'll go away [21:29:31] Code isn't as beauteous as I would have liked, but I couldn't think of a better way to do it... [21:32:25] sure, it seems fine to me [21:38:05] (CR) Ejegg: [C: 2] Convert numerical URL parameters to numbers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/434433 (https://phabricator.wikimedia.org/T195276) (owner: AndyRussG) [21:46:11] (Merged) jenkins-bot: Convert numerical URL parameters to numbers [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/434433 (https://phabricator.wikimedia.org/T195276) (owner: AndyRussG) [21:46:45] fr-tech looks like the audit is picking up a lot of those missing donations! [21:59:22] eileen sorry, can you give me 10 more min before the civi chat? [22:00:26] ejegg: perfect - suits me too - or longer if you wish [22:10:14] ejegg: ^ thx!!! [22:23:35] eileen: ok, ready now [22:33:30] fr-tech I fixed the panel on the phab dashboard. all the links are back!! [22:44:28] dstrine: which dashboard? [22:48:21] AndyRussG: the stakeholder dashboard [22:48:39] I think most people use that as their phab homepage [22:57:06] ah hmmm [22:57:15] looking.....