[00:01:08] hey sorry been in the garden [00:01:31] I can post up shortly if needed [00:11:30] (CR) Eileen: "I went through this & only had one question." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431695 (owner: Ejegg) [00:12:43] (CR) Eileen: "Also, I didn't find any instances that had been missed" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431695 (owner: Ejegg) [00:37:48] cwd: just left the talk [00:38:04] cwd: sorry just saw your msg now :) [00:38:26] only one question from the ops side - can we get that /srv/kafkatee file logrotated in 15 minute chunks like the /srv/bannerLogs files? [00:39:23] yeah definitely [00:39:28] great! [00:39:35] cwd: ^ ...and a main conclusion also is that it makes more sense to redo most of DjangoBannerStats rather than trying to coax the new EventLogging kafka stream into the old WebLoggy format [00:39:40] :) [00:39:46] oh, maybe even per-year folders too [00:39:58] cool [00:40:28] can it wait for the morning? doing some yard work but i can put it down if it's urgent [00:55:58] cwd definitely can wait! [00:57:01] (CR) Ejegg: No more magic strings for WmfException (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431695 (owner: Ejegg) [00:57:51] (PS6) Ejegg: No more magic strings for WmfException [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431695 [00:57:57] thanks eileen ! [01:47:41] (CR) Eileen: [C: 2] No more magic strings for WmfException [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431695 (owner: Ejegg) [01:47:48] (CR) Eileen: [C: 2] "looks good to me" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431695 (owner: Ejegg) [01:53:06] (Merged) jenkins-bot: No more magic strings for WmfException [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/431695 (owner: Ejegg) [02:02:59] (PS16) Ejegg: WIP: SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) [03:52:50] (PS17) Ejegg: WIP: SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) [04:13:26] (PS18) Ejegg: WIP: SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) [04:17:30] (CR) jerkins-bot: [V: -1] WIP: SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) (owner: Ejegg) [05:03:23] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Chinese-Sites, Patch-For-Review: Offer contentlanguage targeting for CentralNotice banners - https://phabricator.wikimedia.org/T53475#4227520 (Jseddon) This issue T194939 and in place of CentralNotice three sepera... [06:14:36] (PS1) Eileen: Latest Stock CiviCRM + WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/434869 [06:16:31] (Abandoned) Eileen: Stock CiviCRM + core updates (5.2) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/432320 (owner: Eileen) [06:16:51] (Abandoned) Eileen: Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/432321 (owner: Eileen) [06:23:49] Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: enable Force Merge Selected Duplicates for new DS-Admin permissions level - https://phabricator.wikimedia.org/T193674#4227559 (Eileenmcnaughton) @MBeat33 I have a new fix on staging - this is... [13:56:22] mornin fr-tech! [14:11:56] (PS2) Ejegg: Updated composer to pull in smashpig 0.5.6.3 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/433442 (owner: Jgleeson) [14:12:02] (CR) Ejegg: [C: 2] Updated composer to pull in smashpig 0.5.6.3 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/433442 (owner: Jgleeson) [14:14:13] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico recurring messages missing token - https://phabricator.wikimedia.org/T195488#4228753 (Ejegg) p:Triage>Normal [14:14:19] (Merged) jenkins-bot: Updated composer to pull in smashpig 0.5.6.3 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/433442 (owner: Jgleeson) [14:30:58] fundraising-tech-ops: adjust nagios_nsca cron job timing to vary when hosts send data - https://phabricator.wikimedia.org/T191899#4228785 (Jgreen) a:Jgreen [14:33:19] Jeff_Green: oh shoot, I think something went wrong with the syslog bucketing [14:33:37] all the globalcollect_gateway: stuff is now ending up in payments-misc [14:34:04] we still need that in pyaments-globalcollect - the new API is only in testing so far [14:34:22] oh! whoops. fixing... [14:36:00] do we need commstats too? [14:36:09] yeah, I think so [14:36:23] tho commstats is way less important [14:37:06] damn, would it be possible to backfill the past day of payments-globalcollect somehow? [14:37:33] unfortunately, the iDEAL donations only come in via audit, not via the front end [14:37:48] which means they need to find all the donor data in the log file [14:38:00] definitely possible [14:38:03] and we've still got banners up in NL [14:38:05] awesome! [14:38:20] will the audit processor work with logs that are out of sequence? [14:38:27] Jeff_Green: yep, totally [14:38:31] ok [14:38:35] it just greps for a line with the right order ID [14:39:10] cool, then I think I can just append the new log file to the old one, there's nothing real yet for the new processor right? [14:39:25] Jeff_Green: there was stuff for the 1 hour test back on the 11th [14:39:38] but nothing today [14:39:51] stuff that was logged since we tweaked the config yesterday? [14:40:05] No, no completed donations [14:40:10] ok cool [14:40:14] just a test first-stage form submit [14:40:51] I guess there's no reason to remove the new log anyway, I'll just append it to the gc one and leave it be [14:41:01] ok, great [14:42:18] I need to make a couple more updates to the audit processor to handle the new gateway ID for the new API [14:43:37] * cwd yawns [14:43:46] speaking of logs [14:43:46] mornin cwd! [14:43:51] howdy [14:46:26] Jeff_Green: wondering about the current kafkatee logrotate setup [14:46:32] for the output text files [14:46:37] ejegg: ok it should be fixed for the log that rotated last night, and for the one that's appending today [14:46:38] starting to think it is not actualy logrotate [14:46:43] cwd: yeah that needs rethinking [14:46:44] it's not [14:46:52] Jeff_Green: thanks! [14:46:57] cwd there's a script right? [14:47:02] ejegg: no problem! [14:47:03] looking... [14:47:08] hi ejegg! [14:47:11] i'm not sure what happens tbh [14:47:13] hi mepps! [14:47:16] i forget ~why~ it's not logrotate, lemme look too [14:48:07] aaah, rotate_banner_logs [14:49:25] https://wikitech.wikimedia.org/view/Fundraising_Analytics/Impression_Stats [14:49:35] is that even a proper url? [14:49:43] I think I didn't trust kafkatee reload [14:50:23] apparently not any longer [14:50:38] https://wikitech.wikimedia.org/wiki/Fundraising_Analytics/Impression_Stats [14:51:09] pretty outdated [14:51:22] Banner impressions and landing page stats are collected from Squid logs via udp2log running on Locke. [14:51:25] hehe [14:52:06] so this is circa 2012 [14:54:15] ok well this looks worthy of a task to me [14:54:38] i think the main benefit of doing this with a script vs logrotate is the ability to detect/notify upon failure [14:55:18] but maybe we can get logrotate to do our bidding, I don't know [14:55:32] i will look into it [14:55:42] cool [14:56:19] right now I think it's logging nice informative stuff to syslog when it works, and printing output thus cron emails upon failure [14:57:46] good lord, there's been a wood chipper running since 8AM on our block, i think someone must be clearcutting a small forest [14:58:38] (PS1) Ejegg: Audit: get more fields from JSON logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434928 (https://phabricator.wikimedia.org/T195337) [14:59:03] Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog, Fr-Ingenico-integration_2017-18, Patch-For-Review, Unplanned-Sprint-Work: Update Ingenico WX audit parser to handle txns from new API - https://phabricator.wikimedia.org/T195337#4228844 (Ejegg) p:Triage>Normal [14:59:32] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, and 2 others: Re-think kafka pipeline text log ro... - https://phabricator.wikimedia.org/T195492#4228852 [15:02:54] (CR) jerkins-bot: [V: -1] Audit: get more fields from JSON logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434928 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [15:06:51] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/434930 [15:07:00] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/434930 (owner: Ejegg) [15:07:48] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/434930 (owner: Ejegg) [15:07:53] https://www.theonion.com/nsa-scrambling-to-reestablish-whereabouts-of-man-who-co-1826078931 [15:08:06] (PS1) Ejegg: Update SmashPig [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/434931 [15:08:42] (CR) Ejegg: [C: 2] Update SmashPig [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/434931 (owner: Ejegg) [15:14:15] (PS2) Ejegg: Audit: get more fields from JSON logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434928 (https://phabricator.wikimedia.org/T195337) [15:16:30] (CR) Ejegg: [V: 2 C: 2] Update SmashPig [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/434931 (owner: Ejegg) [15:17:47] (PS1) Ejegg: Update vendor for SmashPig update [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/434932 [15:17:53] (CR) Ejegg: [C: 2] Update vendor for SmashPig update [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/434932 (owner: Ejegg) [15:18:44] (CR) jerkins-bot: [V: -1] Audit: get more fields from JSON logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434928 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [15:22:48] fundraising-tech-ops: adjust nagios_nsca cron job timing to vary when hosts send data - https://phabricator.wikimedia.org/T191899#4228920 (Jgreen) Open>Resolved commit 3185d613df5f3753fe0d359aad990ddc7c7b684b Author: Jeff Green Date: Thu May 24 11:15:21 2018 -0400 splay... [15:25:35] (Merged) jenkins-bot: Update vendor for SmashPig update [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/434932 (owner: Ejegg) [15:25:51] Fundraising-Backlog, fundraising-tech-ops: Move all /etc/fundraising config into /etc, drop the subdirectory - https://phabricator.wikimedia.org/T161544#4228932 (Jgreen) Open>Resolved [15:26:16] (PS3) Ejegg: Audit: get more fields from JSON logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434928 (https://phabricator.wikimedia.org/T195337) [15:28:34] crud, after a package update I'm getting tons of test failures locally with mysqli_free_result(): Couldn't fetch mysqli_result in /home/elliott/src/php/fundraising/crm/civicrm/packages/DB/mysqli.php [15:29:05] mepps have you seen any of that? [15:30:24] (CR) jerkins-bot: [V: -1] Audit: get more fields from JSON logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434928 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [15:33:08] (PS4) Ejegg: Audit: get more fields from JSON logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434928 (https://phabricator.wikimedia.org/T195337) [15:35:50] Fundraising-Backlog, fundraising-tech-ops: Alert fatigue: "frdev1001/check_procs is CRITICAL" - https://phabricator.wikimedia.org/T191798#4228953 (Jgreen) Open>Resolved a:Jgreen commit 2c00d582894e552259eb562a0bf985090eb9aeb8 Author: Jeff Green Date: Thu May 24 11:34:... [15:35:57] the test failures ejegg? [15:36:21] I haven’t run crm tests in a while... [15:36:47] k [15:37:16] ooh, it seems to have to do with the civicrm submodule update [15:37:36] I reverted from the latest stuff on staging to what's in master, and the tests aren't complaining any more [15:37:43] I thought it was a php package thing, but no [15:39:26] oh jeez, have we been sending iDEAL donors english TY letters all this time? [15:39:53] Boo... I think so, from what I can see in the audit log parser [15:40:04] fundraising-tech-ops, monitoring, Epic: overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508#4228997 (Jgreen) [15:40:06] fundraising-tech-ops: Create alerts for rsyslog rate limiting - https://phabricator.wikimedia.org/T176924#4228996 (Jgreen) Open>stalled [15:42:38] Good thing everyone in NL is fluent in English [15:43:49] fundraising-tech-ops, monitoring: fundraising postfix metrics into prometheus - https://phabricator.wikimedia.org/T176293#4229011 (Jgreen) [15:43:51] fundraising-tech-ops, monitoring: fundraising recurring_gc* queues metrics into prometheus - https://phabricator.wikimedia.org/T176295#4229010 (Jgreen) Open>stalled [15:56:51] (PS5) Ejegg: Audit: get more fields from JSON logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434928 (https://phabricator.wikimedia.org/T195337) [16:01:57] (PS1) Ejegg: Ingenico audit: use JSON blob instead of XML [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434945 (https://phabricator.wikimedia.org/T195337) [16:02:04] fr-tech ok, those should be ready for review ^^^ [16:38:01] this cafe seems to have decided I've hogged enough bandwidth for today... [16:45:29] fundraising-tech-ops, Operations, ops-eqiad: rack frpig1001 - https://phabricator.wikimedia.org/T187365#4229207 (Jgreen) [16:47:17] fundraising-tech-ops, Operations, ops-eqiad: rack frdata1001 - https://phabricator.wikimedia.org/T187364#4229224 (Jgreen) [16:52:46] home again, home again, jiggedy jog [17:26:05] huh weird ejegg i ddin't get assigned to those crm patches [17:26:40] i thought fr-tech had just done some lightning speed code review [17:29:39] mepps weird indeed [17:29:46] let's see if the cr-bot is glitching again [17:34:41] https://www.mediawiki.org/wiki/Git/Reviewers [17:35:02] has a link to https://tools.wmflabs.org/gerrit-reviewer-bot/ to check that [17:35:31] but it look OK to me [17:36:18] mepps somehow you're not on the list for the crm project, just civicrm [17:36:39] will add you back [17:36:43] ahh is anyone on the list for crm? no one is assigned these patches [17:36:52] just me :) [17:36:58] yeah i see that [17:37:29] oh right, there's a built-in gerrit feature too, the 'watched projects' [17:42:06] Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: enable Force Merge Selected Duplicates for new DS-Admin permissions level - https://phabricator.wikimedia.org/T193674#4229503 (MBeat33) Thank you @Eileenmcnaughton. I tested the Force Merge op... [17:42:37] ok, I just added all of fr-tech to a lot of projects [17:42:43] prepare for gerritspam! [17:43:23] well, down the line anyway [17:51:24] (PS1) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/434969 [17:51:51] (CR) Ejegg: [C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/434969 (owner: Ejegg) [17:53:34] ooh, REL1_31 branch exists all over the place [17:59:32] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/434969 (owner: Ejegg) [18:01:02] grr [18:01:21] oh, gerrit's down. that's no fun [18:01:51] D: [18:02:16] (CR) Mepps: [C: 2] Audit: get more fields from JSON logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434928 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [18:02:40] (CR) Ejegg: [C: 2] "recheck" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/434969 (owner: Ejegg) [18:03:47] (CR) Mepps: Ingenico audit: use JSON blob instead of XML (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434945 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [18:04:35] mepps list the transaction? [18:04:45] cwd seems to have been a momentary thing [18:06:29] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/434969 (owner: Ejegg) [18:06:52] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/434969 (owner: Ejegg) [18:07:02] (Merged) jenkins-bot: Audit: get more fields from JSON logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434928 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [18:08:07] grr, grr [18:13:45] PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Puppet has 10 failures. Last run 5 minutes ago with 10 failures. Failed resources (up to 3 shown) [18:14:15] ^^^ that was me breaking pupppet, already fixed... [18:15:25] PROBLEM - check_puppetrun on frdb1002 is CRITICAL: CRITICAL: Puppet has 29 failures. Last run 6 minutes ago with 29 failures. Failed resources (up to 3 shown) [18:15:31] ejegg well it looks like before it said which transaction it was logging and it looks lik eyou're logging "transaction: " but with no transaction name [18:15:39] unless i'm missing something [18:17:57] mepps ohhh, that log line is just referring to the donation as a 'transaction' [18:18:17] so, it's redirecting to the processor page [18:18:35] PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Puppet has 10 failures. Last run 10 minutes ago with 10 failures. Failed resources (up to 3 shown) [18:18:53] mepps the rest of the audit processors already use that log line to get the missing details [18:19:02] it's got a slightly different wording for amazon [18:19:30] because we get the user details AFTER we've redirected them through the login page [18:20:25] PROBLEM - check_puppetrun on frdb1002 is CRITICAL: CRITICAL: Puppet has 29 failures. Last run 11 minutes ago with 29 failures. Failed resources (up to 3 shown) [18:23:35] PROBLEM - check_puppetrun on americium is CRITICAL: CRITICAL: Puppet has 10 failures. Last run 15 minutes ago with 10 failures. Failed resources (up to 3 shown) [18:25:25] RECOVERY - check_puppetrun on frdb1002 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [18:28:35] RECOVERY - check_puppetrun on americium is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [18:28:41] mepps so, the log parser used to get its missing data from the XML for a specific 'transaction' as in API call [18:29:16] ah i think i see, so this is just grepping? [18:29:23] but now it works like the rest of the other parsers and gets the data from a JSON blob that happens to be prefixed with the word 'transaction' [18:29:26] yeah [18:29:30] just grepping [18:29:41] (CR) Mepps: [C: 2] Ingenico audit: use JSON blob instead of XML [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434945 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [18:29:50] thanks! [18:30:02] This still doesn't get us the right gateway tag though [18:30:24] I haven't found anything better than the merchant reference format to distinguish :( [18:30:35] and like I said, that's a heuristic, not a hard rule [18:31:01] mepps do you want to take a look? [18:31:27] At the audit files that is [18:31:32] sure ejegg [18:31:34] to see if you can find a better rule [18:31:46] the audit file for 5/14 contained most of the 1 hr test donations [18:32:07] they all have order IDs starting with 40000, also [18:34:01] (Merged) jenkins-bot: Ingenico audit: use JSON blob instead of XML [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434945 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [18:49:12] (CR) Ejegg: [C: 2] "recheck" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/434969 (owner: Ejegg) [18:49:56] fr-tech: Reedy's helping fix the core tests for our branch over in #wikimedia-releng [18:50:52] ejegg: Hmm. It's "only" running mediawiki-extensions-php55-jessie [18:51:06] heh, that doesn't help [18:51:25] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/434969 (owner: Ejegg) [18:51:47] Same problem :/ [18:52:04] Reedy: if the old tests are gone, let's not resurrect them just for the next couple weeks [18:52:24] well, unless they're also needed to fix the normal REL1_27 branch [18:52:33] guess that should still get tests till official EOL [18:52:37] I think what's broken is the fallback [18:52:55] it'll be fine on REL1_27, as the branches exist [18:53:07] Reedy: We weren't running the extensions tests on fr branches before [18:53:08] I'm guessing there was some logic for FR branches not to test with extensions you don't care about [18:53:16] just the core tests, qunit, and lint [18:53:17] Right, so I'm guessing that got killed [18:53:30] /erroroneously enabled for the FR branch [18:53:39] right right [18:56:01] Is it worth skipping mediawiki-extensions-php55-jessie too? [18:56:28] At least you're getting linting... [18:58:32] Reedy: yeah, let's skip the extensions [19:00:38] hmm. rabbit holes [19:03:30] https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L926 [19:03:36] It's hiding somewhere like that [19:04:42] # Run MediaWiki PHP 5.5 tests on MW < 1.31 [19:04:42] - name: ^(quibble|mediawiki|mwext|mwskin).*php55.*$ [19:04:42] branch: ^(REL1_(2[789]|30)|fundraising/.*)$ [19:04:45] I bet that one [19:13:03] (CR) Reedy: "recheck" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/434969 (owner: Ejegg) [19:15:30] ejegg: want to try re-applying your CR+2? [19:22:49] will do Reedy [19:22:58] (CR) Ejegg: [C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/434969 (owner: Ejegg) [19:34:25] weird, some kinda split? [19:40:15] Reedy: huh, that didn't fail, but it didn't merge either [19:40:53] fundraising-tech-ops: fix nagios plugin perl path snafu for fundraising stretch hosts - https://phabricator.wikimedia.org/T195522#4229754 (Jgreen) [19:44:28] (CR) Ejegg: [V: 2 C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/434969 (owner: Ejegg) [19:44:41] I'mma just push that through to get it deployed [19:49:26] !log updated payments-wiki from c81e25f8d3 to 43989ebc96 [19:49:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:57:58] (PS1) Mepps: WIP: Add popup contact record in merge screens [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/435002 (https://phabricator.wikimedia.org/T188141) [19:58:04] (PS1) Mepps: Add cancelPayment for rectifyOrphan [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/435003 (https://phabricator.wikimedia.org/T163949) [20:04:46] (PS2) Mepps: Add cancelPayment for rectifyOrphan [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/435003 (https://phabricator.wikimedia.org/T163949) [20:05:53] ejegg looks like these tests are passing but locally i'm getting: PHP Fatal error: Class 'PHPUnit\Framework\TestCase' not found in /var/www/fr-tech/mediawiki_payments/extensions/DonationInterface/tests/phpunit/ArrayHelperTest.php on line 23 [20:06:34] mepps sounds like a phpunit version conflict [20:06:47] are you using phpunit from distro, or from vendor? [20:06:56] phpunit ejegg [20:07:03] phpunit from vendor i mean [20:07:07] ah, I think we always need to use vendor/bin/phpunit [20:07:09] oh huh [20:07:36] oh wait [20:08:05] i'm using mediawikis phpunit.php [20:09:15] err [20:09:26] lessee what I'm doing, i've got some alias set up [20:09:52] ok, yeah, i'm using the same [20:09:55] yeah i'm using the same alias [20:10:25] so it changes dir to mw/tests/phpunit [20:10:44] then it runs php phpunit.php [20:11:38] yup [20:13:39] dang, they're all passing locally for me [20:18:40] weird! [20:23:18] what's your php version ejegg? i've got 5.6.32 [20:24:00] huh, I'm on 7.0 but it should autoload the same [20:27:29] hmm still failing with 7.0 [21:21:46] mepps: really lame idea for the distinction between gateways: I'm going to left-pad the old API reference suffix so it's always 5 digits [21:29:39] (PS1) Ejegg: Pad merchant reference suffix to always by 5 digits [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/435050 [21:29:44] fr-tech whaddaya think? ^^^ [21:32:02] Fundraising Sprint Junebugs prefer July, Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog: Cancel & refund the remaining unintended recurring donations from Big EN - https://phabricator.wikimedia.org/T192958#4230080 (XenoRyet) a:XenoRyet [21:32:51] (PS1) XenoRyet: Unintended Recur Part 3 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/435052 [21:40:13] fr-tech: ^ If someone wants to take a look at that patch to cancel the latest round of bad GC subscriptions, I think that's the last piece I need to wrap up the GC side of the latest round of unintended recurs. [21:41:10] XenoRyet: I'll take a look. [21:41:23] How's it going with the refund list? [21:41:46] Fundraising Sprint Junebugs prefer July, Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog, Patch-For-Review: Cancel & refund the remaining unintended recurring donations from Big EN - https://phabricator.wikimedia.org/T192958#4230109 (XenoRyet) I believe I'm more or less s... [21:41:55] I ended up just figuring the rest of it out myself, it's ready to go. [21:43:50] nice! [21:44:22] Yea, you were busy with other stuff when I got to the tricky bits, so I just googled a lot and found what I needed to get it done. [21:57:22] Fundraising Sprint Junebugs prefer July, Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog, Patch-For-Review: Cancel & refund the remaining unintended recurring donations from Big EN - https://phabricator.wikimedia.org/T192958#4230144 (MBeat33) Thank you @XenoRyet It's good... [21:58:34] Fundraising Sprint Junebugs prefer July, Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog, Patch-For-Review: Cancel & refund the remaining unintended recurring donations from Big EN - https://phabricator.wikimedia.org/T192958#4230148 (CCogdill_WMF) Sure. Can we set a time... [22:02:10] (CR) Ejegg: [C: 2] Unintended Recur Part 3 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/435052 (owner: XenoRyet) [22:06:16] (Merged) jenkins-bot: Unintended Recur Part 3 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/435052 (owner: XenoRyet) [22:07:32] Fundraising Sprint Junebugs prefer July, Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog, Patch-For-Review: Cancel & refund the remaining unintended recurring donations from Big EN - https://phabricator.wikimedia.org/T192958#4230177 (XenoRyet) Tomorrow would technically v... [22:12:03] (CR) Ejegg: [C: -1] "Looks pretty good, just need to delete an extra parameter and fix the whitespace. Could also assert what ID is passed in the test." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/435003 (https://phabricator.wikimedia.org/T163949) (owner: Mepps) [22:17:41] (PS2) Ejegg: Fix to ensure that setting source to empty does not cause a hard-error. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/432338 (owner: Eileen) [22:18:23] (CR) Ejegg: [C: 2] Fix to ensure that setting source to empty does not cause a hard-error. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/432338 (owner: Eileen) [22:22:58] (Merged) jenkins-bot: Fix to ensure that setting source to empty does not cause a hard-error. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/432338 (owner: Eileen) [22:37:30] (CR) XenoRyet: [C: 2] Pad merchant reference suffix to always by 5 digits [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/435050 (owner: Ejegg) [22:42:57] (Merged) jenkins-bot: Pad merchant reference suffix to always by 5 digits [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/435050 (owner: Ejegg) [22:46:42] whew, ok, I think we have some other differences to go on [22:47:52] old-API txns have different entries in the CustomerData section [23:04:54] Fundraising Sprint Junebugs prefer July, Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog, Patch-For-Review: Cancel & refund the remaining unintended recurring donations from Big EN - https://phabricator.wikimedia.org/T192958#4230281 (MBeat33) Cool, want to say tomorrow 11... [23:09:44] (PS1) Ejegg: Indicate correct gateway for Connect API donations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/435066 (https://phabricator.wikimedia.org/T195337) [23:10:20] (CR) jerkins-bot: [V: -1] Indicate correct gateway for Connect API donations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/435066 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [23:10:26] hrm? [23:10:46] ah, formatting [23:11:23] (PS2) Ejegg: Indicate correct gateway for Connect API donations [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/435066 (https://phabricator.wikimedia.org/T195337) [23:18:30] ok, now we need to have the one audit processor be able to look at different logs... [23:23:26] argh, that's going to be really hairy