[07:15:56] fundraising-tech-ops, Operations, ops-codfw: frdb2001 RAID disk failure - https://phabricator.wikimedia.org/T196251#4252737 (MoritzMuehlenhoff) p:Triage>Normal a:Papaul [14:40:40] (CR) Mepps: [C: 2] Fix undefined variable error [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/436845 (owner: Ejegg) [14:44:49] (Merged) jenkins-bot: Fix undefined variable error [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/436845 (owner: Ejegg) [14:51:52] * mepps ejegg just noticed the build is failing for this patch: https://gerrit.wikimedia.org/r/#/c/436188/ [14:54:45] mepps taking a look [14:55:41] (PS2) Ejegg: Update donation-interface library to 2.3.0 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/436188 (https://phabricator.wikimedia.org/T169357) [14:56:52] mepps I think it was just sitting on top of a failing patch set from the parent commit [15:02:01] should i wait on that earlier patch to be out of WIP for that one ejegg? [15:07:55] sure, might as well [15:08:15] k4 is back tonight right fr-tech? [15:08:20] today* [15:08:49] for non UTC :) [15:10:13] yup jgleeson! [15:28:20] M$ acquires github [15:28:23] amazing [15:30:26] yeah, I've seen lots of guides for migrating to gitlab circulating [15:30:55] also, MS is more valuable than google - huh? [15:32:01] heh [15:32:11] the intertia of large companies is absolute nonsense [15:32:27] as microsoft devours their way back to relevance [15:32:42] monopoly never got punished in the 90s when it shoulda [15:33:37] US economy sucks [15:55:57] (PS5) Mepps: WIP Move errored messages to damaged queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430800 (https://phabricator.wikimedia.org/T191654) [16:04:10] fr-tech anyone have a couple minutes to look over this one? https://gerrit.wikimedia.org/r/435294 [16:05:53] sure ejegg [16:05:57] thanks! [16:07:37] (PS33) Ejegg: WIP: SmashPig payment processor extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/426068 (https://phabricator.wikimedia.org/T1888678) [16:11:09] (CR) Mepps: [C: 1] "One question, otherwise looks good." (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/435294 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [16:14:37] (CR) Ejegg: "thanks mepps, response inline" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/435294 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [16:18:38] (CR) Mepps: [C: 2] Fix IDs for Ingenico audit entries [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/435294 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [16:19:07] (Merged) jenkins-bot: Fix IDs for Ingenico audit entries [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/435294 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [16:24:06] ejegg got tests passing here: https://gerrit.wikimedia.org/r/#/c/430800/ [16:24:37] cool mepps! Want to take it out of WIP then? [16:24:38] (PS6) Mepps: Move errored messages to damaged queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430800 (https://phabricator.wikimedia.org/T191654) [16:24:44] done :) [16:27:06] nice! Heading to a cafe, I'll take a look at it as soon as I get set up there [16:30:37] welcome back K4-713 :) [16:30:51] Thank you! [16:30:53] * K4-713 waves [16:31:41] * cwd rubs eyes [16:32:42] hello K4-713! [16:33:22] ejegg|afk, when you get a chance, did you see my feeback re this patch https://gerrit.wikimedia.org/r/#/c/426068/ [16:33:41] helloooo. Did I miss anything good? :) [16:33:52] I had to change the... payment processor model.. I think, to Ingenico_SmashPig [16:34:25] to get to work, I wonder if that is something that should of happened as a db update or whether it's vagrant weirdness that caused it to be out of sync [16:35:13] K4-713, mepps did an amazing job while you were away! [16:35:42] aww thanks jgleeson! [16:55:30] welcome back K4-713 ! [16:55:39] jgleeson|dinner: looking [16:55:40] hey K4-713 !!! http://i.imgur.com/x9OLWRn.gif [16:55:55] welcome back! [16:56:36] K4-713: what jgleeson said about mepps, seconded! [16:58:29] K4-713: hi! welcome :) [17:03:24] omg so many email [17:03:31] all the email [17:04:22] eek [17:04:39] yeah, i thought i had it bad coming back from hackathon + 1 week vaca [17:05:08] 1500 emails [17:05:51] how much of that is failspam? [17:05:53] Which is honestly not as bad as I thought it would be... [17:05:55] heh [17:06:15] Couple hundred. :P [17:06:38] Incidentally, did we ever get a monitor for failmail counting up and running? [17:06:51] This is not a directive: I am just curious. [17:20:16] Fundraising-Backlog: civi job conflicting with database dumps (?) - https://phabricator.wikimedia.org/T196394#4254561 (Jgreen) [17:20:27] Fundraising-Backlog, fundraising-tech-ops: civi job conflicting with database dumps (?) - https://phabricator.wikimedia.org/T196394#4254571 (Jgreen) [17:32:12] K4-713: nice to meet you curious, I'm AndyRussG ;p [17:32:44] Also, quick serious question: what was your final verdict on those mini secondary screens you were looking at? [17:32:51] also, how was the sabbatical???! [17:35:12] AndyRussG: mini secondary screen was working great for me for a couple kernel versions, then it started freezing up my machine on eject again a month or two ago [17:35:59] (I'm using the built-in displaylink support, not the blob from the vendor, which never seemed to work) [17:36:33] really nice to have irc always visible alongside whatever project yr working on [17:36:43] awww hmmmm [17:36:53] so not hdmi? [17:37:06] no, the one I got is usb [17:38:12] hmmm so +1 on form factor but maybe I should look 4 a different brand? [17:38:33] Since I'll be in SF seems like the time to stock up [17:38:59] ah, sounds smart [17:39:44] if you see something on the amazonz, i can help get that to SF [17:41:45] oh hey thx!! [17:42:17] you're going elsewhere in the us before sf? [17:43:04] prolly could get stuff shipped directly office-side [17:43:08] too [18:16:18] fr-tech, can we use the ticket status Invalid for duplicate tickets? [18:16:39] in phab [18:17:27] seems like a good question for dstrine but i imagine you could also close the duplicate with a link to the open issue [18:19:11] jgleeson: there's an action for 'close as duplicate' that links them and closes one [18:19:42] so random [18:20:10] that related tasks menu [18:20:59] it's a conspiracy so you don't notice it, and end up making more tasks [18:21:25] yeah I couldn't find it in Actions [18:21:27] and Fab gets more Fab task royalties [18:21:27] found it now [18:21:31] thanks all [18:22:26] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Recurring: "Recurring donation but no subscription ID or recurring payment token found" error being thrown during import - https://phabricator.wikimedia.org/T194519#4254738 (jgleeson) [18:22:28] Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico recurring messages missing token - https://phabricator.wikimedia.org/T195488#4254741 (jgleeson) [18:24:17] (PS4) Ejegg: Audit functions can deal with multiple logs for one date [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/435220 (https://phabricator.wikimedia.org/T195337) [18:24:19] (PS2) Ejegg: Audit: allow log_filename functions to return arrays [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/435286 (https://phabricator.wikimedia.org/T195337) [18:24:21] (PS3) Ejegg: WIP Ingenico audit handles both APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/435293 (https://phabricator.wikimedia.org/T195337) [18:30:05] (CR) jerkins-bot: [V: -1] WIP Ingenico audit handles both APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/435293 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [18:30:54] (PS4) Ejegg: WIP Ingenico audit handles both APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/435293 (https://phabricator.wikimedia.org/T195337) [18:32:39] argh, really want to get rid of that fakedb mode [18:33:02] T187501 [18:33:05] T187501: wmf_audit: get rid of 'test' and 'fakedb' options - https://phabricator.wikimedia.org/T187501 [18:33:37] pretty sure PS4 needs work to do the right lookups for existing txns, but there's no allowance for that in the current test setup [18:34:08] mepps: and jgleeson sorry for the delay here. it sounds like ya'll got it solved [18:43:37] hey ejegg before I jump into the bug relating to missing ingenico tokens, are there any outstanding code review you need someone to look at? I know you had a few on friday [18:44:13] also, any thoughts on the comment about the payment processor model update in relation to the civi recurring ext? [18:47:29] jgleeson: I haven't figured out why you'd have to do that [18:47:39] maybe it was from an older version of the patch? [18:47:58] maybe [18:48:03] You'd want to delete all the entries in the civicrm_payment_processor table [18:48:14] I wonder if I can restore the table and try again [18:48:26] there were quite a few entries [18:48:37] might of been from my own testing on related work [18:48:41] might have to get rid of all the tokens first because foreign keys [18:48:56] ohhh, yeah, it was probably due to that patch I had before [18:49:03] making the dummy processor entries [18:49:10] pretty sure I've abandoned that one [18:49:55] then, you might need to delete all the smashpig* entries from the payment_processor_type table [18:50:22] anyway, I think the audit patches are ready for review too [18:50:51] I just verified that we're using the right logic to check for existing txns [18:51:05] I'll just take the WIP off [18:51:26] any preference on the order? [18:51:35] audit/civi [18:51:54] mepps just merged the smashpig one, so what's left is the three in Civi [18:52:03] and those are all parent/child chained [18:52:25] starting with this one: https://gerrit.wikimedia.org/r/435220 [18:54:30] cool I'll see if I can pull down the required log/audit data and run a test [18:55:43] (PS5) Ejegg: Ingenico audit handles both APIs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/435293 (https://phabricator.wikimedia.org/T195337) [18:55:52] jgleeson: there are some tests with fake data in the final patch in the chain [18:56:22] that actually use the multi-log capability [18:56:42] ^^^ PS5 just updates the commit message [19:01:41] (PS2) Ejegg: Clean up unused audit regex functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/436079 [19:04:36] (CR) Ejegg: "Can we split the major composer update out? looks like a lot of unrelated changes" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430800 (https://phabricator.wikimedia.org/T191654) (owner: Mepps) [19:06:53] (CR) Ejegg: "Trace would be nice too!" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/430800 (https://phabricator.wikimedia.org/T191654) (owner: Mepps) [19:14:23] AndyRussG: do you have some time later today to walk me through T178930 ? [19:14:24] T178930: CentralNotice: Consolidate typical analytics queries (for example, for impression rates) into a library - https://phabricator.wikimedia.org/T178930 [19:14:34] I'd love to review [19:16:54] ejegg: yeah for sure :) [19:16:57] thx much! [19:17:10] any time this aft or evening is great [19:17:43] AndyRussG: I've got a free hour between 2pm and 3pm pacific [19:18:00] ejegg: okok [19:23:26] Fundraising-Backlog, Fr-Ingenico-integration_2017-18, MediaWiki-extensions-DonationInterface: Plan best way to use Civi tables for Ingenico recurring - https://phabricator.wikimedia.org/T188448#4254945 (Ejegg) Open>Resolved a:Ejegg Think we've worked this all out! [19:25:23] fundraising-tech-ops: barium low on disk space - https://phabricator.wikimedia.org/T144659#4254957 (Ejegg) [19:25:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Ingenico, FR-WMF-Audit: Have Ingenico audit processor remove intermediate files - https://phabricator.wikimedia.org/T144832#4254954 (Ejegg) Open>Resolved a:Ejegg No longer using the old ingenico audit processor, and the new one ha... [19:26:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Turn on search capability for Estimated Net Worth - https://phabricator.wikimedia.org/T195886#4240018 (DStrine) [19:28:21] Fundraising-Backlog: Update Wikimedia CH landing page redirects - https://phabricator.wikimedia.org/T196403#4254979 (Pcoombe) [19:29:50] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, and 2 others: Create job to deliver the eventlogg... - https://phabricator.wikimedia.org/T189820#4254992 [19:29:51] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, and 2 others: Re-think kafka pipeline text log ro... - https://phabricator.wikimedia.org/T195492#4254990 [19:31:51] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, and 2 others: Create job to deliver the eventlogg... - https://phabricator.wikimedia.org/T189820#4054681 [19:44:32] Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog: Help switch over foundation pages to donate wiki - https://phabricator.wikimedia.org/T193663#4175705 (mepps) For thank you emails, need to change them in the wiki pages because they are hard-coded. [19:45:28] Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog: Help switch over foundation pages to donate wiki - https://phabricator.wikimedia.org/T193663#4255031 (mepps) [19:52:44] Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog: Help switch over foundation pages to donate wiki - https://phabricator.wikimedia.org/T193663#4255053 (mepps) a:mepps [19:54:16] Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog: Help switch over foundation pages to donate wiki - https://phabricator.wikimedia.org/T193663#4255059 (DStrine) Once these pages are working and used by our systems, we need to ste redirects on the foundation page to these. Should t... [20:10:09] cwd & Jeff_Green: any ops stuff to coordinate today? [20:10:23] oh, I guess there's that new box for frpig [20:10:49] the kafka thing is ready for traffic [20:10:52] nothing that would benefit from in-meeting discussion that I can think of [20:27:45] http://hyperpolyglot.org/scripting#parallel-assignment [20:27:55] I forgot how good that site was [20:45:15] (PS1) Mepps: Change documentation variables and test to outline where changes are needed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/437357 (https://phabricator.wikimedia.org/T193663) [20:48:33] (CR) jerkins-bot: [V: -1] Change documentation variables and test to outline where changes are needed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/437357 (https://phabricator.wikimedia.org/T193663) (owner: Mepps) [20:54:28] (PS2) Mepps: Change documentation variables and test to outline where changes are needed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/437357 (https://phabricator.wikimedia.org/T193663) [21:16:05] Fundraising-Backlog, Recurring-Donations, FR-Email: receipt/thank you email for recurring donors - https://phabricator.wikimedia.org/T195907#4255299 (CCogdill_WMF) [22:16:33] fundraising-tech-ops, Operations, ops-codfw: Rack/Setup frbast2001.frack.codfw.wmnet - https://phabricator.wikimedia.org/T196417#4255460 (Jgreen) [22:49:21] Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity import issue - https://phabricator.wikimedia.org/T196005#4255554 (DStrine) Open>Resolved [23:03:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Free form Partner field - https://phabricator.wikimedia.org/T196420#4255585 (LeanneS) [23:10:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Free form Partner field - https://phabricator.wikimedia.org/T196420#4255602 (LeanneS) Okay, we now have a Partner field! Could you take a look to make sure it's set up as it should be?