[00:01:50] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: enable Force Merge Selected Duplicates for new DS-Admin permissions level - https://phabricator.wikimedia.org/T193674#4176356 (Eileenmcnaug... [00:04:34] (CR) jerkins-bot: [V: -1] Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 (owner: Eileen) [00:25:52] (CR) Eileen: Add custom ts() override fn to use MW messages (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440026 (owner: Ejegg) [00:30:09] (CR) Eileen: "So the standard function that comes in an extension is" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440026 (owner: Ejegg) [00:34:40] (CR) Eileen: "What does the language key look like? 'en_US' ?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440026 (owner: Ejegg) [00:51:36] (CR) Eileen: [C: 1] "So in general I'm OK with this & I think it will work. I made a couple of comments but I wonder if we could make the case that ts should a" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440026 (owner: Ejegg) [01:02:37] (PS8) Eileen: Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 [01:05:08] (CR) jerkins-bot: [V: -1] Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 (owner: Eileen) [01:08:22] (PS9) Eileen: Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 [01:11:16] (CR) jerkins-bot: [V: -1] Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 (owner: Eileen) [01:26:24] (PS10) Eileen: Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 [01:32:07] (CR) jerkins-bot: [V: -1] Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 (owner: Eileen) [02:04:50] (PS11) Eileen: Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 [02:10:50] (CR) jerkins-bot: [V: -1] Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 (owner: Eileen) [02:41:01] (PS12) Eileen: Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 [02:44:34] (PS13) Eileen: Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 [02:50:40] (CR) jerkins-bot: [V: -1] Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 (owner: Eileen) [03:12:17] (PS14) Eileen: Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 [14:11:24] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising-Backlog, Patch-For-Review: Help switch over foundation pages to donate wiki - https://phabricator.wikimedia.org/T193663#4282877 (Pcoombe) Okay @mepps, the new Thank You pages have be... [14:13:11] hi folks! [14:13:21] hi jgleeson, hi mepps ! [14:13:26] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising-Backlog, Patch-For-Review: Help switch over foundation pages to donate wiki - https://phabricator.wikimedia.org/T193663#4282895 (mepps) Great @pcoombe! @Ejegg let's plan for when we... [14:13:30] hi ejegg! [14:13:33] and jgleeson! [14:14:07] So, I wonder if we can take some time to go over that recurring ingenico extension again today? [14:15:28] sure ejegg, maybe this afternoon (east coast)? [14:16:05] ok, whenever works for you. I'm holding out a glimmer of hope that we can deploy the thing today [14:16:34] for monthly-donation-timing reasons [14:16:37] hmm i'm working in a dr's office right now, but i'll be home in about an hour if you want to do it then [14:16:42] sure! [14:32:14] (PS2) Ejegg: Fix mishandling of 'forget' [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/440050 (owner: Eileen) [14:32:25] (CR) Ejegg: [C: 2] Fix mishandling of 'forget' [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/440050 (owner: Eileen) [14:38:15] (Merged) jenkins-bot: Fix mishandling of 'forget' [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/440050 (owner: Eileen) [14:45:04] !log updated CiviCRM from 69091d8b5f4f3e2dd to f54f9810ab6742463 [14:45:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [14:45:43] ok, i'm going to turn the queue consumers off to test that new audit logic [14:48:44] !log disabled donations and refund queue consumers [14:48:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:00:05] fundraising-tech-ops, Operations, netops: adjust NAT mapping for frdata.wikimedia.org - https://phabricator.wikimedia.org/T196656#4282970 (ayounsi) NAT change pushed. [15:06:03] hmm, the queue contents all look good [15:06:39] but I'm a little confused by the log output - not listing both files for grepping [15:06:54] even though there are things in the queue it MUST have gotten from the log grep [15:07:19] mepps or jgleeson want to do any verification of those queue contents before I turn the consumers back on? [15:17:24] they seem to legitimately be things missing from the db [15:17:37] there are about 10 from the 1 hr test [15:22:13] ejegg how do we verify this? i wonder if the missing txns have to do with https://phabricator.wikimedia.org/T194517 [15:22:25] which i'm working on [15:22:28] mepps they might! [15:22:54] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico We don't have an order status after doing a GET_ORDERSTATUS. - https://phabricator.wikimedia.org/T194517#4283028 (mepps) a:mepps [15:22:54] so, to look at the queue messages you ssh into frqueue1001 [15:23:12] then you can use redis-cli to query the queues [15:37:46] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: enable Force Merge Selected Duplicates for new DS-Admin permissions level - https://phabricator.wikimedia.org/T193674#4283079 (MBeat33) Th... [15:47:55] ok, gonna turn those qcs back on! [15:50:37] (PS1) Ejegg: Update CiviCRM pointer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440356 [15:50:42] (CR) Ejegg: [C: 2] Update CiviCRM pointer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440356 (owner: Ejegg) [15:56:18] (Merged) jenkins-bot: Update CiviCRM pointer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440356 (owner: Ejegg) [15:58:13] (PS4) Ejegg: Fix 'build up' of variable. (variable was not being re-set within the loop & hence each row included the previous [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440251 (owner: Eileen) [15:58:22] (CR) Ejegg: [C: 2] Fix 'build up' of variable. (variable was not being re-set within the loop & hence each row included the previous [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440251 (owner: Eileen) [16:03:51] (Merged) jenkins-bot: Fix 'build up' of variable. (variable was not being re-set within the loop & hence each row included the previous [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440251 (owner: Eileen) [16:07:24] fundraising-tech-ops, Operations, netops: adjust NAT mapping for frdata.wikimedia.org - https://phabricator.wikimedia.org/T196656#4283202 (cwdent) Open>Resolved Thanks @ayounsi Site looks good, and slander is working again after kicking syslog a few places [16:07:27] fundraising-tech-ops, Operations, ops-eqiad: rack frdata1001 - https://phabricator.wikimedia.org/T187364#4283204 (cwdent) [16:14:28] fr-tech sorry, connection cut out [16:15:21] oh darn, this cafe wifi is time limited [16:15:41] not gonna let me back on for an hr [16:17:26] ah bummer [16:36:23] XenoRyet, we're still goin if you wanna jump on [16:36:40] Oh really, figured I'd missed it all. [16:38:13] oops, that's the phone hitting its wifi time limit too [16:38:24] :( [17:49:44] dstrine, [17:49:52] I'm a little confused by the reply from ingenico [17:50:45] shall I reply in email asking for clarification or do you want me to hand it over? [17:51:16] actually, the question and answer are technical, so I will reply [17:51:38] although I don't understand what he means when he says liability shift [17:52:00] jgleeson: That's some 3DSecure buzzwording [17:52:07] ahhh [17:52:18] I've been reading up on that for the other ingenico bug [17:52:53] Basically part of the point of 3DS is to have the actual issuing bank looped in on authenticating transactions, so if it goes wrong it's not all the merchant's fault. [17:53:25] The liability shift is basically saying the bank said the password was ok. [17:53:48] thanks for explaining that [17:54:12] No worries. I was coincidentally in that headspace just now. [17:54:20] I'm wondering why it would affect tokenized payments, maybe they can't tokenize at the point they usually do due to the hand off [17:55:08] looks like visa and mastercard are set up for 3d-secure so I'll put through a test and see what comes back [17:55:41] I'm not totally understanding his email either, but if I had to guess it'd be that he's saying 3DS isn't meant to work with a recurring transaction because there's no chance for the donor to input that password on anything but the first go. [17:56:11] ah I see [17:56:16] ahhhhhh [17:56:25] so it's a requirement for every transaction [17:56:35] pretty much preventing reusable tokens [17:56:41] well that sucks [17:56:46] for our use case [17:56:50] Maybe. I'm less clear about that part. [17:57:06] thanks for unpacking that, I'll reply back asking if that's the case [17:57:14] Might be the intent is to use 3DS on that first one, then since we trust that, just do regular stuff for the recurs. [17:57:33] oh yeah, that's how I assumed it would work [17:58:13] I think the issue is though that we don't get a token back, for the initial 3d-secure payment [17:58:26] so I'm not sure how we can follow up without a token [17:58:36] unless I'm missing the obvious? [17:58:51] don't get a token back at step 1* [17:59:26] well, right now we're doing a combined redirect+tokenize, I think [18:00:05] but once we get some successful 3dsecure transactions, we should be able to tokenize in a separate API call [18:00:31] got ya [18:00:44] hopping into the google meat for the queue stuff [18:00:56] cool, coming too! [18:01:35] hmm, loading very slowly [18:18:18] jgleeson: sorry just saw your comment. XenoRyet definitely knows more than me. can anyone remember if we had 3dsecure turned on in the older implementation? If no, can we turn if off in this implementation? [18:18:42] I think we have used it in specific countries but not others? [18:19:49] I'm not sure about any of that. [18:57:56] everyone literally fell off meet :) [18:58:06] good presentation ejegg! [18:58:22] thanks! [18:58:49] guess I'll find another space to work... even IRC connection here is really flakey [18:59:22] but if anyone has any time to review the recurring smashpig extension I'd be grateful! [20:28:59] (PS1) Ejegg: Delete unused extensions and skins [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/440415 [20:29:02] (PS1) Ejegg: Add WMF logos [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/440416 [20:29:05] (PS1) Ejegg: Add payments-wiki extensions [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/440417 [20:29:08] (PS1) Ejegg: Update vendor for merged fundraising deps [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/440418 [20:29:20] fr-tech looks like the REL1_31 release is imminent [20:29:53] I'm hoping we can get rid of the extensions/*/vendor subdirectories this time [20:30:05] and just use the merged ones in mediawiki/vendor [20:44:55] (PS4) Ejegg: Move utils file to one that is named Utils. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440252 (owner: Eileen) [20:45:02] (CR) Ejegg: [C: 2] Move utils file to one that is named Utils. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440252 (owner: Eileen) [20:50:28] (Merged) jenkins-bot: Move utils file to one that is named Utils. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440252 (owner: Eileen) [20:52:15] (PS4) Ejegg: Rename obfuscate back to forget, have upstream fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440250 (owner: Eileen) [20:52:59] (CR) Ejegg: [C: 2] "Looks good. Deploy note: I had to uninstall and reinstall the extension; drush cc all didn't seem to be enough to make it stop using 'obfu" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440250 (owner: Eileen) [20:58:18] (Merged) jenkins-bot: Rename obfuscate back to forget, have upstream fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440250 (owner: Eileen) [21:03:19] (PS1) Mepps: WIP: Handle no status code for Ingenico api [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440465 (https://phabricator.wikimedia.org/T194517) [21:10:06] ejegg theres' not a lot happening here but as stated in the notes that's because i'm not even sure how to detect the error behavior in the test ^^ [21:12:33] mepps: ok, I'll take a look [21:14:15] hmm, so, were there exceptions thrown in prod mepps? [21:14:52] There is a log message ejegg but it’s not clear it’s an exception [21:19:52] can you tell me the ct_id associated? [21:25:38] mepps ^^ [21:58:33] (CR) Ejegg: [C: -1] "Looks good when the payments_fraud row exists, but when there's no corresponding p_f row I get this:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 (owner: Eileen) [21:58:59] mepps can you point me to one of the errors? [22:13:19] (PS15) Eileen: Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 [22:13:27] (CR) jerkins-bot: [V: -1] Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 (owner: Eileen) [22:13:52] ejegg: I think I have a fix for that issue you spotted in CR [22:14:15] (PS16) Eileen: Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 [22:16:25] thanks eileen ! [22:18:12] eileen: different error now: cannot unset string offsets in filterOutDuplicateEntityID [22:18:30] (line 190) [22:18:57] seems odd... why can't it? [22:20:20] ah, that fn is getting called twice [22:20:56] once when this->displayValues is set to the expected thing, id->assoc array [22:21:31] and then a second time, when this->displayValues is for some reason just an array of two values [22:22:23] i.e. $this->displayValues = [ "9336907", "9336908" ] [22:22:32] now how did that get mangled? [22:23:11] ah, ok, so this is for the 'fredge' entity [22:26:18] and it seems to have just returned the contribution_ids associated with the donor [22:27:16] XenoRyet|food: any chance you're available to walk through that recurring ingenico code? [22:27:37] looking less and less likely to be deployed within a week of the intended recur date [22:28:46] Heh, forgot to turn of my lunch nick again [22:29:20] Yea, I guess I could make some time right now. [22:30:49] This one, right? https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/426068/ [22:32:21] That's a big one [22:34:08] Actually, I see it's got notes on how to test. How about I pull it down and run through it, we' [22:34:14] we'll talk about it after. [22:36:25] ok, I've got to sign off soon is the thing [22:37:00] Ok, I guess run me through it first, then I'll play with it? [22:37:14] sure! [22:37:27] Ok, jumping in the usual [22:37:37] hm, i guess me having to sign off soon means it's too late to deploy in any case, but I"ll hop in the chat too [22:37:57] Yea, probably deploying today isn't in the cards, but we can get started anyway. [23:13:21] (CR) Ejegg: [C: -1] "different error now: cannot unset string offsets in filterOutDuplicateEntityID (line 190)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 (owner: Eileen)