[00:38:16] PROBLEM - check_puppetrun on civi1001 is CRITICAL: CRITICAL: Puppet last ran 8 hours ago [00:43:16] RECOVERY - check_puppetrun on civi1001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [13:22:05] fr-tech, looks like we're unable to submit to ingenico sandbox atm [13:22:18] tried a couple of times this morning and requests just timing out [13:30:53] (CR) Jgleeson: "Code looks good and tests pass for me. Just waiting on Ingenico sandbox access to put through a test before +2" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 (owner: Ejegg) [13:42:16] (CR) Jgleeson: "could we get a couple of sample message somewhere to show the different use cases, or maybe a test?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441250 (owner: Ejegg) [13:51:00] (CR) Jgleeson: "Looks good so far. I'm interested to know how we redirect it to the new queue at the DonationInterface level post the hosted checkout stat" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441251 (owner: Ejegg) [13:58:34] (CR) Jgleeson: "Following on from the last comment... looks like we'd remove the recurring-by-default behaviour from all createHostedCheckout calls, push" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441251 (owner: Ejegg) [14:15:19] (CR) Thiemo Kreuz (WMDE): [C: -1] Add returnUrl, remove returnTitle (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/441423 (https://phabricator.wikimedia.org/T163949) (owner: Mepps) [14:27:44] ingenico back up! [14:28:00] ingenico sandbox* [14:53:45] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog: Write a specification for mapping banner/landing page impression event properties -> database schema - https://phabricator.wikimedia.org/T196563#4308002 (AndyRussG) Ready for [... [14:54:43] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog: DB schemas (production changes and test DB) and SQL commands to run for new banner and LP impression data from EL - https://phabricator.wikimedia.org/T196564#4308008 (AndyRussG... [15:33:37] (PS2) Mepps: Add returnUrl, remove returnTitle [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/441423 (https://phabricator.wikimedia.org/T163949) [15:37:54] hey ejegg [15:43:37] the default code isn't working as expect for me... [15:53:06] hi mepps [15:53:09] oh? [15:56:51] yeah it doesn't seem to be sending returnUrl even though ti's set as a default, just thought of something to check though [15:57:59] yeah i figured it out [16:05:43] (PS5) Mepps: Return url without Title Class for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441243 (https://phabricator.wikimedia.org/T163949) [17:51:47] (CR) Ejegg: [C: 1] "This works! Kinda crazy-making how many different casing standards are involved here. Maybe use return_to in the var_map and the default t" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441243 (https://phabricator.wikimedia.org/T163949) (owner: Mepps) [17:58:12] (CR) Mepps: Return url without Title Class for Ingenico (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441243 (https://phabricator.wikimedia.org/T163949) (owner: Mepps) [18:17:58] (CR) Ejegg: [C: 2] "ok, let's not add another standard!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441243 (https://phabricator.wikimedia.org/T163949) (owner: Mepps) [18:19:59] (Merged) jenkins-bot: Return url without Title Class for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441243 (https://phabricator.wikimedia.org/T163949) (owner: Mepps) [18:52:56] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog: Write a specification for mapping banner/landing page impression event properties -> database schema - https://phabricator.wikimedia.org/T196563#4308544 (Ejegg) Added a comment... [19:14:07] fr-tech working through some computer troubles... [19:48:07] (PS4) Ejegg: WIP job to add tokens to Ingenico payments [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441251 [20:13:19] (PS1) Ejegg: Fix var_dump -> print_r [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/441572 [20:13:24] (CR) Ejegg: [C: 2] Fix var_dump -> print_r [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/441572 (owner: Ejegg) [20:18:43] (Merged) jenkins-bot: Fix var_dump -> print_r [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/441572 (owner: Ejegg) [20:19:38] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/441573 [20:19:50] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/441573 (owner: Ejegg) [20:21:26] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/441573 (owner: Ejegg) [20:41:26] (CR) Mepps: "ditto jgleeson, would love to see a test." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441250 (owner: Ejegg) [20:44:30] (CR) Mepps: skipAuthentication flag disables 3DSecure for Connect (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 (owner: Ejegg) [20:45:37] (PS2) Mepps: Simplify return stuffing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/441258 (owner: Ejegg) [20:45:41] (CR) Mepps: [C: 2] Simplify return stuffing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/441258 (owner: Ejegg) [20:50:52] (Merged) jenkins-bot: Simplify return stuffing [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/441258 (owner: Ejegg) [20:55:06] fundraising-tech-ops: encrypt fundraising mariadb replication - https://phabricator.wikimedia.org/T170320#4308763 (Jgreen) Debian's stock mariadb (jessie = 10.0.32) is compiled with YaSSL instead of OpenSSL . . . https://groups.google.com/forum/#!msg/linux.debian.bugs.dist/cSoKYOOdLFo/rU7Ut3taAgAJ . . . wh... [20:57:22] (PS5) Mepps: Clean up unused audit regex functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/436079 (owner: Ejegg) [20:57:25] (CR) Mepps: [C: 2] Clean up unused audit regex functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/436079 (owner: Ejegg) [20:57:45] thanks for the review blitz mepps! [20:57:58] adding a test for that job deserialization just now [21:02:37] (Merged) jenkins-bot: Clean up unused audit regex functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/436079 (owner: Ejegg) [21:25:37] (PS5) Ejegg: Job to add tokens to Ingenico payments [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441251 [21:26:45] XenoRyet1: how's it going with the refund investigation? [21:38:22] (CR) Ejegg: "mepps and jgleeson: I added a test in the next patch, since the next patch introduces the first class capable of being deserialized this w" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441250 (owner: Ejegg) [21:54:29] (CR) Ejegg: "Seems to work great! I'm a bit concerned about completely deleting the payments_fraud entries. Everything else in there is just technical" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 (owner: Eileen) [21:57:04] (CR) Ejegg: [C: 2] Add appeal_template property to EventLogging [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/441403 (owner: AndyRussG) [22:01:45] (PS3) Ejegg: skipAuthentication flag disables 3DSecure for Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 [22:03:03] (Merged) jenkins-bot: Add appeal_template property to EventLogging [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/441403 (owner: AndyRussG) [22:04:50] (PS4) Ejegg: skipAuthentication flag disables 3DSecure for Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 [22:05:53] (CR) Ejegg: "mepps OK, swapped the sense of that variable" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 (owner: Ejegg) [22:14:15] (PS1) Ejegg: Rewrite DeletePendingJob as Runnable [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441583 [22:14:39] (CR) jerkins-bot: [V: -1] Rewrite DeletePendingJob as Runnable [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441583 (owner: Ejegg) [22:17:54] (PS2) Ejegg: Rewrite DeletePendingJob as Runnable [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441583 [22:21:19] (CR) Ejegg: "mepps and jgleeson: for further consideration, here is what it would look like to rewrite one of the existing jobs as a simple Runnable un" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441250 (owner: Ejegg)