[03:56:12] Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity import issue - https://phabricator.wikimedia.org/T196005 (CommunityTechBot) p:High>Triage [03:56:14] Fundraising Sprint Karma chameleons hide amongst us, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Benevity import issue - https://phabricator.wikimedia.org/T196005 (CommunityTechBot) [12:59:16] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising-Backlog, Fr-Ingenico-integration_2017-18, Patch-For-Review: Ingenico We don't have an order status after doing a GET_ORDERSTATUS. - https://phabricator.wikimedia.org/T194517 (jgle... [13:14:24] good morning fr-tech [13:15:44] morning mepps [13:15:57] how were your travels jgleeson? [13:16:42] hi mepps and jgleeson! [13:16:56] hey ejegg! where are you now? [13:17:12] I'm back in the Boston area, at my friend's place in Stoneham [13:17:15] mepps, is was ok thanks how about yours?. I'm still working out the last of the jet lag [13:17:20] morning ejegg [13:17:44] also okay, james helped me catch up on jet lag by waking up at 6am the next morning screaming for me [13:18:38] fr-tech hellosies!!! [13:18:53] hi AndyRussG! [13:18:59] :) [13:19:07] election go as hoped? [13:19:08] hey AndyRussG! i was just reading a headline about mexico's election [13:19:15] are you happy with the outcome? [13:26:53] fr-tech, I'm trying to find a convenient way to filter fr-tech affected phab tickets following the vandalism attack I emailed about earlier. I'm following the phab advanced search instructions here https://secure.phabricator.com/book/phabricator/article/search/ attempting the following query https://phabricator.wikimedia.org/search/query/.cbYl4SZzvs_/#R but the results are not what I expect. It's ignoring the title: filter. The [13:26:53] vandal title pattern appears to be ([a-z0-1]{3})aaaaaaa so filtering with the title substring of ~aaaaaaa and our tag should do it in theory [13:27:43] there's still ~1300 phab-wide that are affected, down from 3000 yesterday [13:28:32] woah crazy jgleeson [13:42:37] wow, that's a lot of spam [14:46:55] jgleeson|physio: and fr-tech let's hold off on changing any other tickets back. I'm glad jgleeson|physio worked on the current sprint and you all should be unblocked for today. I'm worried our efforts might collide with the other efforts I'm seeing on wikitech-l. Let me take point on all this. I have some phab tricks that should come in handy [14:51:01] thanks dstrine [14:51:24] np! [16:00:36] fr-tech, day 2 into being a vegetarian. Last night we had vegetarian curry which was great. If you have any recommended recipe staples you'd like to share feel free to send them over. [16:00:55] wow! [16:00:59] nice! [16:01:24] there's a lentil stew I like, if you can find garam masala [16:01:46] oh yeah lentils would be a definite go-do [16:01:49] *go-to [16:02:00] yeah I can get that locally [16:02:06] https://www.thespicehouse.com/recipes/red-lentil-soup-with-garam-masala-recipe [16:02:29] awesome, thanks! [16:02:32] molletes: https://en.wikipedia.org/wiki/Mollete#/media/File:Molletes.JPG [16:02:47] I often add carrots (near the end so they stay crunchy) [16:03:25] I often make red pasta sauce without the meat. It's just everything you'd do to make bolognesa sauce, just don't add the meat [16:03:27] and sometimes tomatoes [16:03:46] but otherwise, onion, garlic, red wine, tomatoes, and let it stew 3 hours on low heat [16:03:56] I'm curious about the feeling of 'fullness' [16:04:00] then freeze it in smallish portions [16:04:04] without the standout protein [16:04:40] do you have slightly bigger portions or substitute the typical meat element with something like mushrooms/tofu ? [16:04:40] so for example you can throw it in the lentil stew, or put it on bread and melt cheese to make pizza toast [16:05:12] sounds good AndyRussG! [16:05:35] jgleeson: there is a whole lot of theory about how to get the right amount of protein. You'll definitely want to look it up if you haven't... Legumes (beans, lentils), cheese, other dairy, nuts... [16:07:32] fr-tech There are a whole bunch of janky tables in pgehres that aren't described in the Python script's create.sql [16:07:35] https://tools.wmflabs.org/paste/view/59ffd62f [16:07:55] I guess I'll forget about the ones not described by the script for now, but make a task for some spring cleaning there? [16:11:48] AndyRussG: ohh, a lot of those are boilerplate django tables [16:12:12] well, all the django_ and auth_ ones, anyway [16:12:38] ejegg: anything else ingressing data other than DjangoBannerStats? [16:12:45] https://phabricator.wikimedia.org/T198635 [16:13:07] pretty sure there isn't [16:13:21] Also some that are defined in create.sql of Django fame aren't there [16:14:11] As my kids would say, it's kinda "bugueado" (derived from "bug") [16:14:31] weird, taking a look [16:17:06] Also a lot of cruft in the lookup tables, check out the contents of pgehres.project [16:17:55] and language and country [16:20:30] I guess we should disallow at least bad characters in those [16:20:52] and remove obviously bad rows [16:21:09] ejegg: ^ [16:22:05] AndyRussG: yeah, maybe as an add-on task? [16:22:46] yep [16:25:39] https://phabricator.wikimedia.org/T198639 [16:25:52] Fundraising-Backlog: pgehres: Remove obviously incorrect rows from lookup tables - https://phabricator.wikimedia.org/T198639 (AndyRussG) [16:26:23] wikibugs returns [16:27:59] Fundraising-Backlog, fundraising-tech-ops: add primary keys or unique indexes to fundraising civicrm/drupal/pgehres database tables - https://phabricator.wikimedia.org/T176631 (Jgreen) Survey of replicated tables that have no primary key or unique index: Schema.Table Rows civicrm.blank_addresses 568 civ... [16:42:21] fr-tech there is a bot fixing phab right now. It's looking really good. I found one error out of like 200 tasks. The bot it almost done. I'll do some extra scans after that but we should be pretty much in the clear now [16:42:34] great [16:42:38] Good times [16:44:16] (CR) Mepps: "Eileen, do you have any idea why the css/javascript wouldn't be opening on the popup?" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/435002 (https://phabricator.wikimedia.org/T188141) (owner: Mepps) [16:47:37] (CR) Ejegg: "Eileen, I remember you expressing some doubts about this patch so I held off reviewing it. Were those doubts allayed?" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/439788 (owner: Eileen) [16:49:27] fr-tech some trivial code review if anyone has a minute: https://gerrit.wikimedia.org/r/442231 [16:49:54] oh yeah i've been looking at that ejegg--i just need to look in the codebase, hang on [16:50:55] ejegg: so can I safely say we are in a position for a one hour test of ingenico? [16:51:09] (CR) Mepps: "ejegg why is fredge the only constant not in all caps?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/442231 (owner: Ejegg) [16:51:23] dstrine: I think we need to do a deploy, let me check [16:51:59] ok and of course we wouldn't do this right before the 4th or the weekend. So it would have to be thursday or next week [16:52:14] dstrine: ooh, I guess we still need to merge that code [16:52:45] and... that's right, I decided to de-dupe something so I -1-ed it myself [16:52:50] lemme just do that right quick [16:52:56] ok let's review at fr-tech standup [16:53:07] this week didn't have good timing options anyway [17:21:42] Fundraising-Backlog, fundraising-tech-ops: add primary keys or unique indexes to fundraising civicrm/drupal/pgehres database tables - https://phabricator.wikimedia.org/T176631 (Jgreen) Removing this from the replag (T173472) task dependency tree, but it's still a dependency for changing from mixed- to ro... [17:54:30] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner button need to apply Design Style Guide button properties - https://phabricator.wikimedia.org/T195471 (AndyRussG) >>! In T195471#4391182, @Volker_E wrote: > @AndyRussG Any news here, where the code is situated? Hi! Apologies f... [18:26:29] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog: DB schemas (production changes and test DB) and SQL commands to run for new banner and LP impression data from EL - https://phabricator.wikimedia.org/T196564 (AndyRussG) Propos... [18:29:58] fr-tech: I feel like I missed most of you after we got back from Sonoma and didn't have chance to say bye properly :( Was so great to see you last week, hope you all had good journeys home! [18:30:17] you to pcoombe! [18:30:21] too i mean :) [18:53:12] (PS2) Mepps: WIP: Handle no status code for Ingenico api [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440465 (https://phabricator.wikimedia.org/T194517) [18:55:42] (CR) jerkins-bot: [V: -1] WIP: Handle no status code for Ingenico api [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440465 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [18:56:20] fr-tech does anyone else have two random failing paypal tests locally? [18:56:27] in donation interface i mean [19:00:10] mepps, do you have a phpunit group? [19:00:19] before I search for paypal [19:00:21] :) [19:00:43] jgleeson it's happening when i run all of the di tests [19:00:53] for some reason the group flag hasn't been working for me [19:01:12] ah ok [19:01:16] I'll take a look at my end [19:02:40] fr-tech, tech talk in queen mary? [19:03:01] just joined! ejegg AndyRussG XenoRyet? [19:03:36] fr-tech one sec! [19:04:50] one sec too! [19:05:10] fr-tech is this an impromptu? [19:05:14] I'm there btw [19:05:30] AndyRussG, we're in the hangout from the calendar invite [19:05:36] mepps: which calendar invite? [19:31:12] fr-tech just gonna grab some more foodsies quickly [19:47:12] pcoombe: was really good to see u too! :D Travels went fine for me... how was ur flight? [19:51:50] (CR) Eileen: [C: -1] "ejegg - shipping the xml is an upstream change but I want to see a 'final' upstream cut on this - & then redo over it - adding minus 1 for" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/439788 (owner: Eileen) [20:04:12] fundraising-tech-ops, Operations, ops-eqiad, Patch-For-Review: Rack/setup frmon1001 - https://phabricator.wikimedia.org/T186073 (cwdent) a:cwdent [20:04:36] fundraising-tech-ops, Operations, netops: NAT and DNS for fundraising monitor host - https://phabricator.wikimedia.org/T198516 (cwdent) [20:04:42] fundraising-tech-ops, Operations, ops-eqiad, Patch-For-Review: Rack/setup frmon1001 - https://phabricator.wikimedia.org/T186073 (cwdent) [20:05:01] AndyRussG: Yeah, it wasn't too bad. Haven't had such an early one back before, but managed to get a few hours sleep all the same. [20:06:25] fundraising-tech-ops, Operations, ops-eqiad: Authentication for grafana - https://phabricator.wikimedia.org/T198648 (cwdent) p:Triage>Normal [21:17:07] (PS2) Ejegg: Fix Fredge Exception constructor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/442231 [21:17:33] (CR) Ejegg: "Good call mepps. Now capitalized" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/442231 (owner: Ejegg) [21:37:45] pcoombe: cool! yeah I also tried to sleep on the flight, mostly just tossed about in the seat [21:42:37] mepps I don’t have a full answer on your crm-popup - but I have some extra info [21:43:06] It was appending the class bit to the url not putting it as a class - I can’t see why but moving it before the bit of smarty helped [21:44:01] hmm & then I had a space after & before the quotes & that got added too - so something weird [22:02:31] (CR) Eileen: "(from irc )" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/435002 (https://phabricator.wikimedia.org/T188141) (owner: Mepps) [23:31:50] FYI - upstream PR on sessions - https://github.com/civicrm/civicrm-core/pull/12362