[00:01:45] ejegg|afk: someone I’m very vaguely connected to coming your way maybe - https://www.boosted.org.nz/projects/medellin-international-poetry-festival [05:22:02] (PS1) Eileen: Add basic print button [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443542 (https://phabricator.wikimedia.org/T196511) [05:23:53] (PS2) Eileen: Add basic print button [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443542 (https://phabricator.wikimedia.org/T196511) [05:29:34] (CR) jerkins-bot: [V: -1] Add basic print button [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443542 (https://phabricator.wikimedia.org/T196511) (owner: Eileen) [06:27:45] (PS5) Ejegg: skipAuthentication flag disables 3DSecure for Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 [06:29:21] (CR) jerkins-bot: [V: -1] skipAuthentication flag disables 3DSecure for Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 (owner: Ejegg) [06:42:51] (PS6) Ejegg: skipAuthentication flag disables 3DSecure for Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 [06:50:57] (CR) Ejegg: [C: 2] Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 (owner: Eileen) [06:56:48] (Merged) jenkins-bot: Add wmffraud into the showme/forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440253 (owner: Eileen) [07:54:45] Fundraising-Backlog, fundraising-tech-ops: Re-activate staging access for Adam - https://phabricator.wikimedia.org/T198347 (awight) >>! In T198347#4322095, @cwdent wrote: > @awight yes please, also a new fundraising ssh key :) https://office.wikimedia.org/wiki/User:Awight/ssh_key_fr > Access to your yu... [14:59:51] (PS3) Mepps: Fix Fredge Exception constructor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/442231 (owner: Ejegg) [14:59:54] (CR) Mepps: [C: 2] Fix Fredge Exception constructor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/442231 (owner: Ejegg) [15:07:04] (Merged) jenkins-bot: Fix Fredge Exception constructor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/442231 (owner: Ejegg) [15:11:59] thanks mepps [15:36:42] Fundraising-Backlog, fundraising-tech-ops: frdev access for rschoenbaechler - https://phabricator.wikimedia.org/T191446 (cwdent) Open>Resolved [16:33:09] https://wikitech.wikimedia.org/wiki/Fundraising/tech/git [16:34:03] i am feeling a serious need to go on a documentation cleanup crusade [16:34:18] That's never a bad thing [16:35:00] >As of April 2012, fundraising is using both Subversion and Git to manage repositories. [16:35:04] * cwd spittake [16:35:33] Yea... [16:35:49] something i want to get serious about documentin is our codfw rollover plan [16:36:04] wikitech seems like as good a place as anywhere [16:36:20] unless it should be private, but i am not thinking of a reason [16:51:02] cwd ooh, 2012.... [16:51:25] "Make sure you are up to date and create a branch based on the Mingle ticket" [16:51:28] v up to date [16:51:46] 2012. [16:52:04] :) [16:52:19] i feel like we could merge what is on wikitech and what is on mediawiki.org [16:52:24] That's an ominous year to be invoked before I know what's happening. [16:52:37] cwd yeah, that's been the plan for a while! [16:52:52] which one dies? [16:53:09] cwd wikitech stuffs are more outdated [16:53:31] wfm [16:53:32] the idea used to be that if it's 'WMF-specific' it goes on wikitech [16:54:05] but seeing as how all of our stuff is still pretty wmf-specific we might as well make it easier to find [16:54:38] then when we get any serious traction with SmashPig we can maybe put its docs on smashpig.org [16:55:00] yeah [16:55:30] i'm imagining the audience as 1) new fr tech people and 2) non-fr wmf people [16:55:40] yeah [16:56:46] maybe getting phabricator tightly coupled to the problem would help [16:56:54] like a ticket per page what needs refreshin [16:57:12] I like that idea [16:57:37] It'd make it easier to just pick one to clean up when you had a few spare minutes [17:01:12] oh wow: https://www.mediawiki.org/wiki/Extension:DonationGateway [17:04:40] XenoRyet: working on anything interesting? [17:05:03] Just getting ready for the retro today mostly. [17:05:35] Though I'm sort of wondering if we should have it today or move it to next week. We've sort of just spent a whole week doing in-person retroing. [17:09:16] Need to see how dstrine feels about the planning portion when he comes online today. [17:11:32] XenoRyet|brb, cwd, I like the idea of phab tickets for req docs [17:12:04] definitely help fill my quiet mornings and help me reinforce my own knowledge too [17:14:32] Hmm, been meaning to get to the q message docs for a while, I'll file a (ph|f)abricator task at least [17:15:42] cool [17:15:48] well i'm going to start filing some [17:15:53] much to dstrine's dismay :) [17:19:21] huh, wikibugs isn't announcing [17:19:49] * jgleeson gets a flashback to the discussion around fr-tech norms on when we can create tickets, it involved lots of references to dstrine-away [17:20:27] actually I think it was then simplified to something like "you can create a ticket in an emergency, or if it's not.. you can't." [17:20:36] :) [17:21:01] jgleeson: Na, you can create tickets to your heart's content, you just can't add 'em to the sprint without David's blessing. [17:21:02] ejegg: yesterday wikibugs was intermittent for me [17:21:05] sorry! no that's not correct. I am misremembering, this was the sprint [17:21:28] that was it XenoRyet [17:21:30] heheh backlog spam and then skip backlog honing [17:33:37] Fundraising-Backlog: Update fr-tech git norms doc - https://phabricator.wikimedia.org/T198735 (cwdent) [17:34:20] AndyRussG: where did you need some further review of things? [17:48:32] ejegg, could you give me the cli command I need to run the tokenizeRecurringJob? I have the broken message in the new queue. [17:51:47] or are you instead just running your own local cli process to test it? [17:51:58] it doesn't look like the logic has the home yet [17:52:08] although it works as a discrete module [18:01:19] jgleeson|mobile: I was using some damaged entries [18:01:28] ohhh, right, sorry [18:01:41] different tokenize thing [18:02:58] so, it would be php Maintenance/QueueJobRunner.php --queue=jobs-ingenico --config-node=ingenico [18:05:27] ejegg|ish: T196563 and T196564 [18:05:28] T196563: Write a specification for mapping banner/landing page impression event properties -> database schema - https://phabricator.wikimedia.org/T196563 [18:05:28] T196564: DB schemas (production changes and test DB) and SQL commands to run for new banner and LP impression data from EL - https://phabricator.wikimedia.org/T196564 [18:11:34] ok ok [18:14:38] thx!!! [18:41:05] fr-tech: How do people feel about just doing a quick meeting today and moving the full retro and sprint planning to next week? [18:41:23] that works for me XenoRyet! [18:41:39] The theory being we just did a lot of in-person retro-like talking, and this week is fragmented anyway. [18:42:00] XenoRyet: all good here :) [18:42:36] That way jgleeson|mobile and ejegg|ish can finish watching that match as well ;-) [18:44:26] sorry all. I was not on IRC. It was feeling like a very quiet day :P [18:46:55] Ok, I think I've got sprint planning moved properly, but for some reason it won't let me edit the tuesday standup [18:48:26] Wrong permissions I guess? [18:48:45] dstinre: Maybe it wants you to do it? ' [18:49:29] We can just interrupt next week's retro to do standup, like it says on the calendar ;p [18:49:39] Sounds like a plan [18:51:17] thanks folks! [18:56:55] ejegg|ish: :) [19:09:56] fr-tech so today at 12:45 Pacific I guess? [19:10:06] Yep, that's the plan. [19:10:32] XenoRyet: okok thx! [19:23:29] Should I feel bad about eating curry on pasta (tortiglioni, specifically) instead of rice? [19:23:50] Na, sounds tasty. [19:32:52] thanks XenoRyet [19:33:21] No worries. It was mostly for logistics, getting to watch the game is a happy accident. ;-) [19:34:28] it's a pretty tense game, and as a result it's running over slightly [19:34:47] although I've got my laptop with me now [19:35:00] so i'll change my name [19:35:18] We can frontload BS time too, if the game isn't quite over in time. [19:36:25] Yeah, I think there is going to be a lot of stoppage time! [19:36:43] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Fatal exception of type "BannerExistenceException" - https://phabricator.wikimedia.org/T197793 (AndyRussG) [19:36:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, Wikimedia-log-errors: Don't serve an exception on Special:CentralNoticeBanners when the banner doesn't exist - https://phabricator.wikimedia.org/T149240 (AndyRussG) [19:37:07] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, Wikimedia-log-errors: Don't serve an exception on Special:CentralNoticeBanners when the banner doesn't exist - https://phabricator.wikimedia.org/T149240 (AndyRussG) [19:37:21] is there sprint planning? [19:38:00] eileen: We moved it to next week. We're just doing a standup-ish meeting at 12:45 in the usual hangout. [19:38:17] ah ok - in 7 mins? [19:38:23] Yep [19:45:27] still 7 min plus stoppage time left in Moscow [20:09:59] ejegg|ish, this is tense! [20:41:12] jgleeson: seriously tense! let's just hope nobody gets a yellow card doing a penalty kick [20:41:20] ha [20:41:47] England doesn't have a great record with penalties [20:42:05] it's our national fear at big tournaments [20:49:28] Whoo, it ain't over 'till it's over, eh? [20:55:34] fundraising-tech-ops, Operations, netops: NAT and DNS for fundraising monitor host - https://phabricator.wikimedia.org/T198516 (Jgreen) Looks like .4, .9, and .15 are available. .9 was tellurium and still has crufty DNS so my suggestion is we use that, and clean up the cruft in the process. [20:56:44] fundraising-tech-ops, Operations, netops: NAT and DNS for fundraising monitor host - https://phabricator.wikimedia.org/T198516 (Jgreen) Looks like .4, .9, and .15 are available. .9 was tellurium and still has crufty DNS so my suggestion is we use that, and clean up the cruft in the process. [20:59:33] it's over now AndyRussG ! [20:59:51] condolences ejegg|ish [21:00:02] that was insane [21:01:15] aww, thanks [21:14:13] jgleeson: ejegg|ish: :) [21:17:04] eileen: hi [21:17:11] cwd hey [21:17:37] i was late to the meetup yesterday [21:17:50] how do you feel about adding indexes to the log tables? [21:29:48] what about adding instead logs to the index tables? [21:30:14] I imagine it's a dozen of one and half of six of the other [21:31:14] * AndyRussG dons straitjacket [21:34:23] cwd it sounds like we need to add an extra column to the log tables [21:34:44] since even id + connection + time + operation isn't guaranteed unique [21:35:08] ah ha [21:35:21] so an auto increment id? [21:35:27] yeah... [21:35:58] do you have performance concerns? [21:35:59] i'd definitely want to get some perf data before + after [21:36:08] yeah [21:36:28] @AndyRussG you about? [21:36:52] right, it's still all voodoo to me, but i guess it's like a table lock on inserts when you have that [21:37:25] it is when the triggers execute? [21:37:49] that is when the logging happens? [21:38:00] we insert into log tables using triggers, yeah [21:38:23] @AndyRussG this is quite urgent if you are about [21:38:32] cwd AND, there are triggers on all sorts of contact-associated tables, like address [21:38:43] which add entries to log_contact [21:38:51] Seddon: anything I might be able to help with? [21:39:22] one of the EU_Copyright campaigns? [21:39:57] I'm having major issues in modifying centralnotice banners when using the translate extension variables in them [21:40:01] I keep getting this error [21:40:04] https://usercontent.irccloud-cdn.com/file/dKc0ssIZ/image.png [21:40:15] well damn [21:40:20] The specifically is [21:40:25] banner specifically is [21:40:41] Something to do with the recent work on Multi-content revisions would be my first guess [21:40:42] https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/EU_Copyright_Directive_ML [21:40:52] https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/EU_Copyright_Directive_ML2 [21:41:19] crud, I forget where we get access to full stack traces [21:41:25] cwd do you happen to know? [21:41:40] i do not [21:41:43] but i can ask tyler [21:42:04] that would rock! [21:42:11] searching wikitech meanwhile [21:42:29] Seddon: helloo? [21:42:44] See above^^ [21:42:46] AndyRussG: he's getting some new-looking errors [21:42:49] Seddon: k reading backscroool [21:43:01] MediaWiki\Storage\RevisionAccessException [21:44:39] Seddon: hmmm ok, does this happen every time you modify the variables, or just sometimes? [21:44:55] Checking logstash [21:45:08] AndyRussG: I get the error the moment I create the banner, then if I try to edit the banner in any manner I get that error [21:45:21] logstash, that's the thing! Thanks AndyRussG [21:46:24] cwd: AndyRussG knew where to look ^^ [21:46:55] Seddon: ok. I can see the stack trace on logstash [21:47:17] Lemme see if it might be from something just deployed now [21:47:20] (in core) [21:47:30] nice [21:48:27] This is the first multilingual banner I've built in weeks but I've noticed other odd errors at least in the last week [21:48:39] definitely looks like new code [21:48:53] Closure$MediaWiki\Storage\RevisionStore::emulateMainSlot_1_29 [21:50:09] https://bit.ly/2IOASH5 [21:50:55] AndyRussG: I was looking at this one: https://logstash.wikimedia.org/app/kibana#/dashboard/default?_g=h@44136fa&_a=h@95eaeea [21:51:36] seems to match Seddon's error: https://usercontent.irccloud-cdn.com/file/dKc0ssIZ/image.png [21:51:37] ejegg: click on the "share" to get the right URL to share the view... [21:51:50] ah, one sec [21:51:54] ejegg: Seddon looks like there's no train deploy this week. https://www.mediawiki.org/wiki/MediaWiki_1.32/Roadmap [21:52:35] AndyRussG: or just search for RevisionAccessException [21:53:03] Yeah... Notice also some other translate-related errors in the log there [21:53:07] Something about a deprecation [21:53:18] ejegg: what makes u say it looks like new code? [21:53:29] the LanguageGetMagic hook is what's deprecated? [21:54:17] AndyRussG: The multi-content revision code is still being worked on, but they've deployed the first bits of the code in the last month or two [21:54:54] and the stack trace I saw for the RevisionAccessException was calling a backwards-compatibility shim they've added to make the new code work with the old db rows [21:55:11] though I don't know if that's the issue here [21:55:36] hmmm [21:55:50] just looking for the changelogs on that [21:56:18] oh, ok, that's actually not as new as I thought [21:57:08] that fn has been around since last August, last changed in April [21:57:24] Seddon: so far this looks like there's a chance this is complex to track down, fix, and get deployed. If this an urgent banner (for example, related to the itwiki protest and that issue) you may wish to consider making a non-multilingual version for some of the most important languages, as a temporary workaround [21:58:49] @AndyRussG understood! [21:59:01] ah, there's some more detail in the logstash 'message' field [21:59:11] Failed to load data blob from tt:18303612: Failed to load blob from address tt:18303612 [22:00:53] who else should we consult on this... [22:01:01] ejegg: I feel like we should track down who wrote whatever changed most recently in the code path along the stack trace, and ping them, and also try to reproduce locally [22:01:27] looks like a 'Kinzler' and addshore have done work in the past year on that [22:01:46] 'that' meaning functions in RevisionStore.php [22:03:14] hmm, and it looks like that RevisionAccessException is caused by an underlying BlobAccessException [22:03:38] yerp [22:04:56] (code also written mostly by Kinzler, some Schultz in there) [22:05:20] but still not seeing anything changed in the past 2 months [22:06:24] Oh Kibana has a url shortener built-in [22:06:27] https://logstash.wikimedia.org/goto/22b29f95b2c5e365115511a18e5847ae [22:06:35] Mmm let's ping 'em all [22:06:49] Maype on #wikimedia-operations? [22:08:04] aha, thanks [22:08:05] https://logstash.wikimedia.org/goto/610270aa608bafe1a8885e715135bbfd [22:09:25] K ping sent [22:17:15] ejegg: did you see my ping from Civi-JIRA [22:17:37] eileen: ah, let me check my other email [22:22:26] eileen: was it on gitlab? [22:22:41] ejegg: https://issues.civicrm.org/jira/browse/CRM-20711 [22:23:46] ejegg: I guess we need a task... [22:23:59] AndyRussG: yeah, this is non-trivial, huh? [22:24:06] fer sures [22:25:17] eileen: aha! That's interesting [22:25:24] weird huh [22:25:27] So that's what we get for being early adopters [22:25:48] & funny they found our internal commit on github - I’ll upstream it now I know it’s not just us [22:29:42] nice [22:29:53] I guess we're well-indexed [22:34:35] XenoRyet: there's some fund mediawiki-core debugging to do if you're interested [22:34:40] (see backscroll) [22:35:05] we're also pinging folks in #mediawiki-operations [22:50:31] AndyRussG: weird, I got a different error [22:50:39] Declaration of FundraisingTranslateWorkflow\FundraisingMessageGroup::initCollection($code) must be compatible with MessageGroupOld::initCollection [22:50:44] ah, lemme update my extensions [23:17:53] ejegg: yeah [23:32:39] grr, still getting similar errors, following rabbits down holes [23:42:13] (PS1) Ejegg: Update horrible kludge to match parent updates [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/443755 [23:42:45] AndyRussG: I needed ^^^ to get anything working at all on latest core [23:43:43] but with that applied, I can add a translatable message and then add a value for it [23:45:03] lessee if i'm hitting any of those code paths [23:46:44] ejegg: woohoo! [23:47:19] AndyRussG: well, i still haven't been able to replicate the error seddon got on prod [23:47:20] ejegg: I have non-work heading my way in the coming hours but will check it out later this evening!!! :) [23:47:30] Yeah I haven't either [23:51:48] hmm, so do we see any warnings like this one? https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/Storage/SqlBlobStore.php$345