[00:39:39] (PS3) Eileen: Add Logging.get api support for contact_id as a filter. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/441328 [00:39:40] (PS5) Eileen: Further upstream fixes in 5.3 release [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/439788 [04:53:38] (PS3) Eileen: Add basic print button to the forgetme screen. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443542 (https://phabricator.wikimedia.org/T196511) [04:53:40] (PS1) Eileen: Just an extraction. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443886 [04:57:43] (Abandoned) Eileen: Finally drop old do_not_solicit field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/424187 (owner: Eileen) [05:00:56] (CR) Eileen: [C: 2] Reformat Translation.php with drupal style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440023 (owner: Ejegg) [05:06:10] (Merged) jenkins-bot: Reformat Translation.php with drupal style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440023 (owner: Ejegg) [05:33:09] (PS2) Eileen: Just an extraction. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443886 [05:33:11] (PS4) Eileen: Add basic print button to the forgetme screen. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443542 (https://phabricator.wikimedia.org/T196511) [05:33:13] (PS1) Eileen: Enotice fix - much as I would like it I can't give all fields titles in the metadata. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443887 (https://phabricator.wikimedia.org/T195611) [05:36:22] (PS1) Eileen: Code simplification. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443888 (https://phabricator.wikimedia.org/T196644) [05:37:19] (PS1) Eileen: Move metadata to class - re-organisation of code, no functional change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443889 (https://phabricator.wikimedia.org/T196644) [06:37:56] (PS6) Eileen: Further upstream fixes in 5.3 release [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/439788 [06:59:49] (PS7) Eileen: Further upstream fixes in 5.3 release [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/439788 [06:59:51] (PS4) Eileen: Add Logging.get api support for contact_id as a filter. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/441328 [06:59:54] (CR) Eileen: [C: -1] Add Logging.get api support for contact_id as a filter. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/441328 (owner: Eileen) [12:16:12] (CR) Jgleeson: [V: 1 C: 1] "Working for me! although I did have to go through a fairly contrived test process locally to push it through. I did the following:" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441251 (owner: Ejegg) [12:26:10] (CR) Jgleeson: [V: 1 C: 1] "I kinda like the separation of the job and message properties that the 'payload' intermediate gives you. I prefer the new one, just becaus" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441583 (owner: Ejegg) [12:29:35] (CR) Jgleeson: [V: 1 C: 1] "I kinda like it. Works for me in the patch that builds upon it." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441250 (owner: Ejegg) [15:22:43] Hewwowsie-ohs [15:27:48] hey hey AndyRussG :) [15:27:55] jgleeson: :) [15:27:55] and mepps :) [15:50:55] (CR) Jgleeson: "The behaviour makes sense to me. I've added a few points where I feel we'd benefit from some extra comments." (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 (owner: Ejegg) [16:00:36] (CR) AndyRussG: [C: 2] "LGTM! Kicks silly, horrible, kludgy butt!!" [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/443755 (owner: Ejegg) [16:05:11] ejegg|afk meeting? [16:08:53] (Merged) jenkins-bot: Update horrible kludge to match parent updates [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/443755 (owner: Ejegg) [16:36:05] ejegg: ^ thx 4 ur patch there... I can't believe I didn't even know that extension.......... [16:37:21] beta cluster still borks, so I think that wasn't it [16:51:54] I've never seen that extension before either. Does it just restrict who can publish certain messages? [16:55:13] pcoombe That's sure what it looks like. I don't see the actual purpose clearly explained. No extension page on mediawiki.org [16:56:36] ^ the patch by ejegg is essentially a no-op that makes the existing code comply with a strict php rule... and it worked locally... which is why I was ok +2'ing without a fuller understanding of the whole context, infact [17:01:07] https://github.com/wikimedia/mediawiki-extensions-FundraisingTranslateWorkflow/blob/master/FundraisingMessageGroup.php#L56-L57 [17:01:33] fr-tech, should we postpone tech talk until Dylan is back? [17:02:21] * AndyRussG indiffers [17:02:29] either way okok by me [17:14:16] fr-tech meet froze [17:14:21] im here, just stuck [17:14:24] i can hear you [17:14:29] and did have a questiin [17:14:32] question* [20:18:07] (PS7) Ejegg: skipAuthentication flag disables 3DSecure for Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 [20:19:20] (PS8) Ejegg: skipAuthentication flag disables 3DSecure for Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 (https://phabricator.wikimedia.org/T176512) [20:19:33] (PS9) Ejegg: skipAuthentication flag disables 3DSecure for Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 (https://phabricator.wikimedia.org/T176512) [20:21:20] (CR) Ejegg: "Thanks for the suggestions jgleeson. I fleshed out the comments and moved the rest of the logic to see if the flag is settable into the ca" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/441483 (https://phabricator.wikimedia.org/T176512) (owner: Ejegg) [20:31:25] mepps: looks like jgleeson gave this one a +1 https://gerrit.wikimedia.org/r/441250 [20:31:47] any chance you'd want to give it the second point to push it over the line? [20:35:26] (CR) Ejegg: "right, 'factory' is a bad name for the new functionality. Maybe needs renaming to 'jobMessageFromGatewayOrderId' or something" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441583 (owner: Ejegg) [20:40:19] (CR) Ejegg: "for the queue manipulation, you can also use two of the SmashPig maintenance scripts:" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/441251 (owner: Ejegg) [21:57:17] (CR) Ejegg: [C: 2] "Seems to work, doesn't mess up our queue consumers." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/439788 (owner: Eileen) [21:57:37] fr-tech I'm going to deploy those Civi bugfixes ^^^ [22:05:05] (Merged) jenkins-bot: Further upstream fixes in 5.3 release [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/439788 (owner: Eileen)