[03:24:01] (PS4) Eileen: Move metadata to class - re-organisation of code, no functional change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443889 (https://phabricator.wikimedia.org/T196644) [03:29:17] (CR) jerkins-bot: [V: -1] Move metadata to class - re-organisation of code, no functional change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443889 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [03:33:05] (PS5) Eileen: Move metadata to class - re-organisation of code, no functional change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443889 (https://phabricator.wikimedia.org/T196644) [03:38:03] (CR) jerkins-bot: [V: -1] Move metadata to class - re-organisation of code, no functional change. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443889 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [03:49:28] (PS6) Eileen: Move metadata to class, switch to whitelisting of entities to show & forget. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443889 (https://phabricator.wikimedia.org/T196644) [04:02:12] (PS1) Eileen: Add showme for logging [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/444482 (https://phabricator.wikimedia.org/T196644) [04:02:20] (Abandoned) Eileen: WIP on showing logging [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/441339 (owner: Eileen) [04:02:30] (Abandoned) Eileen: Add Logging.get api support for contact_id as a filter. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/441328 (owner: Eileen) [04:03:46] (PS2) Eileen: [WIP] Components for new contact editor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443202 [04:29:19] (PS2) Eileen: Add showme for logging [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/444482 (https://phabricator.wikimedia.org/T196644) [04:29:21] (PS1) Eileen: Add forgetme for logging [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/444484 (https://phabricator.wikimedia.org/T196644) [05:01:54] (PS1) Eileen: Add code to delete select contact fields & custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/444487 (https://phabricator.wikimedia.org/T196644) [05:33:45] (PS2) Eileen: Add code to delete select contact fields & custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/444487 (https://phabricator.wikimedia.org/T196644) [13:34:25] (CR) Ottomata: "The PHP Kafka consumers are pretty bad. We actually really want to move the only existing usage of this consumer to EventBus (or its succ" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/279745 (https://phabricator.wikimedia.org/T130304) (owner: Awight) [13:34:45] (CR) Ottomata: "s/PHP Kafka consumers/PHP Kafka clients/" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/279745 (https://phabricator.wikimedia.org/T130304) (owner: Awight) [15:09:22] oops [15:22:48] (PS2) Mepps: WIP Refactor of ConfirmCreditCard [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444311 (https://phabricator.wikimedia.org/T194517) [16:14:47] (PS3) Mepps: WIP Refactor of ConfirmCreditCard [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444311 (https://phabricator.wikimedia.org/T194517) [16:26:26] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/444613 [16:26:40] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/444613 (owner: Ejegg) [16:28:26] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/444613 (owner: Ejegg) [16:33:28] (PS1) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444614 [16:33:35] (CR) Ejegg: [C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444614 (owner: Ejegg) [16:34:04] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444614 (owner: Ejegg) [16:35:26] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444614 (owner: Ejegg) [16:35:40] (PS1) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444616 [16:36:19] (Abandoned) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444614 (owner: Ejegg) [16:40:17] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444616 (owner: Ejegg) [16:41:42] (CR) Ejegg: [V: 2 C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444616 (owner: Ejegg) [16:46:04] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444616 (owner: Ejegg) [16:46:09] grr [16:46:48] fr-tech ^^^ seems like more evidence of 1.27 decaying in continuous integration [16:51:26] asking for help in #wikimedia-releng [16:52:03] fr-tech Hewwoh! FYI just pinging people in #wikimedia-dev for help with the CN blob-bug (T198869) [16:52:04] T198869: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 [17:03:23] (PS1) Ejegg: Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444628 [17:03:43] fr-tech anyone else have a sec to look at that ^^^ [17:03:44] ? [17:03:50] sure ejegg [17:03:52] Might be needed to get CI working again [17:03:54] thanks! [17:04:37] anything I can help with? just got off 1:1 [17:04:42] ejegg can you explain a little more what the merge is for? [17:05:06] Sure mepps - some of the core CI tests were failing under PHP7 [17:05:13] and this pulls in at least one of the fixes [17:05:30] have we upgraded it all to php7 then? [17:05:41] I guess CI runs php7 now [17:06:20] ahh [17:06:38] but prod still doesn't? should i test this under 5.6 or have you done that already? [17:07:04] ah dang, good call [17:07:14] I don't see any CI tests under 56 [17:07:23] just hhvm and php7 now [17:08:10] (CR) jerkins-bot: [V: -1] Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444628 (owner: Ejegg) [17:10:02] hmm looks like build also broken ejegg ^^ [17:10:14] i'm running tests locally under 5.6 and will try out a contribution [17:10:14] yeah, it fixed the first error [17:10:35] but it's still checking out the wrong branch for the Vector skin [17:10:40] that needs to be fixed in the CI setup [17:11:08] ah [17:13:12] filed https://phabricator.wikimedia.org/T199130 for it [17:14:28] thanks Reedy! [17:15:16] ejegg it might be a local setup thing for me but i got a fatal error while running the tests in php5.6 [17:15:26] so would definitely recommend doing it on your machine too [17:15:57] oh shoot, I don't actually have 5.6 installed any more :( [17:17:11] What's the fatal? [17:19:25] mepps what is the error? [17:19:48] oops sorry it's PHP Fatal error: Call to a member function getTextSnippet() on boolean in /var/www/fr-tech/mediawiki_payments/tests/phpunit/includes/search/SearchEngineTest.php on line 175 [17:20:10] at least it's not a syntax error :P [17:20:11] ejegg Reedy ^^ [17:20:16] :) [17:20:32] oh huh, I remember seeing those in CI earlier [17:22:10] hmm making sure i'm up to date [17:22:24] and i am [17:22:50] running the tests without this patch though on 5.6 [17:23:13] jgleeson do you have 5.6 on your machine? [17:23:24] no sorry mepps :( [17:23:41] actually I might be able to install it on my vagrant instance [17:23:52] rebuild that is [17:24:26] hmm how about cwd or XenoRyet, do you have php5.6 locally? [17:26:51] i do not [17:27:13] Though, that's curious "Call to a member function getTextSnippet() on boolean" [17:27:23] " * @return SearchResultSet|Status|null" [17:28:44] If it was broken... I'm guessing it was already broken [17:29:48] mepps: No, me either [17:37:24] just installing 5.6 now [17:37:42] mepps, are you running the mediawiki tests? [17:42:51] yes jgleeson [17:59:33] the git clone of mw is pretty meaty [18:01:09] mepps just gonna grab some good, I've installed 5.6 locally and now pulling down mw, will configure to work with gerrit to pull in ejeggs patch and try out tests when back to see if I can recreate the error [18:01:27] some food* [18:01:32] :) [18:29:55] oh hey, I DO have force-merge on fundraising/REL1_27 [18:30:14] I was sure that Submit button was missing before [18:31:28] well, I'mma go ahead with that just so we can get the 3dsecure patch up [18:34:05] (PS2) Ejegg: Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444628 [18:37:41] (CR) jerkins-bot: [V: -1] Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444628 (owner: Ejegg) [18:38:53] (CR) Ejegg: [V: 2 C: 2] Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444628 (owner: Ejegg) [18:41:30] !log updated payments-wiki from 43989ebc96 to 198c31a657 (patches from REL1_27) [18:41:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:44:51] (PS2) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444616 [18:50:09] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444616 (owner: Ejegg) [18:51:56] (CR) Ejegg: [V: 2 C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444616 (owner: Ejegg) [18:56:05] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444616 (owner: Ejegg) [18:59:34] !log updated payments-wiki from 198c31a657 to f302c5ffa3 (DI update) [18:59:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:01:17] crud, 'Remember my details' and 'Cancel' are showing up again in the ingenico iframe [19:03:06] and... i'm still getting the 'verified by visa' step :( [19:03:28] yeah, force is only there after V+2 C+2 is applied [19:14:43] fr-tech the new code doesn't seem to be turning 3d secure off in production :( [19:14:58] oh no [19:15:00] and even with CurlVerboseLogging we're not logging the outbound data [19:15:03] oh darn ejegg :( [19:15:05] That's unfortunate [19:15:09] wait, is there another setting? [19:16:21] ah, not a setting, and never actually overridden log_outbound... [19:25:37] (PS1) Ejegg: log-outbound setting for CurlWrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/444662 [19:26:00] fr-tech here's a thing to try to get the outbound data in the log ^^^ [19:26:20] (CR) jerkins-bot: [V: -1] log-outbound setting for CurlWrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/444662 (owner: Ejegg) [19:30:16] (PS2) Ejegg: log-outbound setting for CurlWrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/444662 [19:30:39] (CR) jerkins-bot: [V: -1] log-outbound setting for CurlWrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/444662 (owner: Ejegg) [19:31:57] (PS3) Ejegg: log-outbound setting for CurlWrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/444662 [19:46:51] Wikimedia-Fundraising-Banners: All banner images should be inline SVG where possible - https://phabricator.wikimedia.org/T199147 (Pcoombe) [19:47:28] Fundraising-Backlog, fundraising-tech-ops: Doc update: probably delete this page - https://phabricator.wikimedia.org/T198739 (DStrine) [20:33:16] (CR) XenoRyet: [C: 2] "Yea, that'll do the trick." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/444662 (owner: Ejegg) [20:33:41] (Merged) jenkins-bot: log-outbound setting for CurlWrapper [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/444662 (owner: Ejegg) [21:14:49] mepps, I remember you saying you couldn't use the group flag on phpunit tests, did you figure out why by any chance? I have the same issue on my 5.6 setup [21:19:10] (PS1) Ejegg: Update SmashPig library [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444740 [21:20:06] (CR) Ejegg: [C: 2] Update SmashPig library [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444740 (owner: Ejegg) [21:21:22] mepps: ejegg if you can look at this at some point https://lab.civicrm.org/dev/core/issues/233 [21:21:51] eileen: ah yeah, I was thinking at one point a whole nother table to track merged contacts might make sense [21:22:16] (PS1) Ejegg: Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/444741 [21:22:27] ejegg: yeah - well when I dug I realises we DO have the info already - if we use that parent_id field [21:22:36] so I guess we should consider using that [21:22:46] & see if there is a reason that it won’t work [21:22:49] ah, in the activities table? [21:23:27] (CR) Ejegg: [C: 2] Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/444741 (owner: Ejegg) [21:24:31] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/444742 [21:24:50] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/444742 (owner: Ejegg) [21:24:57] :P [21:25:16] (CR) Ejegg: [V: 2 C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/444742 (owner: Ejegg) [21:31:40] (Merged) jenkins-bot: Update SmashPig library [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444740 (owner: Ejegg) [21:31:42] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/444742 (owner: Ejegg) [21:32:17] (CR) Ejegg: [V: 2 C: 2] Update SmashPig library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/444741 (owner: Ejegg) [21:40:05] (PS1) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444747 [21:40:59] (CR) Ejegg: [V: 2 C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444747 (owner: Ejegg) [21:44:24] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444747 (owner: Ejegg) [21:45:52] !log updated payments-wiki from f302c5ffa3 to ed40f33c44 (Outbound cURL logging in SmashPig) [21:45:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:55:11] ah frack [21:55:14] I found it [21:56:21] there are two diff top level keys [21:56:28] cardPaymentSpecificInput [21:56:35] and cardPaymentMethodSpecificInput [21:56:47] we put skipAuthentication under the wrong one [21:59:59] wait, how the heck were we getting tokens in the sandbox? [22:03:01] (PS1) Ejegg: Fix Ingenico cardPaymentMethodSpecificInput key [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444750 [22:03:07] fr-tech I think this is the fix we need ^^^ [22:03:17] Just trying a few recurring things against the sandbox [22:03:28] not sure how it was giving us those tokens with the key in the wrong place [22:03:50] :| [22:04:21] is the sandbox working as expected with that key? [22:05:21] I should of compared the original patch against the spec really in the absence of us being able to perform a "real" test [22:06:43] Hmm, I do see a recurring payment token in the final message [22:07:11] but... where did it come from? not seeing it in the logged API responses at first glance [22:07:40] ah, there it is [22:08:02] jgleeson: yeah, definitely getting the token with the new key [22:19:14] ok fields looks good, although ejegg|brb I think we've got isRecurring in two blocks [22:19:30] is that a knock on from the global collect parent sending ignored flags? [22:20:26] jgleeson: ooh, do we [22:20:27] ? [22:20:54] yup, unless my ide is deceiving me [22:21:06] it's in cardSpecific.. and hostedCheckout... [22:21:23] I'm guessing I missed that first time round [22:22:23] ah crud [22:22:44] just gonna step through the response then I'll rerun to confirm [22:23:51] OK, looks like it's not supposed to be in cardPaymentMethodSpecificInput [22:24:17] only hostedCheckoutSpecificInput [22:24:30] (though the other recurring flags DO go in cardPayment [22:24:32] ) [22:25:30] for some reason the plural tokens is confusing me [22:25:34] has it always been that? [22:25:48] yeah, it is confusing [22:26:33] (PS2) Ejegg: Fix Ingenico cardPaymentMethodSpecificInput key [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444750 [22:26:36] ok, cleaned up the duplicate isRecurring ^^ [22:27:40] cool, just tested the previous which worked fine so will test the latest up to the point of DI making request [22:29:35] ejegg: yes sorry - had calls - we currently use the activity table in a non core way - but we could use the core data [22:30:13] I forgot to say in stand up - will be attending a funeral this arvo - not sure how much of the day it will knock out for me [22:30:44] sorry to hear that [22:30:57] sorry to hear eileen [22:33:54] eileen: condolences [22:36:29] yeah bit sucky [22:36:50] (not someone young - but not that old - recently retired) [22:39:07] (CR) Jgleeson: [C: 2] "Looks good. Donation with token ends up on the queue for me still and tests passing." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444750 (owner: Ejegg) [22:39:18] thanks jgleeson! [22:54:48] :( [23:01:43] jgleeson: weird, what happened to your c+2? [23:02:11] Comment sure looks like you applied it, but it's not listed above [23:02:27] (CR) Jgleeson: [C: 2] Fix Ingenico cardPaymentMethodSpecificInput key [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444750 (owner: Ejegg) [23:02:33] not sure [23:02:34] (CR) Ejegg: [C: 2] "Weird, jgleeson's C+2 got lost?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444750 (owner: Ejegg) [23:02:46] thanks! [23:03:02] gonna go for a little walk before the sun goes down, but I'll deploy that when I get back [23:04:06] (Merged) jenkins-bot: Fix Ingenico cardPaymentMethodSpecificInput key [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444750 (owner: Ejegg) [23:12:49] mepps, I sunk a bit of time into trying to work out why smashpig wouldn't work within a standlone mw clone with donation interface and nothing else, from the cli, turned out I was missin php-sqlite. Now it looks like I have contribution tracking issues... making me feel that this exercise to "quickly" pull down a fresh install of mw on 5.6 and just run the tests from cli is instead turning into more of a full-stack setup [23:12:49] outside of vagrant. I'll continue tomorrow! Have a good night all. [23:42:52] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/444766 [23:42:57] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/444766 (owner: Ejegg) [23:50:16] (PS1) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444767 [23:50:30] (CR) Ejegg: [V: 2 C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444767 (owner: Ejegg) [23:53:19] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/444766 (owner: Ejegg) [23:54:51] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/444767 (owner: Ejegg) [23:58:06] !log updated payments-wiki from ed40f33c44 to 383f667171 [23:58:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log