[00:03:27] woot, that did it! [00:05:53] (PS1) Eileen: [WIP] CiviCRM 5.4 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/444769 [00:12:11] (CR) jerkins-bot: [V: -1] [WIP] CiviCRM 5.4 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/444769 (owner: Eileen) [01:03:07] ok folks, signing off for the evening [15:24:12] Wikimedia-Fundraising-Banners: All banner images should be inline SVG where possible - https://phabricator.wikimedia.org/T199147 (schoenbaechler) Thanks for identifying and listing these @Pcoombe, will take on this task with pleasure! [16:34:33] Hi, can anyone help with the translation of the message for the site? https://meta.wikimedia.org/wiki/User_talk:Pcoombe_(WMF)#Question_about_translation [16:36:48] hi sunpriat! [16:38:13] Hmm, that's a good question. Some of our messages are translated on translatewiki, but not that one. [16:41:23] pcoombe: donatewiki doesn't have any automatically-translated content like the thank you letter on meta, does it? [16:45:26] ejegg there are so https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=UK&uselang=qqx https://donate.wikimedia.org/wiki/Special:PrefixIndex/Template:2011FR/Appeal-default/title/ and only registered users can create messages there [16:49:10] fr-tech, might be a little late to tech talk, gotta pop out and pick up family [16:49:29] sunpriat yeah, we have to keep that one locked down since it's on the pathway to accepting credit cards. [16:50:47] I see that some of the translations on donate.wikimedia.orrg come from interface messages in the Donation Interface extension, but I'm not sure how longer text like the appeal and the 'sorry, not accepting donations from X country' message would be translated [16:51:05] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (AndyRussG) Friendly ping also for @Tgr @MarkTraceur @Ano... [16:51:45] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-Platform-Team, MediaWiki-extensions-CentralNotice: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (CCicalese_WMF) [16:54:39] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-Platform-Team, MediaWiki-extensions-CentralNotice: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (daniel) @Ejegg quick guess,... [16:56:06] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-Platform-Team, MediaWiki-extensions-CentralNotice, Multi-Content-Revisions: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (... [16:56:46] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-Platform-Team, MediaWiki-extensions-CentralNotice, Multi-Content-Revisions: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (... [17:01:51] should I create a task on the phabricator for this task or just wait for a response from Pcoombe or write somewhere else? [17:02:36] sunpriat: a phab task would be the best way to track it, if it's no trouble for you to make one [17:02:39] thank you! [17:02:43] fr-tech I should probably dig into the comments we just got on CN bug from core engineers, since they seem active now... [17:03:17] AndyRussG: yeah! Kinzler has a theory, and there's a WIP patch that would fix it, if that is indeed the issue [17:03:32] just opening the project again to try to understand what PageUpdater does [17:03:44] also, was thinking of diving into this in tech talk [17:03:59] ejegg sure! [17:04:05] unfortunately google meat has been saying Loading... for 3 minutes [17:04:11] Oh [17:04:13] hmmm [17:04:47] Mmm wrt PageUpdater it looks like there's a method there we should be calling instead of a deprecated one in WikiPage [17:05:03] However the WikiPage deprecated one just calls the new PageUpdater one under the hood [17:05:36] oh [17:07:05] My house is pretty noisy at the moment, give me a minute to relocate then I'll be into tech-talk [17:11:02] [17:20:18] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-Platform-Team, MediaWiki-extensions-CentralNotice, Multi-Content-Revisions: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (... [17:30:04] sunpriat: Apologies for not replying yet, it's been a busy day. I'll make a phabricator task for that if you haven't already [17:48:16] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-Platform-Team, MediaWiki-extensions-CentralNotice, Multi-Content-Revisions: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (... [17:48:30] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-Platform-Team, MediaWiki-extensions-CentralNotice, Multi-Content-Revisions: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (... [18:38:01] surprise standup, or standup surprise? [18:43:41] We could do both [18:44:06] Everyone stand up surprisingly in our surpise standup meeting [18:57:14] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-Platform-Team, MediaWiki-extensions-CentralNotice, and 2 others: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (AndyRussG) Th... [18:57:40] heheh [18:58:44] fr-tech btw core fix by Daniel Kinzler fixed the CN issue on the beta cluster!! wheee [18:58:56] Nice [18:59:00] AndyRussG: great! [18:59:29] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-Platform-Team, MediaWiki-extensions-CentralNotice, and 2 others: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (daniel) @Andy... [18:59:43] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-Platform-Team, MediaWiki-extensions-CentralNotice, and 2 others: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (daniel) ping... [19:02:25] yeah... [19:02:27] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-Platform-Team, MediaWiki-extensions-CentralNotice, and 2 others: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (AndyRussG) @d... [19:02:56] Nice when you know a codebase..... [19:03:25] K4-713: ^ CN bug apparently fixed [19:03:28] :) [19:03:53] Wow. That was fast. [19:08:15] ooo surprise standup [19:08:23] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi Dedupe searches yielding minimal results - https://phabricator.wikimedia.org/T197481 (MBeat33) We are still seeing much lower percentage rates from newer searches. Typically they'll yield ~1%, whereas early searches returned around 4 to 6%. I will br... [19:08:58] nice AndyRussG! [19:09:50] Wikimedia-Fundraising-CiviCRM: Civi: contribs export failing for DS agent - https://phabricator.wikimedia.org/T196569 (MBeat33) Open>Resolved a:MBeat33 Whatever caused this, Kristie is able to export normally now, so I'm resolving this task. [19:10:44] jgleeson: K4-713 yeah! basically it they're working on a change similar to our Kafkatee stuff, in that it's a big back-end change that needs to have identical effects for most inputs and outputs [19:10:56] but it's like several orders of magnitude more complex [19:11:59] so though the actual fix was only a few lines, to get there, I think you need a pretty deep knowledge of both the before and after code [19:12:20] Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, MediaWiki-Platform-Team, MediaWiki-extensions-CentralNotice, and 2 others: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (daniel) @Andy... [19:12:27] * AndyRussG continues to try to justify his inability to fix it himself [19:12:34] AndyRussG: Oh, for sure. That's pretty typical in my experience. Laser-beam fixes, almost. [19:12:44] AndyRussG: ha, no way. [19:12:45] also, it had to do with how the system works in a multi-db environment, so none of us had a local setup that could replicate it [19:13:57] yep [19:14:18] AndyRussG: It would have been a little bit alarming if you could just, you know... read core, no big deal. [19:14:42] Here's a peek at just some of their notes: https://www.mediawiki.org/wiki/User:Daniel_Kinzler_(WMDE)/MCR-PageUpdater [19:15:29] ejegg: probablly in fact one of us should know how to set up a testing environment for that [19:15:37] ulp... yeah [19:15:40] not the first bite we've received [19:15:46] and simulate slow replication :S [19:15:58] I was going to talk about automated testing... [19:16:09] And, you know, faking all these things. [19:18:39] I mean, it's not like faking a simple setup is applicable to anywhere we're actually using this code. [19:30:31] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: enable Force Merge Selected Duplicates f... - https://phabricator.wikimedia.org/T193674 [20:48:07] Wikimedia-Fundraising-CiviCRM: Civi: contribs export failing for DS agent - https://phabricator.wikimedia.org/T196569 (MBeat33) Resolved>Open Woops, still an active issue. [20:52:50] (PS1) Ejegg: Fix Ingenico FormChooser settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445017 [20:55:41] XenoRyet: can you take a quick look at https://gerrit.wikimedia.org/r/445017 ? [20:55:50] pcoombe needs that for the 1 hr test tomorrow [20:55:56] Yea, looking now [20:57:10] (CR) XenoRyet: [C: 2] Fix Ingenico FormChooser settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445017 (owner: Ejegg) [20:59:23] ejegg|dstrine, anything urgent ingenico-wise I should be looking at tomorrow alongside the stuff I'm doing? [20:59:50] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/445018 [20:59:54] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/445018 (owner: Ejegg) [21:01:14] I figured the sprint is ending tomorrow so unless there's anything urgent I'll pick up something else in planning the day after? (I won't make the retro as it's a bit late for me tomorrow as I finish earlier on Wednesdays) [21:02:29] jgleeson: if you just want to keep plugging away at comparing the old + proposed new impressions stats tomorrow, that sounds good to me [21:03:04] (Merged) jenkins-bot: Fix Ingenico FormChooser settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445017 (owner: Ejegg) [21:03:06] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/445018 (owner: Ejegg) [21:03:08] great, I hoped that was gonna be the answer but just wanted to check-in to make sure my learning adventures aren't taking me away from other urgent things [21:03:30] (PS1) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445019 [21:04:10] on that note, have a good evening fr-tech! [21:04:16] you too jgleeson [21:04:17] you too [21:04:21] jgleeson: cya! [21:04:45] awe, the form chooser still exists. [21:05:20] Someone bribed me with pie to write that over the weekend. [21:05:46] :) [21:06:21] I hope it doesn't still look like weekend pie bribe code. [21:06:43] well... the refactor has been languishing in gerrit for more than a year now [21:07:44] ha. My memory of that problem was that it was made of edge-cases. [21:07:46] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445019 (owner: Ejegg) [21:08:09] So, like, nothing to reuse without removing something that somebody needed. [21:08:25] Cascade of overrides. [21:10:29] there was one thing that could be de-duped, tho - the 'isValidForm' logic was begging to be used inside the getAllValidForms loop [21:10:43] aaaaaaaa [21:11:06] aaaaaayeah, I remember. [21:12:00] I think getAllValidForms was introduced after the chooser. [21:12:33] grr, i'mma just hack out that 1 test that's failing in fundraising/REL1_27 [21:12:48] we're never gonna touch the stuff that would REALLY make that fail [21:12:57] or... scratch that and reverse it. [21:12:59] heh [21:13:19] ejegg: When are we moving to the new branch? [21:13:23] it's just CI checking out a dumb branch of Vector to test against [21:13:52] K4-713: next month, the same time as we do the db updates to add the indexes that will allow other replication modes [21:13:59] cool. [21:14:21] if it was any later I'd spend the rest of the day fixing fr/1.27 CI instead of the hack [21:20:51] ejegg: thanks for all your help on this! I need to log off soon, do you reckon the form chooser should be fixed by tomorrow morning? [21:24:23] pcoombe: yep, gonna deploy it shortly! [21:26:17] (PS2) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445019 [21:26:19] (PS1) Ejegg: Hack out some failing tests on fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445024 [21:30:31] ejegg: Cool thanks. Here's one of the banners for tomorrow, can you check that credit card goes to the right form once the change is deployed? https://en.wikipedia.org/wiki/NASA?banner=B1819_0711_en4C_dsk_p1_lg_frq_cnt&force=1&country=GB [21:30:50] ok, will do pcoombe [21:31:18] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445019 (owner: Ejegg) [21:31:25] grr [21:31:34] (CR) jerkins-bot: [V: -1] Hack out some failing tests on fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445024 (owner: Ejegg) [21:31:45] haha, I see why it was renamed jerkins [21:33:34] can you also ping spatton once it's deployed and he'll be able to help test the different banners and countries. I'll be able to give things another final check tomorrow morning as well. [21:34:13] Thanks again for the help, and have a good night! [21:37:57] Fundraising-Backlog: Translate CountryNope message to other languages - https://phabricator.wikimedia.org/T199255 (Pcoombe) a:Pcoombe [21:41:28] (PS2) Ejegg: Hack out some failing tests on fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445024 [21:41:30] (PS3) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445019 [21:50:20] (CR) jerkins-bot: [V: -1] Hack out some failing tests on fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445024 (owner: Ejegg) [21:51:44] still??? [21:51:58] (CR) jerkins-bot: [V: -1] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445019 (owner: Ejegg) [21:54:34] (PS3) Ejegg: Hack out some failing tests on fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445024 [21:54:36] (PS4) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445019 [22:05:25] (CR) Ejegg: [C: 2] Hack out some failing tests on fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445024 (owner: Ejegg) [22:05:33] (CR) Ejegg: [C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445019 (owner: Ejegg) [22:23:56] (Merged) jenkins-bot: Hack out some failing tests on fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445024 (owner: Ejegg) [22:24:00] (Merged) jenkins-bot: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/445019 (owner: Ejegg) [22:27:15] !log updated payments-wiki from 383f667171 to 63372154d0 [22:27:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:52:28] (PS1) Ejegg: Allow 'donation' under tx type for Bitpay import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445035 (https://phabricator.wikimedia.org/T198669) [22:52:48] XenoRyet: ^^^ is a pretty tiny fix, but I think it'll let us import that Bitpay file [22:52:51] got a sec to review? [23:02:55] hi eileen. feeling a bit better? [23:03:42] looks like that bitpay issue was pretty trivial - just a tx type of 'donation' instead of 'sale': https://gerrit.wikimedia.org/r/445035 [23:50:08] !log disabled ProcessSmashPigRecurring in Civi scheduled jobs, to be replaced with process-control job [23:50:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log