[00:12:18] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/445326 [00:12:34] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/445326 (owner: Ejegg) [00:13:54] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/445326 (owner: Ejegg) [00:15:28] !log updated CiviCRM from d24c2bc08b to b21d783e7f [00:15:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:17:22] Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: BitPay import error - https://phabricator.wikimedia.org/T198669 (Ejegg) @LeanneS OK, we deployed a fix for this! Hope... [00:17:57] (PS1) Ejegg: WIP add opt_in field for selected countries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445327 (https://phabricator.wikimedia.org/T199278) [00:34:52] taking off for now, folks! [01:03:05] Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, Fundraising-Backlog, Core-Platform-Team, and 4 others: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869 (CCi... [01:44:06] (PS3) Eileen: [WIP] Components for new contact editor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443202 [01:47:51] (PS3) Eileen: Code simplification. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443888 (https://phabricator.wikimedia.org/T196644) [01:47:53] (PS7) Eileen: Move metadata to class, switch to whitelisting of entities to show & forget. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/443889 (https://phabricator.wikimedia.org/T196644) [01:47:55] (PS3) Eileen: Add showme for logging [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/444482 (https://phabricator.wikimedia.org/T196644) [01:47:57] (PS2) Eileen: Add forgetme for logging [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/444484 (https://phabricator.wikimedia.org/T196644) [01:47:59] (PS3) Eileen: Add code to delete select contact fields & custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/444487 (https://phabricator.wikimedia.org/T196644) [01:48:01] (PS1) Eileen: Forget activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445331 (https://phabricator.wikimedia.org/T196644) [01:51:22] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, and 2 others: QUnit tests for CentralNotice impression ev... - https://phabricator.wikimedia.org/T199395 [01:56:39] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: QUnit tests for CentralNotice impression events - https://phabricator.wikimedia.org/T199395 (AndyRussG) [01:59:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: QUnit tests for FundraiserLandingPage events - https://phabricator.wikimedia.org/T199396 (AndyRussG) p:Triage>Normal [02:00:32] (CR) jerkins-bot: [V: -1] Forget activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445331 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [02:06:54] Fundraising-Backlog: Document the new Kafka EventLogging -> MariaDB pipelines - https://phabricator.wikimedia.org/T199399 (AndyRussG) p:Triage>Normal [02:07:07] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: QUnit tests for FundraiserLandingPage events - https://phabricator.wikimedia.org/T199396 (AndyRussG) a:Ejegg>None [02:08:09] Fundraising-Backlog: Queries and maybe scripts to verify equivalence of data in new-Kafka-pipeline-testing and pgehres production databases - https://phabricator.wikimedia.org/T198752 (AndyRussG) a:Ejegg>None [02:11:23] (PS2) Eileen: Forget activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445331 (https://phabricator.wikimedia.org/T196644) [03:31:03] (PS1) Eileen: Forget activity logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445335 (https://phabricator.wikimedia.org/T196644) [03:36:34] (CR) jerkins-bot: [V: -1] Forget activity logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445335 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [03:47:35] (PS2) Eileen: Forget activity logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445335 (https://phabricator.wikimedia.org/T196644) [05:11:55] (PS1) Eileen: Forget relationships [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445342 (https://phabricator.wikimedia.org/T196644) [05:17:30] (CR) jerkins-bot: [V: -1] Forget relationships [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445342 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [05:21:01] (PS2) Eileen: Forget relationships [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445342 (https://phabricator.wikimedia.org/T196644) [05:26:29] (CR) jerkins-bot: [V: -1] Forget relationships [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445342 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [05:29:20] (PS3) Eileen: Forget relationships [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445342 (https://phabricator.wikimedia.org/T196644) [06:26:38] (PS1) Eileen: Forget mailing provider data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445344 (https://phabricator.wikimedia.org/T196644) [06:28:56] (CR) Eileen: [C: 2] Add custom ts() override fn to use MW messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440026 (owner: Ejegg) [06:29:14] (CR) Eileen: [C: 2] "Just closing the loop on this - I think it will be fine" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440026 (owner: Ejegg) [06:29:48] (CR) Eileen: [C: 2] "good idea!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445232 (owner: Ejegg) [06:34:05] (Merged) jenkins-bot: Add custom ts() override fn to use MW messages [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/440026 (owner: Ejegg) [06:36:08] (Merged) jenkins-bot: Set recurring smashpig job params in spec function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445232 (owner: Ejegg) [06:43:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Look at work by Tim on caching - analyse test bug - https://phabricator.wikimedia.org/T199408 (Eileenmcnaughton) [07:34:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test & deploy Coleman's contact summary work - https://phabricator.wikimedia.org/T199410 (Eileenmcnaughton) [07:46:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix annoying upstream CIviCRM bug that hits us when we try to upgrade - https://phabricator.wikimedia.org/T199412 (Eileenmcnaughton) [08:01:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test & deploy Coleman's contact summary work - https://phabricator.wikimedia.org/T199410 (Eileenmcnaughton) @LeanneS it's loading! see layout is changed here /civicrm/contact/view?reset=1&cid=11863262 due to config here civicrm/a/#/contact-summary-e... [13:32:04] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 3 others: FundraiserLandingPage: Parse EL sa... - https://phabricator.wikimedia.org/T195908 [13:46:23] mepps, just been looking over your WIP to tidy up the globalcollect adapter. It's making me wonder how we followup, after determining a status of pending [13:47:01] do we have a scheduled process polling pending items in some way? [13:47:04] jgleeson with the orphan rectifier [13:47:11] Yes [13:48:19] got it, thanks [13:52:19] what schedule does that run on mepps out of interest? [13:59:04] Fundraising-Backlog, Scoring-platform-team: Machine Learning for Fraud Detection - https://phabricator.wikimedia.org/T190523 (saurabhbatra96) Updates - * ML code snippets are being tracked here - https://github.com/saurabhbatra96/wmf-samplecodes * PR plots for various classifiers with the dummy dataset... [14:22:23] moar coffeeee!!! har har har [14:22:39] also, homemade bread, fried ham, fried egg, and cheese... au gratin 8p [14:25:56] nice AndyRussG! [14:26:45] I had a bowl of lentil soup for lunch made from the recipe ejegg|away suggested - https://www.thespicehouse.com/recipes/red-lentil-soup-with-garam-masala-recipe [14:27:54] back later! [14:30:24] jgleeson looks like it runs about every 30 minutes [14:30:39] ooh i love red lentil soup! [14:41:36] mmmm that soup does sound good [14:41:48] Last night I gave the kid brown lentil soup for supper [14:42:19] Sofi had like 3 cups :) [14:42:55] (supper here is a lighter meal, like lunch in many English-speaking countries) [14:51:35] fr-tech I'm gonna call it fr_user_event_consumer [14:51:53] (the python module for the new scripts to replace the current Python kafkatee->db stuff) [14:52:11] "user event" because it deals with events from user-facing stuff [14:52:13] ok, cool [14:52:25] not necessarily all donors [14:52:29] so, users [14:52:35] mmm [14:52:43] also to differentiate it from any of the zillions of back-end events that we could have [14:52:51] yeah, got it [14:53:24] and if ever we wanted more user events (like say, more details of how people click about donate forms) this would be the thing to expand for that, I think [14:53:35] or at least, if we ever wanted to put such events in a db [14:53:56] ejegg: though another option would be "kafka event consumer" [14:54:03] fr_kafka_event_consumer [14:54:08] no, I like your first name [14:54:12] okok :) [14:54:16] technology-agnostic [14:54:21] mmm true [14:54:31] json_mysql_stuffer [14:55:20] implements fr_user_event_consumer [14:57:17] hrmmm [14:57:36] just foolin, let's go with your first idea [14:57:39] :) [14:57:46] I mean, the general principal is solid [14:58:05] I don't know if there's a context for defining a backend-agnostic api at this point [14:58:22] ejegg fr-tech here are my notes so far on how to do this: https://etherpad.wikimedia.org/p/fr_user_event_consumer_notes [14:59:45] any suggestions greatly appreciated! [15:09:23] that all looks good, though the last point looks tricky [15:09:43] I think we might need some kind of batching to make the inserts more performant [15:19:02] ejegg: yes for sure... But at least separate out the stuff to the degree it's reasonable, bearing that possible future in mind [15:19:56] so, file-reading, line-parsing, field-transformation, aggregation, and db write all divvied up [15:20:17] mmm I guess (2) and (3) may go together...ish ^ [15:20:21] k [15:24:29] https://old.reddit.com/r/BATProject/comments/8y0fgd/any_plans_on_wikipedia_working_with_bat_brave/ [15:37:08] cwd interesting [15:37:33] the description in the sidebar looks a lot like our aims with CentralNotice [15:37:35] yeah i thought so too [15:37:41] heh [15:37:48] "BAT Ads matches ads to users using client-side machine learning algorithms and locally-stored data." [15:37:56] "value" is a pretty abstract concept these days [15:38:06] though we have no client-side ML :P [15:38:21] I'll make a phab ticket [15:38:30] thanks! [15:38:42] hehehe, was kidding about the client-side ML [15:39:05] but I guess we should look into getting verified to be able to cash out any BAT people do donate [15:39:09] i don't really get why mining crypto in your users' browsers is less legitimate [15:39:26] seems like about the same thing when you break it down [15:39:46] if you then shared it with them [15:40:51] hmmm [15:41:05] I think the "ad" part would make it not fly [15:41:44] AndyRussG: I think people using the Brave browser collect those tokens on a lot of different sites [15:41:55] and can donate those tokens to sites not running ads [15:42:12] ejegg: still, there are advertisers associated with the project, no? [15:42:27] (PS7) Mepps: WIP Refactor of ConfirmCreditCard [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444311 (https://phabricator.wikimedia.org/T194517) [15:42:44] so in theory, those advertisers might indirectly end up having some sway over encyclopedic content? [15:43:13] it'd be like indirect advertising on the site, almost? [15:43:53] * AndyRussG goes wiki-puritan [15:45:06] very hard to see a cause and effect link there [15:45:46] well, if certain advertisers are big with that scheme, and we start getting a significant amount of contributions from there, there could be a tendency to avoid massively criticizing those advertisers [15:46:07] basically the same reason for avoiding advertising all together [15:46:19] But it's not the advertisers donating tokens [15:46:25] true [15:46:27] the users earn tokens by seeing ads [15:46:53] but if it became a big thing, and people donating a lot of their tokens to wp, it could still have the same systmeic effect [15:47:19] ah, so you're saying if the type of ads that generate tokens are all from one sector or company [15:47:28] yeah [15:47:54] the logic is that it's not enough for the people involved to start out with good intentions. the system has to be built to tend away from being beholden to any interest other than knowledge and collaborative creation thereof [15:48:50] if I had to bet on which model will keep the content most impartial in 15 years, I'd definitely stick with the small-monetary-donations-from-readers model [15:50:16] So, as long as this is a niche ad scheme that COULD be dominated by one sector, I'd imagine it would be a small enough part of our revenue to not influence us [15:50:31] but then also small enough to not be worth the risk? [15:50:54] Who is the organization beholden to? In part, follow the money [15:51:52] It's the mozilla founder's scheme to try to get the web's revenue stream out from under the thumbs of goog + FB [15:51:53] and in our case, even the perception of bias like that could be detrimental, I think? [15:51:59] hmmm [15:52:00] yes [15:52:06] I mean, on that point it sounds fine [15:52:24] important for sure [15:52:31] not sure it'd be our ball of wax tho [15:53:44] how screwed would WP be if there was no google? [15:54:10] how screwed would google be if there was no WP? [15:54:35] would walled gardens have already taken over? [15:54:57] oh yeah i'm just saying we are already sort of beholden to their dirty ad money [15:55:19] maybe in a less direct way [15:55:39] right, in both cases the revenue from ALL ads in that stream is mixed [15:55:47] yeah [15:56:36] i feel like this project is not the right solution to the internet [15:56:45] but i also don't know that we shouldn't take the quick cash [15:56:51] why not [15:57:59] 'cause not doing so is whta's made us different all along? [15:58:59] https://www.theguardian.com/technology/blog/2010/feb/18/wikipedia-google [16:01:59] hmmmm :) [16:04:52] you know nobody hates advertising more than i do [16:06:20] i think the misassumption that many people have about "fixing" the ad based internet is that it can be easy and painless [16:06:57] the internet is broken and i don't think it is going to get fixed w/o a fairly devastating tech recession [16:08:09] which will look a whole lot like it always does, the rich weasling the middle class out of their jobs and homes [16:08:26] * cwd not super optimistic [16:19:04] cwd: mmmm :( 8/ [16:19:20] checking out the article, btw! [16:35:28] jgleeson: so, the front end seemed like the simplest part of the new opt-in field [16:36:44] We have a config file in country_fields.yaml in some of the *_gateway/config/ folders [16:37:00] it's what we use to ask for full addresses in the countries that have AVS [16:37:09] and just state/province in AU [16:37:29] so that's a way to conditionally list a field as required [16:38:02] (other required fields are listed in payment_methods.yaml under the 'validation' subkeys [16:38:05] ) [16:39:15] ---woohoo, active editors numbers are up! [16:40:40] ok, and gateway_common/DonationData.php is one place we define what are the fields to look for [16:40:45] is awight still overseas? [16:40:59] cwd I think I saw him in a meeting room yesterday [16:41:08] ah cool [16:49:31] was just catching up on cwd's link from earlier ejegg [16:49:37] ok I'm with you so far.. [16:50:07] "Wikipedia's been on a rather relentless fundraising drive that ended up bringing in $8m of cash to keep it going." ..2010 [16:50:31] heh, nice [16:52:54] 20% year on year? [16:53:06] pretty big growth [16:53:34] ambitious indeed! [16:55:10] 39 steps... wasn't that a hitchcock film? [17:02:43] jgleeson: anyway... I had rushed ahead yesterday with some code that implements those parts [17:03:45] https://gerrit.wikimedia.org/r/445327 [17:04:22] Feel free to take that over if you'd like [17:05:57] hmm, so it looks like it also needs to be added to sendData in ext.donationInterface.forms.js's callDonateApi [17:06:48] and then we might need some logic to make sure it's either [17:07:22] a) sending opt_in=null in donation/pending messages where the box wasn't shown [17:07:45] or b) just leaving it off the message entirely when the box wasn't shown [17:11:45] ok ejegg, will pull it down and check it out [17:12:14] jgleeson: sorry, does that look too far advanced to meaningfully collaborate? I had the idea that there was more left to do. Anyway, just let me know if you'd like to take up the work. [17:18:26] gonna get some lunch, back in a bit [17:19:13] cool ejegg|food, just had a play with it [17:19:35] is the end goal to add a field to the queue message indicating selection [17:19:52] (true if someone ticks the box, false is they leave it blank) [17:20:39] and then retrofit that option to other areas in the code where donations can be received [17:26:19] if you think it makes sense for you to finish it ejegg|food because your far along with it, I can shadow you on screen share and hand it back over if that works? [17:26:28] you're* [17:55:35] Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: BitPay import error - https://phabricator.wikimedia.org/T198669 (LeanneS) Thanks @Ejegg! The import worked with impor... [18:10:37] saurabh: hi [18:10:45] casey here from ops [18:10:54] i am going to get you set up w/ some accounts [18:12:41] jgleeson|dinner: let me know when you're back [18:15:19] hey cwd! [18:16:32] hi saurabh! happy to see you're getting access [18:18:18] yeah the NDA took some time, but looks like we're finally here! :-) [18:18:36] excited to sw from dummy data to the real thing [18:19:06] great [18:19:16] saurabh: are you familiar with ssh? [18:19:36] yup [18:20:17] super, the first thing we'll need is a new ssh key for fundraising [18:20:21] preferably with a good passphrase [18:20:29] logging back in as saurabhbatra, be back in a second [18:21:57] hey [18:22:06] sorry about that, changed systems [18:22:07] howdy [18:22:09] np [18:22:20] there is some more info about the ssh key here https://wikitech.wikimedia.org/wiki/Production_shell_access [18:23:55] I think I'm at step 4? [18:25:12] i.e. to create a ticket requesting access? [18:25:44] we've already got that: https://phabricator.wikimedia.org/T199373 [18:25:46] with my shell username [18:26:19] those instructions are for the prod servers, we have a different setup in fundraising [18:26:31] and less documented :) [18:26:58] so the setting up access section is what I'm supposed to be looking at? [18:27:11] ah, yes, it says prod server access at the top :-) [18:27:28] yep [18:27:34] well it's not really a good distinction [18:27:39] our servers are also production [18:27:53] the ... main cluster i guess [18:27:57] i.e. the wikis [18:28:38] *slightly confused* but i will power through it :) [18:29:04] the fundraising servers are separate mainly because we have to deal with extra rules becaues there is money involved [18:29:16] and donor information [18:29:51] sorry, don't mean to overwhelm :) [18:30:23] no, it does make sense [18:30:27] is saurabh a good username? [18:30:32] yup [18:30:46] saurabh or saurabhbatra or saurabhbatra96 [18:30:49] anything works for me [18:32:57] (PS1) Ejegg: Make sure to send right timestamp format to antifraud [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/445447 [18:34:23] Fundraising Sprint Naming Sprints Is Not Important, Fundraising-Backlog, FR-Smashpig, Unplanned-Sprint-Work: payments-antifraud messages with wrong date format - https://phabricator.wikimedia.org/T199468 (Ejegg) [18:34:36] (PS2) Ejegg: Make sure to send right timestamp format to antifraud [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/445447 (https://phabricator.wikimedia.org/T199468) [18:34:40] alright so done with setting up the ssh key and the config file [18:37:46] ejegg, back! [18:38:08] ok, cool! [18:38:16] let's meet in queenmary [18:38:28] ok will be 2 minutes [18:38:32] cool cool [18:38:34] just need to pop downstairs [18:40:40] lol @ #queenmary. That was a fantastic offsite though. [18:41:03] sup awight [18:41:06] ccccccigdijldgcttfglthecbuhtvgebtndlvcdvfbjf [18:41:20] the usb c yubikey is even easier to accidentally touch [18:41:55] but it is apropos of what i was going to ask which is are you back with your yubikey? [18:46:03] haha [18:46:08] hey good call [18:46:17] I can't find my darn keys, actually [18:46:27] everything in my life is made of invisible ink lately [18:46:42] mebbe I can ask OIT for another :-/ [18:46:52] are you at the office? [18:46:57] yep [18:47:02] >.> [18:47:03] <.< [18:47:11] yeah they give em out like candy [18:47:31] in a good way [18:47:55] https://i.pinimg.com/736x/6f/fd/c2/6ffdc2ba7938cfe7839fe8f401f1c3c5.jpg [18:49:04] thanks for the note, I'll take care of that [18:49:22] :) [18:49:32] hi awight! :-) [18:50:02] what tz are you in nowadays? [18:50:22] cwd: Remind me which capability we need? just OTP? [18:50:27] yup [18:50:29] saurabhbatra: hi! UTC-8, pacific [18:50:47] did anyone give saurabhbatra a bunch of wiki accounts? [18:51:25] nope, this is my first stint with ops [18:51:45] i only have a phab account [18:51:49] you might not need them...probably better for sanity [18:52:18] Adam - realized we haven't yet come up with a name for our tool yet [18:52:34] saurabhbatra: yesss, that could be fun [18:52:35] getting hard to name my repos :-) [18:52:54] wmf-fd-api was the best I could do [18:53:19] saurabhbatra: if you could email me the public key that would work [18:53:24] cdentinger@wikimedia.org [18:53:30] sure, doing that rn [18:53:51] saurabhbatra: and also throw a yubikey pass in there too [18:55:05] as in what I want my yubikey pass to be right? [18:55:19] cause i don't have my hands on one of those yet [18:55:48] ah [18:56:05] when you touch them they spit out passwords...like what i did above [18:56:11] hrm [18:56:17] where are you located? [18:56:23] yeah i've used them before [18:56:35] https://www.yubico.com/store/resellers/ [18:56:57] There are official resellers in Mumbai and Bangalore, fwiw [18:56:58] OIT will send you one but it takes a couple days [18:57:13] but if you can find one locally they'll reimburse you [18:57:29] I'll have to look, give me a minute [18:57:50] cwd: This is GSoC btw, I'm not sure how we can reimburse... It's okay according to the rules, but WMF would want more paperwork. [18:58:05] oh good point [18:58:30] Thinking we might have to just use FR budget to have a local reseller sell to WMF, then deliver to S [18:58:45] call up and read the card number? [18:59:02] so no resellers listed in my city [18:59:12] lol [18:59:17] i'll be in Bangalore next weekend though but that might delay things [18:59:32] they do have yubikeys on amazon though [18:59:57] oh, india, well that would probably delay shipping from SF significantly [19:00:08] saurabhbatra: I bet they could drop a yubikey in the post... [19:00:16] but it seems a little weird that we make him buy something [19:00:36] cheapest one costs around 40 USD [19:01:02] sheesh [19:01:06] does this fit the criteria - https://www.amazon.in/Yubico-Y-123-FIDO-U2F-Security/dp/B00NLKA0D8/ref=sr_1_7?ie=UTF8&qid=1531421980&sr=8-7&keywords=yubikey [19:02:00] Oh hey there are lots of locations for this reseller, http://www.ivalue.co.in/contact-us/ [19:02:12] saurabhbatra: no, I think it has to be one of the black ones [19:02:19] needs "OTP" [19:03:25] well, if OIT shipped one and it took a while we could work around it in the mean time [19:03:42] i like the post idea though [19:04:23] what i can do is call them up tomorrow (it's 12.30 in the night here), and ask if they can send one over to Hyderabad [19:05:14] shipping it all the way from SF would cost about as much as a new Youbikey tbh [19:05:19] *yubi [19:05:54] yeah but wmf would pay for that [19:06:46] if we could have a workaround in the meantime [19:06:49] we could work around it with a kerberos password or something, but i wouldn't want to do it w/o checking with jeff who will be back monday [19:07:11] i'm mostly concerned with the time it'll take [19:07:59] i guess we could wait till Monday in that case [19:08:16] he probably wouldn't care if i sms him [19:09:02] alright, great then! :-) [19:09:24] i'll check into it [19:10:02] saurabhbatra: don't see your ssh key yet [19:10:10] i'll send you the ssh key in the meanwhile [19:11:40] ty [19:11:43] (PS1) Ejegg: List 'variant' as allowed API param [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445451 [19:12:07] done [19:13:06] looks good [19:14:57] great! :-) [19:15:15] if there's anything else you need me to do just ping me here, i'll be around for another hour [19:18:04] sounds good [19:18:44] (PS2) Ejegg: List 'variant' as allowed API param [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445451 [19:18:46] (PS2) Ejegg: WIP add opt_in field for selected countries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445327 (https://phabricator.wikimedia.org/T199278) [19:24:55] does oit use phab at all? [19:26:50] cwd: They use zendesk IIRC [19:29:42] yeah...should saurabhbatra email them you think? [19:29:51] will it work w/o a wmf email? [19:30:11] I think it does work with external addresses, good question [19:30:19] But I think we should take care of it on our side, if possible [19:30:39] * awight arrives at the uncomfortable conclusion that I should do this [19:33:49] haha [19:48:31] cwd current django python scripts keeps a config file in /etc/ . I imagine that wouldn't really be our current best practice? Should the config be specified on the command line? Looked for in the python module's root dir by default? any other suggesitons? [19:48:35] thx in advance! [19:53:16] AndyRussG: is it something you think you'll need to change much? [19:53:37] cwd: nope [19:54:02] i could just put it in puppet then [19:54:03] Fundraising-Backlog: Figure out where json_encode will screw us in php 7.1+ - https://phabricator.wikimedia.org/T199471 (Ejegg) [19:54:05] and /etc [19:54:08] Maybe once when switch from testing db to production, and maybe only again if there's another need to switch to a different db [19:54:11] if you odn't need to be able to deploy it [19:54:13] w/o ops [19:54:28] cwd: it'd have db pwd in it [19:54:53] is it currently deployed w/ deploy tools? [19:54:55] that file? [19:55:22] one sec, gonna find it :) [19:56:16] cwd, awight logging out [19:56:27] cwd: see civi1001:/etc/django_settings.py [19:56:53] Dunno what currently controls that, but this'll be the new equivalent [19:57:14] In the code repo we'll just put a mostly blank example config [19:57:22] It'll be yaml btw [19:57:45] cwd: fyi here are my notes for this: https://etherpad.wikimedia.org/p/fr_user_event_consumer_notes [19:57:58] name of the new thing is tentatively fr_user_event_consumer [19:58:08] since it consumes events from user-facing stuff [19:58:49] or does it stuff faces at user-consuming events? [19:58:51] AndyRussG: ah yeah it's already in puppet [19:59:02] i can change it to whatever you need [19:59:34] cwd: ok mmm that file will stay and there'll be a new one [19:59:41] for the new scripts that will run in parallel [20:00:55] sounds good [20:01:01] have a good evening fr-tech, and see you all monday! [20:01:55] AndyRussG: i like the outline [20:02:13] cwd: cool! :) [20:02:50] cwd: We'll see how long I can hold onto this: [20:03:07] argh no action. brb [20:03:14] hehe [20:04:30] U2F nonsense [20:06:24] awight: fun! [20:06:30] 8p [20:07:00] * AndyRussG collapses under the weight of irony [20:07:04] good luck :) [20:07:23] (PS1) Ejegg: DB settings default to null [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/445456 (https://phabricator.wikimedia.org/T195814) [20:08:04] cwd: hmm it looks like django gets settings location from an environment variable, boo https://docs.djangoproject.com/en/2.0/topics/settings/ [20:08:29] Fundraising Sprint Naming Sprints Is Not Important, Fundraising-Backlog, MediaWiki-extensions-ContributionTracking, Patch-For-Review: [ContributionTracking] default DB settings differs when using extension registration - https://phabricator.wikimedia.org/T195814 (Ejegg) p:Triage>Normal a:... [20:08:57] cwd: is /etc/ the ideal place then? Where do similar config files for other stuff live? [20:09:29] I could make it by default look in /etc/ and if nothing there, in the module's root dir [20:09:39] or we could specify where it is on the command line [20:10:04] Just wondering what is most inline with other stuff we have, to make this as un-snowflakey as possible [20:12:42] hmm it looks like there is a lot of stuff in /etc [20:12:46] AndyRussG: generally things with db passwords live in /etc/ where they're controlled by puppet, and things with dev-tweakable settings are pulled in from files deployed with the source code [20:13:12] so we've had to split out setting for things like smashpig which needs some of one and some of the other [20:13:25] drupal, audit yaml stuff [20:13:57] ejegg: okok gotcha [20:14:11] so hardcoding "look in /etc/ for config file" is not too smelly? [20:14:32] err, and by 'deployed with the source code' i mean they are in the same dir, but may be plucked from a separate 'localsettings' repo [20:14:38] sure, /etc/ is fine [20:14:45] to hardcode [20:15:45] ejegg: rightoh [20:15:55] :) [20:17:24] yep /etc is fine [20:17:31] if that's the normal place people put it [20:17:56] cwd: yeah looks like it :) [20:27:32] fundraising-tech-ops, Operations, netops: New PFW policy for Amazon - https://phabricator.wikimedia.org/T199341 (cwdent) Resolved>Open @ayounsi I reverted this since it wasn't the problem after all, please deploy 1531426993 at your leisure [20:32:36] (PS3) Ejegg: WIP add opt_in field for selected countries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445327 (https://phabricator.wikimedia.org/T199278) [20:36:35] (CR) jerkins-bot: [V: -1] WIP add opt_in field for selected countries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445327 (https://phabricator.wikimedia.org/T199278) (owner: Ejegg) [20:39:11] (PS3) Ejegg: Make sure to send right timestamp format to antifraud [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/445447 (https://phabricator.wikimedia.org/T199468) [20:41:03] (PS4) Ejegg: WIP add opt_in field for selected countries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445327 (https://phabricator.wikimedia.org/T199278) [20:56:13] (CR) Hashar: "check experimental" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/445456 (https://phabricator.wikimedia.org/T195814) (owner: Ejegg) [20:58:52] (PS1) Mepps: Consolidate flags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445534 (https://phabricator.wikimedia.org/T194517) [20:58:54] (PS1) Mepps: WIP Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) [20:59:09] fr-tech my end of day update is that this is what i've been working on ^^ [20:59:40] it's still messy and some tests are failing but basically hoping to work towards more clarity in terms of what is happening and reducing overall number of variables at play [21:01:02] (CR) jerkins-bot: [V: -1] WIP Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [21:02:26] thanks mepps, I'll take a look [21:15:01] (PS2) Ejegg: Make sure we're adding numbers in AdyenAudit [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/439634 [21:19:57] (Abandoned) Ejegg: Update donation-interface library to 2.3.0 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/436188 (https://phabricator.wikimedia.org/T169357) (owner: Ejegg) [21:20:29] (PS2) Ejegg: Delete old GlobalCollect audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434597 [21:23:00] (CR) Hashar: [C: 1] "I have filled the task for the experimental job quibble-vendor-mysql-php70-docker which uses wfLoadExtension(). It passes!!" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/445456 (https://phabricator.wikimedia.org/T195814) (owner: Ejegg) [21:23:31] (CR) Hashar: [C: 1] "(not +2ing since I have no idea what this extension is for nor what are the impacts on the cluster or the fundraising cluster if any)." [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/445456 (https://phabricator.wikimedia.org/T195814) (owner: Ejegg) [21:33:26] fundraising-tech-ops, Operations, netops: New PFW policy for Amazon - https://phabricator.wikimedia.org/T199341 (ayounsi) 1531426993 Pushed. [21:33:39] fundraising-tech-ops, Operations, netops: New PFW policy for Amazon - https://phabricator.wikimedia.org/T199341 (ayounsi) Open>Resolved [21:55:21] Fundraising-Backlog: Figure out where json_encode will screw us in php 7.1+ - https://phabricator.wikimedia.org/T199471 (Ejegg) putting this in /etc/php/7.2/fpm/php.ini fixes it, sad enough: serialize_precision: 14 Default value in debian was -1, meaning 'choose the best precision', and was json_encoding 2.... [22:04:06] cwd here's a head-up for upgrading to PHP 7.1+ https://phabricator.wikimedia.org/T199471 [22:10:13] great