[00:33:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18, Epic: [epic] Improvements to Contact page - https://phabricator.wikimedia.org/T118354 (Eileenmcnaughton) @DStrine we might be about to wrap this one up! [00:35:20] (PS1) Eileen: Activity tab performance - switch from deprecatedGetActivitiesCount to getActivitiesCount ditto for getActivities. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/447944 (https://phabricator.wikimedia.org/T199753) [00:35:26] how do I merge these 2 Bug: T199753 [00:35:27] Bug: T191867 [00:35:27] T199753: slow anonymous save - https://phabricator.wikimedia.org/T199753 [00:35:27] T191867: Slow query on activity dashboard making anonymous contact unretrievable - https://phabricator.wikimedia.org/T191867 [00:35:57] found it [00:36:29] Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: slow anonymous save - https://phabricator.wikimedia.org/T199753 (Eileenmcnaughton) [00:36:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Slow query on activity dashboard making anonymous contact unretrievable - https://phabricator.wikimedia.org/T191867 (Eileenmcnaughton) [00:43:03] Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: slow anonymous save - https://phabricator.wikimedia.org/T199753 (Eileenmcnaughton) https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/447944/ [01:10:58] (PS6) Ejegg: Forget activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445331 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [01:11:18] (CR) Ejegg: [C: 2] Forget activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445331 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [01:17:21] (Merged) jenkins-bot: Forget activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445331 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [01:17:45] thanks ejegg [01:27:16] (PS6) Ejegg: Forget activity logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445335 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [01:28:09] thank you eileen ! Sorry to leave 'em languishing so long [01:28:19] ejegg: no worries [01:28:21] (CR) Ejegg: [C: 2] Forget activity logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445335 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [01:28:26] I have something I’m trying to figure out [01:28:43] it looks like for a period of time we doubled up omnimail recipient data entries [01:29:01] unique key is mailing+event+contact identfier+timestamp [01:29:22] & there seems to be a period where we have 2 entries with timestamps 7 hours apars [01:29:25] apart [01:29:33] so I think I can see how that could have happened [01:29:53] the issue is that whatever way I tackle deleting the rows will have high overhead [01:32:49] some self-joins on a pretty big table, huh? [01:33:03] would it have to also join against the core tables? [01:33:24] or could we run it with just the mailing jobs off and a warning not to try to run those reports? [01:34:21] (Merged) jenkins-bot: Forget activity logs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445335 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [01:34:39] ejegg: it’s massive! [01:34:53] it will only affect omnimail jobs [01:35:04] but it might take a long time [01:35:13] I think I’ll have to batch it somehow [01:35:22] I’m loath to php process everything though [01:35:42] ugh, yeah, seems like a ridiculous amount of i/o [01:43:28] (PS7) Ejegg: Forget relationships [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445342 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [01:43:34] I might batch via a temp table - ie create a batch of rows into there & then delete joining that batch - will see how long the queries take - this is pretty painful [01:44:26] (CR) Ejegg: [C: 2] "Took me a minute to understand how this patch enabled relationship deletion! So the 'options' were already being sent, this patch just mak" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445342 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [01:45:27] eileen: yeah, temp table sounds like the way to go... could do some kind of string manipulation while selecting into it to make the joins nicer [01:45:39] maybe [01:50:32] (Merged) jenkins-bot: Forget relationships [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445342 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [01:53:31] ejegg: if that stuff is driving you to distraction the contact editor stuff is a bit more interesting to play with [01:54:01] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [01:54:21] (CR) jerkins-bot: [V: -1] Forget previous lives [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [01:57:09] (PS1) Eileen: Submodule commit on CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/447956 [01:57:57] (CR) Eileen: [C: 2] Submodule commit on CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/447956 (owner: Eileen) [01:58:35] (PS5) Eileen: Forget mailing provider data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445344 (https://phabricator.wikimedia.org/T196644) [01:58:37] (PS3) Eileen: Forget previous lives [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) [02:03:56] (Merged) jenkins-bot: Submodule commit on CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/447956 (owner: Eileen) [02:04:16] (CR) jerkins-bot: [V: -1] Forget previous lives [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [02:05:28] eileen: heh, I feel like I should push on through while I'm still in that headspace [02:05:42] fair enough [02:05:52] & the good news is that is the end really [02:06:08] because after that the silverpop part is kinda conceptually different [02:06:38] looks like that 'previous lives' one needs a civi module bump? [02:06:46] so I guess a good thing to ask yourself once you get through those ones is ‘what is missing from this picture’ (apart from a bit more caching & silverpop) [02:06:55] ejegg: you mean submodule - I put it up [02:07:03] eileen: ah right [02:07:11] just merged [02:07:28] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [02:07:37] cross fingers [02:07:56] eileen: also, is there a way to disable logging while deleting the stuff? Looks like it creates rows that we then delete [02:08:28] I *think* only the activity rows wind up in there - just cos of the order it happens in [02:08:41] I did add a test on that & it passes but it might not really be robust enough [02:08:52] I mean the rows from the NEW activity (forget me) [02:08:54] yeah, relying on that order seems a little iffy - at least worth a comment next to that list [02:09:12] 'leave logging last' [02:14:54] (CR) jerkins-bot: [V: -1] Forget previous lives [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [02:20:11] I’m just checking that test fail [02:32:29] (CR) Ejegg: [C: -1] "Impressive tests! Looks like forgetme is missing a return statement." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445344 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [02:32:58] ejegg: ah - I wonder if I messed up my commits somewhere [02:33:01] getting pretty late here - i'm going to sign off [02:33:10] see you! [02:38:50] cool [04:03:46] (PS1) Eileen: Update Omnimail silverpop to manage set date to GMT [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/447975 (https://phabricator.wikimedia.org/T200240) [04:11:16] (CR) jerkins-bot: [V: -1] Update Omnimail silverpop to manage set date to GMT [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/447975 (https://phabricator.wikimedia.org/T200240) (owner: Eileen) [04:59:32] (CR) Eileen: [C: -1] "hang fire - test fails. Also recent data seems ok... - will dig" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/447975 (https://phabricator.wikimedia.org/T200240) (owner: Eileen) [05:08:23] I’m runing a slow query on staging [05:08:44] ah finished [06:55:56] fundraising-tech-ops: encrypt fundraising mariadb replication - https://phabricator.wikimedia.org/T170320 (jcrespo) > SSL connection error: Failed to verify the server certificate Either you haven't restarted mysql, or set the right replication start parameters, or using a different connection string than w... [07:20:52] (PS6) Eileen: Forget mailing provider data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445344 (https://phabricator.wikimedia.org/T196644) [07:20:54] (PS4) Eileen: Forget previous lives [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) [07:27:02] (CR) jerkins-bot: [V: -1] Forget previous lives [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [07:27:38] (CR) jerkins-bot: [V: -1] Forget mailing provider data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445344 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [07:36:16] (PS7) Eileen: Forget mailing provider data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445344 (https://phabricator.wikimedia.org/T196644) [08:01:15] (PS5) Eileen: Forget previous lives [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) [08:08:05] (CR) jerkins-bot: [V: -1] Forget previous lives [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [09:05:51] (PS6) Eileen: Forget previous lives [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) [13:46:24] fundraising-tech-ops: encrypt fundraising mariadb replication - https://phabricator.wikimedia.org/T170320 (Jgreen) Definitely restarted mysql, and here's what I've got for replication start params vs client command line: MariaDB [(none)]> show variables like "%ssl%"; +---------------+-----------------------... [13:57:28] fundraising-tech-ops: encrypt fundraising mariadb replication - https://phabricator.wikimedia.org/T170320 (Jgreen) Oh HO! I think I may have just figured it out... change master to master_host='frdb1001.frack.eqiad.wmnet', master_user='replication', master_password='ding', master_port=3306, master_log_file=... [13:57:41] fundraising-tech-ops: encrypt fundraising mariadb replication - https://phabricator.wikimedia.org/T170320 (jcrespo) Check error log both both servers, you may find more info there. If it worked with yassl, maybe you have an incompatibility- I don't think those (openssl and yassl) play well together. BTW, ss... [14:11:43] fundraising-tech-ops: encrypt fundraising mariadb replication - https://phabricator.wikimedia.org/T170320 (Jgreen) >>! In T170320#4453287, @jcrespo wrote: > Check error log both both servers, you may find more info there. If it worked with yassl, maybe you have an incompatibility- I don't think those (openss... [14:42:51] (CR) Jgleeson: [C: 1] "Looks good, works as described for me!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/447919 (https://phabricator.wikimedia.org/T200218) (owner: Ejegg) [14:59:08] Fundraising-Backlog: 2018 Japan campaign: switch card processor to Adyen - https://phabricator.wikimedia.org/T200439 (MBeat33) [15:36:43] Fundraising-Backlog: Document the new Kafka EventLogging -> MariaDB pipelines - https://phabricator.wikimedia.org/T199399 (AndyRussG) Part of this should be to update or remove and archive oudated documentation about DjangoBannerStats and other bits of the pipeline that have changed. Here are a few bits that... [16:20:50] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, and 2 others: Create job to deliver the eventlogging_Cent... - https://phabricator.wikimedia.org/T189820 [16:30:29] fr-tech, halo on pc always reminds me of this video https://www.youtube.com/watch?v=rVC7I5VcTiw [16:32:27] (CR) Ejegg: [C: 2] Activity tab performance - switch from deprecatedGetActivitiesCount to getActivitiesCount ditto for getActivities. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/447944 (https://phabricator.wikimedia.org/T199753) (owner: Eileen) [16:39:27] (Merged) jenkins-bot: Activity tab performance - switch from deprecatedGetActivitiesCount to getActivitiesCount ditto for getActivities. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/447944 (https://phabricator.wikimedia.org/T199753) (owner: Eileen) [16:51:30] Fundraising-Backlog, Epic: Create job to deliver the eventlogging_LandingPageImpression topic - https://phabricator.wikimedia.org/T200449 (AndyRussG) p:Triage>Normal [16:52:41] (PS4) Jforrester: build: Adding MinusX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388353 (owner: Legoktm) [16:52:43] (PS5) Jforrester: build: Updating mediawiki/mediawiki-codesniffer to 19.0.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/437659 [16:52:47] (PS2) Jforrester: build: Re-enable MediaWiki.Usage.ForbiddenFunctions.join [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440180 [16:52:49] (PS2) Jforrester: build: Re-enable MediaWiki.Usage.ForbiddenFunctions.key_exists [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440181 [16:53:22] (CR) Jforrester: [C: 1] "PS4: Manual rebase. Above comment still applies." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/388353 (owner: Legoktm) [16:54:45] (PS6) Jforrester: build: Updating mediawiki/mediawiki-codesniffer to 19.0.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/437659 [16:54:47] (CR) jerkins-bot: [V: -1] build: Re-enable MediaWiki.Usage.ForbiddenFunctions.key_exists [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440181 (owner: Jforrester) [16:55:03] (CR) jerkins-bot: [V: -1] build: Re-enable MediaWiki.Usage.ForbiddenFunctions.join [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440180 (owner: Jforrester) [16:55:05] (CR) Jforrester: "PS5: Rebase. PS6: Auto-fix one minor item from new code." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/437659 (owner: Jforrester) [16:56:20] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, and 2 others: Create job to deliver the eventlogging_Cent... - https://phabricator.wikimedia.org/T189820 [17:11:05] (PS3) Jforrester: build: Re-enable MediaWiki.Usage.ForbiddenFunctions.join [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440180 [17:11:11] (PS3) Jforrester: build: Re-enable MediaWiki.Usage.ForbiddenFunctions.key_exists [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440181 [17:12:32] (CR) jerkins-bot: [V: -1] build: Re-enable MediaWiki.Usage.ForbiddenFunctions.join [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440180 (owner: Jforrester) [17:13:15] (CR) jerkins-bot: [V: -1] build: Re-enable MediaWiki.Usage.ForbiddenFunctions.key_exists [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440181 (owner: Jforrester) [17:15:51] (PS4) Jforrester: build: Re-enable MediaWiki.Usage.ForbiddenFunctions.join [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440180 [17:16:23] (PS4) Jforrester: build: Re-enable MediaWiki.Usage.ForbiddenFunctions.key_exists [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440181 [17:16:34] Jeff_Green: looks like the grafana simplejson backend also requires a web app to serve up the files [17:16:53] ah [17:17:13] just the raw data? or does it need to graph them? [17:25:45] Jeff_Green: https://grafana.com/plugins/grafana-simple-json-datasource [17:25:52] Your backend needs to implement 4 urls: [17:27:29] https://github.com/bergquist/fake-simple-json-datasource [17:27:43] why is everything complicated [17:33:15] it's just returning text right? then let's not run nodejs :-) [17:34:39] everything about grafana and prometheus feels like they just gave up trying to solve the problem of an off-the-shelf solution to anything [17:43:50] uh huh [17:46:06] Fundraising-Backlog: Generate new Civi certificate for Kristie - https://phabricator.wikimedia.org/T200281 (cwdent) a:cwdent [18:34:06] Fundraising-Backlog: 2018 Japan campaign: switch card processor to Adyen - https://phabricator.wikimedia.org/T200439 (Pcoombe) I've changed the [donatewiki form for Japan](http://donate.wikimedia.org/?country=JP) to use Adyen ([diff](https://donate.wikimedia.org/w/index.php?title=Template:2012FR/Form-country... [18:58:59] (PS1) Ejegg: JP/JPY form chooser should go to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448104 [18:59:20] fr-tech I think ^^^ should steer JP/JPY donors to Adyen from the form chooser [18:59:23] just testing locally now [19:01:08] Hmm, should we be accepting Amex in JP via Adyen? [19:06:18] Fundraising-Backlog: 2018 Japan campaign: switch card processor to Adyen - https://phabricator.wikimedia.org/T200439 (Ejegg) I've got a patch up to default JP/JPY to Adyen at the form chooser. I notice that we're currently not offering Amex via Adyen in JP/JPY - @Ppena do you know if we can add that? [19:09:12] (PS2) Ejegg: JP/JPY form chooser should go to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448104 (https://phabricator.wikimedia.org/T200439) [19:18:20] hey ejegg [19:18:58] just having a look through DonationInterfaceFormSettings and it looks like global collect for JP is allowing amex [19:19:10] unless I'm misunderstanding how it works [19:19:38] prior to your change [19:21:04] https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/448104/2/DonationInterfaceFormSettings.php@70 [19:54:18] hi jgleeson [19:54:23] hey! [19:54:44] sorry, just switched my phone data over, and it looks like the IRC alerter isn't working [19:55:16] anyway, I just wanted to make sure with PPena that we are capable of accepting Amex via Adyen before I go ahead and put it in the form [19:55:38] ah I see [19:56:35] although I'm still a little confused [19:56:47] aha, I think I found the permissions issue with my IRC notifier. Want to try pinging me again? [19:56:47] https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/448104/2/DonationInterfaceFormSettings.php@434 [19:57:05] it looks like amex was already enabled for IL? [19:57:15] for Adyan [19:57:17] jgleeson: yah, for IL / Adyen [19:57:56] so we wanna know does amex, on adyen, working specifically for Japan [19:58:15] work* [19:59:12] yeah, I feel like when we first started using Adyen we couldn't do Amex in JPY for some reason [19:59:18] but I don't know if that's still the case [20:00:19] got it [20:01:56] Fundraising-Backlog, Patch-For-Review: 2018 Japan campaign: switch card processor to Adyen - https://phabricator.wikimedia.org/T200439 (Ejegg) @PPena, Never mind, I just found an email from 2016 from our Adyen contact saying Amex should work for JPY. Will add that too. [20:02:14] jgleeson: ^^^ will put up another version of that patch [20:03:04] (PS3) Ejegg: JP/JPY form chooser should go to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448104 (https://phabricator.wikimedia.org/T200439) [20:04:58] jgleeson: ok, that should be ready to go ^^^ [20:05:17] I can cherry-pick it to deploy if ppl want it before the opt-in buttons [20:05:46] looking now [20:06:21] (CR) Jgleeson: "Looks good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448104 (https://phabricator.wikimedia.org/T200439) (owner: Ejegg) [20:06:24] (CR) Jgleeson: [C: 2] JP/JPY form chooser should go to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448104 (https://phabricator.wikimedia.org/T200439) (owner: Ejegg) [20:06:29] thanks! [20:07:56] oh hey, it's gerrit upgrade o'clock [20:08:03] uh oh [20:08:17] yup it is [20:10:59] and... back again! [20:12:29] jgleeson: looks like zuul didn't quite catch the +2 - want to take it away and add it again? [20:12:57] (CR) Jgleeson: [C: 2] JP/JPY form chooser should go to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448104 (https://phabricator.wikimedia.org/T200439) (owner: Ejegg) [20:13:06] done [20:13:07] thanks! [20:15:35] (Merged) jenkins-bot: JP/JPY form chooser should go to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448104 (https://phabricator.wikimedia.org/T200439) (owner: Ejegg) [20:22:35] (PS1) Ejegg: JP/JPY form chooser should go to Adyen [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/448149 (https://phabricator.wikimedia.org/T200439) [20:22:57] (CR) Ejegg: [C: 2] JP/JPY form chooser should go to Adyen [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/448149 (https://phabricator.wikimedia.org/T200439) (owner: Ejegg) [20:24:08] (Merged) jenkins-bot: JP/JPY form chooser should go to Adyen [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/448149 (https://phabricator.wikimedia.org/T200439) (owner: Ejegg) [20:26:57] (PS1) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448151 [20:27:18] (CR) Ejegg: [C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448151 (owner: Ejegg) [20:29:29] (Merged) jenkins-bot: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448151 (owner: Ejegg) [21:24:16] (PS1) Ejegg: Disable showing opt_in buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448156 (https://phabricator.wikimedia.org/T200439) [21:24:57] fr-tech anyone around to approve that ^^^ ? Just deleting a few lines in 2 yaml files [21:26:43] (CR) jerkins-bot: [V: -1] Disable showing opt_in buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448156 (https://phabricator.wikimedia.org/T200439) (owner: Ejegg) [21:27:12] heh, I guess those tests work! [21:27:56] (PS2) Ejegg: Disable showing opt_in buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448156 (https://phabricator.wikimedia.org/T200439) [21:34:41] (CR) XenoRyet: [C: 2] Disable showing opt_in buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448156 (https://phabricator.wikimedia.org/T200439) (owner: Ejegg) [21:35:21] thanks! [21:36:26] oh hey, this one is still in review... [21:36:32] https://gerrit.wikimedia.org/r/ [21:37:11] (Merged) jenkins-bot: Disable showing opt_in buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448156 (https://phabricator.wikimedia.org/T200439) (owner: Ejegg) [21:40:36] (PS2) Ejegg: JS module to add English email explainer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/447919 (https://phabricator.wikimedia.org/T200218) [21:41:15] fundraising-tech-ops: Prometheus/Grafana snapshots for long term storage - https://phabricator.wikimedia.org/T198876 (cwdent) My current approach is exporting grafana/prometheus data as json and using the SimpleJSON back-end. This will also require: - a cron job that dumps metrics at a reasonable resolutio... [21:46:20] hey cwd, you around? [21:49:48] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/448159 [21:49:55] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/448159 (owner: Ejegg) [21:51:04] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/448159 (owner: Ejegg) [21:52:17] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448161 [21:52:20] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448161 (owner: Ejegg) [21:55:10] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448161 (owner: Ejegg) [21:57:04] !log updated payments-wiki from 6390e50abd to 5e01f50983 [21:57:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:00:02] (PS1) XenoRyet: Name Filter won't flag on initials [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448162 [22:00:52] (CR) Ejegg: [C: 2] Forget mailing provider data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445344 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [22:01:38] (CR) jerkins-bot: [V: -1] Name Filter won't flag on initials [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448162 (owner: XenoRyet) [22:07:28] (Merged) jenkins-bot: Forget mailing provider data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/445344 (https://phabricator.wikimedia.org/T196644) (owner: Eileen) [22:17:39] (PS2) XenoRyet: Name Filter won't flag on initials [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448162 [22:18:11] (PS3) XenoRyet: Name Filter won't flag on initials [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448162 (https://phabricator.wikimedia.org/T199454) [22:20:37] (CR) jerkins-bot: [V: -1] Name Filter won't flag on initials [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448162 (https://phabricator.wikimedia.org/T199454) (owner: XenoRyet) [22:38:17] saurabhbatra: at the grocery store back soon [22:38:19] Fundraising Sprint Owls, Fundraising-Backlog, MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review: 2018 Japan campaign: switch card processor to Adyen - https://phabricator.wikimedia.org/T200439 (Ejegg) Form settings are updated - chooser now takes JP/JPY cc donors to... [22:39:42] (CR) XenoRyet: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448162 (https://phabricator.wikimedia.org/T199454) (owner: XenoRyet) [22:40:28] cwd: You can ping me about it when you’re back, Saurabh is hopefully asleep [22:41:06] Fundraising Sprint Owls, Fundraising-Backlog: publish Oanda exchange rates to internal, private google doc - https://phabricator.wikimedia.org/T200227 (Ejegg) Hi @jgleeson, a drush script would be a fine place for this if you're working in PHP. Want to just add it to the existing exchange_rates module? [23:25:17] awight: sup? [23:27:27] cwd: hey. [23:27:53] We were hoping there’s a shared folder on frdev where saurabh and I can look at files together? [23:28:39] awight: sure, tmp no good? [23:31:49] ahh okay we can do it that way [23:33:27] awight: ok, but i'm open to suggestions if that's not ideal [23:33:58] it should not be considered resilient storage :) [23:39:25] Cleared every reboot by default, I think [23:39:41] Yeah that’ll do for now, though! Thanks for reminding me :) [23:40:11] awight: np, we could do something like a shared git repo too [23:40:33] It’s a whole lot of contact data [23:40:47] actually, that makes me think /tmp might be a bit risky [23:40:54] since it subverts any access control on the machine. [23:41:14] true, however everyone who has an account on there has mysql access [23:41:38] & no way this could be exploited by a service account? [23:41:39] awight: you are both part of the fundraising group so you could chown as such [23:41:53] it's not impossible [23:41:57] that’ll work, good idea [23:43:06] on one hand it's nice that /tmp gets cleared out in case any donor data gets forgotten there [23:43:15] but the 777 part is not great [23:43:41] XenoRyet: saurabhbatra whipped up a bad name detector today, already might be worth finding a way to integrate it into fraud scores… [23:44:10] He retrained a Markov chain thing, https://github.com/rrenaud/Gibberish-Detector on a sample of names from our CRM [23:44:19] Yea, I'd love to take a look. [23:44:54] It’s currently in his homedir on frdev, but we can put it into /tmp tomorrow for sharing... [23:45:59] Sounds good