[00:44:55] (CR) Ejegg: "Looks pretty good! One question: does the ActivityContact ForgetMe need to be updated? The activitiesToKeep 'get' params include this:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [00:47:55] (CR) Eileen: "ejegg - most Core api natively support the $operator => [] format. ActivityContact.forget just passes that through to activity.contact.get" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [01:08:45] (CR) Ejegg: "yeah, the pass-through works great when setting $activityContactRecords." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [01:10:28] (CR) Eileen: "ok - that looks wrong will check - just a heads up that we will see the actual forgetme activity linked at the end of it" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [01:16:29] (PS7) Eileen: Forget previous lives [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) [01:16:48] (CR) Eileen: "ejegg - just pushed a fix on that" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [01:26:32] (CR) Ejegg: "Thanks! Just need to drop the no-longer-needed array wrapper" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [01:27:55] (PS8) Eileen: Forget previous lives [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) [01:28:05] (CR) Eileen: "ug - you are right! done" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [01:28:38] (CR) Ejegg: "Actually, it looks like instead of making that extra ActivityContact.get call, you could loop over $activityContactRecords and look at the" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [01:33:34] (CR) Eileen: "ejegg I don't think that works. I know if we have activity contact records related tot the contacts to be deleted - the question is if the" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [02:01:03] (CR) Ejegg: [C: 2] "Ah, right, I was thinking of it too simplistically. Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [02:08:33] (Merged) jenkins-bot: Forget previous lives [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446536 (https://phabricator.wikimedia.org/T199748) (owner: Eileen) [05:03:31] (CR) jerkins-bot: [V: -1] build: Updating mediawiki/mediawiki-codesniffer to 21.0.0 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/448314 (owner: Libraryupgrader) [15:39:58] (CR) Ejegg: [C: 1] "Looks good! Could you please add the new required field to the filter's doc in README.txt?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/448162 (https://phabricator.wikimedia.org/T199454) (owner: XenoRyet) [15:44:41] hi jgleeson, how's it going? [15:44:48] and hello to AndyRussG too! [15:46:16] hey ejegg, good thanks, just working on this drush google api script. Currently figuring out how to include composer packages inside drupal/drush. How about you [15:47:21] jgleeson: doing well, just reviewing stuff [15:47:55] jgleeson: for the composer packages, don't we include vendor/autoload at the bottom of our settings file? [15:48:23] settings.php:require_once __DIR__ . '/../../vendor/autoload.php'; [15:48:24] settings.php:require_once __DIR__ . '/../../vendor/autoload.php'; [15:48:28] oops [15:51:09] ejegg: jgleeson: fr-tech morningz! [15:52:05] how's things up in Tenochtitlan? [15:52:45] mornings AndyRussG! [15:52:59] yep I see that ejegg although I'm having issues loading some google lib files [15:53:20] I'm gonna step through and see whats up [15:53:26] sometimes its a cache thing [15:53:30] with drush [15:53:32] ejegg: eh not toooo bad [15:53:37] jgleeson: :) [15:54:13] jgleeson oh yeah, I've been conditioned to drush cc all every time something doesn't work [16:13:15] (CR) Jgleeson: [C: 2] JS module to add English email explainer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/447919 (https://phabricator.wikimedia.org/T200218) (owner: Ejegg) [16:15:49] (Merged) jenkins-bot: JS module to add English email explainer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/447919 (https://phabricator.wikimedia.org/T200218) (owner: Ejegg) [16:16:01] thanks jgleeson ! [16:56:30] fr-tech for a general check-in about the Kafka Python scripts, I'm eyeing Monday at 8:30 am Pacific Time, looks free for everyone [16:57:25] ok, cool [16:57:31] Hmmm might be early for Dylan [16:57:50] He has something at 9 am [16:58:06] Oh wait sorry [16:58:26] fr-tech or maybe 10:30 am Pacific? [16:58:53] right after standup? [16:58:59] sure! [16:59:05] err, that's dept-wide standup [16:59:17] yeah the other standup [17:00:02] Ours is still a Daily Autopsy [17:00:51] K I'll throw something on the calendar [17:03:01] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/448588 [17:03:22] works for me AndyRussG ! [17:03:51] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/448588 (owner: Ejegg) [17:05:49] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448592 [17:05:53] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448592 (owner: Ejegg) [17:06:19] ejegg: jgleeson: cool, thx! [17:16:10] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/448588 (owner: Ejegg) [17:16:23] (PS1) Ejegg: Add variant dir for email explainer [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448595 [17:27:50] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448592 (owner: Ejegg) [17:28:33] (PS1) Ejegg: Merge remote-tracking branch 'origin/REL1_31' into fundraising/REL1_31 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448603 [17:32:30] (PS1) Ejegg: Add form_variants from fr/REL1_27 branch [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448605 [17:33:02] oops, I just self-merged a bunch of the REL1_31 branch stuff [17:33:22] thought I was just pushing the updated from the upstream REL1_31, but I acatually pushed all my setup patches [17:33:32] anyway... that's one step closer to deploy-able [17:34:06] fr-tech if anyone's interested in code deletion: https://gerrit.wikimedia.org/r/446492 [17:34:52] (Abandoned) Ejegg: WIP merged vendor dirs for payments-wiki [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/405822 (https://phabricator.wikimedia.org/T185547) (owner: Ejegg) [17:45:01] (PS1) Ejegg: Fix .gitmodules branch for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448607 [17:45:24] (CR) jerkins-bot: [V: -1] Add form_variants from fr/REL1_27 branch [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448605 (owner: Ejegg) [17:49:53] ejegg, I don't know where I stand on code deletion [17:50:19] I guess in the most part it's good, when it's stuff that's no longer needed [17:50:24] but then terrifying if it still is [17:51:11] jgleeson: I'm pretty sure all that stuff from ContributionTracking is very obsolete [17:51:34] that's the type I like then [17:51:37] It used to be used to initiate paypal contributions from non-payments wikis [17:52:06] but of course that meant all sorts of non-PCI-scope wikis had write access to the fundraising DBs [17:52:26] Also, it sure as heck can't make paypal EC donations [17:55:29] (CR) jerkins-bot: [V: -1] Fix .gitmodules branch for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448607 (owner: Ejegg) [18:18:33] ejegg, I've had a look through the deletions in that patch and they all make sense. However, without a test suite to run for ruling out any regressions, and no obvious way to test the old functionality, the best review I can do is reading the code changes. Is that enough for a +2? I'm thinking maybe +1 and then someone else more familiar confirms it? what do you think? [18:19:39] jgleeson: sadly, the people that are more familiar with it no longer work on fr-tech [18:19:55] ah, I see [18:20:36] it's basically just used for that maintenance page, and to give us the connection string to insert rows into c_t [18:21:37] so, if your local DonationInterface pages can still get rows into c_t when loading a payments form, and you can still see the 'sorry' page when you set $wgContributionTrackingFundraiserMaintenance=true [18:21:46] that should be enough to OK it for payments-wiki [18:21:59] ok I'll try that now [18:29:15] ejegg, I'm getting a weird gerrit error when trying to pull down that patch [18:29:39] do we have a wiki* pastebin? [18:30:18] actually there's nothing sensitive, I'll use a general one [18:30:25] oh huh [18:30:44] https://glot.io/snippets/f3aw4bmzj2 [18:30:53] .gitreview file looks ok [18:31:18] oh huh [18:31:19] drupal/c_t looks like it's getting records fine [18:31:28] so not sure what's up with that [18:32:32] jgleeson: i guess i'm not too familiar with using git-review -d [18:32:46] I generally copy-paste from the 'download' dropdown in the gerrit UI [18:36:13] huh, that worked! [18:44:00] (CR) Jgleeson: [V: 2 C: 2] "c_t table still being written to and maintenance flags still working as expected. Looks good to me!" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/446492 (owner: Ejegg) [18:45:18] calling it a day, have a good weekend fr-tech! [19:06:08] (Merged) jenkins-bot: Delete obsolete parts of this extension. [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/446492 (owner: Ejegg) [21:04:33] AndyRussG: bout sir? [21:04:49] Seddon: yes... Just about to start a meeting tho [21:05:01] Will be around after that, too (about 50 minutes from now-ish) [21:05:08] Everything okok? [21:07:24] AndyRussG: are you aware that the Maxmind database is being deprecated for a new version [21:13:13] (CR) Ejegg: [C: 2] Merge remote-tracking branch 'origin/REL1_31' into fundraising/REL1_31 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448603 (owner: Ejegg) [21:13:34] (CR) Ejegg: "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448605 (owner: Ejegg) [21:19:09] (Merged) jenkins-bot: Merge remote-tracking branch 'origin/REL1_31' into fundraising/REL1_31 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448603 (owner: Ejegg) [21:29:52] (CR) Ejegg: [C: 2] Add variant dir for email explainer [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448595 (owner: Ejegg) [21:32:00] (Merged) jenkins-bot: Add variant dir for email explainer [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448595 (owner: Ejegg) [21:39:22] !log updated payments-wiki from 5e01f50983 to f0138ab066 [21:39:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:39:26] >_> [21:39:29] <_< [21:39:48] I swear it was harmless changes [21:53:39] (PS2) Ejegg: Add form_variants from fr/REL1_27 branch [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448605 [21:53:40] (PS2) Ejegg: Fix .gitmodules branch for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448607 [21:53:43] (PS1) Ejegg: Update ContributionTracking and DonationInterface [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448784 [21:53:46] well, in for a penny... [21:54:10] (PS1) Ejegg: Fix array in email explainer form variant [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448786 [21:54:18] (CR) Ejegg: [C: 2] Fix array in email explainer form variant [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448786 (owner: Ejegg) [21:57:36] (Merged) jenkins-bot: Fix array in email explainer form variant [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/448786 (owner: Ejegg) [21:59:31] Seddon: no I didn't know... Is there a Fab ticket about that? [22:00:35] Though we (through CentralNotice) take care of client-side code for geolocation, most of the work for that happens server-side and is under the purview of operations, or traffic teams [22:01:16] Geolocation is totally essential to a lot of teams' work... All our web logs are geolocated server-side too [22:03:28] Seddon: or are you talking about a different database of theirs? [22:03:42] (not finding anything in Fab just now) [22:04:23] Seddon: I'll be afk for about 20 minutes now, gotta walk the wog. Back again in a bit! [22:05:55] !log updated payments-wiki from f0138ab066 to 8c4d6aaa13 [22:05:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:10:04] weird [22:10:14] emailExplain variant works locally [22:10:24] but not on payments [22:10:36] nostate variant works fine on payments, though [22:38:37] (PS1) Ejegg: Move queue sending fns out of global scope [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/448808 (https://phabricator.wikimedia.org/T195337) [22:45:26] Fundraising-Backlog, FR-Email: Create opt-IN page for fundraisingEmailUnsubscribe, consume messages - https://phabricator.wikimedia.org/T200576 (Ejegg) [22:45:51] Fundraising Sprint Owls, Fundraising-Backlog, MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review: Add explainer text to CC payment form (for banner checkbox experience) - https://phabricator.wikimedia.org/T200218 (CCogdill_WMF) Done, awesome! @Ejegg I know you said we... [22:58:23] Fundraising Sprint Owls, Fundraising-Backlog, MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review: Add explainer text to CC payment form (for banner checkbox experience) - https://phabricator.wikimedia.org/T200218 (Ejegg) I set up a variant called emailExplain. It's al... [22:59:12] Fundraising Sprint Owls, Fundraising-Backlog, MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review: Add explainer text to CC payment form (for banner checkbox experience) - https://phabricator.wikimedia.org/T200218 (Ejegg) Also, that variant is configured for adyen, glo... [23:29:21] (PS2) Ejegg: Move queue sending fns out of global scope [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/448808 (https://phabricator.wikimedia.org/T195337) [23:29:23] (PS1) Ejegg: Ingenico audit: deal with untokenized recurring. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/448820 (https://phabricator.wikimedia.org/T195337)