[00:00:47] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449377 [00:01:13] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449377 (owner: Ejegg) [00:04:10] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449377 (owner: Ejegg) [00:05:00] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 4 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [00:07:34] !log updated payments-wiki from 8c4d6aaa13 to 344233cff8 [00:07:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:08:25] OK mepps, all the footer links are updated [00:09:36] ejegg: are we good then? [00:09:43] dstrine: I think so [00:10:14] there are a bunch of links in the i18n messages but I think those might all be obsolete [00:10:19] trying to see how to trigger those [00:11:30] so when I go to the regular donation form, and I click on the links at the bottom of the page I go back to the old foundation wiki [00:11:51] dstrine: 2 now go to donatewiki [00:11:56] Just tested looks like no links are broken [00:12:12] but the ones that were pointing to the new foundation site were broken, i.e. the redirects weren't working [00:12:27] it was to a Special:LandingPage url, so it would have been a tricky redirect [00:12:53] mepps: OK, I found where we use at least on of the i18n messages with links hardcoded [00:13:12] it's in the error-default template [00:13:21] can't think right now how to trigger that [00:13:41] but I think it would show up when there's e.g. a problem making API calls to a processor [00:14:10] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/55643b06de8c4a58a2208536b3a43b97b4779ab7/gateway_forms/mustache/error_form.html.mustache#L10 [00:15:38] (PS1) Jgleeson: WIP: Publish fundraising exchange_rates data to Finance Dept spreadsheet via Google Sheets API. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) [00:16:21] ejegg: sorry I'm not sure how to verify what you have changed. [00:17:00] dstrine: before: broken links in footer. now: no broken links in footer [00:17:18] the links for FAQ and Tax info [00:19:00] ejegg: ok but the fix was to point to the old foundation wiki pages? We'll still need to switch all those links to the new donate wiki pages like.. tomorrow right? Cause we don't know how long the foundation wiki will stay up [00:19:29] dstrine: mepps says that those two will be on the new foundation site [00:19:49] we just didn't know exactly where, so for right now we just pointed them to something that wasn't 404 [00:20:29] Yeah dstrine I also asked for the links in my update on the plan task [00:20:45] This is just a short term fix so we don’t have broken links [00:21:51] mepps: ejegg ah right sorry. got a little mixed up over here. Still have a crazy headache. Again thanks for staying on. I know it's later for you. [00:22:03] dang, Donor policy link in the footer is still broken [00:22:42] Erg [00:22:49] ejegg: donor policy goes to the old foundation wiki page for me [00:23:00] I get this in a new tab: https://foundation.wikimedia.org/wiki/Donor_privacy_policy/en [00:23:24] dstrine: really? I get this: https://wikimediafoundation.org/wiki/Donor_policy [00:23:27] 404 Error [00:23:27] Imagine a world in which there is a page here [00:23:49] dstrine: footer of donatewiki or payments? [00:23:56] we're trying to fix payments just now [00:24:01] this is the payment page I am on: https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=US&uselang=en&utm_medium=spontaneous&utm_source=fr-redir&utm_campaign=spontaneous [00:24:12] Dstrine the link works on donatewiki but not paymentswiki [00:24:18] yah, looks like pcoombe fixed that one [00:24:31] oh sorry [00:25:20] ok I can reproduce....side note: that's not a great 404 message [00:25:29] mepps: gonna try rebasing your i18n patch just for fun [00:25:35] (PS2) Ejegg: Also, update templates with direct links [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/439592 (https://phabricator.wikimedia.org/T193663) (owner: Mepps) [00:25:41] Also on donatewiki the links all go to foundationwiki but on paymentswiki a couple go to donatewiki [00:25:42] cool, no merge conflict! [00:25:49] Yay! [00:26:09] oh, but it's pointing to a bad redirect chain for donor policy too [00:26:44] On paymentswiki? [00:26:51] Or in my patch [00:27:14] the patch assumed donor policy would move to donatewiki, but it seems not to have been implemented there [00:27:23] Ah gotcha [00:27:24] https://donate.wikimedia.org/wiki/Donor_policy [00:27:32] and the 'moved' link is bad [00:27:57] will fix [00:27:58] I’m wondering if we should point the links on paymentswiki all to foundationwiki [00:28:14] Just temporarily to match the links on donatewiki [00:28:23] oh, ok [00:28:54] I’ll update the phab task [00:29:56] hmm, redirects thru newfoundationwiki don't preserve language [00:30:25] oh wait, they do with language param, not uselang [00:31:04] Ugh I can’t login to phab on my phone [00:33:19] wat, some of these policy links are to meta [00:33:46] dstrine: would you be able to update the phab task to say we’re sending all the footer links to foundation wiki? [00:34:08] Also, https://wikimediafoundation.org/wiki/Donor_policy should redirect [00:36:17] mepps: done [00:36:19] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 4 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [00:36:55] Thanks! ejegg can we say that all the most visible links aren’t broken at this point? [00:37:00] Argh, this is so dumb... We need to T108699 and end the madness [00:37:01] T108699: WMF-specific links and emails should be in LocalSettings - https://phabricator.wikimedia.org/T108699 [00:37:51] have a good evening fr-tech! [00:37:57] see ya jgleeson_ [00:38:35] Agreed ejegg [00:40:12] If we update the links from donatewiki to foundationwiki, could we say it’s in a good place for the night ejegg? Trying to get to good enough so we can approach this more systematically tomorrow [00:40:27] mepps yeah, just doing that [00:40:44] it's just there were a bunch of weird variations [00:40:54] I guess I've checked our most-used languages [00:41:45] donatewiki MediaWiki:Common.js [00:41:46] donatewiki MediaWiki:Resources/landingpage-2.js [00:41:46] (PS3) Ejegg: Also, update templates with direct links [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/439592 (https://phabricator.wikimedia.org/T193663) (owner: Mepps) [00:41:54] Can someone update wikimediafoundation.org on those pages please? :) [00:41:55] mepps want to cross-check that ^^^ [00:42:09] Reedy: thanks for the find! [00:42:27] I've updated... [00:42:28] metawiki MediaWiki:FR2012/Resources/DropdownForm.js [00:42:28] metawiki MediaWiki:FR2012/Resources/DropdownFormi18n.js [00:42:28] metawiki MediaWiki:FR2013/Resources/DropdownForm-ptBR.js [00:42:35] But I dunno if they just want deleting [00:42:50] oh, probably [00:42:56] :P [00:43:12] man, fundraising left a trail everywiki [00:43:25] (CR) jerkins-bot: [V: -1] Also, update templates with direct links [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/439592 (https://phabricator.wikimedia.org/T193663) (owner: Mepps) [00:43:30] lolol [00:44:02] I’m confused ejegg about where we should direct these links in the short term and how the template update will affect users experience [00:45:23] mepps yeah, since new-foundation-wiki seems to be redirecting to old-foundation-wiki for the policy page? [00:45:25] well, now it's a broken link [00:45:31] For some stuff... [00:45:36] Redirects aren't complete [00:46:54] oh wow, MediaWiki:Resources/landingpage-2.js has some super-obsolete paypal logic. that can't possibly be in use anywhere [00:47:03] What is new foundation wiki in this context? [00:47:16] mepps wikimediafoundation.org is the wordpress site [00:47:22] foundation.wikimedia.org is the old wiki [00:48:55] Right so there is no new foundation wiki, just the new site, right? [00:49:11] mepps right, sorry, 'wiki' on the brain [00:49:35] but new-foundation-site is redirecting to old-foundation-wiki for the policy link in the donate footer [00:49:41] Yeah, old wiki has been moved [00:55:26] (PS4) Ejegg: Also, update templates with direct links [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/439592 (https://phabricator.wikimedia.org/T193663) (owner: Mepps) [00:57:09] mepps want to sanity check that? [01:00:00] ejegg can we hop on a quick call? i just want to make sure we're clear on what we're doing [01:00:16] sure, old-school hangouts link? [01:00:28] sure [01:07:00] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 4 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [01:07:26] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 4 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [01:11:16] (PS5) Ejegg: Also, update templates with direct links [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/439592 (https://phabricator.wikimedia.org/T193663) (owner: Mepps) [01:12:32] (PS6) Ejegg: Point all links to foundation.wikimedia.org [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/439592 (https://phabricator.wikimedia.org/T193663) (owner: Mepps) [01:12:49] (CR) Mepps: [C: 2] Point all links to foundation.wikimedia.org [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/439592 (https://phabricator.wikimedia.org/T193663) (owner: Mepps) [01:13:33] mepps: and ejegg just saw the note about getting on the call and the updates on the task. let me know if I can help with anything [01:13:48] thanks dstrine [01:13:56] thanks dstrine!! [01:14:06] I think this is a good plan. Thanks for winging it [01:14:09] we're pointing it all (except the thank you page) to the old site for tonight [01:15:05] (Merged) jenkins-bot: Point all links to foundation.wikimedia.org [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/439592 (https://phabricator.wikimedia.org/T193663) (owner: Mepps) [01:15:12] cool ejegg. I hope you two take some extra personal time this week [01:15:29] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/449385 [01:15:45] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/449385 (owner: Ejegg) [01:16:43] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449386 [01:16:45] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449386 (owner: Ejegg) [01:16:55] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/449385 (owner: Ejegg) [01:19:20] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449386 (owner: Ejegg) [01:20:31] !log updated payments-wiki from 344233cff8 to 6afaca3de3 [01:20:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:26:10] Payments footer lookin good to me [01:26:23] thanks so much [01:26:59] Fundraising Sprint Owls, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy, and 2 others: WMF-specific links and emails should be in LocalSettings - https://phabricator.wikimedia.org/T108699 (Ejegg) [01:27:38] Fundraising Sprint Owls, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy, and 2 others: WMF-specific links and emails should be in LocalSettings - https://phabricator.wikimedia.org/T108699 (Ejegg) Moving this into sprint - it's the only sane way to wrangle all the URLs [02:00:06] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 4 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [04:09:45] fundraising-tech-ops: Remove stretch repos from jessie boxes - https://phabricator.wikimedia.org/T200725 (MoritzMuehlenhoff) Generally speaking installing packages from a later release is unsupported (but works fine in the case of prometheus-mysqld-exporter which IIRC is a Go-based app which only does static... [05:06:17] Fundraising-Backlog, wikimediafoundation.org: Recreate the thank you page on donate wiki - https://phabricator.wikimedia.org/T193662 (Varnent) [05:06:31] Fundraising-Backlog, Wikimedia-Fundraising, wikimediafoundation.org: Move fundraising thank you pages to donate.wikimedia.org - https://phabricator.wikimedia.org/T189664 (Varnent) [05:06:45] Fundraising-Backlog, Wikimedia-Fundraising, wikimediafoundation.org: Move fundraising support pages to donate.wikimedia.org - https://phabricator.wikimedia.org/T189668 (Varnent) [05:06:59] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 5 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [14:18:23] Fundraising-Backlog: Adyen JCB 'invalid card' errors from donation form - https://phabricator.wikimedia.org/T200610 (MBeat33) Order ID 58199484.1 says **Visa at Adyen** console, but shows as **JCB in Civi** cid=26551944 from @Ejegg //if we're sending the wrong code to Adyen for card type, that could explai... [14:38:12] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 5 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [14:53:06] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 5 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [15:01:01] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 5 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [15:10:16] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 5 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [15:23:17] fundraising-tech-ops: Remove stretch repos from jessie boxes - https://phabricator.wikimedia.org/T200725 (Jgreen) In frack when we attach a non-stock repo, we also add a -10 pin for all packages from that repo so they are never considered. Then we add a +1001 pin for individual specific packages as necessary... [15:27:07] (PS1) Ejegg: Parameterize 'Other ways to give' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449474 (https://phabricator.wikimedia.org/T108699) [15:37:11] (PS1) Ejegg: Parameterize 'Donor Policy' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449477 (https://phabricator.wikimedia.org/T108699) [15:40:27] hmph, tests complaining about those ampersands [15:40:39] but why only the policy URL? [15:40:53] (CR) jerkins-bot: [V: -1] Parameterize 'Donor Policy' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449477 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [15:46:25] hey ejegg, mepps, how did the foundation site stuff go? [15:47:04] hi jgleeson ! [15:47:21] well, we got the bad links gone [15:47:33] still need to work out where they go for the long term [15:47:45] I need to catch up with that discussion [15:47:58] for now I've just been focusing on getting the URLs out of the i18n messages [15:49:39] cool [15:50:55] what's the plan for todays tech talk, do you know? [15:51:19] jgleeson: no, do you have any suggestions? [15:51:38] ummm, just checking https://etherpad.wikimedia.org/p/fr-tech-talk-ideas [15:51:53] I think we can move the process-control jobs to the previous: block [15:52:26] we could invite ops and do a talk on prometheus/grafana [15:52:38] or the IP whitelisting subject is one handy to know [15:53:24] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 5 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [15:53:41] i can't make tech talk today, i have another meeting at the same time jgleeson ejegg [15:53:46] oh shoot [15:54:00] Me either, I have to take M to his swim lessons. [15:54:09] so... reschedule? [15:54:12] ah, maybe hold off then [15:54:40] jgleeson: if you've got time to meet anyway, I'd love to hear how the google sheets stuff works [15:55:06] I'll be busy with that from I think 9:45-11:00 for the next three days. Any other time should be ok for me though. [15:55:23] (PS2) Ejegg: Parameterize 'Donor Policy' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449477 (https://phabricator.wikimedia.org/T108699) [15:55:39] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 5 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [15:55:52] ejegg, jump in! check out the getting setup steps in the commit message. https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/449379/ [15:56:03] it's a bit of a long one [15:56:14] but only because you have to setup the API access with google [15:57:06] (CR) jerkins-bot: [V: -1] Parameterize 'Donor Policy' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449477 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [15:59:08] I'm currently adding the logic to the spreadsheet to read the exchange rates and thinking about how to test the code in that patch [15:59:24] the Finance Dept* spreadsheet [15:59:28] oh, cool! [16:00:20] (PS1) Ejegg: Escape special chars in Mustache URL params [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449480 (https://phabricator.wikimedia.org/T108699) [16:02:19] (CR) jerkins-bot: [V: -1] Escape special chars in Mustache URL params [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449480 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [16:07:33] (PS3) Ejegg: Parameterize 'Donor Policy' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449477 (https://phabricator.wikimedia.org/T108699) [16:07:35] (PS2) Ejegg: Escape special chars in Mustache URL params [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449480 (https://phabricator.wikimedia.org/T108699) [16:09:26] jgleeson: oh, one other thing we could work on with the tech talk time: those JCB / Adyen errors might be from a missing brandCode api param. [16:09:35] Would be pretty nice to fix that one fast! [16:09:47] works for me! [16:10:05] that's this task: https://phabricator.wikimedia.org/T200610 [16:10:11] I haven't looked at JCB or Adyen yet so be another good learner [16:10:20] it'll be* [16:10:36] I was looking at the payments logs, and all the JCB / Adyen attempts I saw ended in failure at the processor side [16:12:35] Fundraising-Backlog, Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM: Add es-419 as a supported 'preferred language' in Civi - https://phabricator.wikimedia.org/T199733 (Pcoombe) a:Pcoombe>None [16:13:25] fundraising-tech-ops: Remove stretch repos from jessie boxes - https://phabricator.wikimedia.org/T200725 (Jgreen) When we attach a non-stock repo in frack, we also add a default -10 pin for all packages for that repo, plus a +1001 pin for specific individual packages we want to include for that repo. If ther... [16:21:43] (PS2) Ejegg: Parameterize 'Other ways to give' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449474 (https://phabricator.wikimedia.org/T108699) [16:21:45] (PS4) Ejegg: Parameterize 'Donor Policy' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449477 (https://phabricator.wikimedia.org/T108699) [16:21:48] (PS3) Ejegg: Escape special chars in Mustache URL params [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449480 (https://phabricator.wikimedia.org/T108699) [16:25:48] (PS4) Ejegg: Escape special chars in Mustache URL params [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449480 (https://phabricator.wikimedia.org/T108699) [16:59:17] Darn, I can’t remember how to navigate from https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/Inspire_Community_Health to the banner content as as a wiki page. [17:00:04] https://meta.wikimedia.org/wiki/MediaWiki:Centralnotice-template-Inspire_Community_Health [17:00:26] awight: nice, I was just starting to puzzle that out [17:01:30] jgleeson: trying to join the meet(ing), Loading... forever [17:01:36] needs a link or something... [17:01:48] same ejegg [17:02:14] jgleeson: the queen seems to load [17:02:15] I’m confused after coming back to CN after so many months. lmk if you need a finger puppet to interview [17:02:28] lol, sekret fr-tech talk [17:02:37] awight: what brings you back? [17:02:40] ejegg, she's "loaded" * [17:02:42] * awight slowly backs out of the cigar-filled room :-) [17:02:43] (to cn) [17:03:01] (the queen) :) [17:03:02] ejegg: Just digging through logs to answer a banner question for someone in IRC [17:03:04] lol [17:03:26] awight: all good? also, hi! [17:03:31] fr-tech I'm in the hangoot [17:03:58] AndyRussG, we're in the queenmary [17:03:59] AndyRussG: oh, we're in queenmary cos that wasn't loading for us [17:04:04] the other meet wasn't loading [17:05:23] ah okok [17:05:36] AndyRussG: yeah, it’s an Inspire campaign thing, nbd [17:15:57] awight: did you try https://wikimediafoundation.org/ [17:18:12] (CR) AndyRussG: WIP: Publish fundraising exchange_rates data to Finance Dept spreadsheet via Google Sheets API. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) (owner: Jgleeson) [17:33:04] hi awight! [17:43:58] saurabhbatra: o/ Exciting developments! [17:44:17] what's up? [17:44:21] saurabhbatra: BTW, cwd recommended that we share files in /tmp for now [17:44:39] saurabhbatra: oh, exciting that you have a first round of features to evaluate! [17:45:16] awight: ah, yes i was hoping to have plots by today but there was some problem with the updation of sklearn [17:45:54] saurabhbatra: if the /tmp files include any protected donor info or identifying feature values, let’s give the directory 0770 permissions and the “fundraising” group, which I hear we share. [17:46:20] kk let me know if I can help with the py package or anything else. [17:46:38] there are a couple of solutions to this - a) i could write the code for train_test_split myself, b) we import it by hand (scp it over and then something?) [17:46:49] or c) build it from source [17:48:24] just not sure which is the "correct" way to do it [17:48:30] Wait, first what is the problem? [17:48:35] scikit-learn won’t install? [17:48:45] or, it’s an old version? [17:55:01] awight: it's at v 0.14 [17:55:10] train_test_split support was added in 0.16 [17:55:22] I'm currently running 0.19 [17:55:24] Aah cool. [17:55:39] +1 that backporting a few modules might be expedient [17:56:12] That particular function is just [:N] [N:] slicing IIRC [17:56:19] yeah that might save us some time [17:56:28] i'll write the function and see what plots we get [17:56:29] btw [17:56:39] re- name gibberish scorer [17:56:49] python is a forgiving language for that kinda hack. Godspeed! [17:57:27] we should have an additional feature is_name_english right [17:57:45] to account for other scripts (Japanese, Russian etc.) [17:59:04] mmm, that doesn’t seem right. How about a feature do_text_scripts_agree [17:59:34] hmm [17:59:51] because the implementation of gibberish scorer uses only english alphabet [18:00:36] https://github.com/rrenaud/Gibberish-Detector/blob/master/gib_detect_train.py#L6 [18:03:36] yes that’s crummy. I suspect that the Markov chain will cope fine with multilingual inputs [18:03:46] if for the vowel reason and nothing else [18:04:57] Vowels in each script will have strong connectivity to other letters across languages [18:11:18] awight: "Return only the subset of chars from accepted_chars. This helps keep the model relatively small by ignoring punctuation, infrequenty symbols" [18:11:48] ah interesting. [18:11:52] Let’s throw symbols in as well :-) [18:11:54] so it just ignores the other script symbols [18:12:01] We can afford a larger model... [18:12:22] what scripts do we want to add? [18:12:48] or maybe wait till another iteration before we worry about such details... [18:13:08] Had a thought for the future: we could train a gibberish model on each field, since a street address looks much different than a name... [18:13:32] yup, that does sound nice [18:13:38] Adding all scripts seems really cheap, is why I think it makes a good strategy [18:14:02] I mean, most features are “optional” for the first round of course. [18:14:18] yes of course [18:14:24] i'll see if i can get a plot up in a bit [18:14:36] then holler at you and share the plots in tmp [18:14:40] :-) [18:15:27] Sorry, I’m just catching up with you. English-only is really unjust, but its bias is partly neutralized by an is_english flag. [18:15:32] That makes sense, too! [18:16:08] yup, i thought adding a dimension solves the problem [18:16:15] tells the model that the scores are unreliable [18:17:08] :-) That also works for a first draft, we keep en_gibberish. It’ll certainly help with the names in English. [18:17:10] although making the scores reliable would be better [18:17:13] So how do we detect is_english? [18:17:37] oh yeah, interface language is captured in a few features. [18:17:55] check if all the letters are in the 'abc...z' dict? [18:18:15] It’s worth double-checking that “language” is captured—do you happen to remember? [18:18:27] language isn't [18:18:44] i'll send you a list of the final features on pm [18:18:46] cool. Maybe for the same reasons as caused us to omit country? [18:18:50] *that [18:19:31] Have we chatted about Themis? [18:19:41] i'm using country currently [18:19:48] although i wasn't too sure about it [18:19:55] What if we include all the prejudicial features, including language and country, but run a post-analysis using https://github.com/LASER-UMASS/Themis [18:20:03] (or a homebrew equivalent) [18:20:29] We build the model using all available information, but check how it behaves when only country, language are varied. [18:20:33] Fundraising-Backlog, Easy: Geolocation not available on wikimediafoundation.org - https://phabricator.wikimedia.org/T73747 (Varnent) Open>declined No longer applies to new site. [18:21:58] can't believe i haven't heard of this before [18:22:09] <3 cool [18:22:27] maybe we can add geo-location info later too... [18:22:32] ;-) [18:22:37] It’s just a strategy, obviously. The software is neat but maybe not industry-standard quality as of now. [18:22:51] LIME btw is the real deal, I’ve heard of a dozen integrations w/o even asking. [18:23:02] ooh geo-location ftw. [18:23:10] neat, I wonder if that’s just two scalars. [18:23:12] it's referenced a lot (LIME) [18:23:16] +1 [18:23:28] yup, with added granularity [18:23:37] Themis still an underdog, but its field is about to blossom it seems. [18:23:54] it's a major problem tbh - machine learning racism [18:24:06] Right, and fortunately there’s some attention on the problem. [18:24:18] so i was attending this talk by a person who worked with Google Photos [18:24:22] The Big Deal according to me is that we can’t probe the corporate AIs [18:24:38] Following C. Sandvig [18:24:46] oh? [18:24:59] and he told us how Google got into a lawsuit b.c. Google Photos tagged people from Africa as gorillas... [18:25:04] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, and 2 others: Create job to deliver the eventlogging_Cent... - https://phabricator.wikimedia.org/T189820 [18:25:12] a disaster... [18:25:13] ouch. yes I think I’ve heard of this [18:25:16] to say the least [18:25:37] then they fixed it by removing the tag "gorilla" [18:25:48] which just shows that no ML model can be made perfect [18:25:58] It’s such a deep criticism of itself… Capitalism is its best parody. [18:26:14] OMFG I had no idea that was the punchline. [18:26:21] +1 :-) [18:26:23] sickening [18:27:07] It means that *every single* step of the Google product pipeline was afflicted by systematic racism and vileness. [18:27:24] Training data, ML design, QA, everything. [18:27:41] yup, i guess they never bothered to question their choice of features... [18:28:18] although image recognition is a different field from classic ML so I'm not so sure [18:28:45] but they probably never tested it thoroughly re-racism which puts the blame on them... [18:33:02] and in fact, the resulting model barely even needs interpretation, you can just look at its behavior and see that it comes from a culture that has bought into this idea of race and uses it to separate people into castes with limited job and mobility opportunities. [18:33:23] hehe I’ll stop distracting you from kernel-hacking sklearn [18:35:27] oh i get your point now, it's not Google-specific [18:35:56] it's more about how looking at data from an ML perspective reveals our underlying misgivings [18:36:42] which makes sense and is prevalent in almost any AI which has human interactions [18:39:54] Fundraising Sprint Owls, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy, and 2 others: WMF-specific links and emails should be in LocalSettings - https://phabricator.wikimedia.org/T108699 (Ejegg) p:Triage>Normal a:Ejegg @MBeat33 Is there any real difference between... [18:48:19] saurabhbatra: yeah I wasn’t saying that any of the specific people involved at Google are vile or racist, but in aggregate their behavior is roughly as racist as the extremely racist society most of the employees are embedded within, and this kind of thing shows like daylight in the model. And yeah totally not Google-specific, they’re jut one example… [18:55:03] Fundraising Sprint Owls, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy, and 2 others: WMF-specific links and emails should be in LocalSettings - https://phabricator.wikimedia.org/T108699 (MBeat33) Thanks, @Ejegg problemsdonating@ is an old delegated Gmail account - retiring it... [19:25:52] (PS1) Ejegg: Send brandCode to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449524 (https://phabricator.wikimedia.org/T200610) [19:27:07] Fundraising-Backlog, fundraising-tech-ops, Epic: Create job to deliver the eventlogging_LandingPageImpression topic - https://phabricator.wikimedia.org/T200449 (Jgreen) I think I've got this done according to the task plus our IRC discussion about file naming and sample rates for both collectors: -... [19:37:59] Fundraising Sprint Owls, Fundraising-Backlog, Patch-For-Review: Adyen JCB 'invalid card' errors from donation form - https://phabricator.wikimedia.org/T200610 (DStrine) [19:38:02] (PS2) Ejegg: Send brandCode to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449524 (https://phabricator.wikimedia.org/T200610) [19:40:07] (PS3) Ejegg: Send brandCode to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449524 (https://phabricator.wikimedia.org/T200610) [19:42:39] Fundraising-Backlog, fundraising-tech-ops, Epic: Create job to deliver the eventlogging_LandingPageImpression topic - https://phabricator.wikimedia.org/T200449 (Jgreen) a:AndyRussG @AndyRussG can you confirm this is working as desired, and close or assign the task back to me based on what you find? [19:58:58] fr-tech anyone want to check this out? Would be great to try it out today: https://gerrit.wikimedia.org/r/449524 [20:01:11] ejegg, did you put through a manual test using a Adyen test env? [20:01:20] if so, could you send me over the paymentwiki settings? [20:02:04] DI settings sorry [20:07:59] jgleeson: sure, one sec [20:08:21] ccccccddfrjhgrtveureeckekiiuvivnbgfuujlvljlg [20:08:24] derp [20:08:41] sorry [20:09:01] although now I'm thinking I should just look on the paymentswiki server in the sandbox dir [20:09:12] for this type of thing [20:09:27] @_@ [20:09:30] jgleeson: yeah, the payments-wiki-testing dir does seem to have some adyen creds [20:09:36] awight: you around? [20:09:42] at the top of the 20-DI-accounts.php file [20:09:56] the plot's looking better than expected :-) [20:17:27] Fundraising-Backlog, fundraising-tech-ops: add primary keys or unique indexes to fundraising civicrm/drupal/pgehres database tables - https://phabricator.wikimedia.org/T176631 (Jgreen) I have two ideas for the civicrm.log* tables: we could add a new autoincrement primary key column, or we could do a two-... [20:22:25] fr-tech and here's the work for moving URLs out of i18n messages: [20:22:29] https://gerrit.wikimedia.org/r/449474 [20:22:33] https://gerrit.wikimedia.org/r/449477 [20:22:36] https://gerrit.wikimedia.org/r/449480 [20:23:43] Fundraising Sprint Owls, Fundraising-Backlog, MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review: 2018 Japan campaign: switch card processor to Adyen - https://phabricator.wikimedia.org/T200439 (Ejegg) Open>Resolved p:Triage>High a:Ejegg [20:24:08] Fundraising Sprint Owls, Fundraising-Backlog, MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review: Add explainer text to CC payment form (for banner checkbox experience) - https://phabricator.wikimedia.org/T200218 (Ejegg) Open>Resolved [20:24:32] Fundraising Sprint Owls, Fundraising-Backlog, Patch-For-Review: Adyen JCB 'invalid card' errors from donation form - https://phabricator.wikimedia.org/T200610 (Ejegg) p:Triage>High a:Ejegg [20:27:03] (CR) Mepps: [C: 2] Parameterize 'Other ways to give' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449474 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [20:27:45] (CR) Mepps: "Oops, can you add documentation like in the next patch?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449474 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [20:28:50] (CR) Ejegg: "The Other Ways to Give URL was already in settings and documented in the README - it just wasn't being used as a param in all the places t" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449474 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [20:28:57] (CR) Mepps: [C: 2] Parameterize 'Donor Policy' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449477 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [20:29:15] (CR) Mepps: [C: 2] Parameterize 'Other ways to give' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449474 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [20:30:47] (CR) Mepps: [C: 2] Escape special chars in Mustache URL params (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449480 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [20:31:52] (CR) Ejegg: Escape special chars in Mustache URL params (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449480 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [20:35:31] (PS1) Ejegg: Less repetition of logic in URL map [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449601 [20:36:11] (PS2) Ejegg: Less repetition of logic in URL map [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449601 [20:54:34] (PS1) Ejegg: Fix error msg with otherways URL, add instructions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449610 (https://phabricator.wikimedia.org/T108699) [20:55:52] mepps oops, I missed adding the parameter to one of the places I extracted the 'other ways' URL ^^^^^ [20:56:49] Fundraising-Backlog: Bahrain & Oman donation forms - minimum amount error - https://phabricator.wikimedia.org/T178402 (krobinson) We just got another ticket related to this issue: #461176: "I'm trying to donate 10.00 Bahraini Dinars (around 26.50 US dollars) but the website is saying it can't process amount... [20:56:58] (CR) Mepps: [C: 2] Fix error msg with otherways URL, add instructions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449610 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [20:58:38] Fundraising-Backlog: Bahrain & Oman donation forms - minimum amount error - https://phabricator.wikimedia.org/T178402 (Ejegg) Oh shoot, BHD is one of those currencies that takes three decimal points - I bet that has something to do with it. This is probably stopping us from getting anything at all in that cu... [20:59:30] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 5 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [21:05:03] holy zuul backlog, batman [21:05:29] there are patches in there waiting 2 hrs + [21:18:56] Fundraising-Backlog, fundraising-tech-ops: add primary keys or unique indexes to fundraising civicrm/drupal/pgehres database tables - https://phabricator.wikimedia.org/T176631 (Jgreen) >>! In T176631#4466885, @Jgreen wrote: > I have two ideas for the civicrm.log* tables: we could add a new autoincrement... [21:20:39] Fundraising-Backlog, fundraising-tech-ops: add primary keys or unique indexes to fundraising civicrm/drupal/pgehres database tables - https://phabricator.wikimedia.org/T176631 (Eileenmcnaughton) @Jgreen I agree that the existing columns are not unique enough :-( [21:28:24] (PS2) Ejegg: Fix error msg with otherways URL, add instructions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449610 (https://phabricator.wikimedia.org/T108699) [21:36:48] Fundraising-Backlog: Banner previews fail to load, occasionally - https://phabricator.wikimedia.org/T200853 (spatton) [21:39:41] Fundraising-Backlog: Banner previews occasionally fail to load - https://phabricator.wikimedia.org/T200853 (spatton) [22:08:33] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/449618 [22:09:45] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/449618 (owner: Eileen) [22:10:01] (PS1) Ejegg: WIP show opt-in interstitial for paypal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449620 (https://phabricator.wikimedia.org/T199281) [22:10:46] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/449618 (owner: Eileen) [22:11:57] (Merged) jenkins-bot: Parameterize 'Other ways to give' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449474 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [22:11:59] (Merged) jenkins-bot: Parameterize 'Donor Policy' URL in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449477 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [22:12:09] (Merged) jenkins-bot: Escape special chars in Mustache URL params [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449480 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [22:20:14] (CR) Ejegg: [C: 2] "Re-applying mepps's +2" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449610 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [22:36:22] (Merged) jenkins-bot: Fix error msg with otherways URL, add instructions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449610 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [22:52:30] Fundraising Sprint Owls, Fundraising-Backlog, Patch-For-Review: publish Oanda exchange rates to internal, private google doc - https://phabricator.wikimedia.org/T200227 (jgleeson) I've cloned the WMF expense report and updated this version to include a new formula that will work out the conversion ra... [22:56:37] !log update CiviCRM civicrm revision changed from 24b497072d to a0a7ea846a, config revision is 35a258d015 [22:56:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:00:22] Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: slow anonymous save - https://phabricator.wikimedia.org/T199753 (Eileenmcnaughton) @LeanneS @MBeat33 I just deployed this [23:04:58] (PS2) Jgleeson: WIP: Publish fundraising exchange_rates data to Finance Dept spreadsheet via Google Sheets API. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) [23:05:43] (PS4) Ejegg: Send brandCode to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449524 (https://phabricator.wikimedia.org/T200610) [23:06:00] (PS7) Ejegg: Get rid of traces of old 'optout' field. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/446207 (https://phabricator.wikimedia.org/T199278) [23:06:29] ejegg, I really underestimated how long it would take to finish the formulas, sorry man I haven't had a chance to review the adyen stuff but I'll jump on it first thing [23:06:43] (PS3) Ejegg: Less repetition of logic in URL map [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449601 [23:08:10] (PS2) Ejegg: Copy es messages to es-419 (Latin American) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/446054 (https://phabricator.wikimedia.org/T199682) [23:08:24] jgleeson: OK, no worries [23:08:34] maybe XenoRyet has time to take a look [23:08:55] XenoRyet: hoping to put up a possible fix for JCB / Adyen problems [23:09:05] https://gerrit.wikimedia.org/r/449524 [23:09:29] Do you have a little time to review that and try some sandbox Adyen txns locally? [23:09:45] well, I'll put up that i18n stuff for now [23:10:36] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/449630 [23:13:07] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/449630 (owner: Ejegg) [23:16:20] (PS1) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449633 [23:20:43] ccogdill: do you have any suggestions on the safest way to test a GDPR erasure request [23:20:54] I don’t much like testing deletes on a live DB [23:31:59] (CR) Ejegg: [C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449633 (owner: Ejegg) [23:32:14] eileen, @_@ [23:32:24] I scanned that and had to read it again [23:32:39] even fatigued, that stood out [23:32:48] because of the idea of testing deletes on a live DB? [23:33:00] yup [23:33:08] what can go wrong? [23:33:21] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/449630 (owner: Ejegg) [23:33:33] yeah - so we upload a csv which looks like Email, email@example.com [23:33:48] so in theory it’s safe but.... [23:34:47] (Merged) jenkins-bot: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449633 (owner: Ejegg) [23:40:45] have a good evening fr-tech! [23:41:38] !log updated payments-wiki from 6afaca3de3 to 626ff1cb72 [23:41:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log