[00:07:36] (CR) jenkins-bot: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449633 (owner: Ejegg) [00:09:35] ejegg|away: Sorry I missed that ping, had my sound off and the IRC window was hiding. I'll look at that first thing in the morning if it still needs it. [01:38:48] With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/ [01:38:49] I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ [01:38:50] With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/ [01:38:50] I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ [01:38:50] Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate [01:38:50] Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate [01:38:54] A fascinating blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ [01:38:54] A fascinating blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ [07:55:40] Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: contribs export failing for DS agent - https://phabricator.wikimedia.org/T196569 (Eileenmcnaughton) From Kristie: " Hey both! So it would appear I can do this a... [07:56:00] Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: contribs export failing for DS agent - https://phabricator.wikimedia.org/T196569 (Eileenmcnaughton) Open>Resolved [10:33:04] (PS3) Jgleeson: WIP: Publish fundraising exchange_rates data to Finance Dept spreadsheet via Google Sheets API. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) [10:55:20] (PS4) Jgleeson: WIP: Publish fundraising exchange_rates data to Finance Dept spreadsheet via Google Sheets API. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) [12:04:25] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner previews occasionally fail to load - https://phabricator.wikimedia.org/T200853 (Pcoombe) I've seen the same issue occasionally in the past few days. Didn't see anything in the browser console when it happened. [12:27:44] Fundraising-Backlog: Nothing in pgehres.bannerimpressions table since 2018-07-31 18:29:00 - https://phabricator.wikimedia.org/T200896 (Pcoombe) p:Triage>High [17:00:14] pcoombe: aha, the filename format was changed when the job restarted [17:00:21] a dot changed to a dash [17:00:27] or vice versa [17:01:08] we should really stop using morse code for filename /s [17:31:54] https://phabricator.wikimedia.org/search/query/hMt6xoUUcMGh/ [17:36:06] Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: slow anonymous save - https://phabricator.wikimedia.org/T199753 (LeanneS) Thanks @Eileenmcnaughton! [17:42:20] (PS1) Ejegg: Loosen filename regex [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/449773 (https://phabricator.wikimedia.org/T200896) [17:42:38] fr-tech anybody able to look at that real quick ^^^ ? [17:43:15] looking [17:44:39] (CR) XenoRyet: [C: 2] Loosen filename regex [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/449773 (https://phabricator.wikimedia.org/T200896) (owner: Ejegg) [17:44:58] (Merged) jenkins-bot: Loosen filename regex [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/449773 (https://phabricator.wikimedia.org/T200896) (owner: Ejegg) [17:47:01] !log updated DjangoBannerStats from 43e47f98a2 to 73d74f1b5e [17:47:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:58:18] (PS1) Ejegg: Loosen filename format in more places [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/449776 (https://phabricator.wikimedia.org/T200896) [17:59:24] fr-tech oops, that last patch only fixed the backfill job [17:59:40] but this one ^^^ should fix the scheduled runs [17:59:46] anyone able to look at that? [18:25:44] Seddon: Pacific [18:30:01] (CR) XenoRyet: [C: 2] Loosen filename format in more places [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/449776 (https://phabricator.wikimedia.org/T200896) (owner: Ejegg) [18:30:20] (Merged) jenkins-bot: Loosen filename format in more places [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/449776 (https://phabricator.wikimedia.org/T200896) (owner: Ejegg) [18:38:10] Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Test & deploy Coleman's contact summary work - https://phabricator.wikimedia.org/T199410 (Ejegg) p:Triage>Normal a:Eileenmcnaughton [18:49:29] !log updated DjangoBannerStats from 73d74f1b5e to 02be6cbb74 [18:49:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:12:55] (CR) XenoRyet: [C: 2] "Jgleeson: Yea, the return URL is something that gets set in the Adyen console." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449524 (https://phabricator.wikimedia.org/T200610) (owner: Ejegg) [19:29:30] (Merged) jenkins-bot: Send brandCode to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449524 (https://phabricator.wikimedia.org/T200610) (owner: Ejegg) [19:35:49] (PS1) Ejegg: Parameterize support email in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449799 (https://phabricator.wikimedia.org/T108699) [19:37:37] Fundraising Sprint Owls, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy, and 3 others: WMF-specific links and emails should be in LocalSettings - https://phabricator.wikimedia.org/T108699 (Ejegg) @pcoombe OK, here's the final list of messages that will need to take the email as... [19:38:06] fr-tech are y'all meeting in the old hangout? [19:38:24] hmm, nope, that's empty too [19:38:40] I'll stick around in the new one in case anyone wants to fr-tech-talk [19:40:59] (PS8) Ejegg: Get rid of traces of old 'optout' field. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/446207 (https://phabricator.wikimedia.org/T199278) [19:41:59] (PS2) Ejegg: Parameterize support email in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449799 (https://phabricator.wikimedia.org/T108699) [19:42:52] (PS3) Ejegg: Copy es messages to es-419 (Latin American) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/446054 (https://phabricator.wikimedia.org/T199682) [19:45:08] so... if there's no tech talk today, I'mma relocate [20:01:39] oh sorry ejegg i missed that on the calendar [20:08:05] (PS1) Ejegg: Update default support email [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/449811 [20:12:02] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/449872 [20:12:05] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/449872 (owner: Ejegg) [20:12:47] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449873 [20:13:02] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449873 (owner: Ejegg) [20:13:50] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/449872 (owner: Ejegg) [20:16:02] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449873 (owner: Ejegg) [20:17:28] !log updated payments-wiki from 626ff1cb72 to 0c9c24d30c [20:17:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:23:58] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/449873 (owner: Ejegg) [20:34:07] Fundraising Sprint Owls, Fundraising-Backlog, Patch-For-Review: Nothing in pgehres.bannerimpressions table since 2018-07-31 18:29:00 - https://phabricator.wikimedia.org/T200896 (Ejegg) OK, looks like this is working again [20:38:07] Fundraising Sprint Owls, Fundraising-Backlog, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review: Adyen JCB 'invalid card' errors from donation form - https://phabricator.wikimedia.org/T200610 (Ejegg) @MBeat33 we just deployed the patch to send the brandCode along wit... [20:42:49] (CR) Mepps: [C: 2] Get rid of traces of old 'optout' field. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/446207 (https://phabricator.wikimedia.org/T199278) (owner: Ejegg) [20:44:38] (Merged) jenkins-bot: Get rid of traces of old 'optout' field. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/446207 (https://phabricator.wikimedia.org/T199278) (owner: Ejegg) [20:50:18] Fundraising Sprint Owls, Fundraising-Backlog, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review: Adyen JCB 'invalid card' errors from donation form - https://phabricator.wikimedia.org/T200610 (MBeat33) Awesome, thank you @Ejegg I appreciate this rolling out before to... [20:55:31] (PS1) Ejegg: Update opt-in text to version approved by Legal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449876 (https://phabricator.wikimedia.org/T200439) [20:57:16] fr-tech: I could do some code review. What needs looking at most? [20:59:52] Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: slow anonymous save - https://phabricator.wikimedia.org/T199753 (LeanneS) @Eileenmcnaughton I just received a note from Chris that the anonymous record isn't working at all for them now. It shows as a blank page for them. Co... [21:01:05] (PS2) Ejegg: Update opt-in text to version approved by Legal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449876 (https://phabricator.wikimedia.org/T200439) [21:01:05] (PS1) Ejegg: Re-enable opt_in buttons for GB and IE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449877 (https://phabricator.wikimedia.org/T200610) [21:01:27] XenoRyet: the first of those is ready, I think ^^^ [21:01:34] 10-4 [21:02:05] plus this tiny thing: https://gerrit.wikimedia.org/r/449811 [21:02:40] (CR) XenoRyet: [C: 2] Update default support email [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/449811 (owner: Ejegg) [21:02:49] then this one will require a careful eye to make sure I haven't missed any place the parameter needs to be supplied: https://gerrit.wikimedia.org/r/449799 [21:03:17] Cool, I'll give that a look as well. [21:07:49] (CR) Pcoombe: "Wrong bug number in the commit message I think?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449876 (https://phabricator.wikimedia.org/T200439) (owner: Ejegg) [21:08:42] (Merged) jenkins-bot: Update default support email [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/449811 (owner: Ejegg) [21:08:46] Fundraising Sprint Owls, Fundraising-Backlog, Patch-For-Review: Nothing in pgehres.bannerimpressions table since 2018-07-31 18:29:00 - https://phabricator.wikimedia.org/T200896 (Pcoombe) Open>Resolved a:Pcoombe Yes, looks good to me now. Thanks! [21:10:00] (PS3) Ejegg: Update opt-in text to version approved by Legal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449876 (https://phabricator.wikimedia.org/T199278) [21:10:02] (PS2) Ejegg: Re-enable opt_in buttons for GB and IE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449877 (https://phabricator.wikimedia.org/T199278) [21:10:29] (CR) Ejegg: "Thanks PCoombe, fixed it!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449876 (https://phabricator.wikimedia.org/T199278) (owner: Ejegg) [21:20:42] (CR) Ejegg: "Note to other reviewers: if you get this error:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/447563 (owner: Eileen) [21:24:17] (CR) XenoRyet: [C: 2] "Form says what it's supposed to say. Looks good to me." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449876 (https://phabricator.wikimedia.org/T199278) (owner: Ejegg) [21:33:11] mepps: do you know which menu to use to enable the Shoreditch theme once you've installed the extension? [21:33:16] or eileen ^^^ ? [21:33:59] ejegg: administer/system settings/resource urls [21:34:06] ooh, sneaky [21:34:37] just the 'Custom CSS URL' then? [21:35:01] looking good... [21:35:28] or.... not entirely [21:35:44] stuff on the contact screen is very squished horizontally [21:36:17] like it only wants to use the middle third of the screen [21:36:27] lessee if some force-reloading is needed [21:37:23] eileen: does shoreditch give you vast white spaces on both sides of the content too? [21:37:43] hmm - the same as on staging? [21:38:01] ah, no, staging goes all the way out to the side [21:38:06] hmm [21:38:08] is that a different drupal theme then? [21:38:26] I enabled a different theme on staging at the drupal level but I don’t htink that is it [21:40:12] eileen: the 'seven' theme definitely dows make my local look a lot more like frdev [21:40:39] hmm, seems to hide the recent contacts though [21:40:45] ejegg: yeah I think I have another one on frdev - trying to think of the name of it [21:41:17] Tivy, looks like [21:41:21] I'll snag that then [21:42:35] (Merged) jenkins-bot: Update opt-in text to version approved by Legal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449876 (https://phabricator.wikimedia.org/T199278) (owner: Ejegg) [21:43:22] eileen: oh hey, there's a bootstrap-drupal theme [21:43:57] I think shoreditch is a trendy london suburb & tivy is …. a suburb [21:45:17] not finding Tivy on https://www.drupal.org/project/project_theme [21:45:37] should the civi extension somwhow have made it available to drupal? [21:47:14] aha: https://github.com/3sd/tivy [21:47:46] eileen: let's add that to our drupal repo [21:49:13] ejegg: sure - we haven’t made any decisions about changing to the shoreditch look but our current preferreds at least make it easier to demo options [21:49:53] eileen: ah, we don't need shoreditch to use the contact view editor? [21:50:09] ejegg: we need the extension but not the ‘look’ [21:50:25] the extension adds some bootstrap stuff [21:50:54] ok, and the contact layout editor can load the css without changing that resource url? [21:51:14] yep [21:51:29] Nora was keen on the look change but we’d need to see what others think [21:52:28] (CR) Ejegg: "More testing notes" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/447563 (owner: Eileen) [21:52:38] eileen: ok, cool [21:53:20] I think coleman said he had a fix for those misplaced menu triangles when the ext was installed without the css enabled, right? [21:54:12] ejegg: yeah - it’s merged to the next core release I think [21:54:17] pretty sure I merged it [21:54:25] or it might be to the release about to go rc [21:54:39] ah, cool, it's core and not in the shoreditch extn [21:56:28] (PS3) Ejegg: Parameterize support email in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449799 (https://phabricator.wikimedia.org/T108699) [21:57:33] (PS4) Ejegg: Copy es messages to es-419 (Latin American) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/446054 (https://phabricator.wikimedia.org/T199682) [22:20:01] (CR) XenoRyet: [C: 2] Parameterize support email in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449799 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [22:21:41] (Merged) jenkins-bot: Parameterize support email in messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449799 (https://phabricator.wikimedia.org/T108699) (owner: Ejegg) [22:30:26] this one should be a doddle too: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/446054 [22:40:28] (CR) XenoRyet: [C: 2] Copy es messages to es-419 (Latin American) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/446054 (https://phabricator.wikimedia.org/T199682) (owner: Ejegg) [22:50:26] (Merged) jenkins-bot: Copy es messages to es-419 (Latin American) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/446054 (https://phabricator.wikimedia.org/T199682) (owner: Ejegg) [22:58:49] Heh, I just looked at the clock and thought 'Well, time to knock off for the day' and then realized it was 4:00 Pacific, not 5:00... [23:02:00] (PS1) Ejegg: Support lots of country tlds for yahoo, hotmail, and outlook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449900 [23:04:05] (PS2) Ejegg: Support lots of country tlds for yahoo, hotmail, and outlook [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449900 [23:04:39] If you're looking for more stuff to review, there's the Ingenico audit / recururring tokenization job thing! [23:05:02] starts with this: https://gerrit.wikimedia.org/r/448808 [23:05:14] then the real logic is here: https://gerrit.wikimedia.org/r/448820 [23:05:44] and this gets the test code out of the prod codepath: https://gerrit.wikimedia.org/r/449245 [23:05:52] XenoRyet: ^^ [23:06:48] (PS3) Ejegg: Re-enable opt_in buttons for GB and IE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449877 (https://phabricator.wikimedia.org/T199278) [23:07:05] (PS12) Ejegg: Truncate referrers when hosts match a pattern [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/232218 (https://phabricator.wikimedia.org/T110564) [23:07:20] Yea, I'll take a peek at those, see how far I get. [23:07:24] thanks [23:47:55] Fundraising-Backlog, fundraising-tech-ops: add primary keys or unique indexes to fundraising civicrm/drupal/pgehres database tables - https://phabricator.wikimedia.org/T176631 (Jgreen) Adding a log_id column to every log_* table took 249m14.875s on frdev1001's dev_civicrm database, I think that should gi... [23:50:04] Fundraising-Backlog, fundraising-tech-ops: add primary keys or unique indexes to fundraising civicrm/drupal/pgehres database tables - https://phabricator.wikimedia.org/T176631 (Eileenmcnaughton) That's a lot better timing that we anticipated - yay