[00:01:31] Okay we should find time to talk on Monday [00:01:53] My Monday 😀 [00:23:37] (PS1) Eileen: Port activity tab performance fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/450175 (https://phabricator.wikimedia.org/T201008) [00:31:20] (PS1) Eileen: Revert "Activity tab performance - switch from deprecatedGetActivitiesCount to getActivitiesCount" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/450177 (https://phabricator.wikimedia.org/T199753) [00:32:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: some CIDs not opening - https://phabricator.wikimedia.org/T201008 (Eileenmcnaughton) I just pushed up a patch https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/450175/ and also deployed it on staging Th... [00:32:55] mepps: I just put up 2 alternatives for dealing with the regression T201008 [00:32:56] T201008: Civi: some CIDs not opening - https://phabricator.wikimedia.org/T201008 [00:33:20] one is ‘the fix’ - the other is just a ‘revert & worry about it next week option' [00:33:45] if you have an opinion that we should do the latter we could merge & deploy now [02:02:33] looking at 'the fix' [02:14:48] (CR) Ejegg: [C: 2] "Sure, this seems like an improvement! Nice to have the getCount method not depend on the more complex one." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/450175 (https://phabricator.wikimedia.org/T201008) (owner: Eileen) [02:16:05] (PS1) Ejegg: Update CiviCRM submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450182 [02:16:15] (CR) Ejegg: [C: 2] Update CiviCRM submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450182 (owner: Ejegg) [02:16:24] (CR) jerkins-bot: [V: -1] Update CiviCRM submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450182 (owner: Ejegg) [02:17:03] (PS1) Ejegg: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450183 [02:17:17] (CR) Ejegg: [C: 2] Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450183 (owner: Ejegg) [02:20:50] (Merged) jenkins-bot: Port activity tab performance fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/450175 (https://phabricator.wikimedia.org/T201008) (owner: Eileen) [02:20:52] (CR) jerkins-bot: [V: -1] Update CiviCRM submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450182 (owner: Ejegg) [02:22:49] (CR) jerkins-bot: [V: -1] Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450183 (owner: Ejegg) [02:23:18] (CR) jerkins-bot: [V: -1] Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450183 (owner: Ejegg) [02:24:20] (CR) Ejegg: [C: 2] Update CiviCRM submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450182 (owner: Ejegg) [02:24:39] wow, 'Start Review' is the button to undo 'Work in Progress' [02:24:48] really intuitive, gerrit... [02:25:15] (Merged) jenkins-bot: Update CiviCRM submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450182 (owner: Ejegg) [02:25:17] (CR) Ejegg: [C: 2] Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450183 (owner: Ejegg) [02:31:05] (Merged) jenkins-bot: Update CiviCRM submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450183 (owner: Ejegg) [02:35:51] !log updated CiviCRM from a0a7ea846a to 03012506b9 [02:35:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:44:14] Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: some CIDs not opening - https://phabricator.wikimedia.org/T201008 (Ejegg) Looks like @Eileenmcnaughton's fix was the real deal! Just deployed it, and all of the cids mentioned in this ticket are l... [02:44:38] Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: some CIDs not opening - https://phabricator.wikimedia.org/T201008 (Ejegg) p:Triage>High a:Eileenmcnaughton [02:46:54] thanks for porting that fix over eileen! [02:47:02] seems to be working like a charm [02:48:00] (Abandoned) Ejegg: Revert "Activity tab performance - switch from deprecatedGetActivitiesCount to getActivitiesCount" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/450177 (https://phabricator.wikimedia.org/T199753) (owner: Eileen) [02:48:13] thanks ejegg|away [06:09:04] With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/ [06:09:05] I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ [06:09:08] Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate [06:09:11] A fascinating blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ [07:04:54] With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/ [07:04:58] I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ [07:05:07] Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate [07:05:07] A fascinating blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ [11:20:12] Fundraising Sprint Owls, Fundraising-Backlog, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review: Adyen JCB 'invalid card' errors from donation form - https://phabricator.wikimedia.org/T200610 (MBeat33) [[ https://docs.google.com/spreadsheets/d/1pQcXdK0300nS7KoIvE6GdT... [11:26:19] Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: some CIDs not opening - https://phabricator.wikimedia.org/T201008 (MBeat33) Thanks, @Eileenmcnaughton & @Ejegg, this is excellent. [14:18:56] wow that spam is weird [14:54:12] (CR) Mepps: [C: 1] "Just one comment and then I can approve it if you think it's okay to leave in the extra comment fix ejegg." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449877 (https://phabricator.wikimedia.org/T199278) (owner: Ejegg) [14:56:16] (CR) Mepps: Robust-ify needsTokenizing logic (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/448832 (https://phabricator.wikimedia.org/T195337) (owner: Ejegg) [15:07:02] (CR) Mepps: "Questions because I'm missing the context" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449944 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [15:07:20] (CR) Ejegg: "answered inline, mepps" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449877 (https://phabricator.wikimedia.org/T199278) (owner: Ejegg) [15:07:39] (CR) Mepps: [C: 2] Re-enable opt_in buttons for GB and IE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449877 (https://phabricator.wikimedia.org/T199278) (owner: Ejegg) [15:07:48] thanks ejegg! [15:07:52] thank you! [15:09:26] (Merged) jenkins-bot: Re-enable opt_in buttons for GB and IE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449877 (https://phabricator.wikimedia.org/T199278) (owner: Ejegg) [15:10:41] ejegg did you or eileen get her fix reviewed last night? [15:10:55] mepps I took a look at the fix and the rollback [15:11:11] the fix looked good [15:11:19] makes the getCount call just use the getCount API [15:11:53] and just shares the code to get the rest of the parameters with the getActivities call [15:12:05] so it seemed worth going forward [15:12:23] the anon contact loads quickly too now [15:15:08] (CR) Ejegg: "Want to make the removal of do_finishpayment explicit in the commit message? It seems to be designed specifically for people doing 3d-secu" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444311 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [15:19:16] (CR) Mepps: "Ejegg do you mean the comment in the code or the comment in the commit message?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444311 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [15:19:28] awesome ejegg re:eileen's fix [15:28:13] (CR) Mepps: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445534 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [15:29:25] (Abandoned) Mepps: Add returnUrl, remove returnTitle [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/441423 (https://phabricator.wikimedia.org/T163949) (owner: Mepps) [16:06:17] (CR) Ejegg: "I mean actually delete it from the code, and explain in the commit message that we never use it." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444311 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [17:14:51] fr-tech just uploaded a bit moar, thx in advance for any suggestions/comments/flying rotten tomatoes! https://github.com/AndrewGreen/fr_user_event_consumer [17:22:23] Thx in advance! [17:22:36] K off to last-minutely-changed kid pickup time... [18:21:04] (CR) Mepps: "Ejegg I remove it in a later commit but I can make the comment explicit there." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444311 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [18:22:38] (PS7) Mepps: Trying to simplify logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/446187 [18:23:24] (PS9) Mepps: WIP Refactor of ConfirmCreditCard to handle pending flag [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444311 (https://phabricator.wikimedia.org/T194517) [18:23:27] (PS3) Mepps: Consolidate flags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445534 (https://phabricator.wikimedia.org/T194517) [18:23:28] (PS8) Mepps: WIP Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) [18:23:30] (PS8) Mepps: Trying to simplify logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/446187 [18:27:43] (PS9) Mepps: WIP Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) [18:29:40] (CR) jerkins-bot: [V: -1] WIP Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [18:31:05] (PS10) Mepps: WIP Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) [18:32:37] (CR) jerkins-bot: [V: -1] WIP Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [18:35:22] (Abandoned) Mepps: Trying to simplify logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/446187 (owner: Mepps) [18:35:44] (PS11) Mepps: WIP Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) [18:58:48] /nick AndyRussG [19:01:13] fr-tech anyone know about Python unit testing? Just trying to understand what Pythonic+testable+KISS would be in this case... [19:02:10] thx in advance for any thoughts/suggestions!!! :) [19:13:44] AndyRussG: nosetests is what we use in the tools repo [19:28:24] Fundraising Sprint Naming Sprints Is Not Important, Fundraising-Backlog, Patch-For-Review: Investigate why Ingenico donation did not recur on 6/14 - https://phabricator.wikimedia.org/T199331 (MBeat33) Resolved>Open @Ejegg I'm reopening this, as it looks like these restarted recurring donation... [19:56:42] ejegg: ah oki important to note! [19:57:26] any idea if it's easier to mock an instance of a class (such as LogFileManager) than an imported module? [20:00:19] ejegg: is this the one? nose2? https://github.com/nose-devs/nose2 [20:05:15] or this? http://nose.readthedocs.io/en/latest/ [20:05:33] looks like plain nose (not nose2) is headed for deprecation? [20:06:47] Hmmm looks like just noe [20:16:14] also https://sqa.stackexchange.com/questions/26184/pros-and-cons-of-python-unit-testing-packages/27669#27669 [20:16:23] https://docs.pytest.org/en/latest/ [20:16:31] is recommended over either in that post... [20:46:37] AndyRussG: I think we're using nose2 at this point... [20:46:45] sorry for the delay [20:47:20] hmm, though test-requirements.txt just asks for nose [20:47:55] ejegg: k thx! yeah that's what I saw [20:48:37] the same SO post ^ sez pytest is compatible with nose [20:48:40] not sure what that means tho [20:49:07] so perhaps that needs an upgrade [21:00:16] ejegg: fr-tech eventually we'll have to decide which framework... though what I'm mainly worried about now is just how anything about the code layout might impact testability [21:01:14] For example, now LogFileManager is a class that provides a service (so in practices used as a singleton) with just one method, no state needed: https://github.com/AndrewGreen/fr_user_event_consumer/blob/master/fr_user_event_consumer/log_file_manager.py [21:01:26] (though it could be broken down) [21:01:34] (into more methods) [21:01:45] ^ implicit parenthetical expression concatenation [21:02:08] I feel like the typical pythonic way for that is just to make a module and a function [21:02:11] AndyRussG: so, we need some way to swap it out? [21:02:19] yea that's the question [21:02:26] So right now, there is such a way [21:02:42] https://github.com/AndrewGreen/fr_user_event_consumer/blob/master/fr_user_event_consumer/central_notice_consumer_controller.py [21:03:09] It's used by the controller and in tests we can just put the mock there in the corresponding controller property... I think? [21:03:21] Or can we swap it out if it's just a module+function? [21:03:34] Or in summary, I need to understand how we'll swap in mocks in the tests [21:03:41] and I don't know if that varies from framework to framework [21:04:19] I think mock.patch is pretty versatile for swapping out fake functions [21:05:12] Hmmm [21:05:18] is that something used in all the frameworks? [21:06:00] mock is a standalone package I think [21:06:58] https://medium.com/uckey/how-mock-patch-decorator-works-in-python-37acd8b78ae [21:09:37] ejegg: okok I think I got it ;p [21:09:47] anyway lots to dig into...! thx!!!!! [21:10:28] I'll take a dive and return with a mouldy penny that we can mock [21:10:40] or will try to.... [21:13:38] sorry, looks like we're not actually using the decorator there [21:14:21] oh wait, we're using it some places and not others [21:17:10] ah hmmmm okok [22:28:06] (CR) Eileen: "mepps - both very good questions!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449944 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [22:35:21] This channel has been hacked by Australia's #1 hacker Simon 'eVestigator' Smith https://evestigatorsucks.com/ [22:35:25] With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/ [22:35:28] I thought you guys might be interested in this blog by freenode staff member Bryan 'kloeri' Ostergaard https://bryanostergaard.com/ [22:35:32] Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate [22:35:35] A fascinating blog by freenode staff member Matthew 'mst' Trout https://MattSTrout.com/ [22:39:52] ejegg: there it is ^ [22:40:09] oh fun [22:41:16] hnrgggh [23:54:30] ejegg|away, you can /invite Sigyn (an antispam bot), which might help. [23:55:34] Looks like we just locked everything down again because it was so widespread [23:56:12] thanks foks [23:56:33] np. She can be a bit slow to actually k-line / kick [23:56:39] but yeah [23:57:14] and in future you can /mode #wikimedia-fundraising +r which blocks unidentified users, which is basically what is set globally just now