[08:49:15] (PS1) Umherirrender: Improve param docs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/450519 [11:11:21] (CR) Umherirrender: "recheck" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/448314 (owner: Libraryupgrader) [11:40:09] (PS2) Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 21.0.0 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/448314 (owner: Libraryupgrader) [11:40:13] (CR) Umherirrender: [C: 2] build: Updating mediawiki/mediawiki-codesniffer to 21.0.0 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/448314 (owner: Libraryupgrader) [13:30:52] (CR) Mepps: [C: 2] Improve param docs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/450519 (owner: Umherirrender) [13:52:15] (CR) Mepps: "This looks good, any plans for tests?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 (owner: Eileen) [13:56:55] (CR) Mepps: [C: 2] Fix impossible test for recurring (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446714 (owner: Ejegg) [13:57:08] (CR) Mepps: [C: 2] "Ejegg note comment on here." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446714 (owner: Ejegg) [14:04:44] (Merged) jenkins-bot: Improve param docs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/450519 (owner: Umherirrender) [14:06:27] (Merged) jenkins-bot: Fix impossible test for recurring [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/446714 (owner: Ejegg) [14:09:44] Fundraising Sprint Owls, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy, and 3 others: WMF-specific links and emails should be in LocalSettings - https://phabricator.wikimedia.org/T108699 (Pcoombe) Thanks @Ejegg. We use `donate_interface-monthly-cancel` in donatewiki, I've adde... [14:31:42] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450577 [14:32:01] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450577 (owner: Ejegg) [14:32:08] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450577 (owner: Ejegg) [14:32:32] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450577 (owner: Ejegg) [14:37:15] oops, need to update vendor [14:38:35] (PS1) Ejegg: Update SmashPig and DonationInterface libs [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/450578 [14:38:43] (CR) Ejegg: [C: 2] Update SmashPig and DonationInterface libs [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/450578 (owner: Ejegg) [14:38:56] (PS2) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450577 [14:39:16] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450577 (owner: Ejegg) [14:45:01] (Merged) jenkins-bot: Update SmashPig and DonationInterface libs [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/450578 (owner: Ejegg) [14:53:05] hnrrrrrrgghh [14:53:31] type type type -> sleep -> wake up -> refactor [14:56:51] all code bits must simple! [14:56:53] incremental progress! :) [15:03:39] jgleeson: followed by implosion and rebuilding...... [16:00:34] (PS5) Jgleeson: WIP: Publish fundraising exchange_rates data to Finance Dept spreadsheet via Google Sheets API. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) [16:03:54] (CR) jerkins-bot: [V: -1] WIP: Publish fundraising exchange_rates data to Finance Dept spreadsheet via Google Sheets API. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) (owner: Jgleeson) [16:06:13] (PS6) Jgleeson: Publish fundraising exchange_rates data to Finance Dept spreadsheet via Google Sheets API. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) [16:06:53] (CR) Jgleeson: "in the latest patch, it handles missing exchange rate data by converting them blank cells within the spreadsheet output, preserving the st" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) (owner: Jgleeson) [16:18:09] ejegg, I'm about to start testing fundraising/REL1_31, any tips before I jump in? [16:27:05] jgleeson: nothing in particular, just run it through its paces! [16:38:15] Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: slow anonymous save - https://phabricator.wikimedia.org/T199753 (LeanneS) @Eileenmcnaughton @cwdent Thanks for your help with this fix. The latest from Chris is that the change sped up the page load to... [16:46:38] Fundraising-Backlog: Amazon nightly download timing out - https://phabricator.wikimedia.org/T201330 (mepps) [16:48:53] (PS1) Ejegg: Add Tivy theme to go with the Civi Shoreditch stuff [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/450614 [16:52:46] fr-tech: sounds like Civi users are pretty psyched about the new UI that's been up on staging for a while [16:53:19] awesome ejegg! [16:53:26] Most of the components are already merged since the contact layout editor depended on them [16:53:47] there's just this one bit of styling at the drupal level needed: https://gerrit.wikimedia.org/r/450614 [16:55:38] ejegg did you see my comments on this patch: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/444311/ [16:55:44] or reply to your comment [16:56:09] yeah! sorry, I owe you another look at it [16:57:18] I guess we'll want to make sure this all gets merged within a short period of time [17:03:13] mepps: sorry, silly nitpick, but can we get the whitespace flapping fixed? [17:07:18] ejegg, is that the Shoreditch theme? [17:07:55] https://civicrm.org/blog/jamienovick/going-shoreditch-civicrms-new-ux-design-comes-to-life-pt-1-of-2 [17:09:11] jgleeson: it's a drupal theme that complements the shoreditch civicrm theme [17:09:39] ah cool! [17:09:42] when you just deploy the shoreditch civi theme without the drupal tivy theme, it leave a lot of blank space around both sides and squishes lots of data [17:10:04] sorry, lemme add a comment about how to enable the tivy theme once you check that patch out [17:12:17] (PS2) Ejegg: Add Tivy theme to go with the Civi Shoreditch stuff [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/450614 [17:15:28] (PS10) Mepps: Refactor of ConfirmCreditCard to handle pending flag [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444311 (https://phabricator.wikimedia.org/T194517) [17:15:30] (PS4) Mepps: Consolidate flags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445534 (https://phabricator.wikimedia.org/T194517) [17:15:32] (PS12) Mepps: WIP Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) [17:29:02] Fundraising-Backlog: Amazon nightly download timing out - https://phabricator.wikimedia.org/T201330 (mepps) Sent an email to our rep. [17:48:54] cacheable vs. cachable? the first, no? [17:49:09] hrrrmmnnn don't ask!!! [18:05:07] yah, the first! [18:08:13] okok thx [18:08:41] heheh correctly spelled spaghetti is the best [18:10:05] hi MBeat! you around? [18:10:39] sure thing, what’s up? saurabhbatra [18:11:11] i needed some help figuring out the meaning of fields in the chargebacks and metrics sheet [18:11:24] i'm looking at monthly gc transactions [18:12:21] which column? [18:13:27] MBeat: # stopped at gc600, 600s settled, gc fraud refunded, gc chargebacks [18:14:12] i think i have a slight idea but i want to be sure coz don't want to quote bad stats [18:14:37] the first is the total stopped by our filters, whether or not we manually settled them [18:14:49] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: List of DonationInterface messages used in banners/donatewiki - https://phabricator.wikimedia.org/T166346 (Ejegg) Ooh, thanks! This is super helpful. [18:15:02] 600s settled is the total we settled (pushed through to 800) either proactively or at donor request [18:15:26] gc fraud refunded is what we proactively identified from our scans and refunded [18:17:30] GC chargebacks is a wider category, it includes actual chargebacks that came from Ingenico at status 1500, but also chargeback alterts from Ingenico and Ethoca that we were able to act on (refund) before we received a chargeback. Basically, a refund is cheaper for us than a chargeback, so if we can refund them before they become chargebacks it’s worth it. I count them as chargebacks partly because if we didn’t refund, that’s wha [18:17:31] they’d become, and to help measure the success of our fraud detection [18:19:09] If you look in the GC Chargebacks tab, anything with a long ID # in Column O is an Ethoca alert [18:19:32] MBeat: GC chargebacks only includes transactions marked as chargeback before you manually look into them? [18:20:06] no, the GC chargebacks tab is also where we track the ones we refund after manually looking into them [18:21:00] but if you filter out the ones w/IDs in Col O you can get a better number of the straightup chargebacks [18:21:00] is the set independent from "# stopped at gc600"? [18:21:23] yes, almost none of the Chargebacks will have been stopped at GC600 [18:21:58] chargebacks are mostly fraud we missed, and some donor confusion (kid did it w/out telling parent, etc) [18:22:15] ah, i think i understand [18:22:32] "# gc chargebacks" are "successful" fraud attempts [18:23:00] when we were unable to identify it as fraud before incurring chargeback fees [18:23:06] on the refund [18:23:14] alas, yes :) [18:23:53] thanks! :-) [18:26:51] np [18:41:53] https://i.redd.it/u632e2bzvpd11.png [18:42:56] ah I am glad to hear less of that [18:43:46] lets work "smarter" [18:43:49] :) [18:52:49] MBeat: quick question - # 600s settled is transactions which have been approved as wrongly flagged by the filters? [18:53:40] yes, you got it saurabhbatra [18:54:05] there seem to be some inconsistencies though... [18:54:20] although i'm probably making some mistakes in my calculations [18:55:37] "(# stopped at gc600 - # 600s settled)" should give me transactions correctly flagged as fraud by our filters... [18:55:46] MBeat: right? [18:57:24] it should, yes - though there are occasional hiccups where the Orphan rectifier may have an issue, or was not deployed (like for recent Ingenico integration tests) [18:57:49] if you look at the GC600s doc, lines shaded in tan will be those exceptions, saurabhbatra [18:59:42] ah yes, it was indeed a mistake in my calculations [18:59:49] sorry for the bother! [19:04:36] ah, cool - np [20:52:48] ejegg, I'll see if I can work it out, if not I'll catch you tomorrow as I might be off before you finish your 1:1 [21:19:46] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 6 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [21:22:55] have a good evening fr-tech! [21:58:20] (CR) Eileen: "mepps yep - I put tests in the upstream repo (which run via travis) on this one https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/c" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 (owner: Eileen) [22:07:11] (PS1) Eileen: Components for new contact editor [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450872 [22:08:20] I went to do a merge to deployment but I’m not quite sure if there is some complexity in the patches pending deploy [22:08:45] I just cherry-picked the one with the extensions as that gets the actual code out of the mix for all of that lot [22:09:05] some of the confusion might be local.... [22:09:06] eileen: ah, sorry [22:09:10] I was about to deploy [22:09:18] ejegg: ah - I’ll kill that cherrypick [22:09:22] & leave it to you [22:09:26] then zuul started complaining [22:09:34] (Abandoned) Eileen: Components for new contact editor [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450872 (owner: Eileen) [22:10:03] no, I got distracted, my fault. Will get that out now! [22:10:11] I spotted a few new tests & also a change to phpunit.dist which arguably should not be in deployment [22:10:43] looks like you filtered out the tests [22:11:09] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450577 (owner: Ejegg) [22:11:15] it was that vendor change I was least sure about - so you have that sorted [22:11:54] yeah, updating SmashPig to enable the new queue for ingenico donation post-processing [22:12:58] oh, shall we push Tivy out too, so it's just a settings change to go to the new UI? https://gerrit.wikimedia.org/r/450614 [22:14:08] eileen: ^^ [22:14:43] ejegg: yeah Tivy is an optional extra but since we are leaning towards it lets’ make it easy to view & test [22:15:04] ejegg: ALSO it’s possible at the drupal level for people to choose their own themes - a small extension [22:15:13] ah, neat [22:15:15] (CR) Eileen: [C: 2] Add Tivy theme to go with the Civi Shoreditch stuff [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/450614 (owner: Ejegg) [22:15:24] but not with the Civi shoreditch CSS url? [22:16:25] ejegg: no - that’s a civi theme - would be good huh [22:16:37] we could probably make that possible though.... [22:16:48] https://www.drupal.org/project/switchtheme - I think this is it [22:17:23] ejegg: I’m trying to find those tests we did upstream for email processing [22:17:38] for mepps email [22:17:45] oh, the bounce processing? [22:18:17] I think I found it [22:19:02] https://github.com/civicrm/civicrm-core/commit/01467aec24d643e8b8e6d1288f57b5a97f6cdce7 [22:19:04] CRM-21521 ? [22:19:17] cool [22:20:58] (Merged) jenkins-bot: Add Tivy theme to go with the Civi Shoreditch stuff [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/450614 (owner: Ejegg) [22:21:22] ejegg: yeah but now I remember - the hard part was finding the problem email [22:21:31] I can’t recall where we trawled to find it [22:21:42] (I think we might have duplicated our efforts on that too) [22:21:58] would have been the mbox folder on the civi box? [22:23:53] where does that even sit (in prod now) [22:24:07] good question - cwd ??? [22:24:36] the inbox for civi bounce processing - any idea where that is? [22:25:33] (PS1) Ejegg: Update drupal submodule for Tivy theme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450873 [22:25:53] (CR) Ejegg: [C: 2] Update drupal submodule for Tivy theme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450873 (owner: Ejegg) [22:26:52] ejegg: like civi sent a message that bounced? [22:27:17] yeah, like when ppl put a bogus email in and we try to thank them [22:27:26] or mailboxes are full [22:27:34] they would be in the postfix queue [22:27:48] ah, ok, not an mbox folder? [22:28:25] https://grafana.wikimedia.org/dashboard/db/fundraising-overview?refresh=1m&orgId=1&panelId=14&fullscreen [22:28:55] cwd that's outbound email? [22:29:09] yep [22:29:28] i believe there is postfix commands to see the messages [22:29:33] cwd so we have a job that processes the incoming bounce mailbox (stuff in random formats from other ppls mail servers) [22:29:54] and it's currently crashing trying to deduce stuff about a certain message [22:30:09] it would be really helpful to be able to see that message [22:30:56] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450874 [22:31:03] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450874 (owner: Ejegg) [22:31:26] I have one on one now but it’s parsed in ezcMailParser::parseMail [22:31:33] (Merged) jenkins-bot: Update drupal submodule for Tivy theme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450873 (owner: Ejegg) [22:31:33] ejegg: sure, just gimme something to search for (on a server is fine if it's PII) [22:31:44] eileen: same ^ [22:32:54] eileen: it would likely be the oldest message in the bounce inbox, right? [22:33:35] Huh, I thought I added some logging when I made that patch to at least log the message ID [22:35:45] but I don't see any message ID in that log [22:36:03] cwd all we have is "Trying to get property of non-object EmailProcessor.php:276" [22:36:34] but I think it tries to process messages in order by date [22:36:46] ejegg: https://github.com/wikimedia/wikimedia-fundraising-crm-drupal [22:39:02] ejegg: there is always a decent amount of stuff in there [22:39:02] ooh, freal? [22:39:27] stuff a few days old [22:42:30] hmm, I'm surprised we're not getting more of that failmail, actually [22:42:56] I'd expect the bounce job would just keep re-trying [22:42:59] let's see [22:43:06] did it disable itself? [22:47:59] eileen: would you expect there to be something in the job log for the Bounces fetcher, even though we're not running it via Civi Cron? [22:48:07] There's nothing there [22:52:19] cwd can you dump the oldest few messages in the bounce folder in /tmp ? [22:53:04] it sure looks like the bounce job is running [22:55:05] ejegg: it's in your home dir on civi1001 [22:55:08] bounces [22:55:22] thanks! [22:55:24] (tmp is pretty gnarly on this machine) [22:56:18] cwd ah, I think the bounce processor is fetching something different [22:56:35] it reads full emails [22:57:05] usually with the original email stapled to a form letter like 'Sorry, this guy's inbox is full' [22:57:26] looking for the mbox [23:04:47] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450577 (owner: Ejegg) [23:06:40] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450577 (owner: Ejegg) [23:06:42] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/450874 (owner: Ejegg) [23:11:59] !log updated CiviCRM from 03012506b9 to d626907f2c [23:12:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:18:04] ejegg: added this for tivy https://github.com/3sd/tivy/issues/1 [23:18:23] eileen: ok, got the layout editor enabled [23:18:27] ah, thanks [23:18:44] ejegg: cool leanne & mnoor will be pleased [23:58:58] (PS7) Ejegg: Publish fundraising exchange_rates data to Finance Dept spreadsheet via Google Sheets API. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) (owner: Jgleeson)