[00:00:04] (CR) Ejegg: [C: 2] "Cool, the behavior looks good in case of missing data now! The composer update touches a lot of unrelated packages, but they all seem like" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) (owner: Jgleeson) [00:05:44] (Merged) jenkins-bot: Publish fundraising exchange_rates data to Finance Dept spreadsheet via Google Sheets API. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) (owner: Jgleeson) [00:28:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Omnimail jobs start failing after update in some circumstances - https://phabricator.wikimedia.org/T201376 (Eileenmcnaughton) [00:30:44] thanks eileen! [00:31:07] ejegg: yeah I guess maybe it was the extension enables or similar that did it [00:31:27] we need to figure out how to test caching more to Redis [00:31:28] hmm [00:31:35] something core-y [00:31:35] mostly performance metrics [00:32:37] ejegg: so Civi caches settings [00:32:57] & it relies on the metadata to do that - which is determined by hook [00:33:25] I have found in the code why hooks are not called properly when doing a civicrm upgrade but guess it applies to other things too. [00:33:41] ah, right, I remember seeing comments to that effect someplace [00:34:04] it’s one of those annoying when it happens but never quite annoying enough to properly fix things [00:43:42] heading out for the evening [00:43:44] see ya! [06:27:21] (PS4) Eileen: Update Omnimail silverpop plugin and update the patch to reflect change [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449944 (https://phabricator.wikimedia.org/T199747) [06:27:23] (PS2) Eileen: Add Erase and Information request actions to Omnirecipient. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 [06:30:31] (Abandoned) Eileen: Update mrmarkfrench/silverpop-php-connector [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449960 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [06:35:12] (CR) jerkins-bot: [V: -1] Add Erase and Information request actions to Omnirecipient. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 (owner: Eileen) [06:37:10] (PS1) Eileen: Update Omnimail test to relfect package update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450905 (https://phabricator.wikimedia.org/T200240) [06:48:17] (Abandoned) Eileen: Update Omnimail silverpop plugin and update the patch to reflect change [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449944 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [06:54:58] (PS3) Eileen: Add Erase and Information request actions to Omnirecipient. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 (https://phabricator.wikimedia.org/T199747) [07:00:48] (CR) jerkins-bot: [V: -1] Add Erase and Information request actions to Omnirecipient. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [07:25:45] (PS1) Umherirrender: Declare FundraisingMessageGroup->group [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/450910 [07:28:52] (PS1) Umherirrender: Fix return type of parser function hooks [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/450911 [10:50:51] Wikimedia-Fundraising-Banners, donate.wikimedia.org: Fundraising banners and donatewiki should pass language es-419 if user is in Latin America - https://phabricator.wikimedia.org/T199683 (Pcoombe) [11:02:27] Wikimedia-Fundraising-Banners: dsk small above infobox in certain languages - https://phabricator.wikimedia.org/T191419 (Pcoombe) [11:47:33] (PS1) simetrical: Don't call SpecialPageFactory methods statically [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/450952 [12:54:42] (CR) Jgleeson: "@ejegg, yeah the rebase over master resulted in composer.lock conflicts which confused me at first. After running composer update I realis" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449379 (https://phabricator.wikimedia.org/T200227) (owner: Jgleeson) [13:59:25] (PS1) Jgleeson: Revert unnecessary composer updates included in earlier patch. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450988 [13:59:27] (PS6) Mepps: Handle no status code for Ingenico api [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440465 (https://phabricator.wikimedia.org/T194517) [14:22:02] jgleeson: hi! [14:22:17] hey ejegg [14:22:20] hey mepps [14:22:24] I think we're fine with the composer updates [14:22:29] and hi mepps ! [14:22:53] hey ejegg, jgleeson! [14:23:04] jgleeson: in general I like having them in a separate commit, just in case something starts acting weird [14:23:06] it looks like some of the updates require an additional patch, according to Eileen's note [14:23:18] so I pushed up a revert [14:23:26] jgleeson: oh, for real? [14:23:37] some of the geocoder stuff? [14:23:37] Yeah checkout the Jackism note [14:25:31] heh, I see [14:25:48] right, I guess since we're using some dev-master versions [14:25:55] we do need to be more careful [14:26:57] but is she talking about a different patch? Yours hasn't been deployed yet [14:28:22] yeah I think I sent out an updated version of.. something, that reviews another patch [14:28:36] that hasn't been +2'd , https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/450905/ [14:28:48] I figured it was safer to roll it back [14:29:02] in https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/450988/ [14:29:06] hmm, that package hasn't actually been updated in deploy since february [14:29:34] lemme review the vendor changes resulting from your patch - maybe we can just +2 the test update [14:29:41] and keep moving forward [14:29:58] well, the test update looks good [14:30:13] (CR) Ejegg: [C: 2] Update Omnimail test to relfect package update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450905 (https://phabricator.wikimedia.org/T200240) (owner: Eileen) [14:35:53] hmm my local env seems to have lost my payments wiki extensions since trying to switch over to 1.31 :| [14:36:07] mepps, just gonna run the new test on your patch [14:36:25] Ingenico patch* [14:37:50] (Merged) jenkins-bot: Update Omnimail test to relfect package update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450905 (https://phabricator.wikimedia.org/T200240) (owner: Eileen) [14:39:19] jgleeson: do you have the fundraising/REL1_31 branch? [14:39:25] or just REL1_31? [14:39:45] I was trying to use the fully qualified one [14:40:02] There should be patches on fundraising/REL1_31 to include the right extensions for payments-wiki [14:40:05] fundraising/ prefix [14:40:18] I'm back on 1.27 now [14:40:28] fund../REL1_27 [14:41:36] hmm, maybe you checked out a different branch in between fundraising branches? [14:41:55] anyway, if you're on a fundraising/* branch, git submodule update --init [14:42:03] might be all you need to get your extensions back [14:43:03] jgleeson: I just went through the code changes in vendor from doing a composer install --no-dev after your composer.lock update [14:43:21] I see where eileen tacked the 'GMT' onto the end of the timestamps for the mailings [14:43:33] but besides that, I don't see anything dangerous [14:44:37] I'd say we could deploy just your patch + eileen's latest test update [14:44:53] and if anything goes wonky, we'll know it was a library update thing [14:45:10] since the other code in your patch doesn't touch any of our regular processes [14:46:29] (CR) Ejegg: [C: 2] Add form_variants from fr/REL1_27 branch [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448605 (owner: Ejegg) [14:54:04] (PS3) Ejegg: Fix .gitmodules branch for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448607 [14:54:06] (PS2) Ejegg: Update fundraising extensions [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448784 [14:54:38] (CR) Ejegg: [C: 2] Fix .gitmodules branch for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448607 (owner: Ejegg) [14:54:45] (CR) Ejegg: [C: 2] Update fundraising extensions [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448784 (owner: Ejegg) [14:55:47] fr-tech I'mma do one last deploy on 1.27 to get the opt-in buttons on the GB and IE forms [14:56:05] then I'll remove the vendor dir from the fundraising extensions [14:56:14] in the deploy branch [14:57:29] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/450998 [14:57:33] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/450998 (owner: Ejegg) [15:00:44] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 [15:01:08] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 (owner: Ejegg) [15:01:45] ejegg, it was due to my mw extensions being on the deployment branches [15:01:56] jgleeson: oh? [15:02:07] ah, so just the tests disappeared? [15:02:17] sorry, I mean that was why my payments wiki filters were not finding anything ext related [15:02:18] yea [15:02:24] phpunit paymentswiki filters* [15:02:42] yep, that'll do it [15:03:00] yep, I seem to forget that a lot [15:03:04] one for the whiteboard me thinks [15:03:55] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 (owner: Ejegg) [15:04:42] hmm [15:05:12] ah, massive zuul backlog [15:06:52] means the underlying DI update is not yet merged [15:07:50] (CR) jerkins-bot: [V: -1] Update fundraising extensions [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448784 (owner: Ejegg) [15:08:27] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 (owner: Ejegg) [15:09:37] (CR) jerkins-bot: [V: -1] Fix .gitmodules branch for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448607 (owner: Ejegg) [15:10:22] grr, quibble stuffs are running on fundraising/ again [15:12:42] Fundraising-Backlog, wikimediafoundation.org: Wikimedia Foundation website includes Wordpress tracking pixel - https://phabricator.wikimedia.org/T201422 (cwdent) [15:12:58] fr-tech: fyi ^ [15:13:47] +! [15:13:49] +1 [15:15:35] thanks cwd [15:16:09] was surprised to not find any current tasks about this [15:27:47] (CR) Jgleeson: [C: 1] "Looks good to me, tests passing. I" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440465 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [15:29:02] (CR) Mepps: Handle no status code for Ingenico api (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440465 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [15:29:02] fr-tech hellosies :) anyone up for talking through new Python Kafka stuff during tech-talk in 1.5 hrs? [15:29:06] thx in advance! [15:29:18] sure! [15:29:21] (and no worries if other stuff is more urgent) [15:29:22] :) [15:31:36] (PS7) Mepps: Handle no status code for Ingenico api [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440465 (https://phabricator.wikimedia.org/T194517) [15:35:47] mepps, am I right in thinking we only wanna +1 that 'no status code' patch for now until the WIP patch it's built on is +2'd? [15:36:30] AndyRussG: yeah, sounds good! [15:37:03] (CR) Jgleeson: [C: 1] Handle no status code for Ingenico api [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/440465 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [15:39:30] jgleeson did you test it with the earlier patch? it won't really work correctly without that anyways [15:39:44] and that one is no longer be WIP, let me fix that [15:41:00] (PS11) Mepps: Refactor of ConfirmCreditCard to handle pending flag [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/444311 (https://phabricator.wikimedia.org/T194517) [15:44:28] mepps, I didn't invoke the IN_PROGRESS status via a manual test, can we do that? I remember trying to test 3d secure via Maestro locally but never got that working (3d secure I think all go to IN_PROGRESS) [15:44:48] but I did put through a payment and run the tests on that patch, which includes the WIP stuff [15:45:50] jgleeson go ahead and review the earlier patch, it's no longer WIP [15:47:46] also go for it if you're set up for easy testing of 3d secure [15:48:14] although when i did a 3d secure test with a later refactor patch it didn't seem to handle it as in_progress... [15:49:48] mepps, It wasn't possible to test 3d secure, it wasn't enabled for us in the test env [15:50:27] I think it might of got switched on maybe when ejegg did the patch to prevent all transactions be 3d secure [15:50:56] jgleeson: you can turn it back on in LocalSettings if you want [15:51:03] or just try a txn in INR [15:51:33] do we know if it actually works now? as in you get all the blurb html on the frontend as explained here https://epayments.developer-ingenico.com/documentation/testcases/ [15:51:43] mepps, ejegg ^ [15:52:10] I haven't had a working, local 3d secure test transaction with ingenico connect [15:52:27] up to the point I was last trying [15:52:35] ah right [15:52:41] Lemme try again [15:53:01] mepps, did you find another way to manually trigger the IN_PROGRESS status? [15:53:29] I haven't been close to that bug, but my guess was that it was coming up as part of the 1 hour test 100% 3d secure transactions? [15:54:50] the missing order status? [15:55:02] we did get a bunch of those on Aug 1st too though [15:55:05] like almost 100 [15:55:16] even with 3d secure disabled [15:55:33] interesting, so there must be another way to get it [15:55:54] No I wrote the test instead jgleeson [15:56:09] zgrep 58209978.2 *20180802.gz [15:56:27] ^^^ might shed some light [15:57:36] RETURNED FROM CURL:{"status":"IN_PROGRESS"} [15:57:40] mepps, yeah the test looked good. [15:58:35] ejegg, were they in response to a cron or something? [15:59:01] jgleeson: no, the weird thing is that was after the donor had been redirected back to our site [15:59:18] I'm trying to think of a scenario where we'd expect a checkout to still be in progress, on multiple hostedCheckouts [15:59:33] yeah that doesn't make sense [15:59:44] maybe a failure to complete the transaction on the ingenico side? [16:00:00] guess we should check the status at the console [16:00:49] ok here's something [16:00:52] https://epayments-api.developer-ingenico.com/s2sapi/v1/en_US/java/statuses.html [16:00:57] CANCELLED_BY_CONSUMER [16:01:03] If a consumer cancels the payment on the payment product detail page of the MyCheckout hosted payment pages, the status will change to IN_PROGRESS. Since we understand you want to be aware of a consumer cancelling the payment on the page we host for you, you can choose to get the status CANCELLED_BY_CONSUMER back instead of the status IN_PROGRESS. In order to get the status CANCELLED_BY_CONSUMER back, you need to have the [16:01:03] returnCancelState flag enabled in the Create hosted checkout call [16:01:45] ejegg, mepps , so if a donor abandons the payment, I think it goes to IN_PROGRESS indefinitely? [16:01:52] based on the above [16:04:45] Fundraising-Backlog, wikimediafoundation.org, Privacy: Wikimedia Foundation website includes Wordpress tracking pixel - https://phabricator.wikimedia.org/T201422 (Reedy) [16:07:57] jgleeson: interesting! [16:08:01] so, let's add that flag [16:08:17] but that sounds like someone pressing the 'cancel' button, which we've hidden with CSS [16:08:37] could they be activating it by mistake? [16:08:58] also, does the 'cancel' button bring them back to the same result page? [16:09:11] I'mma try that... [16:09:33] just seeing if i can simulate it locally [16:10:31] if you tab past the pay button, I think the focus moves to cancel [16:11:56] yup I see that [16:13:02] although I'm now thinking what happens if you just don't enter anything in the form fields and close the page, does the hostedCheckoutSession expire somewhere? [16:13:04] and yeah, it does seem to return the donor to GatewayResult [16:13:20] jgleeson: yeah, it would just quietly expire now [16:13:28] since we don't have an orphan rectifier for Ingenico [16:13:57] jgleeson: you want to put up a patch adding returnCancelState ? [16:14:11] sure [16:14:15] thanks! [16:14:30] I'm curious how many of these there were? [16:14:43] this must be a pretty limited user journey [16:18:53] jgleeson: [16:19:00] zgrep ORDERSTATUS error-20180802.gz | wc -l [16:19:03] 138 [16:19:08] weird [16:19:17] yeah [16:21:56] ah, the console lets you look things up by hosted checkout ID [16:23:12] for i in `zgrep ORDERSTATUS error-20180802.gz | cut -d' ' -f 7 | uniq`; do zgrep $i payments-ingenico-20180802.gz | grep hosted | grep Raw; done [16:23:43] ninja [16:23:53] all the responses from all API calls in sessions that got those errors [16:24:02] mostly just from the initial setup calls [16:24:13] but those at least have the hostec checkout IDs [16:25:02] hmm, maybe not all - I don't see any of the IN_PROGRESS responses [16:25:27] oh right, I was grepping for hosted [16:27:30] ok, minus the 'grep hosted' you do see a ton of status: IN_PROGRESS [16:31:10] * awight rubs hands in anticipation of more crusts next paycheck [16:33:49] Fundraising-Backlog: Amazon nightly download timing out - https://phabricator.wikimedia.org/T201330 (Ejegg) @cwdent checked our firewall config and found that we're not blocking the TCP proxy. [16:35:01] Fundraising-Backlog: Amazon nightly download timing out - https://phabricator.wikimedia.org/T201330 (Ejegg) @cwdent our outbound IP address ranges haven't changed, have they? I gave them a range to allow to use the proxy. [16:54:24] Fundraising-Backlog: Amazon nightly download timing out - https://phabricator.wikimedia.org/T201330 (cwdent) @ejegg nope, I tried the IP from my home internet which also timed out - maybe they have added incoming restrictions? [16:59:09] Fundraising-Backlog, FR-Smashpig, FR-Email: jobs-paypal processor should combine info from pending table - https://phabricator.wikimedia.org/T201438 (Ejegg) [17:05:18] coming fr-tech! [17:33:02] Fundraising-Backlog, wikimediafoundation.org, Privacy: Wikimedia Foundation website includes Wordpress tracking pixel - https://phabricator.wikimedia.org/T201422 (cwdent) [17:34:37] cwd is python 3.6 available for the new civi1001 box? [17:34:47] I see 3.4 is on there now [17:39:38] Fundraising Dash, Fundraising-Backlog, Cleanup, MediaWiki-extensions-Other, User-Zoranzoki21: Archive DjangoAnalytics extension - https://phabricator.wikimedia.org/T199850 (Umherirrender) Contains only python from the fundraising team. If the code is still needed it should be moved to another... [17:44:11] Fundraising Dash, Fundraising-Backlog, Cleanup, MediaWiki-extensions-Other, and 2 others: Archive DjangoAnalytics extension - https://phabricator.wikimedia.org/T199850 (Umherirrender) [17:44:51] ejegg|food: not from apt [17:48:16] Fundraising Dash, Fundraising-Backlog, Cleanup, MediaWiki-extensions-Other, and 2 others: Archive DjangoAnalytics extension - https://phabricator.wikimedia.org/T199850 (Umherirrender) [17:49:17] AndyRussG: bad news for your f"strings" ^^^ [17:49:51] ejegg hrmmm oh wells 8p thx!! [17:50:08] yeah I was wondering why I hadn't discovered those in Python before! [17:51:11] K added a TODO to the etherplaid [17:51:13] we can look into it if you want [17:51:20] we could package a different python [17:51:24] cwd: eh not sure it's worth the effort [17:51:37] cool [17:51:47] It's just a convenient way of embedding expressions in strings that's new in Python 3.6 [17:51:58] There's an old way, just a little more verbosey [17:52:21] I think using that is preferable to adding any operations overhead/complexity [17:52:41] hehe much appreciated :) [17:52:51] cwd heh likewise!! ;) [17:53:21] Yeah I was like, mmm this is really pretty, f'string literal {expression}' [17:54:15] still this is production, bleeding-edge is not the right whey [17:54:28] I think [18:05:37] Fundraising-Backlog: Amazon tcp connection timing out - https://phabricator.wikimedia.org/T201330 (mepps) [18:15:02] hi awight! [18:15:08] up for some light reading? [18:15:12] saurabhbatra: o/ for sure [18:15:24] mailing a draft of my write-up to you [18:15:51] Sounds good—you feeling the deadline stress yet? :-) [18:16:55] * saurabhbatra procrastinates stressfully [18:23:21] saurabhbatra: Thanks, received. I’ll send some notes shortly. [18:23:46] thanks a bunch! [18:25:20] Fundraising-Backlog: Slider for translations on donate.wiki WTG - https://phabricator.wikimedia.org/T201446 (MBeat33) [18:53:37] awight: got your feedback, changing stuff and then sending out to fr! [18:54:02] saurabhbatra: Right on. I’d say my comments are mostly “nice to haves”, fwiw. [18:55:19] i think you understand the audience better than i do so i'll err on the side of safety and "nice to haves" ;-) [18:55:51] oh and yes this is fr-only [18:57:14] ah that reminds me, I should comment on the thread about specific numbers [19:00:56] MBeat: where can i find data like- "how much did chargeback processing cost us in a month" in the sheet? [19:01:11] or something from which i can infer the above [19:01:44] hmm, let me check to see what the Ingenico fee for a chargeback is saurabhbatra [19:07:27] oh hey, Eileen's Civi 5.4 patch is non-WIP [19:07:32] https://gerrit.wikimedia.org/r/444769 [19:07:44] saurabhbatra: AFAIK, the specific type of information that we’re contractually obligated to keep private is our negotiated prices for payment processing and other fees. It should be fine to talk about normal industry rates, or other numbers which don’t make it possible to work out our exact fees. [19:11:23] awight MBeat: will it be okay to quote these figures in the fr mail thread though? [19:11:37] +1 most definitely [19:23:18] (CR) Thcipriani: "recheck" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 (owner: Ejegg) [19:24:35] jgleeson: I looked over the vendor changes from your patch, and I feel comfortable deploying it [19:24:51] ah ok [19:24:59] I'll abandon the revert [19:25:07] Random note, I see that MediaWiki 1.31 is LTS :-) [19:25:27] awight: yes! We're putting it on payments next Monday [19:25:40] and taking the opportunity to use composer-merge-plugin [19:25:52] oho! I got ants in my pants at seeing REL1_27 above. [19:26:03] I see the feeling is mutual :p [19:26:05] now that we've finally gotten the DI dependencies out of dev-master [19:26:18] hehe, yeah, trying to avoid total irrelevancy [19:26:28] and abandonment by releng [19:26:31] :) [19:26:50] There’s got to be a good blog post in how long it takes to pay down tech debt in this environment. [19:27:11] I think we’re mostly servicing interest [19:29:38] (PS1) Ejegg: Update libraries, add google libs [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/451085 [19:29:57] (CR) Ejegg: [C: 2] Update libraries, add google libs [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/451085 (owner: Ejegg) [19:31:30] man o man [19:32:01] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/451086 [19:32:10] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/451086 (owner: Ejegg) [19:34:08] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/451086 (owner: Ejegg) [19:34:08] And we haven’t even started accounting for the fact that MediaWiki is the most suspect possible platform for accepting payments! [19:35:18] (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/451086 (owner: Ejegg) [19:35:35] (CR) Ejegg: [V: 2 C: 2] Update libraries, add google libs [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/451085 (owner: Ejegg) [19:38:48] (CR) Ejegg: [C: 2] Add form_variants from fr/REL1_27 branch [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448605 (owner: Ejegg) [19:44:14] (CR) Eileen: "from my pov I'm not too worried about reverting - i don't think the deploy did any harm per se & composer.lock can be a pain for conflicts" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/450988 (owner: Jgleeson) [19:53:08] (PS4) Eileen: Add Erase and Information request actions to Omnirecipient. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 (https://phabricator.wikimedia.org/T199747) [19:54:15] Fundraising-Backlog: New email signup form - https://phabricator.wikimedia.org/T201458 (DStrine) [20:10:37] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 (owner: Ejegg) [20:14:16] Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Get rid of queue fakery in CiviCRM tests - https://phabricator.wikimedia.org/T172449 (Ejegg) Open>Resolved [20:14:19] Fundraising Sprint Owls, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: some CIDs not opening - https://phabricator.wikimedia.org/T201008 (Ejegg) Open>Resolved [20:14:47] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 5 others: Update Ingenico WX audit parser to... - https://phabricator.wikimedia.org/T195337 [20:15:33] Fundraising Sprint Owls, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy, and 3 others: WMF-specific links and emails should be in LocalSettings - https://phabricator.wikimedia.org/T108699 (Ejegg) Open>Resolved [20:31:44] awight: sent out the mail, the potential money saving for wmf section sure looks good! [20:31:53] hell yeah! [20:35:29] (CR) Thcipriani: "recheck" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 (owner: Ejegg) [20:39:30] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 (owner: Ejegg) [20:41:43] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 (owner: Ejegg) [20:42:41] Fundraising Sprint P 2018, Fundraising-Backlog: New email signup form - https://phabricator.wikimedia.org/T201458 (DStrine) [20:42:43] Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Owls, Fundraising Sprint P 2018, Fundraising-Backlog, Patch-For-Review: Investigate why Ingenico donation did not recur on 6/14 - https://phabricator.wikimedia.org/T199331 (DStrine) [20:42:45] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 7 others: Help switch over foundation pages ... - https://phabricator.wikimedia.org/T193663 [20:42:47] Fundraising Sprint P 2018, Fundraising-Backlog, FR-Smashpig, FR-Email: jobs-paypal processor should combine info from pending table - https://phabricator.wikimedia.org/T201438 (DStrine) [20:42:49] Fundraising Sprint P 2018, Fundraising-Backlog, FR-Smashpig: Failmail should always indicate which machine it comes from - https://phabricator.wikimedia.org/T200245 (DStrine) [20:42:51] Fundraising Sprint P 2018, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner previews occasionally fail to load - https://phabricator.wikimedia.org/T200853 (DStrine) [20:42:53] Fundraising Sprint Owls, Fundraising Sprint P 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Import log files not including all skipped rows - https://phabricator.wikimedia.org/T200031 (DStrine) [20:42:55] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 3 others: New scripts to ingress data from K... - https://phabricator.wikimedia.org/T195594 [20:42:57] Fundraising Sprint Fhabricator is spelled with an "F", Fundraising Sprint Gravity wasn't always this pushy, Fundraising Sprint HTTP originally stood for Happy Turtle Transfer Protocol, Fundraising Sprint Ivory and eggshell white are the same color, and 8 ot... - https://phabricator.wikimedia.org/T189613 [20:42:59] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Owls, and 4 others: Ingenico We don't have an order status after doing a GET_ORDERS... - https://phabricator.wikimedia.org/T194517 [20:44:48] awight: thanks for the follow-up mail. i'm off now, eileen_ is on so probably means time for bed :-) [20:45:09] seriously. OK great to see this push! [20:45:10] :-) night [21:17:20] ejegg, fixed it. I was sending the wrong boolean value... [21:17:34] so I was sending false, for the key 'returnCancelState' [21:17:44] and it needed to be true [21:19:09] although the boolean false, in the values array of a transaction in DI was being mapped as the string 'false', however setting it as true, mapped to the boolean true... so not sure why that happened [21:25:32] (PS1) Jgleeson: WIP:Added returnCancelState=true to createHostedCheckout transaction to stop the indefinite IN_PROGRESS status response when someone cancels a transaction. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451195 [21:26:14] mepps, ^^ is also likely related to the IN_PROGRESS fix you made earlier [21:33:48] (PS2) Jgleeson: WIP:Added returnCancelState=true to createHostedCheckout transaction to stop the indefinite IN_PROGRESS status response when someone cancels a transaction. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451195 [21:33:57] added test instructions [21:35:43] (PS3) Jgleeson: WIP:Added returnCancelState=true to createHostedCheckout transaction to stop the indefinite IN_PROGRESS status response when someone cancels a transaction. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451195 [21:48:21] have a good evening fr-tech! [21:52:02] (PS1) Ejegg: PayPal: use info from Pending table [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/451200 (https://phabricator.wikimedia.org/T201438) [21:52:47] Fundraising Sprint Pluto is still a planet, Fundraising-Backlog, FR-Smashpig, FR-Email, Patch-For-Review: jobs-paypal processor should combine info from pending table - https://phabricator.wikimedia.org/T201438 (Ejegg) p:Triage>Normal a:Ejegg [21:53:47] I know I logged off for the day but had to come back to share with you all a new high-water mark for my time at the foundation after realising I'd written this as a step in my test instructions on a commit message: [21:53:57] - Tab 5 times to select the invisible cancel button [21:54:24] yep, and it's real. Goodnight! [21:55:02] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/451086 (owner: Ejegg) [21:56:26] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/451086 (owner: Ejegg) [21:57:57] lawl ^ [21:58:13] oh, the hacks never stop :( [21:58:22] !log updated CiviCRM from d626907f2c to b60ceb3d2f [21:58:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:59:13] Procrustean payment page manglement to make 'em fit in an iframe [22:00:15] I’m still amazed that it’s legal! [22:00:56] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising-Backlog, Patch-For-Review: publish Oanda exchange rates to internal, private google doc - https://phabricator.wikimedia.org/T200227 (Ejegg) @jgleeson the code is deployed! Next steps: deploy the credentials, set the... [22:03:56] (CR) Ejegg: [C: 1] "Thanks!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451195 (owner: Jgleeson) [22:04:48] (CR) Ejegg: [C: 2] "Nitpick can wait. This will be really useful diagnostic info to have for tomorrow's test!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451195 (owner: Jgleeson) [22:15:48] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 (owner: Ejegg) [22:43:26] (Merged) jenkins-bot: WIP:Added returnCancelState=true to createHostedCheckout transaction to stop the indefinite IN_PROGRESS status response when someone cancels a transaction. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451195 (owner: Jgleeson) [22:49:11] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 (owner: Ejegg) [23:10:49] (PS5) Eileen: Add Erase and Information request actions to Omnirecipient. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 (https://phabricator.wikimedia.org/T199747) [23:16:55] (CR) jerkins-bot: [V: -1] Add Erase and Information request actions to Omnirecipient. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [23:29:38] (PS6) Eileen: Add Erase and Information request actions to Omnirecipient. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 (https://phabricator.wikimedia.org/T199747) [23:35:48] (CR) jerkins-bot: [V: -1] Add Erase and Information request actions to Omnirecipient. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 (https://phabricator.wikimedia.org/T199747) (owner: Eileen) [23:40:38] (PS7) Eileen: Add Erase and Information request actions to Omnirecipient. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 (https://phabricator.wikimedia.org/T199747) [23:41:22] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/451213 [23:41:41] (PS8) Eileen: Add Erase and Information request actions to Omnirecipient. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/449961 (https://phabricator.wikimedia.org/T199747) [23:41:44] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/451213 (owner: Ejegg) [23:42:55] (PS2) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 [23:42:57] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/451213 (owner: Ejegg) [23:44:12] (CR) Ejegg: [V: 2 C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/450999 (owner: Ejegg) [23:44:58] ccccccddfrjhjulnfnruvtuktveghelhtgnfkttinggt [23:45:01] ack [23:46:48] !log updated payments-wiki from 0c9c24d30c to 8cb7c86b12 [23:46:50] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log