[00:00:59] ignore_because file ??? sure, DJBS, whatever you say [00:02:51] (PS4) Ejegg: WIP opt-in method [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/452015 [00:04:07] ejegg: hehe [00:04:22] DJBS knows! [00:04:22] (PS2) Ejegg: Fix common typo in DonationInterface extension [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/452754 (https://phabricator.wikimedia.org/T201491) (owner: D3r1ck01) [00:04:30] (CR) Ejegg: [C: 2] Fix common typo in DonationInterface extension [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/452754 (https://phabricator.wikimedia.org/T201491) (owner: D3r1ck01) [00:44:39] Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising-Backlog, Patch-For-Review: Investigate why Ingenico donation did not recur on 6/14 - https://phabricator.wikimedia.org/T199331 (Ejegg) Hi @MBeat33, of the payme... [00:50:56] (PS1) Ejegg: Update opt-in 'no' text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/452875 [00:51:05] (CR) Ejegg: [C: 2] Update opt-in 'no' text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/452875 (owner: Ejegg) [01:19:43] (Merged) jenkins-bot: Fix common typo in DonationInterface extension [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/452754 (https://phabricator.wikimedia.org/T201491) (owner: D3r1ck01) [01:21:09] that took a while! [01:21:31] oh jeez, that wasn't even the one I was waiting for [01:30:39] (Merged) jenkins-bot: Update opt-in 'no' text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/452875 (owner: Ejegg) [01:52:58] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/452882 [01:53:11] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/452882 (owner: Ejegg) [01:53:54] (PS1) Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/452883 [01:53:56] (CR) Ejegg: [C: 2] Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/452883 (owner: Ejegg) [01:54:15] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/452882 (owner: Ejegg) [01:57:23] (Merged) jenkins-bot: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/452883 (owner: Ejegg) [02:15:31] !log updated payments-wiki from 6002d9edc0 to 46ed86f389 [02:15:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:52:40] (CR) jenkins-bot: Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/452853 (owner: Ejegg) [03:59:04] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/452855 (owner: Ejegg) [04:52:13] (CR) jenkins-bot: Update DonationInterface [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/452883 (owner: Ejegg) [11:19:49] (CR) Jgleeson: [V: 2 C: 2] "Looks good and the integration test is comprehensive." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/451200 (https://phabricator.wikimedia.org/T201438) (owner: Ejegg) [11:20:22] (Merged) jenkins-bot: PayPal: use info from Pending table [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/451200 (https://phabricator.wikimedia.org/T201438) (owner: Ejegg) [11:33:52] (PS1) Umherirrender: Use Html::rawElement for Message::parse [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/452923 [13:31:50] (PS1) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/452934 [13:33:26] (CR) Jgleeson: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/452934 (owner: Jgleeson) [13:33:50] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/452934 (owner: Jgleeson) [13:44:16] (CR) Mepps: [C: 2] Add personal details to repeat payment attempts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/452867 (https://phabricator.wikimedia.org/T199331) (owner: Ejegg) [13:48:09] hey mepps, do you remember how we go about adding new files to the donation interface vendor submodule? [13:48:59] hmm i think we might have to update the submodule directly and then use git submodule update [13:49:19] I've updated smashpig, and it looks like we use deployment the deployment branch for the listener checkout, and then we also tag master and update the DI vendor lib for the DonationInterface checkout [13:49:42] does that sound about right? [13:49:53] (Merged) jenkins-bot: Add personal details to repeat payment attempts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/452867 (https://phabricator.wikimedia.org/T199331) (owner: Ejegg) [14:03:21] ahh mepps, looks like I had to manually update packagist to see the new tag [14:03:39] to allow me to composer update smashpig on the DI project [14:18:30] oh yeah, sorry i thought you'd done the packagist update [14:22:33] I'm gonna update https://collab.wikimedia.org/wiki/Fundraising/Engineering#Deploy_Fundraising_Code to cover that part [14:24:11] good idea! [14:26:37] (PS1) Jgleeson: Update Smashpig to v0.5.7.2 [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/452942 [14:27:28] I also had to run composer update --no-dev, which isn't immediately obvious so I'll add that also [14:28:35] (CR) Jgleeson: [V: 2 C: 2] Update Smashpig to v0.5.7.2 [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/452942 (owner: Jgleeson) [14:34:01] hi jgleeson and mepps! [14:34:15] thanks for the update [14:34:36] don't think we needed to update it inside of DonationInterface though [14:34:58] hey ejegg, I haven't actually released anything yet as I've been kinda confused on how we do the complete update to smashpig [14:35:04] the PayPal job runs via the freestanding SmashPig deploy project [14:35:23] which pushes out the deployment branch [14:35:37] of the smashpig repo [14:36:13] so no need to touch packagist or the other projects [14:36:24] yeah I figured that was the more straightforward update but I wasn't sure whether it needed to be in DI also [14:37:11] nope, not for the jobs run via cron [14:37:28] those directly run smashpig maintenance scripts [14:38:02] ah ok, I wasn't sure [14:38:32] hmmm [14:38:42] good morning ejegg! [14:39:04] hi mepps! [14:39:18] ejegg due to the misunderstanding I've added the new smashpig tag and updated DI and DI vendor to pull in the changes [14:39:42] what do you think of maube turning off the dedupe jobs for today? [14:39:53] so deployment is now running the newly tagged v0.5.7.2 [14:40:11] (yet to be deployed) [14:40:26] and looking at what it'll take to get the 0/null merge bug fixed? [14:40:45] jgleeson ok, that shouldn't hurt anything [14:41:03] hmm this failed https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/452948/ [14:41:40] rsync error [14:42:04] maybe detatch/reattach jenkins-bot to try again? [14:44:42] jgleeson: Fetched in submodule path 'vendor', but it did not contain c0774b7e4f7de2c3a4a76b18cbddd151c4b06bd5. Direct fetching of that commit failed [14:45:02] hellosies [14:45:02] looks like the commit in the 'vendor' repo isn't merged yet [14:45:06] hi AndyRussG [14:45:16] I'll just push out SmashPig (freestanding) for now [14:46:43] ah I see, I need to manually merge this https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/vendor/+/452942/ [14:46:49] ahh, yeah [14:47:03] guess it's not fully automated that deep in [14:47:19] ejegg: [14:47:24] ejegg: hi! (oops ^) [14:47:40] ok just merged that in [14:47:47] !log updated SmashPig free-standing deployment from 2736e41045 to 3603e191a3 [14:47:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [14:47:53] morning AndyRussG :) [14:50:30] !log disabled CiviCRM dedupe jobs [14:50:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [14:50:38] jgleeson: :) [14:50:45] hi AndyRussG ! [14:51:01] Since most of us are here, I guess we'll do standup? [14:51:15] ejegg, I've tried simply readding jenkins-bot as a reviewer but I can't see any jobs related added to the Zuul queues [14:51:48] My plan is just to finish one more TODO on the FRUEC list and be around for the test, but other than that, mostly house cleaning and other non-work [14:52:00] Then I'd be around almost all of Monday [14:52:37] Hehehe as per above "house cleaning" == non-work [14:52:56] I guess they both auto-boolean-convert to False [14:59:12] jgleeson: I tried C+2-ing the patch [14:59:34] jenkins-bot usually sees that as a trigger to run jobs and merge if passing [14:59:39] jgleeson [14:59:51] the other thing is writing a review that just says recheck [15:00:07] that can trigger the tests without putting a C score on the patch [15:00:21] ah ok [15:00:37] I was just about to ask in releng [15:01:37] do you think our release process notes could do with splitting out by project to add in some of the details I worked through today? [15:01:48] https://collab.wikimedia.org/wiki/Fundraising/Engineering#Deploy_Fundraising_Code [15:02:35] it looks like there's enough overlap across the projects to combine most steps although that's only in relation to the project I'm familiar with releasing [15:18:47] jgleeson: sure, it's definitely worth reviewing that stuff [15:19:51] hmm, I know we HAD some separate docs for the payments-wiki deployments [15:48:30] hnrrrrggg Python module inheritance? nonononononono bwahahahaha [15:48:41] is that a thing? [15:48:47] it is not a thing [15:49:03] though when following the Pythonic trail to use modules instead of singletons [15:49:23] you might forget that you loose the inheritance feature [15:49:36] apparently, I'm not the first... [15:50:09] https://stackoverflow.com/questions/21434332/how-to-extend-inheritance-a-module-in-python [15:50:34] https://softwareengineering.stackexchange.com/questions/298019/how-to-achieve-inheritance-when-using-just-modules-and-vanilla-functions-in-pyth [15:51:16] is everyone not taking the day off? [15:51:26] cwd i'm swapping today for monday [15:51:28] (fwiw, line 111: https://etherpad.wikimedia.org/p/fr_user_event_consumer_notes) [15:51:33] and mepps is swapping it for friday [15:51:42] while AndyRussG is splitting the day [15:51:50] cwd how bout you? [15:51:54] it appears banner team is also around? [15:52:05] no real plans, i'm out tomorrow and friday though [15:52:08] oh, it is full queue o'clock? [15:52:10] cwd: anything odd bannerwise? [15:52:17] just queue alerts [15:52:23] arr, sorry [15:52:32] we'll try to speed that ingress up real soon [15:52:33] np [15:52:52] there's some civi core work to move the caching out of temp tables and into redis [15:52:54] cwd: fwiw we turned on centralNotice impression events client-side at 1% sample rate across the board yesterday [15:52:57] which I have high hopes for [15:53:00] unrelated I guess [15:53:05] nice [15:53:08] to both things [15:53:22] :) [15:53:46] replication keeping up well? [15:57:42] yep! [15:57:45] should be a lot faster now [16:02:04] https://www.intel.com/content/www/us/en/architecture-and-technology/l1tf.html [16:02:46] heh these machines we use are complicated [16:17:05] well i'm taking off but will have phone&laptop [16:17:42] cwd: have fun! [16:38:14] AndyRussG|brb: we're doing a mini-standup [16:38:17] in the usual spot [16:45:02] ejegg: ok oops forgot! [16:45:04] coming [16:58:49] fr-tech sorry I didn't see the messages in the chat [16:59:03] ahh AndyRussG, you were pretty cut off then! [16:59:22] heheh I was focusing on fixing sound so wasn't looking continuously at the Hangout window [16:59:48] I'm working on the last bit of refactoring the last bit of db code to remove some near-copy-pasta [16:59:53] in FRUEC [17:00:08] After that I'll be off for most of the day [17:00:30] Hrmmnggg I upgraded the whole system, and something happened that jiggled my custom audio setup [17:00:32] silly me [17:07:49] pcoombe, did the Big English test finish at 6pm? [17:08:05] I just wanna double check before I release an update to donate wiki [17:11:55] fr-tech, gonna pop out to pickup family, be back a little later [17:21:24] jgleeson|away: the UK and Ireland test is still up until 18 UTC (7pm UK time) [17:32:11] mmm I think I'l stay silent for a bit [17:35:38] fr-tech pretty sure I'll have to miss tech-talk this evening (3 pm Pacific), it'll probably coincide with my unusual kid-pickup schedule today. Possibly not though, just depends on traffic and stuff [17:40:52] i can't make it either fr-tech that time is rarely going to be good for me [17:53:15] yeah, it's pretty late for me too. I guess somebody picked it to be good for eileen, right? [18:01:38] woah ejegg|food is something going on with the audit? [18:04:26] paypal audit files missing subscr_id is another recurring theme [18:04:38] they need to regenerate the files [18:04:46] we should send an email [18:06:29] argh, and also throttle the failmail [18:06:52] jeez, it's usually not this many bad rows [18:07:25] yeah i'm taking a look at the file [18:07:39] or about to, except my terminal isn't opening... [18:07:47] might have to restart, brb [18:09:39] erm my terminal program seems broken, awesome [18:13:01] phew got it working again [19:16:21] have a good evening fr-tech! [20:15:26] mepps I think I found the spot to do something about the NULL opt-in values after merge [20:15:37] https://gerrit.wikimedia.org/r/453001 [20:16:01] ^^^ at least makes the 0/NULL difference appear on the merge screen as a difference [20:16:13] haven't tested it with batch merge yet though [20:16:19] those are a bit of a pain to set up [20:19:18] looks like wikibugs is on vacation today too [20:28:26] are there any tests written ejegg? the logic is a bit tricky to follow [20:29:30] ejegg: mepps let me know if you want me to try to write the test on the upstream repo [20:30:12] hi eileen_! [20:30:16] that would be cool [20:30:31] hi eileen_ [20:30:36] ok sure - I’m happy to do it - just don’t want to deprive you of a chance to dive into Civi :-) [20:30:50] I would totally welcome the help! [20:31:03] (But I’m also quite well set up for writing those tests) [20:31:16] ok - I’ll jump on it [20:36:20] oh jeez, just noticing this other bit of zero-related mayhem: [20:36:25] https://github.com/civicrm/civicrm-core/blob/master/CRM/Contact/Form/Merge.php#L62 [20:37:49] this reminds me of when i discovered what happens in civi if someone has the last name "NULL" [20:43:13] :S [20:51:56] Just FYI some upstream PRs from TIm https://github.com/civicrm/civicrm-core/pull/12663/files https://github.com/civicrm/civicrm-core/pull/12664 https://github.com/civicrm/civicrm-core/pull/12665 [20:52:59] we actually had a memcached regression off the work this month :-( some memcache specific key requirement that wasn’t picked up - but has only affected one person as far as we know [20:53:45] cool, I'll see if I can get civi using memcache for caching locally [21:17:30] ejegg: there is a fix to go out soon [21:17:58] but I’ve been running Redis locally with Civi [21:18:28] I don’t know about speed - we need to figure out how to measure that - but it’s pretty set & forget [21:22:13] ejegg: I agree that the place you have picked is the right place in the code - but I’m undecided about !== NULL [21:22:33] I haven’t figured out what treatment an empty string warrants [21:22:57] we could specifically handle 0 for now while I dig on that? [21:23:13] eileen_: ok, sounds good [21:24:08] i noticed that giving the same treatment to the non-custom fields showed a lot of useless junk with empty strings and arrays [21:28:44] hmm [21:29:26] So I guess 0 means something that NULL doesn’t but I’m less sure that empty-string does [21:30:13] it doesn’t seem like this is a situation where empty string could overwrite meaningful string - only empty string could overwrite null [21:30:24] so perhaps 0 is the only think we should handle [21:34:19] trying with if ((!empty($key1) && $key1 !== 0) || (!empty($key2) && $key2 !== 0) ) { [22:06:36] is it tech talk now? [22:15:42] mepps: at formerjob someone named null caused an outage by making a purchase :) [22:19:51] sorry eileen_, we should have cancelled that one. AndyRussG and mepps couldn't make it, and other folks were off [22:19:58] ah ok [22:37:03] (CR) Eileen: [C: 1] "I tested this out & added a PR with a unit test upstream - https://github.com/civicrm/civicrm-core/pull/12669" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/453001 (https://phabricator.wikimedia.org/T200941) (owner: Ejegg) [23:19:52] (PS2) Umherirrender: Add phan-taint-check-plugin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/451285 [23:19:55] (CR) Umherirrender: Add phan-taint-check-plugin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/451285 (owner: Umherirrender) [23:20:01] (CR) Umherirrender: "check experimental" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/451285 (owner: Umherirrender)