[00:00:14] ejegg: it could be the triggers :-( [00:00:29] Did other people see the email that just came out [00:00:38] “During this time, Eileen and Maggie will evaluate what we miss if we don’t have regular quarterly [00:00:39] check-ins. We’d love to hear your thoughts about that, too. [00:00:39] " [00:00:49] During this time, Eileen and Maggie will evaluate what we miss if we don’t have regular quarterly … [00:01:00] Hrm?? [00:01:03] Like - that is not our Maggie not our Eileen [00:01:06] but spooky [00:01:23] ah, the c-team one! [00:01:32] hah, civi-team? [00:04:33] lol [00:04:33] ejegg: No, actually that was the change mepps suggested to make safari work. I was trying for a something that would get no wrapping on every browser, but I couldn't make that work cleanly so I figured we'd see what folks thought about how it looks here. [00:04:49] Anyway, I gotta bounce, but I'll look for comments on the patch later. [00:06:18] There was a little whitespace cleanup for PS6 though. [00:33:07] (PS1) Eileen: Fix duplicate merge to not disregard zero values. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/453309 (https://phabricator.wikimedia.org/T200941) [00:33:58] (CR) Eileen: [C: 1] "ejegg so this is the altered variant per upstream https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/453309/" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/453001 (https://phabricator.wikimedia.org/T200941) (owner: Ejegg) [00:34:56] (CR) Eileen: "proposed in place of https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/453001/" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/453309 (https://phabricator.wikimedia.org/T200941) (owner: Eileen) [00:42:42] (CR) Ejegg: [C: 2] "Thanks, this one looks great!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/453309 (https://phabricator.wikimedia.org/T200941) (owner: Eileen) [00:43:07] (Abandoned) Ejegg: WIP fix null/0 merge bug [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/453001 (https://phabricator.wikimedia.org/T200941) (owner: Ejegg) [00:48:20] (Merged) jenkins-bot: Fix duplicate merge to not disregard zero values. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/453309 (https://phabricator.wikimedia.org/T200941) (owner: Eileen) [00:51:13] (CR) Ejegg: [C: 1] "Seems OK. The text does wrap funny, and the buttons are scrunched up against the text. If I add margin: 5px 3px auto; to the button css, I" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451804 (https://phabricator.wikimedia.org/T201528) (owner: XenoRyet) [03:30:09] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: civi: report filter for total USD within a time period - https://phabricator.wikimedia.org/T151271 (Eileenmcnaughton) @LeanneS @NNichols I started digging on this today & found... [03:34:05] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: civi: report filter for total USD within a time period - https://phabricator.wikimedia.org/T151271 (Eileenmcnaughton) I'll ping you on Monday (mine) since we don't have a mtg.... [03:40:03] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: civi: report filter for total USD within a time period - https://phabricator.wikimedia.org/T151271 (Eileenmcnaughton) Also linking to https://github.com/civicrm/civicrm-core/pu... [03:43:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Thank You email for Stripe Import - https://phabricator.wikimedia.org/T202099 (Ejegg) Got a patch that should allow '0' or '', but we might need to clean up T97684 first [03:48:50] (PS1) Ejegg: Center-align card radio buttons on mobile [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/453316 [03:49:58] (PS2) Ejegg: Center-align card radio buttons on mobile [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/453316 [06:21:16] (PS7) XenoRyet: Fix mobile orientation of radio buttons on payments.wiki opt-in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451804 (https://phabricator.wikimedia.org/T201528) [06:22:05] (CR) XenoRyet: "Yea, that looks better. Changes made." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451804 (https://phabricator.wikimedia.org/T201528) (owner: XenoRyet) [06:37:39] (CR) XenoRyet: "Just a quick test, but it looks like this isn't working on safari mobile for me. Still hanging out on the left there." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/453316 (owner: Ejegg) [07:55:11] Fundraising-Backlog: Cancel button missing for recurring donations in Civi - https://phabricator.wikimedia.org/T202118 (Aklapper) [10:26:19] (PS1) Umherirrender: build: Update mediawiki/minus-x to 0.3.1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/453376 [15:18:48] (PS8) Ejegg: Fix mobile orientation of radio buttons on payments.wiki opt-in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451804 (https://phabricator.wikimedia.org/T201528) (owner: XenoRyet) [15:19:03] (CR) Ejegg: [C: 2] Fix mobile orientation of radio buttons on payments.wiki opt-in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451804 (https://phabricator.wikimedia.org/T201528) (owner: XenoRyet) [15:34:32] (Merged) jenkins-bot: Fix mobile orientation of radio buttons on payments.wiki opt-in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451804 (https://phabricator.wikimedia.org/T201528) (owner: XenoRyet) [15:43:00] hi fr-tech! [15:43:13] hey ejegg :) [15:43:13] Any requests for tech talk today? [15:43:27] we have tech-talk today [15:43:28] > [15:43:29] ? [15:43:57] ohh, oops, I was looking at a different day [15:44:07] heh, guess not [15:55:19] :) [16:01:46] ah, I forgot about our later standup [16:14:19] Fundraising-Backlog: Cancel button missing for recurring donations in Civi - https://phabricator.wikimedia.org/T202118 (Ejegg) We figured this out - the list of recurring donations has been moved to a second sub-tab under the contributions. Under that sub-tab, the recurring donations in 'Completed' state for... [16:15:20] Fundraising Sprint Pluto is still a planet, Fundraising-Backlog: Cancel button missing for recurring donations in Civi - https://phabricator.wikimedia.org/T202118 (Ejegg) p:Triage>Normal [16:15:59] hey ejegg [16:16:14] did we work out what was going on in relation to the missing trnx's? [16:16:46] jgleeson: yeah, they were all fine [16:17:00] Donor Services was just looking for them under the 'globalcollect' gateway tag [16:17:11] when they were new-integration ones with the 'ingenico' tag [16:18:06] ahh [16:20:11] Fundraising-Backlog: Donation form does not save revised email address after card # entered - https://phabricator.wikimedia.org/T201962 (Ejegg) Yeah, that's an unavoidable consequence of our iframe flow. The part of the page that we host, including all the personal info, is totally unaware of events in the i... [16:20:32] thanks for the reminder - i'll mark that ticket as done! [16:21:32] Fundraising Sprint Pluto is still a planet, Fundraising-Backlog: Delay in GC transactions making it into Civi - https://phabricator.wikimedia.org/T202079 (Ejegg) p:Triage>Normal [16:24:12] (PS1) Ejegg: '0' or blank no_thank_you means send email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453429 (https://phabricator.wikimedia.org/T202099) [16:41:46] (CR) Jgleeson: [V: 2 C: 2] "Looks good! updated query working for me locally and tests passing." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453429 (https://phabricator.wikimedia.org/T202099) (owner: Ejegg) [16:48:51] (Merged) jenkins-bot: '0' or blank no_thank_you means send email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453429 (https://phabricator.wikimedia.org/T202099) (owner: Ejegg) [17:03:22] XenoRyet: standup? [17:03:33] Sorry, time warp, brt [17:29:57] Heh it looks like I do have RAID set up at a lower level than LVM [17:30:08] And also at a level below encryption [17:30:13] or, something like that [17:30:33] Hard to remember how this stuff works in between laptop upgrades! [18:57:56] (CR) Jforrester: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/450952 (owner: simetrical) [19:25:03] fundraising-tech-ops: Remove stretch repos from jessie boxes - https://phabricator.wikimedia.org/T200725 (Jgreen) Open>Invalid Closed b/c the identified issue was not actually a problem... [19:27:41] Fundraising-Backlog, Performance: Serve cache control headers for static resources on paymentswiki - https://phabricator.wikimedia.org/T114404 (Jgreen) Open>stalled [19:27:43] Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, Epic, Performance: [Epic] Payments performance tuning - https://phabricator.wikimedia.org/T140311 (Jgreen) [19:27:55] Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, Epic, Performance: [Epic] Payments performance tuning - https://phabricator.wikimedia.org/T140311 (Jgreen) Open>stalled [19:35:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Thank You email for Stripe Import - https://phabricator.wikimedia.org/T202099 (Ejegg) Oops, can't deploy that till we figure out what to do with Engage donations. Turns out they end up with a blank in the no_thank_you field which t... [19:41:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Thank You email for Stripe Import - https://phabricator.wikimedia.org/T202099 (jkim_wikimedia) Let's add @LeanneS to this thread since Rosie isn't currently working with us! [19:42:27] (PS1) Ejegg: Revert "'0' or blank no_thank_you means send email" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453471 [19:42:38] (CR) Ejegg: [C: 2] Revert "'0' or blank no_thank_you means send email" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453471 (owner: Ejegg) [19:44:02] jgleeson: oops, I should have given that more thought. Turns out all the hand-entered donations have been skipping the automatic ty mails all along. I want to understand why, and set up a way to keep the expected behavior happening that doesn't require Engage employees to type in a new field every donation [19:44:58] ah ok [19:45:03] (PS1) Ejegg: Update CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453473 [19:45:15] (CR) Ejegg: [C: 2] Update CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453473 (owner: Ejegg) [19:45:30] jgleeson: so I'll just keep track of that commit and restore it once I figure the rest out [19:45:38] sounds good [19:49:26] (Merged) jenkins-bot: Revert "'0' or blank no_thank_you means send email" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453471 (owner: Ejegg) [19:50:46] (Merged) jenkins-bot: Update CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453473 (owner: Ejegg) [20:07:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Thank You email for Stripe Import - https://phabricator.wikimedia.org/T202099 (Ejegg) Oops, thank you @jkim_wikimedia! @LeanneS Can you remind me why we don't want to send automatic thank you letters to donors entered by Engage?... [20:15:31] (PS1) Ejegg: WIP increment merchant ref and retry payment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) [20:16:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Thank You email for Stripe Import - https://phabricator.wikimedia.org/T202099 (LeanneS) @Ejegg For the Engage import, I believe it defaults to send one. For the donations they enter by hand, we don't always want an automatic TY ema... [20:35:02] (PS5) Ejegg: WIP opt-in method [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/452015 (https://phabricator.wikimedia.org/T200576) [20:35:55] fr-tech ^^^ really torturing that poor extension [20:36:33] Would love to hear feedback - should I keep mangling it to make the 'success' message make sense for the opt-in process? [20:37:01] or just leave it in peace and make a special-purpose page for opt-in? [20:37:30] with (!) modern wiki UI elements etc [20:45:58] (CR) Jforrester: [C: 2] Don't call SpecialPageFactory methods statically [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/450952 (owner: simetrical) [20:53:30] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: civi: report filter for total USD within a time period - https://phabricator.wikimedia.org/T151271 (LeanneS) Awesome - thanks! Happy to go over next week. [21:05:44] (Merged) jenkins-bot: Don't call SpecialPageFactory methods statically [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/450952 (owner: simetrical) [23:50:35] g'night fr-tech! [23:50:45] g'night!