[00:31:54] <wikibugs>	 Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Patch-For-Review: Donation form does not save revised email address after card # entered - https://phabricator.wikimedia.org/T201962 (Ejegg) a:Ejegg
[00:32:45] <wikibugs>	 Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, FR-Email, Patch-For-Review: Create opt-IN page for fundraisingEmailUnsubscribe, consume messages - https://phabricator.wikimedia.org/T200576 (Ejegg) p:Triage>High a:Ejegg
[00:35:41] <wikibugs>	 Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, and 2 others: Investigate why Ingenico donation did not recur on 6/14 - https://phabricator.wikimedia.org/T199331 (Ejegg) @MBeat33...
[10:45:55] <wikibugs>	 (PS1) Umherirrender: Add @covers to unit tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/455138
[12:19:42] <wikibugs>	 (PS1) Zoranzoki21: Fix common typos in code [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/455152 (https://phabricator.wikimedia.org/T201491)
[12:20:11] <wikibugs>	 (PS2) Zoranzoki21: Fix common typos in code [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/455152 (https://phabricator.wikimedia.org/T201491)
[14:07:22] <jgleeson>	 hey fr-tech :)
[14:07:40] <ejegg>	 hi jgleeson !
[14:08:39] <ejegg>	 looks like fruec got its gerrit repo:
[14:08:41] <ejegg>	 https://gerrit.wikimedia.org/r/#/projects/wikimedia/fundraising/FRUEC,dashboards/default
[14:08:46] <jgleeson>	 :D
[14:11:12] <jgleeson>	 ejegg, did you catch my reply re the code review
[14:11:19] <jgleeson>	 hope it makes sense
[14:11:42] <ejegg>	 ah yeah
[14:11:52] <jgleeson>	 I stared at the code for quite a while but couldn't think of an alternative using the same structure
[14:12:34] <ejegg>	 Right, I can't think of a better way to adapt it without a whole lot of deletion
[15:38:25] <wikibugs>	 Fundraising-Backlog: test and deploy payments-listener Debian Stretch / PHP 7 - https://phabricator.wikimedia.org/T197887 (Ejegg) Tested an AstroPay / d*Local IPN. Received fine, did the security check and correctly failed the signature, which was for the test account.
[15:38:51] <ejegg>	 Jeff_Green: got one more missing frpig package for when you have time: php-soap
[15:39:07] <ejegg>	 needed by Adyen
[15:40:54] <ejegg>	 Once that's installed, I think we're all good to swap it over to live!
[15:41:54] <wikibugs>	 Fundraising-Backlog: test and deploy payments-listener Debian Stretch / PHP 7 - https://phabricator.wikimedia.org/T197887 (Jgreen) @ejegg I got php-soap installed
[15:42:30] <ejegg>	 oh cool! re-sending the Adyen IPN
[15:45:25] <ejegg>	 Jeff_Green: looks like we need another apache restart maybe?
[15:49:20] <Jeff_Green>	 ah right
[15:49:24] <Jeff_Green>	 sec
[15:49:55] <Jeff_Green>	 ejegg: ok try now
[15:50:19] <AndyRussG>	 fr-tech: https://gerrit.wikimedia.org/r/#/admin/projects/wikimedia/fundraising/FRUEC
[15:52:37] <Jeff_Green>	 what's the backstory on FRUEC, I keep seeing it in channel and meaning to ask?
[15:53:22] <Jeff_Green>	 carefully curated acronym for a new FR project??
[15:54:19] <jgleeson>	 ejegg,
[15:54:29] <jgleeson>	 the following is on payments, but not on frpig1001
[15:54:32] <jgleeson>	 13d12
[15:54:32] <jgleeson>	 < geoip
[15:54:32] <jgleeson>	 21,22d19
[15:54:32] <jgleeson>	 < mbstring
[15:54:32] <jgleeson>	 < memcache
[15:55:48] <ejegg>	 Jeff_Green: FRUEC is AndyRussG's new scripts to replace DjangoBannerStats
[15:56:13] <wikibugs>	 (PS1) AndyRussG: Add LandingPage test data [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455189
[15:56:22] <jgleeson>	 awesome AndyRussG :)
[15:56:53] <Jeff_Green>	 nice
[15:57:19] <AndyRussG>	 jgleeson Jeff_Green :)
[15:57:46] <AndyRussG>	 Jeff_Green: "FundRaising User Event Consumer"
[15:58:14] <Jeff_Green>	 jgleeson: ah right, mbstring was one that I had to add yesterday to get payments-wiki working on stretch, it was part of another package on jessie
[15:58:24] <Jeff_Green>	 is that used for smashpig too?
[15:58:28] <Jeff_Green>	 AndyRussG: glorious
[15:58:31] <AndyRussG>	 I guess we can think of it as Google's prettiest mispelling of "fruit"
[15:58:54] <Jeff_Green>	 AndyRussG: that's what I figured, now we need a logo like with spashpig
[15:59:00] <AndyRussG>	 Heh yea it'll be nice to do away with that other cruft
[15:59:02] <Jeff_Green>	 smashpig even
[15:59:04] <jgleeson>	 Jeff_Green, I'm not sure, I guess a "better" comparison would of been with thulium
[15:59:18] <jgleeson>	 I'll check
[15:59:30] <AndyRussG>	 How do you visually represent a mispelling?
[15:59:38] <Jeff_Green>	 err, mutant fruit?
[15:59:44] <AndyRussG>	 heheh I guess that could be
[15:59:56] <Jeff_Green>	 maybe slice the image into sections, and arrange them out of order?
[16:00:08] <AndyRussG>	 eh that's great yea
[16:01:14] <jgleeson>	 hmm Jeff_Green ejegg, the difference is bigger between frpig and thulium
[16:01:34] <jgleeson>	 if it's safe to assume the php modules on thulium are required for smashpig
[16:01:42] <jgleeson>	 and not just more general modules
[16:02:51] <ejegg>	 Jeff_Green: mbstring might be nice to have on frpig too
[16:03:33] <ejegg>	 it does handle a bit of unicode data in paypal and amazon comms
[16:08:10] <AndyRussG>	 fr-tech for the new FRUEC Gerrit repo, I think we can follow normal review procedure as we add stuff to what's currently there in the repo, then before deploying, have a big "general review" of the stuff that was previously unreviewed in Github
[16:08:13] <AndyRussG>	 how does that sound?
[16:08:37] <ejegg>	 yeah, sounds good
[16:08:44] <AndyRussG>	 :) cool!
[16:08:44] <jgleeson>	 other packages on thuilium that are not on frpig: bcmath, dba bz2, mhash, zip  (and mysql, apc and ereg but they are either superseded or no longer required)
[16:08:49] <jgleeson>	 Jeff_Green, ejegg ^
[16:09:08] <Jeff_Green>	 ejegg: ok, will add
[16:10:51] <cwd>	 those are all php packages that were removed from defaults?
[16:11:35] <jgleeson>	 there is one thing to consider with these missing modules, they are being generated from the CLI which might not reflect the modules available/enabled in nginx
[16:11:49] <jgleeson>	 (that's if we use nginx)
[16:11:54] <jgleeson>	 @_@
[16:12:10] <jgleeson>	 not sure cwd
[16:13:54] <jgleeson>	 just looking through the code now, doesn't look like we're using any bcmath functions in smashpig
[16:17:21] <ejegg>	 jgleeson: we're running the sites under apache
[16:17:31] <jgleeson>	 ah ok
[16:17:43] <wikibugs>	 Fundraising-Backlog: Annual Fundraising Report discrepancies - https://phabricator.wikimedia.org/T202755 (DStrine)
[16:17:45] <ejegg>	 and using nginx just for ssl termination
[16:18:35] <jgleeson>	 looks like we are using mhash within phpmailer
[16:19:04] <wikibugs>	 Fundraising-Backlog: test and deploy payments-listener Debian Stretch / PHP 7 - https://phabricator.wikimedia.org/T197887 (Ejegg) OK, cool! The Adyen payment went through fine that time. I'm happy with the amount of testing now.
[16:19:21] <jgleeson>	 vendor/phpmailer/phpmailer/extras/ntlm_sasl_client.php:66
[16:21:36] <Jeff_Green>	 alright, added mbstring everywhere smashpig is deployed
[16:22:06] <jgleeson>	 php-zip is used by codesniffer, not sure if that matters
[16:22:23] <Jeff_Green>	 what's codesniffer?
[16:22:36] <jgleeson>	 php_codesniffer, it's a CI tool
[16:22:43] <Jeff_Green>	 oic
[16:22:48] <jgleeson>	 not really important for production
[16:23:13] <jgleeson>	 I've just been searching through smashpig for uses of bcmath, dba, bz2, mhash and zip
[16:23:27] <jgleeson>	 looks like the only one used is mhash
[16:23:52] <jgleeson>	 frpig1001 doesn't have php-mhash according to the cli module output
[16:26:06] <Jeff_Green>	 huh. searching repos turns up php-crypt-chap for mhash
[16:27:05] <jgleeson>	 a cryptic chap indeed...
[16:28:14] <Jeff_Green>	 !
[16:47:16] <wikibugs>	 Fundraising-Backlog: Add fundraising appeal on Wikipedia portal page - https://phabricator.wikimedia.org/T202497 (schoenbaechler) Explored various positions for a possible banner campaign on the portal page this afternoon. To be clear, banners wouldn’t be a permanent element on portal, they would appear duri...
[17:17:31] <wikibugs>	 Fundraising-Backlog: test and deploy payments-listener Debian Stretch / PHP 7 - https://phabricator.wikimedia.org/T197887 (Jgreen)
[18:04:12] <wikibugs>	 Fundraising-Backlog, Epic: Test data for new scripts to ingress data from Kafkatee into MySQL - https://phabricator.wikimedia.org/T201623 (AndyRussG) There's now (in review) some basic test data for both CentralNotice and LandingPage events. However, at least the CN data should be need to be more varied....
[18:23:44] <AndyRussG>	 ejegg: are landingpage events with no country info valid?
[18:26:02] <AndyRussG>	 I guess we're getting those, dunno if DjangoBS is skipping 'em
[18:26:09] <AndyRussG>	 For example, from Matching_Gifts page on donate wik
[18:29:48] <AndyRussG>	 Hmmm it looks like we left it as required in the CN schema but not in the LP schema
[18:30:06] <AndyRussG>	 and DJBS just sets it to "XX" if there's no country info provided
[18:30:14] <ejegg>	 AndyRussG: oh huh, I guess so
[18:30:20] <ejegg>	 what's the percentage?
[18:30:37] <AndyRussG>	 I'm taking a 4% cut of all XX country events
[18:30:44] <AndyRussG>	 I can offer 2% for quality referrals
[18:30:45] <AndyRussG>	 jk
[18:30:49] <AndyRussG>	 percentage of what?
[18:30:51] <ejegg>	 we're not pulling that from the geo cookie?
[18:31:02] <ejegg>	 percentage that you're seeing with no country
[18:31:58] <AndyRussG>	 Mmm haven't calculated it with much of a sample. For the 120 or so events I pulled in for testing data, I think a bit more than 20 have no country on them
[18:33:24] <AndyRussG>	 Lemme see how we're getting it
[18:36:56] <AndyRussG>	 ejegg: well, the event just gets it from a URL param
[18:37:09] <ejegg>	 oh huh
[18:37:25] <AndyRussG>	 If you just go to donate.wikimedia.org you do get geolocated
[18:37:42] <ejegg>	 well, i guess we XX 'em then?
[18:37:43] <AndyRussG>	 and that is added to the URL
[18:38:28] <AndyRussG>	 There must be other URLs people go (or bots?) to on DonateWiki, other than Special:LandingPage, where they don't get geolocated like that
[18:38:45] <AndyRussG>	 In theory DJBS does slurp them in but I'm not sure how many may get excluded by other means
[18:39:03] <AndyRussG>	 yeah I think XX is the way to go, just do as DJBS does for now
[18:39:07] <ejegg>	 Let's ask the db
[18:39:19] <AndyRussG>	 Ah okok good point
[18:39:28] <AndyRussG>	 I forgot we had one of those
[18:40:04] <AndyRussG>	 Mmm I'm gonna XX 'em for now and add a TODO just to not get too sidetracked
[18:43:53] <ejegg>	 good call!
[18:44:02] * ejegg queries anyway just for fun
[18:44:20] <AndyRussG>	 ah cool thx!
[18:45:54] <ejegg>	 hmm, lots of nonsense in the country table too
[18:46:05] <ejegg>	 could validate that code
[18:46:25] <AndyRussG>	 ejegg: oh yes we're doing that
[18:46:31] <AndyRussG>	 and there's a task to clean up that foo
[18:47:00] <AndyRussG>	 In the test data, 19 out of 19 events with no country are "is_bot": false
[18:47:05] <ejegg>	 huh, only 3 of the last 10 entries in landingpageimpression_raw have a good country code
[18:47:23] <ejegg>	 7 are XX
[18:47:39] <ejegg>	 so maybe that front end could be trying harder too
[18:48:03] <AndyRussG>	 I expect so yea
[18:48:35] <AndyRussG>	 I don't imagine there are many that go through the standard LP (Special:LandingPage) that don't get goe'd, tho
[18:48:44] <AndyRussG>	 geo0d
[18:48:46] <AndyRussG>	 geo'd
[18:48:49] <AndyRussG>	 0o0o0o0o0o0o
[18:49:11] <ejegg>	 geode?
[18:50:07] <wikibugs>	 (CR) Mepps: "I agree ejegg that adding more abstracts would be worse. I'd either stick with this but maybe consider my thoughts on naming, or just remo" (2 comments) [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/452008 (https://phabricator.wikimedia.org/T200576) (owner: Ejegg)
[18:52:30] <AndyRussG>	 geo-id'd
[18:54:58] <wikibugs>	 Fundraising-Backlog: test and deploy payments-listener Debian Stretch / PHP 7 - https://phabricator.wikimedia.org/T197887 (Jgreen)
[18:56:13] <AndyRussG>	 Aaaand the default language, if none was provided, is just "en"
[18:56:39] <AndyRussG>	 https://github.com/wikimedia/wikimedia-fundraising-tools-DjangoBannerStats/blob/master/fundraiser/analytics/management/commands/LoadLPImpressions.py#L326
[18:57:23] <AndyRussG>	 just a wee bit simplified fallback
[18:59:57] <AndyRussG>	 Certainly no reason for the front-end not to be able to fish out language and country
[19:10:25] <ejegg>	 right
[19:33:02] <AndyRussG>	 ejegg: can u think of any other validation we should include on this out-of-the-box for LP fields?
[19:33:04] <AndyRussG>	 https://www.mediawiki.org/wiki/User:AGreen_(WMF)/Draft:Mapping_of_EventLogging_properties_to_FundraisingImpressions_database#Mapping_from_LandingPageImpression_events
[19:33:32] <AndyRussG>	 In theory it isn't tooo dangerous to grab stuff straight off the URL like that, since the DB does escape it
[19:52:05] <ejegg>	 AndyRussG|bassoo: I'll take a look
[19:57:10] <wikibugs>	 (PS13) Mepps: Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517)
[19:57:23] <wikibugs>	 (CR) jerkins-bot: [V: -1] Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) (owner: Mepps)
[19:57:59] <wikibugs>	 (PS14) Mepps: Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517)
[19:58:12] <wikibugs>	 (CR) jerkins-bot: [V: -1] Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) (owner: Mepps)
[20:02:02] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, Wikimedia-log-errors: Don't serve an exception on Special:CentralNoticeBanners when the banner doesn't exist - https://phabricator.wikimedia.org/T149240 (Krinkle)
[20:21:09] <wikibugs>	 (PS5) Mepps: Consolidate flags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445534 (https://phabricator.wikimedia.org/T194517)
[20:21:11] <wikibugs>	 (PS15) Mepps: Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517)
[20:22:30] <mepps>	 ejegg i started review up there--i'm very open to feedback on this
[20:23:22] <ejegg>	 thanks mepps, I'll take a look!
[20:24:05] <wikibugs>	 (CR) jerkins-bot: [V: -1] Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) (owner: Mepps)
[20:30:18] <ejegg>	 heading out, will be back in a couple hours to finish up
[20:33:42] <wikibugs>	 (CR) Mepps: "Hmm I saw this failing test earlier and thought I'd resolved it but I'm going put this back into WIP while I look at it." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) (owner: Mepps)
[20:36:32] <wikibugs>	 (PS16) Mepps: Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517)
[20:36:52] <wikibugs>	 (CR) Mepps: "Nevermind, it was just incorporating Jack's change." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) (owner: Mepps)
[20:40:04] <wikibugs>	 (CR) Mepps: [C: 1] "Basic review and local test look good, but looks like it's failing linting and ejegg you said that you still had more work to do?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/455062 (https://phabricator.wikimedia.org/T201962) (owner: Ejegg)
[20:46:38] <wikibugs>	 (CR) jerkins-bot: [V: -1] Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) (owner: Mepps)
[20:56:25] <AndyRussG|ish>	 ^ ejegg|afk thx!
[23:45:16] <ejegg>	 Kalashnikov electic car: https://www.popularmechanics.com/cars/hybrid-electric/a22825307/kalashnikov-soviet-style-electric-car/