[14:17:10] (CR) Ejegg: "Looks good! Does MySQL deal with # comments, though?" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451228 (https://phabricator.wikimedia.org/T200240) (owner: Eileen) [15:13:21] (PS17) Mepps: Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) [15:13:34] (CR) jerkins-bot: [V: -1] Move to problem array, split out functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [17:12:44] Fundraising-Backlog: test and deploy payments-listener Debian Stretch / PHP 7 - https://phabricator.wikimedia.org/T197887 (Ejegg) What is "test fundraising.wikimedia.org functionality" ? [17:14:03] Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review: Handle new CANCELLED_BY_CONSUMER Ingenico responses. - https://phabricator.wikimedia.org/T201647 (Ejegg... [17:18:11] Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, FR-Smashpig, and 2 others: jobs-paypal processor should combine info from pending table - https://phabricator.wikimedia.org/T201438 (Ejegg) Update: seems to need some work for the recurri... [17:18:36] Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, FR-Smashpig, and 2 others: jobs-paypal processor should combine info from pending table - https://phabricator.wikimedia.org/T201438 (Ejegg) Open>Resolved [17:19:39] Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Patch-For-Review: Fix bug smashpig bug relating to IN_PROGRESS and CANCELLED_BY_CONSUMER responses - https://phabricator.wikimedia.org/T201646 (Ejegg) Open>Resolved p:Triage>... [17:20:15] Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, FR-Smashpig, Patch-For-Review: Failmail should always indicate which machine it comes from - https://phabricator.wikimedia.org/T200245 (Ejegg) Open>Resolved p:Triage>No... [17:21:12] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Please remove 'Submit Credit Card Contribution' from civi - https://phabricator.wikimedia.org/T202332 (Ejegg) Open>Resolved p:Triage>Normal a:Eileenmcnaughton [17:21:26] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, FR-Smashpig, Patch-For-Review: Smashpig "Entering logging context" logspam - https://phabricator.wikimedia.org/T202414 (Ejegg) Open>Resolved p:Normal>Low [18:25:10] (PS3) Ejegg: SmashPig payment processor: expose API codes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/452871 (https://phabricator.wikimedia.org/T201773) [18:25:12] (PS3) Ejegg: WIP increment merchant ref and retry payment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) [18:31:22] (CR) jerkins-bot: [V: -1] WIP increment merchant ref and retry payment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) (owner: Ejegg) [18:41:14] Hey there [18:50:25] Fundraising-Backlog, wikimediafoundation.org, Privacy: Wikimedia Foundation website includes Wordpress tracking pixel - https://phabricator.wikimedia.org/T201422 (AndyRussG) It looks like there is tracking of all navigation to external sites with this. For example, when I clicked on "Donate Now", the... [18:59:01] Carliitaeliza: hi [18:59:29] Hey [18:59:52] How I can get an interview [18:59:57] The editor profile you mentioned [5] was created by the Wikimedia Fundraising team. They interview users who are interested in talking about what Wikipedia and other Wikimedia projects mean for them, and some of those profiles are featured in the donation banners in the Wikipedia fundraiser. If you are interested in being interviewed, email my coll [18:59:57] eague Victor Grigas (vgrigas@wikimedia.org) - he would love to hear from you. [19:00:23] I got that message in my dis [19:00:55] Carliitaeliza: did you email Victor? [19:01:18] yeah [19:01:26] about two years ago [19:01:39] we were on the interview [19:01:50] and the internet was so slow [19:02:23] can you link the profile you quoted there? [19:03:34] yeah [19:03:51] https://donate.wikimedia.org/wiki/Thank_You/Benjamin_Chen [19:08:25] Carliitaeliza: is this the url from 2 years ago? [19:09:15] victor moved on from this job but i'd be happy to put you in touch with the right person [19:10:51] oh [19:10:54] :D [19:11:06] ok,please do it [19:11:28] (PS4) Ejegg: Increment merchant ref and retry payment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) [19:12:38] fr-tech Whew, finally got the error code bubbling up! [19:12:40] ^^^^ [19:12:44] ready for reviwe [19:12:47] *review [19:13:00] nice ejegg! [19:14:17] If you look in the Civi\API\Kernel::runSafe method, you can see that it has special formatting for API_Exception to preserve the error_code [19:14:30] but not for CiviCRM_API3_Exception [19:15:02] so if your underlying function throws the latter, it's treated like any other Exception [19:15:15] and the only thing bubbled up is the raw 'code' [19:15:47] unfortunately, there's no way to set the base Exception class's 'code' on a CiviCRM_API3_Exception object [19:16:24] the code you pass into the constructor is tucked into the 'error_code' property, which is ignored by runSafe's generic Exception formatter [19:20:55] (PS3) Ejegg: Disable personal info fields after submit [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/455062 (https://phabricator.wikimedia.org/T201962) [19:22:52] quiddity: do you have have a better answer than me to Carliitaeliza's question above? [19:23:20] looking... [19:23:23] (CR) jerkins-bot: [V: -1] Disable personal info fields after submit [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/455062 (https://phabricator.wikimedia.org/T201962) (owner: Ejegg) [19:32:38] (PS4) Ejegg: Disable personal info fields when opening iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/455062 (https://phabricator.wikimedia.org/T201962) [19:35:09] Carliitaeliza, I think you'd be best to send an email to https://wikimediafoundation.org/profile/megan-hernandez/ giving an explanation of what you're suggesting. [19:35:10] Hope that helps. [19:35:33] I don't know if they do banners of that type anymore, but it's worth an offer. :) [19:35:34] (PS5) Ejegg: Disable personal info fields when opening iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/455062 (https://phabricator.wikimedia.org/T201962) [19:40:12] thanks quiddity [19:41:28] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Trust-and-Safety, JavaScript, and 3 others: CentralNotice provides a means for non interface-admins to bypass new CSS/JS restrictions - https://phabricator.wikimedia.org/T202244 (AndyRussG) Hi! Just a few notes here: - Inline JS is used qui... [19:43:41] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Wikimedia-log-errors: ErrorException from line 79 of FundraisingMessageGroup.php: PHP Warning: Invalid argument: function: not a valid callback array - https://phabricator.wikimedia.org/T202579 (DStrine) [19:46:42] Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Unplanned-Sprint-Work: Inserting Images into Civi mail - https://phabricator.wikimedia.org/T202330 (DStrine) [19:47:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Trust-and-Safety, JavaScript, and 3 others: CentralNotice provides a means for non interface-admins to bypass new CSS/JS restrictions - https://phabricator.wikimedia.org/T202244 (matmarex) >>! In T202244#4535885, @AndyRussG wrote: > - The r... [20:12:12] cwd and Jeff_Green: do you want to chat about the PHP7 upgrades or anything else? [20:12:54] ejegg: jeff is out, i'm available but nothing that needs a call on my end [20:13:19] I'd be curious to chat a little bit about the upgrades if you have a few minutes [20:13:29] sure [20:36:48] Fundraising-Backlog, fundraising-tech-ops: Test Redis caching on Civi staging - https://phabricator.wikimedia.org/T202936 (Ejegg) [22:11:45] (CR) Ejegg: "Note: next patch changes the type of exception thrown in the Pay API to API_Exception (see explanation there)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/452871 (https://phabricator.wikimedia.org/T201773) (owner: Ejegg) [22:30:48] (CR) Eileen: drush to repair omnirecipient entries (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451228 (https://phabricator.wikimedia.org/T200240) (owner: Eileen) [22:32:34] (PS9) Ejegg: drush to repair omnirecipient entries [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451228 (https://phabricator.wikimedia.org/T200240) (owner: Eileen) [22:33:04] (CR) Ejegg: [C: 2] "Cool! Let's give it a shot." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451228 (https://phabricator.wikimedia.org/T200240) (owner: Eileen) [22:37:07] (CR) Legoktm: [C: -2] "vendor/ is upstream files that shouldn't be modified. Any fixes will need to be made upstream." [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/455152 (https://phabricator.wikimedia.org/T201491) (owner: Zoranzoki21) [22:44:06] (Merged) jenkins-bot: drush to repair omnirecipient entries [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/451228 (https://phabricator.wikimedia.org/T200240) (owner: Eileen) [22:52:35] (Abandoned) Zoranzoki21: Fix common typos in code [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/455152 (https://phabricator.wikimedia.org/T201491) (owner: Zoranzoki21) [22:58:17] (PS4) Zoranzoki21: Fix common typos in code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/455034 (https://phabricator.wikimedia.org/T201491) [23:50:59] (CR) XenoRyet: [C: 2] Disable personal info fields when opening iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/455062 (https://phabricator.wikimedia.org/T201962) (owner: Ejegg) [23:52:40] (Merged) jenkins-bot: Disable personal info fields when opening iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/455062 (https://phabricator.wikimedia.org/T201962) (owner: Ejegg) [23:55:36] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/455746