[00:05:18] (PS1) Eileen: Contact layout extension updates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/455748 [00:05:26] (CR) Eileen: [C: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/455746 (owner: Eileen) [00:07:08] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/455746 (owner: Eileen) [00:11:36] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: FY17-18 total not reflected in WMF Donor section - https://phabricator.wikimedia.org/T202102 (LeanneS) Additional examples: 2692210 22806362 8163999 [01:39:18] !log civicrm revision changed from 4e0dcf7cb4 to 863ed3f1a2, config revision is 5a629055fa [01:39:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:04:50] cwd I added a commit in process_control - do you want to double check if for me since that is kinda our process control process [03:35:23] eileen: sure, one minute [03:39:06] eileen: lgtm [03:39:22] thanks cwd [03:39:39] :) [03:39:50] we are passing PCI scans again [04:21:09] cwd - yay [04:21:13] !log process-control config revision is d0de40dec9 [04:21:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:35:36] (CR) Legoktm: [C: 2] Fix common typos in code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/455034 (https://phabricator.wikimedia.org/T201491) (owner: Zoranzoki21) [05:16:51] (Merged) jenkins-bot: Fix common typos in code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/455034 (https://phabricator.wikimedia.org/T201491) (owner: Zoranzoki21) [05:37:10] (CR) jenkins-bot: Fix common typos in code [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/455034 (https://phabricator.wikimedia.org/T201491) (owner: Zoranzoki21) [08:07:00] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Trust-and-Safety, JavaScript, and 3 others: CentralNotice provides a means for non interface-admins to bypass new CSS/JS restrictions - https://phabricator.wikimedia.org/T202244 (Tgr) At a glance, banners are MediaWiki namespace pages prefi... [09:19:55] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: FY17-18 total not reflected in WMF Donor section - https://phabricator.wikimedia.org/T202102 (Eileenmcnaughton) a:Eileenmcnaughton [13:46:25] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Trust-and-Safety, JavaScript, and 3 others: CentralNotice provides a means for non interface-admins to bypass new CSS/JS restrictions - https://phabricator.wikimedia.org/T202244 (AndyRussG) @matmarex @Tgr Interesting! Well, if permission ch... [14:11:18] Buongiorno! [14:18:13] hey AndyRussG :) [14:18:21] jgleeson: :) [14:18:59] hey btw apologies for not having gotten to looking closely at your latest comparison script work..... [14:19:12] Trying to get the LandingPage bit of FRUEC out [14:19:36] Hopefully we can talk about stuff at today's tech-talk? :) thx for being patient!!!!! [14:28:24] sounds good to me AndyRussG :) [14:29:44] I need to double check the schema to confirm the test will handle landing pages also, I think i might have built in a few assumptions around banner impressions naming that I need to generalise [14:30:38] jgleeson: ah ok... yeah check out the specification too (https://www.mediawiki.org/wiki/User:AGreen_(WMF)/Draft:Mapping_of_EventLogging_properties_to_FundraisingImpressions_database#Mapping_from_LandingPageImpression_events ) [14:30:45] landing page events aren't aggregated [14:30:52] or not really [14:32:45] there are two tables: landingpageimpression_raw, which has one line per event, and donatewiki_unique, which is the same but eliminates rows with duplicate utm_source, contact_id combinations [14:33:03] so, oodles of fun 8p [14:56:59] aaaarg the legacy script is so aaaargh [14:57:26] See the new notes on lines 93-94: https://etherpad.wikimedia.org/p/fr_user_event_consumer_notes [14:57:42] ewaiuraekhaeswre [14:58:07] jgleeson: ^ See the new notes on lines 93-94: https://etherpad.wikimedia.org/p/fr_user_event_consumer_notes [15:02:41] cruft begone! [15:27:36] reading AndyRussG [15:28:31] also I just pushed the latest version of the banner impressions test script. I think that might be *usable* in its own right now once we've happy to give it a try [15:29:22] It's still WIP though as I still need to confirm it will work with landing pages, and if not, make necessary changes to accommodate them. Thanks for the info above btw!!! [15:43:09] ejegg, I noticed the ingenico cancelled by consumer stuff has been reopened, did we run into another problem related to it? [15:46:13] jgleeson: oh really? Who re-opened it? [15:46:34] ohhhhhhhhhhh sorry [15:46:42] I have misread [15:46:50] Ejegg closed this task as Resolved. [15:46:53] Ejegg triaged this task as High priority. [15:47:13] I completely missed the above line saying you'd closed it :) [15:47:24] :) oh yeah, I like to try to fill in any missing details when I close a ticket [15:47:52] phew, well that's good. [15:48:02] I know we're getting pretty close with ingenico [15:48:30] I'm gonna check the board now and see if there's anything related I can help with [15:48:34] speaking of which, there's some code in review for the 'merchant ref already used' [15:48:53] I'm at a natural pause on the FRUEC test task I'm working with AndyRussG on [15:49:00] I told XenoRyet I'd walk him through that as soon as he got online today [15:49:15] so if you want to tune in too, I'd be happy to have a wider audience [15:50:05] besides that, there's the opt in form [15:51:01] I did another round of updates friday to change the optin method to subscribe [15:51:11] so it's a little more of a mirror of the 'unsubscribe' [15:51:18] existing method [15:57:29] cool, will check it out [15:57:45] I'm also gonna check out mepps' refactor of the globalcollect stuff [15:57:58] I didn't get chance last week [15:58:40] also, happy to tune in to the mercent ref demo ejegg [15:59:09] that's if it's still going ahead after your surprise :) [15:59:36] hehe, yeah, I'm here for an hour and a half before heading out with the parents [16:00:42] probably the most interesting Ingenico task left to do is the Orphan Rectifier [16:01:18] We could try to see if it's possible to make that work as a script running under Civi that uses SmashPig directly [16:01:43] as opposed to the GlobalCollect one which uses the DonationInterface kludge [16:01:44] that sounds cool [16:09:37] AndyRussG, I squashed all my WIP commits into one so it's more readable, https://github.com/AndrewGreen/fr_user_event_consumer/commit/fffc05065988972c86acba7b0612ca89b17085a9 [16:09:53] and added a useful commit message [16:11:42] actually AndyRussG, I guess since we now have a gerrit repo I should be submitting to that [16:15:11] jgleeson: yes 'fraid so 8p [16:15:18] ok will do :) [16:15:21] thx!!!! [16:15:48] Yeah the process in Gerrit is much geared to work on projects in maintenance mode, or smallish feature development, I think [16:16:25] Outside Gerrit it's nice to be atomic with the commits even if you're not expecting review until the end of the chain [16:16:32] (due to, say, things being in flux) [16:16:47] pls feel free to submit whatever degree of atomicity you like, though [16:17:44] and we can separate the +2'ing from a conceptual "approved" stamp in our brains... does that make sense? [16:18:33] yup [16:19:32] I had to look up atomic commits [16:19:51] I've never come across that description before in relation to small story telling commits [16:20:06] learn something new every day :) [16:21:11] 'mornin ejegg. I'm around any time you want to run me through that patch. [16:22:25] sure XenoRyet, in 5 minutes in the queenmary hangout? [16:22:31] Yea, sounds good [16:29:42] jgleeson: ^^^ [16:32:51] mepps: if you're not too busy, I'm going through the SmashPig recurring / merchant ref in use patch [16:33:07] joining now ejegg [16:44:56] sorry ejegg, I forgot I had an errand to run before tech-talk. I'll follow up by reviewing the patch for the merchant ref stuff. [16:58:39] fr-tech sounds like there's been calls and stuff going on just now--shall we do tech-talk on schedule, or does it make sense for any of you to delay it a bit? [16:58:44] (I'm easy either way [16:58:46] ) [16:59:33] AndyRussG: We're just in queenmary talking about some smashpig stuff [16:59:44] I think we're going to do tech-talk on schedule [17:00:07] You want to just jump in queenmary? [17:02:10] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banners should exist in their own namespace (stop using the MediaWiki namespace) - https://phabricator.wikimedia.org/T33595 (DStrine) [17:02:37] Fundraising-Backlog, Fr-CentralNotice-translations, MediaWiki-extensions-CentralNotice: CentralNotice banners should exist in their own namespace (stop using the MediaWiki namespace) - https://phabricator.wikimedia.org/T33595 (DStrine) [17:03:07] XenoRyet: okok! [17:04:51] Fundraising-Backlog, Fr-CentralNotice-translations, MediaWiki-extensions-CentralNotice, Trust-and-Safety, and 4 others: CentralNotice provides a means for non interface-admins to bypass new CSS/JS restrictions - https://phabricator.wikimedia.org/T202244 (DStrine) [17:07:50] (PS1) AndyRussG: WIP Add landingpage event processing [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455869 [17:13:18] (PS5) Ejegg: Increment merchant ref and retry payment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) [17:21:12] (CR) jerkins-bot: [V: -1] Increment merchant ref and retry payment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) (owner: Ejegg) [17:36:22] (CR) AndyRussG: [C: -2] WIP Add landingpage event processing [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455869 (owner: AndyRussG) [17:36:57] (PS2) AndyRussG: WIP Add landingpage event processing [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455869 [17:47:03] ejegg did mediawiki used to use tables for layouts? [17:54:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Corporate Gift selection for Engage instance - https://phabricator.wikimedia.org/T201883 (LeanneS) That makes sense. Could we add in Corporate Gift to the code? I also don't think we really need the restriction. [17:55:14] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising-Backlog, Patch-For-Review: publish Oanda exchange rates to internal, private google doc - https://phabricator.wikimedia.org/T200227 (DStrine) [18:57:53] mepps heh, wouldn't be surprised if some skins still did use tables [19:12:52] (PS1) Jgleeson: WIP: Backend Stats Comparison Script (bannerimpressions part) [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455900 [19:14:02] hmm that wasn't meant to happen... [19:31:48] (PS3) AndyRussG: WIP Add landingpage event processing [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455869 [19:35:45] Fundraising-Backlog, Epic: Turn off LandingPage events from testwiki - https://phabricator.wikimedia.org/T203020 (AndyRussG) p:Triage>Normal [19:38:15] Fundraising-Backlog, Epic: FUEC: Implement a command to validity of events in a file, without touching the DB - https://phabricator.wikimedia.org/T203021 (AndyRussG) p:Triage>Normal [20:03:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Corporate Gift selection for Engage instance - https://phabricator.wikimedia.org/T201883 (Eileenmcnaughton) @LeanneS I can remove it entirely if we don't need it [20:03:29] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Corporate Gift selection for Engage instance - https://phabricator.wikimedia.org/T201883 (Eileenmcnaughton) [20:10:07] (Abandoned) Jgleeson: WIP: Backend Stats Comparison Script (bannerimpressions part) [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455900 (owner: Jgleeson) [20:20:11] Fundraising-Backlog, Epic: FRUEC: Implement a command to validity of events in a file, without touching the DB - https://phabricator.wikimedia.org/T203021 (AndyRussG) [20:20:30] Fundraising-Backlog, Epic: FRUEC: Implement a command to check validity of events in a file, without touching the DB - https://phabricator.wikimedia.org/T203021 (AndyRussG) [20:30:48] (PS1) Jgleeson: WIP: Backend Stats Comparison Script (bannerimpressions part) [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456016 [20:45:23] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/455940 (owner: L10n-bot) [20:55:25] (PS2) Jgleeson: WIP: Backend Stats Comparison Script (bannerimpressions part) [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456016 [21:08:50] (PS3) Jgleeson: WIP: Backend Stats Comparison Script (bannerimpressions part) [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456016 [21:31:36] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Corporate Gift selection for Engage instance - https://phabricator.wikimedia.org/T201883 (LeanneS) That would be great. Thank you! [23:13:58] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Corporate Gift selection for Engage instance - https://phabricator.wikimedia.org/T201883 (Eileenmcnaughton) a:Eileenmcnaughton [23:14:20] (PS1) Eileen: Remove gift source restriction for Engage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456046 (https://phabricator.wikimedia.org/T201883) [23:14:42] The above is a super trivial review - it just removes a form validation per request on https://phabricator.wikimedia.org/T201883 [23:39:55] (PS1) Eileen: dev/core#353 fixed Source contact ID clause [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/456050 (https://phabricator.wikimedia.org/T203040)