[00:21:07] eileen: yep no problem i will do it in the morning [00:21:14] thanks cwd [00:21:18] :) [02:10:16] (CR) Ejegg: [C: -1] "The content of 'groups' should be an array of strings, not just a string, according to https://epayments-api.developer-ingenico.com/s2sapi" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/456519 (owner: XenoRyet) [14:50:23] (CR) Jgleeson: [C: 1] "I like the direction this is going in and feels like a major improvement from the previous code, especially the logic split out into more " (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445535 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [14:52:02] (CR) Jgleeson: [C: 1] "Looks good and paves the way for your subsequent patch." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445534 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [14:52:46] (CR) Mepps: "jgleeson are you comfortable with a +2?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445534 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [14:54:34] (CR) Jgleeson: [C: 2] "Sure, looks good to me" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445534 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [14:58:14] oops I guess I wasn't |ish all night... [14:58:33] (Merged) jenkins-bot: Consolidate flags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/445534 (https://phabricator.wikimedia.org/T194517) (owner: Mepps) [15:18:52] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog: add zendesk text to problems donating page - https://phabricator.wikimedia.org/T203176 (Ejegg) OK, added the Zendesk terms using the tag on https://donate.wikimedia.org/wiki/Problems_donating and https://donate.wikimedia.org/wiki/Pro... [15:19:45] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog: add zendesk text to problems donating page - https://phabricator.wikimedia.org/T203176 (Ejegg) I didn't see any way to get to Japanese versions of the policies on the Zendesk site, so I just left the links as is. [15:24:07] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog: add zendesk text to problems donating page - https://phabricator.wikimedia.org/T203176 (MBeat33) Many thanks, @Ejegg that looks great. I checked for Japanese-language versions too but didn't see any, I'll ask our rep if they can provide them. [15:24:27] (CR) Jgleeson: Increment merchant ref and retry payment (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) (owner: Ejegg) [15:33:48] (PS2) Ejegg: WIP: Show opt-in interstitial for paypal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449620 (https://phabricator.wikimedia.org/T199281) [15:34:01] (CR) jerkins-bot: [V: -1] WIP: Show opt-in interstitial for paypal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449620 (https://phabricator.wikimedia.org/T199281) (owner: Ejegg) [15:35:33] ejegg, I've reviewed smashpig ingenico merchant ref patches and made one comment, other than that code looks good. However I can't run your new test as I'm getting the following error 'CiviCRM_API3_Exception: Expected one PaymentProcessorType but found 0 [15:35:33] ' which I think is due to my broken civi state, so I can't +2 until I fix my local env which will hopefully be today [15:35:50] jgleeson: ah, right [15:35:58] those would be added in a wmf_civicrm update [15:36:13] thanks for the review! I'll take a look at that comment in a sec [15:36:30] (PS3) Ejegg: WIP: Show opt-in interstitial for paypal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449620 (https://phabricator.wikimedia.org/T199281) [15:36:31] yeah, the updates to that module fell over for me locally with about 56 left to go [15:36:38] so I'm gonna see if I can work out why [15:36:39] oof [15:36:56] lmk which update it was, maybe it's something I've dealt with [15:37:02] will do! [15:51:49] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: add bulk option for 'not a duplicate' in Find and Merge Duplicate Contacts - https://phabricator.wikimedia.org/T191118 (MBeat33) @Eileenmcnaughton This is an increasing impediment to the dedupe workflow. Agents must navigate around lots of search... [15:52:56] Fundraising-Backlog: test and deploy payments-listener Debian Stretch / PHP 7 - https://phabricator.wikimedia.org/T197887 (Jgreen) [15:53:14] Fundraising-Backlog: test and deploy payments-listener Debian Stretch / PHP 7 - https://phabricator.wikimedia.org/T197887 (Jgreen) [16:05:32] (PS10) Ejegg: Increment merchant ref and retry payment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) [16:06:02] (CR) Ejegg: "Thanks jgleeson, fixed that count bug" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) (owner: Ejegg) [16:19:16] mepps: any pointers for where to start on T202415 ? [16:19:17] T202415: Default value for no_thank_you on "New Contribution" UI - https://phabricator.wikimedia.org/T202415 [16:20:11] So, the best way for it to work, I think, would be to show the value in the UI on new contributions. [16:20:46] I don't think that's a post-hook [16:21:09] is there a different hook to use? [16:29:59] ah, looks like buildForm [16:31:43] (CR) Ejegg: [C: 2] Remove gift source restriction for Engage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456046 (https://phabricator.wikimedia.org/T201883) (owner: Eileen) [16:37:31] Fundraising-Backlog: test and deploy payments-listener Debian Stretch / PHP 7 - https://phabricator.wikimedia.org/T197887 (Jgreen) [16:39:32] (Merged) jenkins-bot: Remove gift source restriction for Engage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456046 (https://phabricator.wikimedia.org/T201883) (owner: Eileen) [16:46:34] huh, in buildForm the form elements don't seem to include the wmf_ custom fields [16:47:00] just the main info and the soft credit fields [16:54:37] mepps any idea how to get at the form after it's got the custom fields? [17:00:07] (PS1) AndyRussG: Refactor stats output [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456664 [17:00:28] fr-tech ^ fixed up FRUEC stats output [17:04:34] fr-tech having trouble getting in the hangout [17:16:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: did script delete a contact's email address? - https://phabricator.wikimedia.org/T203198 (MBeat33) @CCogdill_WMF fyi [17:44:13] (PS2) AndyRussG: Add LandingPage test data [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455189 (https://phabricator.wikimedia.org/T195594) [17:47:15] (PS6) AndyRussG: Add landingpage event processing [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455869 (https://phabricator.wikimedia.org/T195594) [18:00:11] (PS2) AndyRussG: Truncate strings to DB column limit [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456434 (https://phabricator.wikimedia.org/T195594) [18:00:50] (PS3) AndyRussG: Truncate strings to DB column limit [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456434 (https://phabricator.wikimedia.org/T195594) [18:02:07] (PS2) AndyRussG: Refactor stats output [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456664 (https://phabricator.wikimedia.org/T195594) [18:02:58] fr-tech ^ this is just the minor fix on the truncation patch + rebasing stuff + adding the bug tag to the commit messages [18:04:01] sorry ejegg i've been meetings for the last few hours [18:08:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: did script delete a contact's email address? - https://phabricator.wikimedia.org/T203198 (CCogdill_WMF) I don't see this contactID in IBM, fwiw. [18:17:13] Fundraising-Backlog: Unable to make edits from Summary Screen - https://phabricator.wikimedia.org/T203266 (NNichols) [18:25:34] (PS3) AndyRussG: Refactor stats output [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456664 (https://phabricator.wikimedia.org/T195594) [18:39:47] ejegg, this is the canary I was telling you about ... https://github.com/wikimedia/wikimedia-fundraising-crm-civicrm/blob/master/Civi/Core/InstallationCanary.php [18:40:03] ah yeah, i took a look at that [18:40:15] * ejegg halfway hoped there would be a picture of a bird [18:40:20] :) [18:41:20] not too sure why running the civicrm installer is resulting in the canary being added [18:41:46] although simply removing the table post-install makes the problems (it causes) go away [18:41:59] although it worries me that something else under the hood didn't work as expected [18:42:25] although although... [18:45:43] well I'm gonna leave it to install all the modules again, looks like it might work this time! [18:45:49] have a good weekend fr-tech! [18:48:22] (PS1) AndyRussG: Print a friendly message confirming config [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456672 (https://phabricator.wikimedia.org/T195594) [18:48:30] back later! [19:22:10] (PS3) XenoRyet: Change Payment Products filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/456519 [19:24:48] mepps so... it's a whole nother http request getting the custom field section of the new contribution page [19:24:59] that section does call the buildForm hook too [19:25:56] but with form type CRM_Custom_Form_CustomDataByType [19:26:23] and without the action populated, so it's hard to tell whether it's a new contrib or editing an old one [19:26:49] hmm, maybe there's a contribution ID populated someplace in there for edited ones? [19:27:17] relocating... [19:32:09] (CR) Ejegg: [C: -1] "The code looks good, but when I try it, the iframe shows the whole list of cards and makes me select one before showing the number input. " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/456519 (owner: XenoRyet) [19:40:17] (CR) XenoRyet: "Oh, that's probably to do with the other step they say we need to do in the configuration center. I'll try to look into that later, or fe" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/456519 (owner: XenoRyet) [20:01:09] hmm ejegg i'm having trouble following your work here but i can look around a little [20:12:27] mepps: lemme try one more thing and I'll put up a WIP showing where I'm trying to make the change [20:22:39] (PS1) Ejegg: Add no_thank_you default for new contribs via UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456741 (https://phabricator.wikimedia.org/T202415) [20:22:50] mepps aha, that seems to work ^^^ [20:25:13] I'll flesh out that commit msg with an explanation [20:29:42] (PS2) Ejegg: Add no_thank_you default for new contribs via UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456741 (https://phabricator.wikimedia.org/T202415) [20:30:18] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Default value for no_thank_you on "New Contribution" UI - https://phabricator.wikimedia.org/T202415 (Ejegg) p:Triage>Normal a:Ejegg [20:30:34] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog: add zendesk text to problems donating page - https://phabricator.wikimedia.org/T203176 (Ejegg) p:Triage>High a:Ejegg [20:33:23] taking a look ejegg [20:33:30] thanks! [20:33:55] d'oh, failmails from the omnimail repair [20:35:28] ugh my local crm is acting up... [20:38:38] (CR) Mepps: [C: 1] "Can't test it locally--working on fixing my setup but here are my initial thoughts." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456741 (https://phabricator.wikimedia.org/T202415) (owner: Ejegg) [20:39:00] (CR) Mepps: "I guess it's not +1 because I'm requesting one small change." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456741 (https://phabricator.wikimedia.org/T202415) (owner: Ejegg) [20:41:54] (CR) Mepps: "It works for me locally now." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456741 (https://phabricator.wikimedia.org/T202415) (owner: Ejegg) [20:42:06] (PS3) Ejegg: Add no_thank_you default for new contribs via UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456741 (https://phabricator.wikimedia.org/T202415) [20:42:56] (CR) Mepps: [C: 2] Add no_thank_you default for new contribs via UI (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456741 (https://phabricator.wikimedia.org/T202415) (owner: Ejegg) [20:43:12] (CR) Ejegg: "Thanks for the CR mepps! I changed the variable name. And I agree heartily we should break this file up. Splitting the hooks off into a se" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456741 (https://phabricator.wikimedia.org/T202415) (owner: Ejegg) [20:43:32] (CR) Mepps: [C: 2] "Agreed ejegg!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456741 (https://phabricator.wikimedia.org/T202415) (owner: Ejegg) [20:43:35] ooh, that was quick! [20:43:54] :) it worked locally for me and the variable name was my only concern [20:44:02] i'mma head to a spanish lesson shortly, but I'll put up a patch splitting the hooks out right after that [20:44:08] awesome [20:44:14] guess you'll be into your weekend at that point though [20:44:18] ps your fix for the survey extension was right on [20:44:18] so have a good one! [20:44:22] will do! [20:44:24] mepps oh cool [20:48:30] (Merged) jenkins-bot: Add no_thank_you default for new contribs via UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456741 (https://phabricator.wikimedia.org/T202415) (owner: Ejegg) [23:51:21] (PS2) AndyRussG: Print a friendly message confirming config [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456672 (https://phabricator.wikimedia.org/T195594)