[00:46:58] (CR) Legoktm: [C: 2] build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/457167 (owner: Libraryupgrader) [01:27:15] (CR) jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/457167 (owner: Libraryupgrader) [04:29:07] (PS1) AndyRussG: Add event_type arg to log_file_mapper.get_lastest_time() [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457272 (https://phabricator.wikimedia.org/T195594) [04:38:31] (PS1) AndyRussG: [WIP] Inline doc and comments [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457275 (https://phabricator.wikimedia.org/T195594) [14:43:46] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog: add zendesk text to problems donating page - https://phabricator.wikimedia.org/T203176 (Pcoombe) Thanks a lot for sorting this @Ejegg. Great idea to use the tag! [15:19:43] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/457482 [15:20:00] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/457482 (owner: Ejegg) [15:21:08] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/457483 [15:21:16] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/457483 (owner: Ejegg) [15:22:29] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/457483 (owner: Ejegg) [15:22:36] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/457484 [15:23:31] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/457484 (owner: Ejegg) [15:40:57] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/457482 (owner: Ejegg) [15:41:01] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/457484 (owner: Ejegg) [15:44:37] !log updated payments-wiki from 763e14b6df to e749025c1a [15:44:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:45:43] !log updated civicrm from from 863ed3f1a2 to ea690851f0 [15:45:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:46:51] hmm, what's up with that? [15:47:01] hey ejegg, you not taking the holiday today? [15:47:16] jgleeson: no, it's not a holiday here so I figure I'll take it later [15:47:27] getting some failmail, maybe from that civi update [15:47:35] yeah just noticed the consumers [15:47:41] did you switch them off for the release? [15:47:47] no, it was a tiny change [15:47:52] but I'll roll it back [15:48:33] !log rolled back civicrm to 863ed3f1a2 [15:48:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:49:05] ah crap, it's the queue settings [15:49:23] those were only for the frdev instance [15:49:35] but they got updated for prod [15:51:33] !log updated civicrm (back) to ea690851f0, but rolled back queue server settings [15:51:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:51:52] OK, that should do it! [15:53:57] Fundraising-Backlog, fundraising-tech-ops: Test Redis caching on Civi staging - https://phabricator.wikimedia.org/T202936 (Ejegg) @cwdent or @Jgreen, looks like we'll need php-redis installed on all the civi boxen to make this work [15:54:15] how's your day been, jgleeson ? [15:54:25] quiet :) [15:54:39] heh, i bet. Any luck with your local civi instace? [15:54:41] not too bad, just working on the landing page stuff for the FRUEC tests [15:54:50] ah no, not exactly [15:55:02] I've reprovisioned a new instance [15:55:30] although it looks like there's some bugs with the fundraising dash in the latest vagrant build [15:55:45] I think it's to do with bower, although I don't need to fix it just yet [15:55:52] ah, I guess I'm not surprised [15:56:13] but the good news is civi is back for me [15:56:20] woohoo [15:56:40] although I couldn't restore the original, so I'm gonna leave that vm as a backup to pull across custom config [15:56:57] hmm, of all projects to leave neglected for a year, one that's pure JS and node is probably the likeliest to go stale, huh [15:57:06] lol indeed [15:57:34] I kinda wanna work out why the other instance of civi never worked [15:58:01] but now isn't the time, I might revisit it again [15:58:22] phew, yeah, I imagine it could have gotten scrambled in an infite number of ways [15:58:44] "Happy families are all alike; every unhappy family is unhappy in its own way." [15:58:58] -Tolstoy, on debugging [15:59:05] hehe [16:24:04] shoot, looks like that field disablement patch stole a couple pixels from the iframe space, and now it's got a scroll bar [16:26:34] huh, only on FF? [16:26:52] :O [16:29:06] (PS1) Ejegg: Add a couple px to GC iframe to stop scroll [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/457507 [16:29:19] Could have been a change in the hosted form [16:29:33] (CR) Ejegg: [C: 2] Add a couple px to GC iframe to stop scroll [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/457507 (owner: Ejegg) [16:29:51] anyway, +2 pixels to the height fixed it [16:41:04] (Merged) jenkins-bot: Add a couple px to GC iframe to stop scroll [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/457507 (owner: Ejegg) [17:00:03] jgleeson|dinner and AndyRussG|a-whey if you guys want to do a mini-standup when you're back, just let me know [17:11:45] ejegg: I can join more or less any time, sure [17:11:54] (mostly not working today, tho heh) [17:13:59] cool, cool [17:14:15] ah, I should get myself subscribed to fruec patches [17:14:26] don't see it on the Git/Reviewers page yet [17:17:51] Ah, I guess those are just added by hand [17:19:14] added! With all fr -eileen as subscribed [17:27:47] ejegg: ah cool beans, thx! [17:28:24] I do hope to finish the inline doc/comments patch todayz [17:28:29] Fundraising-Backlog, FR-Smashpig, Fr-Ingenico-integration_2017-18, MediaWiki-extensions-DonationInterface: Trying to get hosted checkout status with no hosted checkout ID - https://phabricator.wikimedia.org/T203406 (Ejegg) [17:29:21] and maybe update the specification and SQL tasks [17:36:27] (PS1) Ejegg: Update no_thank_you for hand-entered contribs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457514 (https://phabricator.wikimedia.org/T97684) [17:37:00] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix blank no_thank_you - https://phabricator.wikimedia.org/T97684 (Ejegg) p:Triage>Normal a:Ejegg [18:29:45] (CR) Ejegg: [C: -1] "Seems to break the inline editing buttons like 'Add address' or 'add or edit email'" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/455748 (owner: Eileen) [18:39:54] (CR) Ejegg: [C: 2] dev/core#353 fixed Source contact ID clause [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/456050 (https://phabricator.wikimedia.org/T203040) (owner: Eileen) [18:43:13] (PS4) Ejegg: Extended reports update. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456055 (https://phabricator.wikimedia.org/T151271) (owner: Eileen) [18:43:26] (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456055 (https://phabricator.wikimedia.org/T151271) (owner: Eileen) [18:45:37] (CR) Ejegg: "Looks like we need to re-apply the WMF patches on top of this, for namespaced stuff to work" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/456304 (owner: Eileen) [18:47:19] (Merged) jenkins-bot: dev/core#353 fixed Source contact ID clause [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/456050 (https://phabricator.wikimedia.org/T203040) (owner: Eileen) [18:48:13] (PS1) Ejegg: Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/457540 [18:49:04] (Merged) jenkins-bot: Extended reports update. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456055 (https://phabricator.wikimedia.org/T151271) (owner: Eileen) [18:50:28] (CR) Ejegg: [C: 2] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/457540 (owner: Ejegg) [18:54:23] (CR) Ejegg: "Also, is there something missing here? Once I re-apply the WMF patches, there's nothing left except the version numbers and datestamps" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/456304 (owner: Eileen) [18:56:32] (CR) Ejegg: [C: 2] "Ahhhh, we applied the actual fix in I3c93e5b48cf6223588bdc19bb8512de126e2a86d, we just didn't update the version number" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/456304 (owner: Eileen) [18:56:38] (CR) Ejegg: [V: 2 C: 2] Drupal security updates - to 7.59 [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/456304 (owner: Eileen) [18:56:52] (CR) Ejegg: [V: 2 C: 2] Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/457540 (owner: Ejegg) [18:59:12] oh man [18:59:32] our ingenico integration is doing some weird stuff lately [18:59:49] jgleeson: also any time you'd like to talk over FRUEC comparison scripts or anything, pls lmk :) [18:59:55] ejegg: ^ also! :) [19:00:10] how's it going w/ you both, btw? [19:00:43] pretty good so far :) how about you? [19:03:57] (Merged) jenkins-bot: Re-apply WMF patches [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/457540 (owner: Ejegg) [19:06:31] (PS1) Ejegg: Update Civi and Drupal submodules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457544 [19:06:34] (CR) Ejegg: [C: 2] Update Civi and Drupal submodules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457544 (owner: Ejegg) [19:07:22] (PS2) Ejegg: Update no_thank_you for hand-entered contribs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457514 (https://phabricator.wikimedia.org/T97684) [19:08:18] jgleeson: ohh, what's up with the ingenico integration today? [19:08:49] I just pushed mepps's patch for the flags consolidation [19:09:07] the missing hostedCheckoutId bug ejegg [19:09:10] is it related to processing of payments? [19:09:11] that's a strange one [19:09:18] jgleeson: ahh yeah, that was a few days ago [19:09:37] wondering if it's ppl coming to the resultSwitcher page without anything in session [19:09:49] but... those should see a fail page, I think [19:09:50] hmmmm [19:10:52] speaking of ingenico, are you able to run test locally for the recurring processor, now that you've got a happy CRM install again [19:10:55] ? [19:11:45] umm I haven't tried yet but I'll give it a go [19:11:55] Thanks! [19:12:00] would be good to push that out, I saw some new failures last night [19:12:05] I'd be psyched to get that out, yeah [19:13:09] I think the new patch is a lot better organized too [19:13:52] (Merged) jenkins-bot: Update Civi and Drupal submodules [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457544 (owner: Ejegg) [19:15:07] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/457546 [19:15:11] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/457546 (owner: Ejegg) [19:17:51] jgleeson: not tooo bad thx :) [19:18:11] just animating a couple singing cats here... [19:18:17] :) [19:18:39] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/457546 (owner: Ejegg) [19:22:49] !log updated CiviCRM from ea690851f0 to ac5ac25eba [19:22:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:31:39] hey ejegg, tests passing for me so looks good. I just noticed this line https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/453479/10/sites/default/civicrm/extensions/org.wikimedia.smashpig/CRM/Core/Payment/SmashPigRecurringProcessor.php@233 [19:31:57] is_test [19:31:58] oh, the 'is_test' [19:32:02] yeah [19:32:17] right, I was just following the omnimail processor on that one [19:32:18] is it related to actual testing? [19:32:34] not unit testing, but that IS a field available in the payment object [19:32:47] oh ok [19:33:01] just looking at it now [19:33:11] out of curiosity [19:33:30] yeah, seems sub-optimal to have [19:33:42] ahhh [19:33:49] so, the payment processor config page [19:34:06] lets you specify both production and test URLs for the processor API [19:34:27] I guess so you don't need a separate Civi instance to try out your payment processor sandbox [19:34:36] betting that's connected [19:35:09] ahhh i see [19:35:37] hmm still a few quirks to iron out on my new setup, I'm getting smart template errors loading the api explorer [19:35:44] permission joys! [19:35:50] ah man [19:35:56] yeah, that's perennial [19:36:10] I thought I had a fix with chmod +S [19:36:47] but even so the web UI seems to make files I can't delete (with my user in the www-data group) [19:36:56] and vice versa [19:37:25] unit tests leave files with my user and no 'w' permission for the web user [19:37:58] tricky [19:38:40] ok, the code looks good and tests are passing so I will +2 if you're happy with them? [19:38:54] awesome! [19:39:04] let's just rebase that first [19:39:15] ah good call [19:39:29] (PS7) Ejegg: SmashPig payment processor: expose API codes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/452871 (https://phabricator.wikimedia.org/T201773) [19:39:37] (PS11) Ejegg: Increment merchant ref and retry payment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) [19:39:49] heh, no functional difference, just a cleaner git log [19:42:16] (PS2) Ejegg: Add configs for unsubscribe and opt-in queues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/451706 (https://phabricator.wikimedia.org/T200576) [19:42:23] (CR) Ejegg: [C: 2] Add configs for unsubscribe and opt-in queues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/451706 (https://phabricator.wikimedia.org/T200576) (owner: Ejegg) [19:42:47] self-merged a config-only thing, to make testing the opt in queue consumer easier ^^^ [19:42:51] (Merged) jenkins-bot: Add configs for unsubscribe and opt-in queues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/451706 (https://phabricator.wikimedia.org/T200576) (owner: Ejegg) [19:43:21] woot, gotta love having at least one project where none of the unit tests have to hit a db [19:43:30] cool, just waiting on jenkins to do its thing [19:43:38] heh, oh man [19:43:57] if you want to +2 the rebased patches before seeing the v+2, that should be fine [19:44:10] and if jenkins comes back with a -1, you can remove your +2 [19:44:48] (CR) Jgleeson: [V: 2 C: 2] SmashPig payment processor: expose API codes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/452871 (https://phabricator.wikimedia.org/T201773) (owner: Ejegg) [19:44:56] (CR) Jgleeson: [V: 2 C: 2] Increment merchant ref and retry payment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) (owner: Ejegg) [19:45:10] ah, you would usually just C+2 and leave all the Vs to jenkins [19:45:12] done! [19:45:20] thanks! [19:45:21] uh oh [19:45:27] eh, no harm done [19:45:44] (CR) Jgleeson: [C: 2] Increment merchant ref and retry payment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) (owner: Ejegg) [19:46:10] looks like jenkins has woke up [19:47:02] heh, it's actually pretty amazing that it tears down and rebuilds an entire CRM system on top of a content management framework for each patch [19:47:47] yeah it's a game changer for dev [19:48:10] when CI took over, I feel like our jobs became that bit more professional [19:48:35] srsly [19:48:46] vs the days of ftp the full site for a new release [19:48:53] and then click around the homepage for testing [19:48:56] nerve wracking [19:49:18] Wikimedia-Fundraising, MediaWiki-extensions-NavigationTiming, Performance-Team: Track when a CentralNotice banner was displayed to the user in NavTiming - https://phabricator.wikimedia.org/T195840 (Krinkle) [19:50:28] (Merged) jenkins-bot: SmashPig payment processor: expose API codes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/452871 (https://phabricator.wikimedia.org/T201773) (owner: Ejegg) [19:52:12] (Merged) jenkins-bot: Increment merchant ref and retry payment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/453479 (https://phabricator.wikimedia.org/T201773) (owner: Ejegg) [19:53:08] (Abandoned) Ejegg: WIP break up giant audit function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/374559 (owner: Ejegg) [19:53:47] woot, thanks again jgleeson . I'll send that out and see what I can do to fix up the contributions that failed [19:54:11] np [19:55:57] (Restored) Ejegg: Remove obsolete db_error() calls [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/268838 (owner: Ejegg) [19:56:20] (PS2) Ejegg: Remove obsolete db_error() call [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/268838 [19:56:23] whew, I've got a lot of old patches kicking around [19:56:35] seeing which ones are rebase-able [19:56:55] that's just reminded me that I wanna revisit prometheus this week [19:57:12] I think there were a few fixes outstanding [19:57:32] I think we can some duplicate data at some point [20:04:20] hey AndyRussG, sorry for not responding on the fruec talk, I was trying to reimport my previous test data into new fruec (after rebasing over your changes) and the old app so I run a test with the latest changes [20:04:33] jgleeson: no worries! [20:05:23] lmk if I can help with stuff... in Gerrit you can keep working on a separate branch if u like, btw [20:39:42] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/457592 (owner: L10n-bot) [21:12:18] hi eileen! [21:12:27] Hey [21:12:27] I just deployed a few of your patches [21:12:31] looking good! [21:12:33] ejegg: thanks heaps [21:12:41] I haven’t cleared my emails yet [21:12:57] The one thing I found problems with was the contact editor updates [21:13:34] oh wait, I should try that again with all the caches cleared. Maybe it was just leftover CSS [21:13:56] yeah there is a cache clearing issue I think [21:14:19] looks like you figured out what was going on with drupal too [21:14:47] heh, getting the version numbers in sync is good [21:15:04] did you tinker with Redis too? [21:15:24] not much - I tried it locally and got a missing class error [21:15:35] just realized that was the php-redis extension I needed [21:15:53] so I noted we needed that for ops on the ticket [21:16:08] about to try again locally after installing that [21:17:35] ejegg: I think ops installed on staging though? [21:19:28] eileen: looks like just the redis server, not the php-redis extension [21:19:35] ah ok [21:20:04] I guess you are working today because you are not in the US but cwd isn't? [21:20:15] eileen: yah, no fr-tech-ops today [21:20:46] ok well Casey transferred the db from live so I’ll try that performance script again [21:20:55] cool! [21:21:10] did you see my note about the 'latest contribution' logic? [21:21:28] Does it look to you like we're still duplicating that in php and the trigger? [21:24:49] ejegg: I saw the note but I haven’t looked at it yet - will do today [21:24:57] I think I’m gonna [21:25:23] 1) cut a new Civi version off latest code & put it on staging (latest Redis / caching etc ) [21:25:24] rockin. here's hoping we can just delete some redundant code and leave the triggers! [21:25:35] 2) do some testing on staging [21:25:40] with variants [21:26:01] 3) review your no-thank you patch [21:26:57] cool, cool. The one in review now is a pretty minor data fix - mepps reviewed the one to add a default for contribs entered via the UI [21:27:09] but if there's a better way to do the UI one, I'd love to hear about it [21:27:58] Took me a while to figure out that the buildForm hook for the contribution was executing on a completely different HTTP request from the one for the custom field half of the form [21:28:40] ejegg: so I’m not totally up on that one - how do we use the info in that field? [21:28:53] it's just consulted by the thank-you mailer [21:30:54] ejegg: so the thank you mailer sends if that field is unset AND if no_thankyou_date is unset? [21:31:31] yeah [21:31:48] the idea with the current work is to accept '' or '0' as indicators to send mail, not just NULL [21:31:59] (in the no_thank_you field) [21:32:17] so then we'll be able to override defaults in imports, for example [21:33:02] I had merged the TY mailer selection change earlier but had to undo it until the UI default + historic value fix [21:33:46] so we can just restore that once the thing in review is run [21:34:33] OK, after clearing CSS cache, the contact layout extension updates are looking better [21:35:13] (PS2) Ejegg: Contact layout extension updates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/455748 (owner: Eileen) [21:36:17] (CR) Ejegg: [C: 2] "Looks better after clearing CSS and drupal caches! After deploying this, let's send a note around to users suggesting ctrl-F5 if things lo" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/455748 (owner: Eileen) [21:38:38] ejegg: oddly I just ran select count(*) FROM wmf_contribution_extra WHERE no_thank_you in ('', '0') AND source_type IS NULL; [21:38:46] & got about 10k less than in your patch [21:43:47] (Merged) jenkins-bot: Contact layout extension updates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/455748 (owner: Eileen) [21:55:46] g'night fr-tech [22:00:58] (PS1) AndyRussG: Flag SQL template constants as private [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457691 (https://phabricator.wikimedia.org/T195594) [22:01:11] (PS2) AndyRussG: [WIP] Inline doc and comments [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457275 (https://phabricator.wikimedia.org/T195594) [22:01:17] eileen: ooh, that's weird [22:01:33] yeah also I think a bunch have had thank yous [22:01:54] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix blank no_thank_you - https://phabricator.wikimedia.org/T97684 (Eileenmcnaughton) @Ejegg just working through this select no_thank_you, source_type, count(*), thankyou_date FROM... [22:01:58] well, I wouldn [22:02:05] see what I just pasted on the phab [22:02:14] 't think it should matter much how many there were [22:02:45] so the ones with NULL no thank you + no source + no thank you emails - who are they? [22:04:41] hmm, could have been imported after the cutoff date for sending thank yous? [22:04:53] the ty mailer only will thank things newer than 30 days or so [22:05:05] but... no source [22:05:34] aha, I had missed a 'group by' in my earlier select [22:05:40] right, I get 83k now [22:05:43] oooops [22:06:01] * ejegg should run with strict_group_by [22:06:09] or whatever the option is called [22:08:57] Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix blank no_thank_you - https://phabricator.wikimedia.org/T97684 (Eileenmcnaughton) Or more | no_thank_you | source_type | count(*) | sum(I... [22:09:06] ejegg: so (per phab) 6k of the 83k have already had thank you emails [22:09:57] ok, maybe I'll use the ticket's suggested 'legacy_blank' and include all the old ones, not just the ones with source NULL [22:10:30] ejegg: yeah perhaps we should exclude the ones that actually got a thank you [22:10:41] OK, cool, I'll do that too [22:10:54] I’m wondering what they are - will find a couple of examples [22:11:08] may have been edited after being thanked [22:11:20] I think any edit via the UI will result in '' rather than NULL [22:16:15] (PS3) Ejegg: Update legacy blank no_thank_you reasons [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457514 (https://phabricator.wikimedia.org/T97684) [22:16:37] OK eileen, updated the UPDATE ^^ [22:18:41] and tried it out on my local db [22:27:32] (PS1) Ejegg: '0' or blank no_thank_you means send email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457697 (https://phabricator.wikimedia.org/T202099) [22:27:45] ejegg:just thinking - perhaps add a receive_date < ‘2018-09-01’ so we don’t catch any that are just happening as it isi run [22:28:22] (CR) Eileen: [C: 1] "I'm happy with this - I checked on staging & before this there are 735 rows caught by" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457514 (https://phabricator.wikimedia.org/T97684) (owner: Ejegg) [22:28:47] eileen: I think we're OK since we're not updating ones with NULL no_thank_you, which is the only thing that gets thanked now [22:28:55] ok cool [22:29:00] (CR) Eileen: [C: 2] Update legacy blank no_thank_you reasons [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457514 (https://phabricator.wikimedia.org/T97684) (owner: Ejegg) [22:29:04] thanks! [22:29:16] I'll push that stuff out as soon as it merges [22:29:53] ejegg: you have some other changes in review but they look old / incomplete? [22:30:06] probably... [22:30:20] I was just starting to clean up some branches locally [22:30:31] should do a real gerrit clear-out too [22:31:33] couple of cleanup patches: https://gerrit.wikimedia.org/r/451221 , https://gerrit.wikimedia.org/r/454733 , https://gerrit.wikimedia.org/r/434597 [22:34:15] (CR) Eileen: [C: 2] "Yeah seems fine. Note we should also move the theme from sites/all/themes to sites/default/themes for drupal upgrade reasons" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/451221 (owner: Ejegg) [22:35:11] (CR) Eileen: [C: 2] '0' or blank no_thank_you means send email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457697 (https://phabricator.wikimedia.org/T202099) (owner: Ejegg) [22:36:19] (Merged) jenkins-bot: Update legacy blank no_thank_you reasons [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457514 (https://phabricator.wikimedia.org/T97684) (owner: Ejegg) [22:38:02] ejegg: so if Globalcollect Audit is unused it shoul be disabled (& perhaps uninstalled) before we remove the code [22:38:12] eileen: ahh, good point [22:38:21] I always forget that [22:38:36] that would be a two-step patch, then? [22:38:51] I guess - unless we do via the UI [22:38:52] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/457698 [22:39:03] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/457698 (owner: Ejegg) [22:39:03] but perhaps that doesn’t respect people’s locals [22:39:07] yeah [22:39:27] i'm going to leave the selection update for tomorrow's deploy [22:39:37] (got to head out in 10 min-ish) [22:39:41] fair enough [22:39:55] (Merged) jenkins-bot: Delete dev files for Tivy [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/451221 (owner: Ejegg) [22:39:56] ...or maybe later tonight [22:40:08] don’t deploy tonight [22:40:19] if there is a problem then you have deployed at bedtime [22:40:53] (Merged) jenkins-bot: '0' or blank no_thank_you means send email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457697 (https://phabricator.wikimedia.org/T202099) (owner: Ejegg) [22:40:55] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/457698 (owner: Ejegg) [22:44:15] heh, good call. tomorrow it is [22:45:21] !log updated CiviCRM from ac5ac25eba to 1330df3064 [22:45:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:46:56] (PS1) Eileen: Move tivy theme out of drupal managed themes dir (needs drupal patch at same time [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457702 [22:47:33] (PS1) Eileen: Move tivy theme out of drupal managed themes dir (needs crm patch at same time [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/457703 [22:47:36] ahh, I didn't realize there was a better place for downloaded themes [22:55:02] k, looking good after a cache clear [23:21:51] eileen: hey, i looks like you already know but the staging db should be refreshed [23:22:10] cwd thanks [23:24:19] also i finally scripted it to be 2 commands instead of about 20 [23:34:24] cwd :-) [23:34:35] cwd - is php-redis on staging? [23:41:38] (PS1) Eileen: Disable globalcollect_audit (& uninstall) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457732 [23:42:15] (CR) Eileen: "ejegg I've added this for the uninstall https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/457732/" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434597 (owner: Ejegg)