[00:00:50] ejegg: thanks a lot :) [00:03:51] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 10 others: Create Ingenico orphan rectifier ... - https://phabricator.wikimedia.org/T163949 [00:14:00] (PS1) Ejegg: WIP move _extra field calc to pre hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/458333 (https://phabricator.wikimedia.org/T203537) [00:17:29] (CR) jerkins-bot: [V: -1] WIP move _extra field calc to pre hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/458333 (https://phabricator.wikimedia.org/T203537) (owner: Ejegg) [03:12:44] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 10 others: Create Ingenico orphan rectifier ... - https://phabricator.wikimedia.org/T163949 [07:22:39] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/458371 (owner: L10n-bot) [10:51:37] rxy: Thanks for the input. We did take the fundraising campaigns in Japan down last night because of the situation there. In the next few days we'll discuss when they might go back up. [12:07:38] Wikimedia-Fundraising, MediaWiki-extensions-NavigationTiming, Performance-Team: Track when a CentralNotice banner was displayed to the user in NavTiming - https://phabricator.wikimedia.org/T195840 (Gilles) @Ejegg when is the next CentralNotice deployment scheduled? If not scheduled or far in the futu... [14:34:06] (PS3) Ejegg: Use redis to cache drupal lookups [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/458089 [15:18:50] (PS2) Ejegg: Move _extra field calc to pre hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/458333 (https://phabricator.wikimedia.org/T203537) [15:19:02] whew, that one got ugly^^^ [15:19:29] but I think it's working! [15:19:54] It should save us a duplicate insert into wmf_contribution_extra for every contribution save. [15:22:33] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: wmf_contribution_extra table is inserted twice for a single contribution insert - https://phabricator.wikimedia.org/T203537 (Ejegg) p:Triage>Normal a:Ejegg [15:26:42] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Owls, and 4 others: DB schemas (production changes and test DB) and SQL commands ... - https://phabricator.wikimedia.org/T196564 [15:30:58] ejegg: o/ [15:31:05] we have been doing a little CSP header testing [15:41:15] hi cwd [15:42:09] how goes? [15:44:45] pretty good [15:45:17] how's things in CO ? [15:46:18] NM now [15:46:21] but good :) [15:47:30] so basic csp settings break some stuff on payments [15:47:43] i think it can all get whitelisted by modifying the header [15:47:56] but probably some of it is good cleanup opportunities [15:50:09] for instance: Content Security Policy: The page’s settings blocked the loading of a resource at data:image/svg+xml,%3Csvg%20xmlns='http:... (“default-src”). [15:50:28] i think it's complaining about http? [15:53:20] ooh, right, sorry to totally space out on your relocation. that was like 2 yrs ago now, right? [15:54:19] also, no idea about http in xmlns in svg [15:54:27] but we could change that and try again [15:54:46] any idea which svg that would be? [15:55:27] lessee, we'll def need to whitelist a bunch of amazon sources for the amazon pay script [15:56:33] yep just over 2 years [15:56:52] ejegg: another thing it doesn't like is inline js of any type, but i'm guessing changing that is a tall order [15:56:58] and add adyen and new + old ingenico iframe domains to frame-src [15:57:29] yep [15:57:41] so that made me wonder about setting the header in php [15:57:48] cwd right, resource loader adds a couple scripts right to the top [15:58:51] and I think mw doesn't have code to generate nonces till 1.32 [15:59:40] if we set the header in php we could just whitelist what was going to be used that time [16:00:00] hmm [16:00:52] yeah, would be preferable to just whitelist the amazon stuff for that one gateway [16:03:29] it's probably possible in nginx [16:03:39] but probably grosser than php [16:04:15] My only worry is that there's a lot on fr-tech's plate right now [16:04:45] and we're short-handed with mepps taking on k4's duties [16:05:09] would it be possible to just come up with one blanket header to start with and do that in nginx [16:05:34] then do something more tailored as soon as fr-tech has time? [16:06:54] yeah probably best [16:10:10] heh, cool [16:10:39] tho if you want to submit a donationinterface patch I'd be more than happy to CR! [16:14:58] congrats for the shout-out on the exchange rates jgleeson! [16:24:05] oh hey, what happened with that? [16:25:47] i dunno exactly, but the accounting dept just gave a presentation saying they hope in a couple months to have automatic conversion in expense reports [16:26:25] dstrine are we forgoing daily autopsy in favor of the retro? [16:26:37] mepps it was moved earlier [16:26:56] ah cool [16:26:57] oh woops, guess i wasn't there [16:26:58] b/c of clash with staff community time [16:27:58] my news: thing in review to speed up queue imports by a tiny amount: https://gerrit.wikimedia.org/r/458333 [16:28:19] and opt-in qc ready for review: https://gerrit.wikimedia.org/r/456517 [16:29:10] oh hey, I should pull that patch onto staging to see what the actual effect is [16:35:20] reminder: if you lol at anything in this channel, copy it to https://office.wikimedia.org/wiki/Bash so Moriel can make us famous! [16:39:57] hmm, very minor difference in performance :S [16:41:02] baseline was 200 in 36 seconds [16:41:31] and over 6 runs with the new patch, 4 were 36 seconds and 2 were 35 seconds [16:48:02] i keep feeling like i need to respond in the comunity time call righ tnow [16:49:57] heh [17:50:05] (PS4) Ejegg: Show opt-in interstitial for paypal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449620 (https://phabricator.wikimedia.org/T199281) [18:08:41] pcoombe: Thanks for considering situation. [18:34:37] fundraising-tech-ops: EPIC: migrate fundraising hosts to Debian Stretch - https://phabricator.wikimedia.org/T185013 (Jgreen) [18:34:41] Fundraising-Backlog: test and deploy payments-listener Debian Stretch / PHP 7 - https://phabricator.wikimedia.org/T197887 (Jgreen) Open>Resolved [19:07:07] (PS5) AndyRussG: Inline doc and comments [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457275 (https://phabricator.wikimedia.org/T195594) [19:18:29] (PS1) AndyRussG: Minor improvements in create_tables.sql [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/458565 [19:49:52] Fundraising-Backlog: custom payment support for endowment donation form - https://phabricator.wikimedia.org/T203603 (DStrine) [19:56:09] XenoRyet: available for some CR? That paypal Opt-In interstitial is ready for review [19:56:27] https://gerrit.wikimedia.org/r/449620 [19:56:48] (test with GB or IE, with and without opt_in params on the QS [19:56:51] ) [19:57:28] Yea, I actually have to run out for a bit right now. One of my cats is sick and needs to go to the vet, but I was planning on taking a look at that when I get back. [19:57:50] (CR) Ejegg: "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448605 (owner: Ejegg) [19:58:00] k, thanks [19:58:07] hope the cat gets well soon [19:58:48] Yea, we don't think it's anything too serious, she's just throwing up a lot the past couple days. [19:58:55] Anyway, back in a while. [20:12:21] ah crap, sorry dstrine, be at the mtg in a sec [20:26:14] Fundraising-Backlog: Generate new Civi certificate for Kristie - https://phabricator.wikimedia.org/T200281 (MBeat33) @krobinson do you still need a new cert? [20:43:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Break up wmf_civicrm.module - https://phabricator.wikimedia.org/T203715 (Ejegg) [20:54:40] fr-tech, there's a new exhibit in the failmail zoo: https://www.mediawiki.org/wiki/Fundraising_tech/Failmail_zoo [21:25:34] (PS1) Ejegg: Un-cancel Ingenico recurring with duplicate merchant ref [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/458594 (https://phabricator.wikimedia.org/T201773) [21:32:16] ready for some review fr-tech ^^^ [21:32:26] oh hmm, I could try that on dev [21:40:58] shoot, that didn't seem to work [21:51:12] Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, and 3 others: Deal with Ingenico Connect code 300620: MerchantReference XXXX already exists - https://phabricator.wikimedia.org/T201773 (... [21:57:21] well, the SQL was good [22:33:16] (CR) XenoRyet: [C: 2] "Yea, looks good. Works for me." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449620 (https://phabricator.wikimedia.org/T199281) (owner: Ejegg) [22:42:31] (CR) Ejegg: [C: 2] Add form_variants from fr/REL1_27 branch [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448605 (owner: Ejegg) [22:42:51] (CR) Ejegg: [C: 2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448607 (owner: Ejegg) [22:44:21] XenoRyet: thanks for the CR [22:44:37] (Merged) jenkins-bot: Show opt-in interstitial for paypal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/449620 (https://phabricator.wikimedia.org/T199281) (owner: Ejegg) [22:44:38] No worries [22:44:43] hoping to get these recurring ones un-cancelled in the next couple days too: [22:44:58] https://gerrit.wikimedia.org/r/458594 [22:45:35] Did I see in backscroll that you ran a test on dev that didn't work out? [22:45:43] (Merged) jenkins-bot: Add form_variants from fr/REL1_27 branch [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448605 (owner: Ejegg) [22:45:48] (Merged) jenkins-bot: Fix .gitmodules branch for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448607 (owner: Ejegg) [22:45:53] (Merged) jenkins-bot: Update fundraising extensions [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/448784 (owner: Ejegg) [22:46:33] XenoRyet: I'm a lil suspicious of deb [22:46:37] *dev [22:46:50] Agreed, just wondering what happened when you tried. [22:46:59] nothing that I could see [22:47:17] but when I tried capturing the generated SQL and running that, it worked correctly [22:47:31] hmm... [22:47:42] gremlins [22:47:52] So if you want to just review the SQL for a sanity check, I can try the real update on prod [22:48:02] Yea, will do. [22:48:03] and just run the SQL if that doesn't do it [22:48:31] thanks! [22:51:58] (CR) Ejegg: [C: 2] "These look good. I notice a bunch of TY page stuff in here that the old script wouldn't have dealt with. Guess you can filter those out!" [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455189 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG) [22:52:48] (CR) Ejegg: [V: 2 C: 2] "Oh hey, this repo isn't being watched by Jenkins yet" [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455189 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG) [22:54:32] (CR) XenoRyet: [C: 2] "SQL looks good. This will get it done." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/458594 (https://phabricator.wikimedia.org/T201773) (owner: Ejegg) [23:00:35] (Merged) jenkins-bot: Un-cancel Ingenico recurring with duplicate merchant ref [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/458594 (https://phabricator.wikimedia.org/T201773) (owner: Ejegg) [23:11:48] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/458615 [23:13:00] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/458615 (owner: Ejegg) [23:14:02] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/458615 (owner: Ejegg) [23:16:03] !log updated CiviCRM from 7918924e73 to 52873b5dcc [23:16:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:19:00] Cool, that worked in prod [23:24:57] gnight all [23:25:03] Nice [23:25:06] Have a good one [23:25:47] (PS3) Ejegg: Use caret versioning for compat with mediawiki 1.31 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/451343 [23:27:37] XenoRyet: if you're looking for stuff to do, sounds like mepps was asking if anyone else could take a look at the ingenico orphan rectifier, and mbeat was asking for us to prioritize it coz of the impact on DS [23:28:01] I have stuff, but I can take a peek at that too. [23:29:21] ejegg|away: thx for the review! btw suggested starting point for checking out the actual code is the last patch on the chain, currently this one: https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/FRUEC/+/458565/