[02:08:46] (PS1) Eileen: Remove On Duplicate UPDATE for new inserts to improve performance & reduce deadlocks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/459667 [02:13:27] (CR) jerkins-bot: [V: -1] Remove On Duplicate UPDATE for new inserts to improve performance & reduce deadlocks [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/459667 (owner: Eileen) [02:13:56] eileen: would the parentOperation be 'create' in the case of the post hook that was causing two wmf_contribution_extra inserts? [02:14:54] hmm, yeah, I think that line you added the $action parameter on comes after the post hook [02:15:57] just out of curiousity, would that test pass if it was rebased after this one? https://gerrit.wikimedia.org/r/458333 [02:25:14] or rather, if that one was merged to the parent repo [02:26:21] (PS1) Eileen: Remove unused function wmf_civicrm_set_gateway_status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459668 [02:27:00] heh, i was just thinking about nuking that one friday [02:27:53] (CR) Ejegg: [C: 2] Remove unused function wmf_civicrm_set_gateway_status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459668 (owner: Eileen) [02:28:16] ejegg: that’s funny I thought you were super quick on that [02:28:42] ejegg: I was also thinking about that commit of yours [02:29:12] I found a couple of places where we use a custom set function - not sure if you covered them all or not [02:29:59] I’ve been looking into the deadlocks & interestingly they are on wmf_contribution_extra not wmf_donor as I had assumed [02:30:11] probably not - I was just going for the most common case of that one double-insert [02:30:50] wouldn't be surprised if there were more places that 'on duplicate update' comes into play [02:32:10] Oh wow, in that case i'm even more motivated to get that one merged [02:32:15] it looks like this function CRM_Core_BAO_CustomValueTable::setValues has an uncached query [02:32:27] looking [02:32:29] & we are calling it from wmf_civicrm_set_custom_field_value [02:32:39] (which I think your patch does remove) [02:33:08] sadly your patch didn’t give me a speed boost when I tested on staging but it might in conjunction with others [02:33:10] yeah [02:33:28] right, I got a /maybe/ 3% boost when I tried measuring [02:33:37] ok well that’s a good boost [02:33:45] I didn’t get that - but it’s not an exact science! [02:34:05] (Merged) jenkins-bot: Remove unused function wmf_civicrm_set_gateway_status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459668 (owner: Eileen) [02:34:21] i.e. with baseline 36 sec for 200, I applied the patch and got 35 sec more often than not [02:34:33] cool [02:34:37] but still a bunch of runs at 35 sec [02:35:18] *36 sec [02:35:26] I would expect a boost just because of that uncached query - but it also didn’t jump out at me in the query log - so possibly the data set doesn’t hit is as often as perhaps a real one might [02:36:16] wmf_civicrm_settle also seems unused [02:36:23] huh, ok. well, if it lets us use your patch to take away the 'on duplicate update', that's a good start [02:36:36] eileen: yep, let's erase that one too [02:37:53] (PS1) Eileen: Remove unused function wmf_civicrm_settle [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459669 [02:37:53] ok - I pushed that up [02:38:53] (CR) Ejegg: [C: 2] Remove unused function wmf_civicrm_settle [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459669 (owner: Eileen) [02:40:28] (PS1) Eileen: Apply drupal formatting to thank_you.module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459670 [02:41:01] once I’ve reviewed your patch only one remaining place calling our set_values function [02:44:54] (Merged) jenkins-bot: Remove unused function wmf_civicrm_settle [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459669 (owner: Eileen) [02:47:20] (CR) Ejegg: [C: 2] "OK drupal, I can get behind all your formatting rules except that 'else on next line from close-brace' thing. What's up with that?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459670 (owner: Eileen) [02:53:24] (Merged) jenkins-bot: Apply drupal formatting to thank_you.module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459670 (owner: Eileen) [03:04:01] (CR) Eileen: [C: 2] "Yep, I stepped through this & it looks good & may help with the deadlocks (with or without the other patch)." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/458333 (https://phabricator.wikimedia.org/T203537) (owner: Ejegg) [03:11:17] (Merged) jenkins-bot: Move _extra field calc to pre hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/458333 (https://phabricator.wikimedia.org/T203537) (owner: Ejegg) [03:15:03] see you tomorrow eileen [03:15:11] ejegg|away: see ya [03:21:28] (PS1) Eileen: Refine the generation of 'extra' params. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459672 [03:21:44] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/459667 (owner: Eileen) [03:25:50] (CR) Eileen: "ejegg the else on next line think was apparently intended to provide more readable diffs - not sure it worked out that way..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459670 (owner: Eileen) [04:39:24] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/459667 (owner: Eileen) [04:44:53] (PS1) Eileen: Add drupal redis module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459673 [05:55:23] (PS1) Eileen: Do an earlier return on determining last donation details if the donation was made 'today'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459676 (https://phabricator.wikimedia.org/T202446) [06:02:26] (CR) jerkins-bot: [V: -1] Do an earlier return on determining last donation details if the donation was made 'today'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459676 (https://phabricator.wikimedia.org/T202446) (owner: Eileen) [06:25:31] (PS2) Eileen: Do an earlier return on determining last donation details if the donation was made 'today'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459676 (https://phabricator.wikimedia.org/T202446) [06:48:05] Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: FY17-18 total not reflected in WMF Donor section - https://phabricator.wikimedia.org/T202102 (Eileenmcnaughton) Open>Resolved I did discuss... [06:50:51] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, MediaWiki-Database, MediaWiki-extensions-CentralNotice, and 2 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (jcrespo) @mark @faido... [06:51:34] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-Database, and 3 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (jcrespo) [07:21:24] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-Database, and 3 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (Nikerabbit) The reason we haven't replied... [07:34:17] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-Database, and 3 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (jcrespo) > I would propose breaking the Ce... [07:44:04] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-Database, and 3 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (Nikerabbit) There is `$wgNoticeUseTranslat... [07:53:41] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-Database, and 3 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (jcrespo) @AndyRussG Can you help with that? [08:32:35] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-Database, and 3 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (Nikerabbit) I filed {T204026} so that it d... [10:57:57] (PS1) Hashar: Composer merge plugin now prepends VCS repositories [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) [10:58:11] (CR) Hashar: "check experimental" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [11:04:27] (PS1) Hashar: Test merge plugin prepend-repositories [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/459765 (https://phabricator.wikimedia.org/T203084) [11:06:47] (CR) Hashar: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/459765 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [11:50:47] (CR) Hashar: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/459765 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [11:51:11] (CR) Hashar: "check experimental" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [11:51:19] (CR) Hashar: "check experimental" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [12:27:46] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-Database, and 3 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (AndyRussG) @jcrespo @Nikerabbit Thanks!!!... [12:42:25] (CR) Hashar: "check experimental" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [12:51:41] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 10 others: Create Ingenico orphan rectifier ... - https://phabricator.wikimedia.org/T163949 [13:04:04] Fundraising-Backlog: Orphan Slayer module needs handling for timeouts - https://phabricator.wikimedia.org/T204050 (mepps) [13:04:24] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 10 others: Create Ingenico orphan rectifier ... - https://phabricator.wikimedia.org/T163949 [13:10:48] (CR) Mepps: "Hmm eileen I'm not seeing the same things locally. I'll keep exploring." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/435002 (https://phabricator.wikimedia.org/T188141) (owner: Mepps) [13:12:15] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Fr-Ingenico-integration_2017-18, Recurring-Donations, Patch-For-Review: Ingenico Recurring: Card rejection is not a cause for failmail - https://phabricator.wikimedia.org/T203291 (mepps) @Ejegg What does happen when a r... [13:15:54] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: wmf_contribution_extra table is inserted twice for a single contribution insert - https://phabricator.wikimedia.org/T203537 (mepps) @Ejegg I'm moving this into pending deploy... [13:27:30] (PS2) Hashar: Use composer-merge-plugin 1.4.1 to prepend VCS repos [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) [13:40:34] (CR) Hashar: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/459765 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [13:41:23] (CR) Hashar: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/459765 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [13:49:19] (PS2) Hashar: Test merge plugin prepend-repositories [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/459765 (https://phabricator.wikimedia.org/T203084) [13:49:26] (CR) Hashar: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/459765 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [13:51:32] (CR) jerkins-bot: [V: -1] Test merge plugin prepend-repositories [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/459765 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [13:55:41] (CR) jerkins-bot: [V: -1] Test merge plugin prepend-repositories [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/459765 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [14:05:39] (CR) Mepps: [C: 2] "It works locally and there are tests! Awesome." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456517 (https://phabricator.wikimedia.org/T200576) (owner: Ejegg) [14:06:24] Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, and 2 others: Create opt-IN page for fundraisingEmailUnsubscribe, consume messages - https://phabricator.wikimedia.org/T200576 (mepps)... [14:12:03] (Merged) jenkins-bot: Opt-in queue consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/456517 (https://phabricator.wikimedia.org/T200576) (owner: Ejegg) [14:38:12] Hi Seddon, yt? [14:38:36] Am I correct in understanding that this banner never had the problem with a translatable message name with a space in it? https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/SeddonEUCopyright [14:39:13] In the logs I still see some error responses from trying to save it [14:39:15] AndyRussG: Always 💤 [14:40:07] AndyRussG: No I had issues with it but it would at least save, eventually. [14:40:46] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-Database, and 3 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (DStrine) Just for some background I set... [14:45:08] Seddon: ok thanks [15:43:06] Seddon: from the logs, I'm seeing 6 save attempts that returned an error, and one that didn't. Odd, because 4 versions were successfully saved. Can you tell me more about what you saw on your end? [15:43:19] https://meta.wikimedia.org/w/index.php?title=MediaWiki:Centralnotice-template-SeddonEUCopyright&action=history [15:43:45] Also, did you ever try just changing the banner content via the wiki page? [15:50:13] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Unable to make edits from Summary Screen - https://phabricator.wikimedia.org/T203266 (NNichols) @Eileenmcnaughton That makes sense! Thanks for figuring that out. It seems to be working for me no... [15:52:54] dstrine: do you prefer summary update here or via e-mail [15:52:56] ? [16:01:33] dstrine: here's what I have (also sent by e-mail): [16:01:34] - I've found some additional log messages other than those mentioned on the task. As with the other logs we saw, it's related to database operations performed by Translate extension, triggered by CentralNotice. [16:01:36] - Still unclear how significant the impact is on the cluster. [16:01:39] - Still digging! [16:01:44] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-Database, and 4 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (jcrespo) Sorry if I may not very helpful a... [16:02:37] dstrine: also, we are getting a lot of great input from Jaime Crespo (db guy) [16:02:38] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Unable to make edits from Summary Screen - https://phabricator.wikimedia.org/T203266 (NNichols) @Eileenmcnaughton I spoke too soon. I still can't edit tags. Also, if I enter an employer on the s... [16:02:42] he just posted more stuff on the task [16:04:05] AndyRussG: so is it CN affecting the translate extension or the other way around? [16:05:59] dstrine: we don't know [16:06:04] ok [16:06:04] We'll know when we know [16:06:08] ok [16:06:31] dstrine: I'm just going to dig into the info that Jaime Crespo posted [16:06:38] ok [16:08:39] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Unable to make edits from Summary Screen - https://phabricator.wikimedia.org/T203266 (NNichols) @Eileenmcnaughton Sorry to tack on more to this task but is there a way to fix this? {F25777095} I... [16:17:11] dstrine: update, the post from Jaime is very useful [16:17:32] also, urgent, because there's some switchover of a datacenter happening soon [16:23:15] Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Thank You email for Stripe Import - https://phabricator.wikimedia.org/T202099 (jkim_wikimedia) Hey @Ejegg - I just imported l... [16:56:06] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 10 others: Create Ingenico orphan rectifier ... - https://phabricator.wikimedia.org/T163949 [17:00:33] Fundraising-Backlog, Wikimedia-Fundraising, donate.wikimedia.org, wikimediafoundation.org: Move fundraising support pages to donate.wikimedia.org - https://phabricator.wikimedia.org/T189668 (Pcoombe) Open>Resolved [17:41:31] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-Database, and 4 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (Nikerabbit) While checking callers of `Tra... [17:54:01] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-extensions-CentralNotice, and 2 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (Krinkle) [18:08:08] fundraising-tech-ops, Operations, ops-codfw: move/setup/install frauth2001.codfw.wmnet - https://phabricator.wikimedia.org/T204079 (RobH) p:Triage>Normal [18:08:25] fundraising-tech-ops: replace betelgeuse, for it is ancient - https://phabricator.wikimedia.org/T203484 (RobH) [18:12:16] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-extensions-CentralNotice, and 2 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (AndyRussG) >>! In T203925#... [18:12:49] fundraising-tech-ops, Operations, ops-codfw: move/setup/install frauth2001.codfw.wmnet - https://phabricator.wikimedia.org/T204079 (ayounsi) [18:18:14] fundraising-tech-ops, Operations, ops-codfw: move/setup/install frauth2001.codfw.wmnet - https://phabricator.wikimedia.org/T204079 (ayounsi) [18:25:36] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-extensions-CentralNotice, and 2 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (Nikerabbit) Message group... [18:30:01] (PS1) Mepps: Move from clearCache which deletes everything under the key 'translate-groups' to recache, which just restores the definitions Hope for performance improvements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) [18:31:38] (CR) jerkins-bot: [V: -1] Move from clearCache which deletes everything under the key 'translate-groups' to recache, which just restores the definitions Hope for performance improvements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) (owner: Mepps) [18:32:14] (CR) jerkins-bot: [V: -1] Move from clearCache which deletes everything under the key 'translate-groups' to recache, which just restores the definitions Hope for performance improvements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) (owner: Mepps) [18:32:57] (PS2) Mepps: Move from clearCache which deletes everything under the key 'translate-groups' to recache, which just restores the definitions Hope for performance improvements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) [18:36:54] (PS3) Mepps: Move from clearCache which deletes everything under the key 'translate-groups' to recache, which just restores the definitions Hope for performance improvements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) [19:17:35] Fundraising-Backlog, fundraising-tech-ops: Generate new Civi certificate for Kristie - https://phabricator.wikimedia.org/T200281 (cwdent) [19:18:27] Fundraising-Backlog, fundraising-tech-ops: Generate new Civi certificate for Kristie - https://phabricator.wikimedia.org/T200281 (cwdent) Apologies, I lost track of this task because I forgot to tag it fundraising-tech-ops Happy to regen that cert if still necessary, I see the current one is good for an... [19:32:35] (PS1) Mepps: Insert a job into the queue because in this case it is not fast enough to wait for run Would love testing on this patch [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 [19:35:49] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising-Backlog, and 2 others: civi: report filter for total USD within a time period - https://phabricator.wikimedia.org/T151271 (DStrine) [19:43:32] (CR) Mepps: "Would this mean donation details would get calculated later? It's great if this improves the performance!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459676 (https://phabricator.wikimedia.org/T202446) (owner: Eileen) [19:59:43] Fundraising-Backlog, fundraising-tech-ops: Re-activate staging access for Adam - https://phabricator.wikimedia.org/T198347 (cwdent) Open>Resolved This is gone, as well as Saurabh and krb5 pass [20:43:34] (CR) Nikerabbit: [C: 1] "This change is unlikely to improve performance. In fact it might be reduce a bit, because it does the cache rebuilding immediately, and no" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) (owner: Mepps) [20:46:10] (CR) Nikerabbit: [C: 1] "This deferral to JobQueue shouldn't affect any banner code, just the Special:Translate interface, but I haven't tested." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (owner: Mepps) [20:48:42] (CR) Mepps: "Nikerabbit I'm a little confused as this was based on your comment on the issue. What do you recommend?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) (owner: Mepps) [21:02:23] (CR) Nikerabbit: [C: 1] "This change should be done because it helps to avoid cache stampedes." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) (owner: Mepps) [21:09:58] (CR) Eileen: "mepps so what happens is that when a contribution is inserted the last_currency & last_amount are updated to the one being inserted. Later" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459676 (https://phabricator.wikimedia.org/T202446) (owner: Eileen) [22:04:51] https://www.redfin.com/CA/Sunnyvale/582-E-Maude-Ave-94085/home/1711454 [22:45:44] (PS2) Eileen: Apply our patches to 5.6 rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/457783 [22:45:46] (PS1) Eileen: Stock CiviCRM 5.6 as at commit 0ab5c4c [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/459860 [22:45:48] (PS1) Eileen: Port caching patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/459861 [22:50:08] ejegg: here are the updates to CiviCRm https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/459861/ [22:50:18] there is not much change from the other day except [22:50:21] (PS2) Eileen: Stock CiviCRM 5.6 as at commit b875df23ab [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/459860 [22:50:23] (PS3) Eileen: Apply our patches to 5.6 rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/457783 [22:50:25] (PS2) Eileen: Port caching patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/459861 [22:50:29] 1 - the api v4 now ships in the core tarball [22:50:52] also I added the caching patches on top [22:55:48] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 10 others: Create Ingenico orphan rectifier ... - https://phabricator.wikimedia.org/T163949