[00:02:26] thanks eileen [00:05:59] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 3 others: slow anonymous save - https://phabricator.wikimedia.org/T199753 (Eileenmcnaughton) So I did some stats on this after... [00:11:29] ejegg: what do you think about altering the triggers so we specifically skip the anonymous donor https://phabricator.wikimedia.org/T199753#4575865 [00:12:46] sure, seems fine [02:09:28] (PS1) Eileen: Exclude anonymous contact from triggers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459887 (https://phabricator.wikimedia.org/T199753) [02:12:43] (Abandoned) Eileen: Stock CiviCRM 5.6 as at commit 0ab5c4c [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/457782 (owner: Eileen) [02:12:45] (Abandoned) Eileen: WIP try a shorter trigger range [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457805 (owner: Eileen) [02:12:48] (Abandoned) Eileen: WIP try no triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457807 (owner: Eileen) [02:12:50] (Abandoned) Eileen: WIP hack custom php data return [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/457817 (owner: Eileen) [02:12:51] (Abandoned) Eileen: Try campaigns no watchdog(wip) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/458078 (owner: Eileen) [06:49:27] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: did script delete a contact's email address? - https://phabricator.wikimedia.org/T203198 (Eileenmcnaughton) a:Eileenmcnaughton [07:05:10] Fundraising-Backlog, fundraising-tech-ops: Generate new Civi certificate for Kristie - https://phabricator.wikimedia.org/T200281 (krobinson) Apologies for delay in responding @MBeat33, @cwdent - as the export issue is now resolved, I don't think this is necessary anymore. So no, thank you - we're good! [13:30:09] Fundraising-Backlog, fundraising-tech-ops: Generate new Civi certificate for Kristie - https://phabricator.wikimedia.org/T200281 (MBeat33) Open>Resolved [14:07:12] (CR) Krinkle: [C: -1] "This is not a static method." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) (owner: Mepps) [14:27:45] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-extensions-CentralNotice, and 3 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (Krenair) >>! In T203925#45... [14:46:10] Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Unplanned-Sprint-Work: Inserting Images into Civi mail - https://phabricator.wikimedia.org/T202330 (DStrine) Open>Resolved [15:01:48] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Language-Team, MediaWiki-extensions-CentralNotice, and 3 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (AndyRussG) Hi! Some notes... [15:21:34] fr-tech: any news for scrum of scrums? [15:32:28] fundraising-tech-ops, Operations, ops-codfw: move/setup/install frauth2001.codfw.wmnet - https://phabricator.wikimedia.org/T204079 (Papaul) [15:34:47] ejegg: nothing here, really, though I'd love to hear how the datacenter switchover is going. If you want to mention the CN translation concerns, so that people can keep their eyes open for that as a possible cause if there are sudden DB performance problems, that might be good! thx!!!! [15:35:21] yep, yep, got that as the first line in our update [15:35:27] cool thx!!! [15:35:31] gonna relocate, but I have IRC on my fone so pls ping as needed :) [15:37:40] (CR) Nikerabbit: [C: 1] "> Patch Set 3: Code-Review-1" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) (owner: Mepps) [15:37:46] (CR) Nikerabbit: [C: -1] Move from clearCache which deletes everything under the key 'translate-groups' to recache, which just restores the definitions Hope for perf [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) (owner: Mepps) [16:10:14] (CR) Mepps: "Thanks, Krinkle and Nikerabbit!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) (owner: Mepps) [18:10:29] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: move/setup/install frauth2001.codfw.wmnet - https://phabricator.wikimedia.org/T204079 (Papaul) [18:37:38] Fundraising-Backlog, wikimediafoundation.org, Privacy: Wikimedia Foundation website includes Wordpress tracking pixel - https://phabricator.wikimedia.org/T201422 (Framawiki) [19:19:13] fundraising-tech-ops, wikimediafoundation.org: Old links to the donate page on wikimediafoundation.org get redirected weirdly - https://phabricator.wikimedia.org/T203932 (Varnent) Have setup redirect, but will leave ticket open so we can figure out where the outdated link is. [21:57:39] ejegg: how do you think we should try to deploy WRT one hour test tomorrow? Should we try to deploy some stuff first - or after now? [21:58:20] eileen: let's deploy some stuff today [21:58:35] ok cool - is there any stuff you are wanting me to review? [21:58:45] no, but I owe you some review... [21:59:18] oh you put up a redis one - I didn’t see that [21:59:29] ah, redis caching for drupal [21:59:36] for some reason my ‘normal screen’ doesn’t show me a chunk of stuff [21:59:49] but we don't have drupal on prod yet, so that's not a priority [22:00:08] oh wait, you have the same patch! [22:00:12] lol [22:00:18] without sites_enabled through [22:00:20] though [22:00:36] I was wondering though - if it is enabled with no config then no breakage? [22:00:43] exactly [22:00:53] ok cool - I’ll merge yours [22:01:02] (CR) Eileen: [C: 2] Use redis to cache drupal lookups [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/458089 (owner: Ejegg) [22:01:07] :) thanks! [22:02:40] (PS2) Eileen: Refine the generation of 'extra' params. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459672 [22:02:42] (PS3) Eileen: Do an earlier return on determining last donation details if the donation was made 'today'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459676 (https://phabricator.wikimedia.org/T202446) [22:02:44] (PS2) Eileen: Exclude anonymous contact from triggers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459887 (https://phabricator.wikimedia.org/T199753) [22:03:26] (CR) Eileen: [C: 2] Delete old GlobalCollect audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434597 (owner: Ejegg) [22:03:55] (CR) Eileen: [C: 2] "all good module already disabled on live -" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434597 (owner: Ejegg) [22:04:57] (CR) Eileen: [C: 2] Remove obsolete db_error() call [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/268838 (owner: Ejegg) [22:14:45] (Merged) jenkins-bot: Delete old GlobalCollect audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/434597 (owner: Ejegg) [22:20:10] (Merged) jenkins-bot: Remove obsolete db_error() call [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/268838 (owner: Ejegg) [22:32:03] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 2 others: Mailing data double counting in CiviCRM? - https://phabricator.wikimedia.org/T200240 (Eileenmcnaughton) I did some c... [22:42:13] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 2 others: Mailing data double counting in CiviCRM? - https://phabricator.wikimedia.org/T200240 (Eileenmcnaughton) We are proce... [22:45:44] (PS3) Ejegg: Refine the generation of 'extra' params. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459672 (owner: Eileen) [22:47:26] (CR) Ejegg: [C: 2] Refine the generation of 'extra' params. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459672 (owner: Eileen) [22:47:30] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Unable to make edits from Summary Screen - https://phabricator.wikimedia.org/T203266 (Eileenmcnaughton) @NNichols - I want to break this down into subtasks - can you confirm these are the issues... [22:48:33] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Contact summary screen - tag block not working - https://phabricator.wikimedia.org/T204172 (Eileenmcnaughton) [22:48:43] Fundraising Sprint Raw data can give you salmonella, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Unable to make edits from Summary Screen - https://phabricator.wikimedia.org/T203266 (Eileenmcnaughton) a:Eileenmcnaughton [22:49:54] (PS4) Ejegg: Do an earlier return on determining last donation details if the donation was made 'today'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459676 (https://phabricator.wikimedia.org/T202446) (owner: Eileen) [22:50:14] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: move/setup/install frauth2001.codfw.wmnet - https://phabricator.wikimedia.org/T204079 (Papaul) ``` papaul@fasw-c-codfw# show | compare [edit interfaces interface-range disabled] - member ge-0/0/16; - member ge-1/0/16; [edit in... [22:50:26] (CR) Ejegg: [C: 2] "Looks like a good trade-off. And thanks for the extra doc comments!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459676 (https://phabricator.wikimedia.org/T202446) (owner: Eileen) [22:50:48] ejegg: bear in mind with that patch that during BE we might choose to extend the window [22:51:42] like when we start getting lots of things from audit files? [22:51:48] that might be a few days old [22:52:37] ejegg: well if the main queue were backlogged for 3 days... [22:53:07] eek, well, i guess it's good to prepare for nastiness [22:53:32] right I didn’t extend past ‘today’ but wanted to flag that is something we could do if we need to [22:53:53] also, FYI - before the changes earlier this year we were just assuming the donation was the latest [22:53:58] (CR) jerkins-bot: [V: -1] Exclude anonymous contact from triggers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459887 (https://phabricator.wikimedia.org/T199753) (owner: Eileen) [22:54:07] (Merged) jenkins-bot: Refine the generation of 'extra' params. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459672 (owner: Eileen) [22:54:09] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: move/setup/install frauth2001.codfw.wmnet - https://phabricator.wikimedia.org/T204079 (Papaul) ``` papaul@fasw-c-codfw> show interfaces ge-0/0/16 Physical interface: ge-0/0/16, Enabled, Physical link is Up papaul@fasw-c-codfw> show... [22:54:43] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: move/setup/install frauth2001.codfw.wmnet - https://phabricator.wikimedia.org/T204079 (Papaul) [22:54:53] side note - I’ve been surprised by the things that DON’T give us performance improvements [22:55:04] I guess mysql caching does wonders :-) [22:55:28] I’ll be interested to see the improvement when we switch to php 7 [22:59:24] (Merged) jenkins-bot: Do an earlier return on determining last donation details if the donation was made 'today'. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459676 (https://phabricator.wikimedia.org/T202446) (owner: Eileen) [23:01:13] (PS1) Reedy: Remove php entry point [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/460160 (https://phabricator.wikimedia.org/T140007) [23:01:38] (PS1) Reedy: Remove php entry point [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/460161 (https://phabricator.wikimedia.org/T140007) [23:03:49] ejegg: so just digging into Nora’s issues & I’ve discovered Coleman’s work uses the Profile.submit api - which I wrote a long time ago & later wondered if it ever should have been written :-) [23:14:00] (PS3) Ejegg: Exclude anonymous contact from triggers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459887 (https://phabricator.wikimedia.org/T199753) (owner: Eileen) [23:14:02] (PS1) Ejegg: Minor cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/460172 [23:14:23] eileen: oh, was the Profile.submit api the cause or the solution to the problem? [23:14:37] :-) [23:14:55] well I guess it’s the method by which the extension saves data - so by definition both [23:15:09] in the same way CiviCRM is the cause & solution to our CRM problems [23:15:15] (CR) Jforrester: [C: 2] Remove php entry point [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/460160 (https://phabricator.wikimedia.org/T140007) (owner: Reedy) [23:15:28] (CR) Jforrester: [C: 2] Remove php entry point [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/460161 (https://phabricator.wikimedia.org/T140007) (owner: Reedy) [23:15:47] * ejegg waves goodbye to php entry point [23:15:57] bye old-mediawiki-compatibility! [23:15:58] ejegg: re the anonymous exclusion - it seems that there are a small number of Benevity donors on the same scale but I think it’s still OK to just exclude anonymous because we do actually care about totals for other donors [23:16:12] right, sounds good [23:16:16] ejegg: hopefully no one cares about that old MW too much ;P [23:16:16] & more data entry happens on anonymous [23:16:31] heh, especially not for that extn [23:16:40] probably only run on one wiki [23:28:31] (CR) Ejegg: [C: -1] "boolean grouping issue, I think" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459887 (https://phabricator.wikimedia.org/T199753) (owner: Eileen) [23:29:11] sorry, i rebased that before noticing the () issue [23:30:20] oh, but the other stuff is merged [23:30:23] so no biggie [23:33:54] fundraising-tech-ops, Operations, ops-codfw, Patch-For-Review: move/setup/install frauth2001.codfw.wmnet - https://phabricator.wikimedia.org/T204079 (Papaul) @Jgreen @Dzahn has a comment on https://gerrit.wikimedia.org/r/#/c/operations/dns/+/460127/ the network 10.195.0.72/29 can only hold 6 host... [23:36:58] eileen: can we deploy any of the stuff in the civicrm submodule for tomorrow? [23:37:09] like the 'on duplicate update' patch ? [23:37:32] or does that depend on the version upgrade? [23:37:57] ejegg: yeah I’d rather do the version update before adding those other patches [23:38:12] do you think we are too close to the test to do the version update? [23:38:30] (Merged) jenkins-bot: Remove php entry point [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/460160 (https://phabricator.wikimedia.org/T140007) (owner: Reedy) [23:38:48] (Merged) jenkins-bot: Remove php entry point [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/460161 (https://phabricator.wikimedia.org/T140007) (owner: Reedy) [23:38:52] ok, cool [23:39:36] (PS4) Eileen: Exclude anonymous contact from triggers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459887 (https://phabricator.wikimedia.org/T199753) [23:39:41] ejegg: I just fixed that trigger one? [23:39:51] thx, looking again [23:40:15] (Abandoned) Eileen: Add drupal redis module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459673 (owner: Eileen) [23:40:29] (CR) Ejegg: [C: 2] Exclude anonymous contact from triggers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459887 (https://phabricator.wikimedia.org/T199753) (owner: Eileen) [23:45:28] (PS2) Ejegg: Minor cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/460172 [23:46:20] (CR) Eileen: [C: 2] Minor cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/460172 (owner: Ejegg) [23:47:07] (Merged) jenkins-bot: Exclude anonymous contact from triggers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/459887 (https://phabricator.wikimedia.org/T199753) (owner: Eileen) [23:52:49] (Merged) jenkins-bot: Minor cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/460172 (owner: Ejegg) [23:55:04] ejegg: so you are thinking we deploy this stuff today & the civicrm update after the one hour test? [23:55:25] eileen: yeah, that sounds good [23:55:52] ok - I just put slow anonymous save into pending review - I did come up with some more improvement but that is in review upstream [23:56:25] dealing with upstreaming doesn’t fit so well in the sprint flow because it depends on things outside our control [23:56:45] so it’s whether I keep something open or just let it chug along in the back ground