[14:04:07] AndyRussG, hows it goin :) I've worked out a way (I think) to conveniently add review comments to FRUEC. I'm adding in-line comments so far with the prefix '#review#' and commiting them with the comment message as a list of line references and comments e.g. (path/to/file.py:7 - should this be something else?). The commit is against the latest gerrit patch version of the code so I think I can submit it as a new patch just with [14:04:07] the comments, that we can abandon once we're happy. [14:05:32] commit message*** [15:04:09] hey ejegg, wanna catch up for 5 mins before :30 ? [15:05:18] for sure! [15:21:53] ejegg, heading over to the usual joint [15:33:00] AndyRussG: I'm in the hangout on the regular invite pretending to be Maggie if you want to do our weekly checkin. [15:33:26] XenoRyet: thx! yeah one sec :) [15:34:24] XenoRyet: hmmm I don't see u there [15:34:32] Also, jgleeson: How's half an hour sound for rescheduling? That'd make it 9 AM pacific, 4 GMT? [15:39:49] Fundraising-Backlog: Deploy new English thank you email content and subject line - https://phabricator.wikimedia.org/T205880 (Pcoombe) [16:06:14] jgleeson: If you're around I could do check-in right now. Otherwise we'll reschedule it for later. [16:08:23] hey XenoRyet, just on a call now until 9:30am PST and then I'm breaking for dinner but I'm back at 11am onwards if that works? [16:08:56] Ah cool. Yea, that's totally fine. We'll find a time after 11. [16:09:40] Right. Didn't have your calendar turned on, so I didn't see that call you were in. [16:10:47] yeah my calendar is a bit strange. Instead of having free space, I actually have blocked out space when I'm working, but I mark it as me being available so you can drop in a meeting without it complaining [16:11:50] Makes sense [16:18:29] fundraising-tech-ops, Operations, netops: deploy PFW policy commit 99eb6f026 - https://phabricator.wikimedia.org/T205888 (Jgreen) p:Triage>Normal [17:03:40] Fundraising Sprint Sasquatches can't find us either, Fundraising-Backlog: Deploy new English thank you email content and subject line - https://phabricator.wikimedia.org/T205880 (DStrine) [17:08:57] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Update FormChooser settings, coordinate with fr-online - https://phabricator.wikimedia.org/T204768 (Ejegg) Note: @Ppena reminded us that we should make sure the new Ingenico orphan slayer is working. [17:10:46] (PS1) Ejegg: Switch all 'globalcollect' cc forms to 'ingenico' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/463796 (https://phabricator.wikimedia.org/T204768) [17:13:21] (CR) jerkins-bot: [V: -1] Switch all 'globalcollect' cc forms to 'ingenico' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/463796 (https://phabricator.wikimedia.org/T204768) (owner: Ejegg) [17:16:52] Fundraising Sprint Sasquatches can't find us either, Fundraising-Backlog: Deploy new English thank you email content and subject line - https://phabricator.wikimedia.org/T205880 (Ejegg) Looks like we CAN do tokens in subject lines now :) I'll do some local testing to make sure those come out right. [17:18:49] Fundraising Sprint Sasquatches can't find us either, Fundraising-Backlog: Deploy new English thank you email content and subject line - https://phabricator.wikimedia.org/T205880 (CCogdill_WMF) Ooh, fun! I want to note this kind of personalization gets extra complicated in our appeal emails when it gets... [17:22:42] Fundraising Sprint Sasquatches can't find us either, Fundraising-Backlog: Deploy new English thank you email content and subject line - https://phabricator.wikimedia.org/T205880 (Ejegg) Yep! In the TY letters we send the amount through a special localization library that has a lot of symbols and rules bu... [17:24:10] fr-tech: the TY letter has a 'fun' new wrinkle this time - they want to add a token in the TY subject. [17:25:19] The TY subject is now being read from templates, just like the body text [17:26:02] the difference is that the subject generator reads from the DonationInterface i18n files and not from translations on meta-wiki [17:26:44] Ops has sent out an email asking people not to change i18n strings in deployed extensions right now, so it would be OK to directly edit the rendered template [17:28:46] (PS2) Ejegg: Switch all 'globalcollect' cc forms to 'ingenico' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/463796 (https://phabricator.wikimedia.org/T204768) [17:31:17] (CR) jerkins-bot: [V: -1] Switch all 'globalcollect' cc forms to 'ingenico' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/463796 (https://phabricator.wikimedia.org/T204768) (owner: Ejegg) [17:36:23] (PS3) Ejegg: Switch all 'globalcollect' cc forms to 'ingenico' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/463796 (https://phabricator.wikimedia.org/T204768) [17:54:09] (CR) XenoRyet: [C: 2] "Looks good" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/463796 (https://phabricator.wikimedia.org/T204768) (owner: Ejegg) [17:56:59] (Merged) jenkins-bot: Switch all 'globalcollect' cc forms to 'ingenico' [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/463796 (https://phabricator.wikimedia.org/T204768) (owner: Ejegg) [18:18:10] Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Sasquatches can't find us either, and 2 others: Banner previews occasionally fail to load - https://phabricator.wikimedia.org/T200853 (Pc... [18:47:46] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/463827 [18:48:35] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/463827 (owner: Ejegg) [18:50:20] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/463827 (owner: Ejegg) [18:55:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: identify Amazon alexa donations as a subset of amazon - https://phabricator.wikimedia.org/T205912 (DStrine) [19:37:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: identify Amazon alexa donations as a subset of amazon - https://phabricator.wikimedia.org/T205912 (Ejegg) We could use the payment_submethod - same field as distinguishes different credit card types. Currently Amazon donations don't have a submethod, ju... [19:42:35] Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Sasquatches can't find us either, Fundraising-Backlog, Language-Team, and 5 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (CCicalese_... [19:47:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Extend deletion to multiple silverpop databases - https://phabricator.wikimedia.org/T205332 (DStrine) [20:30:03] Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Sasquatches can't find us either, Fundraising-Backlog, Language-Team, and 5 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (Imarlier)... [20:54:12] ejegg: Is any time today better than any other for a quick Maggie-esqe check-in? [20:54:25] I'm pretty flexible from here on out. [20:55:25] sometime in the next hour would be good [20:55:55] Ok, how 'bout in 5 mins at 2:00? That'd work pretty well for me also. [20:56:36] (PS1) Ejegg: Update English TY letter and subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463846 (https://phabricator.wikimedia.org/T205880) [21:02:19] (CR) jerkins-bot: [V: -1] Update English TY letter and subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463846 (https://phabricator.wikimedia.org/T205880) (owner: Ejegg) [21:02:35] Ejegg: I'm in the usual hangout, unless you want to push it back a bit. [21:03:29] shoot, want to give me a couple minues? [21:03:33] *minutes [21:03:52] Sure, how long do you need? [21:06:18] be there in 2 min! [21:06:28] Cool, I'll be there. [21:17:47] Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Sasquatches can't find us either, Fundraising-Backlog, Language-Team, and 5 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (DStrine)... [21:18:36] Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Sasquatches can't find us either, Fundraising-Backlog, Language-Team, and 5 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925 (DStrine)... [21:20:41] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463846 (https://phabricator.wikimedia.org/T205880) (owner: Ejegg) [21:24:34] (CR) jerkins-bot: [V: -1] Update English TY letter and subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463846 (https://phabricator.wikimedia.org/T205880) (owner: Ejegg) [21:27:01] (PS2) Ejegg: Update English TY letter and subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463846 (https://phabricator.wikimedia.org/T205880) [21:32:00] (CR) jerkins-bot: [V: -1] Update English TY letter and subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463846 (https://phabricator.wikimedia.org/T205880) (owner: Ejegg) [21:34:47] (PS5) Eileen: Fix trigger to exclude endowment gifts from totals or last donation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/462831 (https://phabricator.wikimedia.org/T203601) [21:39:25] eileen: I'm getting the same DB Error: unknown error for everything in the TY letter update too [21:39:50] so I'm asking over in #wikimedia-releng if there might be an issue with the CI environment [21:51:38] (PS1) Eileen: Remove trait use as parent class does the same. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463853 [21:52:11] ejegg: yeah - that DB error wasn’t there this time https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/462831/5/sites/all/modules/wmf_civicrm/wmf_civicrm.module [21:52:20] All I added was an exception [21:52:33] (do I need you to re plus-2 it with the exception) [21:52:33] Gotta be something CI-related [21:53:04] oh sure, still looks good to me [21:53:14] (CR) Ejegg: [C: 2] Fix trigger to exclude endowment gifts from totals or last donation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/462831 (https://phabricator.wikimedia.org/T203601) (owner: Eileen) [21:55:18] (CR) jerkins-bot: [V: -1] Remove trait use as parent class does the same. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463853 (owner: Eileen) [21:58:21] (CR) Ejegg: [C: 2] Remove trait use as parent class does the same. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463853 (owner: Eileen) [21:59:43] (Merged) jenkins-bot: Fix trigger to exclude endowment gifts from totals or last donation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/462831 (https://phabricator.wikimedia.org/T203601) (owner: Eileen) [22:01:48] (CR) jerkins-bot: [V: -1] Remove trait use as parent class does the same. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463853 (owner: Eileen) [22:20:01] I have coffee now - world must be gonna get better [22:21:34] ejegg: so on the thank you generators - is the method documented on the wiki. I didn’t catch all the actual commands [22:21:54] and I see that there is a patch for review on it [22:22:18] fundraising-tech-ops: fix NTP configuration for frack cluster - https://phabricator.wikimedia.org/T205751 (Jgreen) Open>Resolved fixed ntp server list, switched FR to systemd-timesyncd, added icinga monitoring [22:22:24] ah yeah, the method is documented on the wiki [22:22:30] the patch is just a content update [22:23:16] eileen: the test page is at /admin/config/thank_you/test [22:23:23] fundraising-tech-ops: fix NTP configuration for frack cluster - https://phabricator.wikimedia.org/T205751 (Jgreen) [22:23:24] (no civi prefix as it's a drupal module) [22:23:25] fundraising-tech-ops, Operations, netops: deploy PFW policy commit 99eb6f026 - https://phabricator.wikimedia.org/T205888 (Jgreen) Open>Resolved [22:26:16] ejegg: method is on collab ? [22:32:43] https://www.mediawiki.org/wiki/Fundraising_tech/Update_Thank_You_Emails [22:32:52] sorry eileen, mw.org ^^^ [22:33:10] ok, gotta run, but I'll be back online in a couple hrs [22:37:53] (CR) XenoRyet: [C: 2] Amazon audit: fix IDs for donations started off-wiki [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/463508 (https://phabricator.wikimedia.org/T194317) (owner: Ejegg) [22:38:20] (Merged) jenkins-bot: Amazon audit: fix IDs for donations started off-wiki [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/463508 (https://phabricator.wikimedia.org/T194317) (owner: Ejegg) [22:40:29] eileen: are you working on the thank you email? [22:40:51] dstrine: ejegg|afk has written a patch I’m trying to review [22:40:59] ok cool [22:41:19] although I was pre-coffee when he talked about it before [22:41:48] So I didn’t process well.... [22:42:09] eileen: or fr-tech just fyi we need to be tell the email team whether or not we got the email out today. It will determine what they do tomorrow [22:42:55] well from a review POV - it looks ‘fine’ but ejegg|afk made comments about testing line breaks in test mode so I figure I should try to do that [22:45:06] Did we figure out why jenkins is failing it for apparently unrealated reasons? [22:54:49] no not sure why [22:58:47] Weird. Well, if you're on the Thank You review, I'm going to go afk for a bit and look after Marek. Poor guy has a 104.0 (40C) fever and Mom could use a break. [22:59:05] oh dear [22:59:32] Yea, poor little dude is having a rough day. [23:10:51] (CR) Eileen: [C: 2] "Here is the text output for recur with EUR - I was surprised how narrow the blocks are but that is unchanged & there is no obvious weirdne" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463846 (https://phabricator.wikimedia.org/T205880) (owner: Ejegg) [23:11:25] (CR) Eileen: [C: 2] "& the subject with EUR" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463846 (https://phabricator.wikimedia.org/T205880) (owner: Ejegg) [23:13:02] (CR) Eileen: [C: 2] "Subject for JPY" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463846 (https://phabricator.wikimedia.org/T205880) (owner: Ejegg) [23:13:52] (CR) Eileen: [C: 2] "USD" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463846 (https://phabricator.wikimedia.org/T205880) (owner: Ejegg) [23:14:08] thank you letter seems OK from my testing [23:14:37] (CR) jerkins-bot: [V: -1] Update English TY letter and subject [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463846 (https://phabricator.wikimedia.org/T205880) (owner: Ejegg) [23:14:40] I feel like it would be good to have the generator script output some samples - but that’ s an aside [23:44:46] !log update process control revision is b9c7ab286e - define but not enable Redis [23:44:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:55:07] Fundraising-Backlog: Investigate/ repair deleted contacts with contributions - https://phabricator.wikimedia.org/T205941 (Eileenmcnaughton) p:Triage>High [23:56:50] Fundraising Sprint Sasquatches can't find us either, Fundraising-Backlog, Patch-For-Review: Contacts and Imported gifts going straight to trash after import - https://phabricator.wikimedia.org/T205134 (Eileenmcnaughton) @NNichols I added a follow on subtask for the other ones. T205941 - this is mayb...