[08:37:10] (CR) Raimond Spekking: "The test complains about https://translatewiki.net/w/i.php?title=MediaWiki:Donate_interface-donate-error-try-a-different-card-html/ja&diff" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/464681 (owner: L10n-bot) [08:47:32] (CR) Raimond Spekking: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/464681 (owner: L10n-bot) [10:01:01] hey eileen, how civi-camp going? [10:01:27] pretty good - sitting in the back of the room listening to Irish green party [10:01:40] coffee is instant :-( [14:47:46] Jeff_Green: good morning [14:47:53] hey ejegg [14:48:02] how's it going? [14:48:04] looks like the public data mover is having some rsync issues [14:48:08] pretty good! [14:48:12] uh oh [14:48:34] is it a key issue? [14:48:50] looks like it might be [14:48:56] ok I know what it is [14:48:57] Permission denied (publickey,password). [14:49:09] remember when I found those keys yesterday I was puzzled about? now we know what they're for [14:49:12] ah, nice to hear [14:49:15] ohhh [14:49:25] I guess I missed that [14:49:40] keys in jenkins's .ssh dir [14:49:50] aha [14:50:00] I'll fix and put a README in the dir for posterity [14:50:07] looks like it broke around 19 hrs ago, so that sounds right [14:51:27] yeah, sorry about that. should be fixed [14:58:46] thanks! [14:59:03] hmm, process-control has some weird output stuttering [14:59:21] related to this thing, or something else? [14:59:24] looking at the last audit parser log [14:59:28] totally unrelated [15:01:03] something in https://phabricator.wikimedia.org/diffusion/WFPC/browse/master/processcontrol/output_streamer.py is not working as expected [15:02:56] huh, the console output looks fine [15:04:00] logging.FileHandler is bad at accepting output from multiple threads over long periods? [15:04:47] i've never used python's logger to it to write to files, only to pipe to syslog [15:04:57] hmmmm [15:05:21] is written such that it would keep files open for a long time between writes? [15:05:41] there's pretty constant output in this log [15:06:02] what's the symptom you're seeing? [15:06:07] it's being written from two threads, though - one that monitors stdout and one that monitors stderr (from the child process) [15:06:36] and a ways down the file, it seems to start repeating a chunk of lines from stdout before every new line from stderr [15:06:47] yuck [15:06:49] maybe I need to flush stuff? [15:10:36] i don't know, I'd be inclined to look further upstream in the code [15:11:07] I haven't seen any malfeasance from the logger with rsyslog, so far you get what you send to it [15:22:49] Jeff_Green: we're sending the same thing to two log handlers, a FileHandler and (when run-job is run from console) a StreamHandler pointing to stdout [15:23:10] scrolling back in the console, the StreamHandler seems to output each line in the right order, the right number of times [15:23:17] but the FileHandler is acting glitchy [15:23:33] so I can't see how that would be upstream problems [15:24:00] guessing the SyslogHandler works more like the StreamHandler [15:24:00] true, it sounds more like unanticipated interaction between the two handlers [15:24:45] no, the FileHandler mangles the output even when run-job is run from a cron job (so we don't add the StreamHandler) [15:26:11] has this been going on forever or is it new? [15:27:16] I dunno, I just noticed it now [15:27:47] seems not to kick in for the first few minutes of any job, so we wouldn't have seen it for most logs [15:29:09] is it possible there's a second process writing to the same file? [15:29:30] Jeff_Green: no, just two threads in the same process [15:29:44] huh [15:30:55] I'll see if adding some flush() calls helps [16:33:04] Fundraising-Backlog, FR-Paypal: Undo bogus PayPal cancellations - https://phabricator.wikimedia.org/T206343 (Ejegg) [16:36:53] Fundraising Sprint They Live, Fundraising-Backlog, FR-Paypal: Undo bogus PayPal cancellations - https://phabricator.wikimedia.org/T206343 (Ejegg) p:Triage>Unbreak! [16:37:28] Fundraising-Backlog, Fr-Ingenico-integration_2017-18, MediaWiki-extensions-DonationInterface: Invalid locale sent to new Ingenico API - https://phabricator.wikimedia.org/T206093 (Ejegg) Sent an email to merchantservices asking them to clarify [17:40:18] Fundraising-Backlog, donate.wikimedia.org: Opt-In form error message: possible to clarify? - https://phabricator.wikimedia.org/T206057 (Pcoombe) @MBeat33 I've changed it to add the error message above the options if they don't select one, instead of in an alert box. Does this seem clear enough? http://do... [17:47:32] oh boy, getting a bunch of failmails with 'subscription account does not exist' [17:47:40] think we need to uncancel those asap! [17:59:55] (PS1) Ejegg: Un-cancel PayPal subs from bogus audit file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/464860 (https://phabricator.wikimedia.org/T206343) [18:00:07] fr-tech let's get that out soon ^^^ [18:00:20] gonna food for a bit [18:04:00] Wikimedia-Fundraising-Banners, donate.wikimedia.org: Try adding inline errors instead of alerts for missing amount/opt-in - https://phabricator.wikimedia.org/T205701 (Pcoombe) I've done this for the email opt-in now. Amount will be a bit more tricky as there's multiple possible error messages, and some n... [18:15:55] Fundraising-Backlog, donate.wikimedia.org: Opt-In form error message: possible to clarify? - https://phabricator.wikimedia.org/T206057 (MBeat33) Open>Resolved Thanks, @Pcoombe I like it, the red color is a nice touch. I imagine it will be clearer for donors to keep them in the form itself, rather... [18:30:47] XenoRyet: want to review that PayPal un-cancel script? https://gerrit.wikimedia.org/r/464860 [18:31:40] Yea, I'll take a look. [18:42:05] (CR) XenoRyet: [C: 2] Un-cancel PayPal subs from bogus audit file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/464860 (https://phabricator.wikimedia.org/T206343) (owner: Ejegg) [18:46:59] thanks XenoRyet. you feel like pushing that out, or should I? [18:47:20] You go ahead, I've got my mind on something else just now. [18:49:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: can't save any changes to prospect tab - https://phabricator.wikimedia.org/T206242 (DStrine) I cannot reproduce this. @LeanneS @NNichols are you seeing any issues here? [18:49:35] (Merged) jenkins-bot: Un-cancel PayPal subs from bogus audit file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/464860 (https://phabricator.wikimedia.org/T206343) (owner: Ejegg) [19:59:13] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/464873 [20:00:32] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/464873 (owner: Ejegg) [20:01:27] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/464873 (owner: Ejegg) [20:03:22] !log updated fundraising CiviCRM from ebc2e0076c to 7a0d14015e [20:03:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:58:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: can't save any changes to prospect tab - https://phabricator.wikimedia.org/T206242 (NNichols) I'm not having any issues. [22:37:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: can't save any changes to prospect tab - https://phabricator.wikimedia.org/T206242 (LeanneS) I didn't have the same issue when I just tested, but it was a bit slow. [23:07:54] (PS1) Ejegg: Add drush command to rebuild triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/464924 [23:15:33] (PS2) Ejegg: Add drush command to rebuild triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/464924 [23:15:47] XenoRyet: still around? [23:16:05] got a drush command to dump trigger SQL without turning logging on and off ^^ [23:16:10] want to give it a gander? [23:16:14] Yea, I'm still here for a bit. [23:16:42] if you want to try both with and without file dumping, you can use this command to switch the trigger permission setting [23:16:55] (I don't think it's exposed in the UI) [23:17:11] drush cvapi Setting.create logging_no_trigger_permission=1 [23:17:27] 10-4 [23:19:17] hmm, I guess I could make that drush command take an optional table name [23:19:22] but that can be version 2 [23:20:29] also, could put this in civi core [23:33:27] but again, longer term [23:39:25] Looks good so far, but I want to play with it more before I give it the ol' +2 and I've gotta sign off and go get the kids. [23:39:37] I'll pick it back up next week. [23:48:48] well, got a pull request submitted to civicrm-drupal, but who knows how long that'll take to get merged [23:55:16] (PS1) Ejegg: Add a drush command to rebuild SQL triggers [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/464932 [23:55:52] (PS2) Ejegg: Add a drush command to rebuild SQL triggers [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/464932 [23:56:47] (Abandoned) Ejegg: Add drush command to rebuild triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/464924 (owner: Ejegg)