[00:44:40] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463195 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [00:58:03] Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint They Live, Fundraising-Backlog, and 8 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925... [01:02:32] Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint They Live, Fundraising-Backlog, and 8 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925... [01:03:35] (CR) jerkins-bot: [V: -1] Switch to csv package [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463195 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [01:30:16] (PS6) Eileen: Switch to csv package [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463195 (https://phabricator.wikimedia.org/T204008) [01:31:07] (PS3) Eileen: Use filter xss rather than check plain on the log output - this lets us view links [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463899 [01:36:45] (CR) jerkins-bot: [V: -1] Switch to csv package [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463195 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [01:38:31] (CR) jerkins-bot: [V: -1] Use filter xss rather than check plain on the log output - this lets us view links [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463899 (owner: Eileen) [01:58:46] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463195 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [02:02:05] (CR) jerkins-bot: [V: -1] Switch to csv package [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463195 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [02:04:24] is anyone about with access to kick some life into CI [02:33:25] Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint They Live, Fundraising-Backlog, and 8 others: Save times for changes to translation variable text in centralnotice paralysingly slow - https://phabricator.wikimedia.org/T203925... [05:16:26] (PS4) Eileen: [alphaish] Functional import using batch api. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463898 (https://phabricator.wikimedia.org/T204008) [05:16:28] (PS1) Eileen: Import code tweak - Use headers property rather than passing headers variable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) [05:19:35] (CR) jerkins-bot: [V: -1] [alphaish] Functional import using batch api. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463898 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [05:20:59] (CR) jerkins-bot: [V: -1] Import code tweak - Use headers property rather than passing headers variable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [06:34:18] (CR) Nikerabbit: [C: 2] Move from clearCache which deletes everything under the key 'translate-groups' to recache, which just restores the definitions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) (owner: Mepps) [06:36:50] (CR) Nikerabbit: [C: -1] Insert a job into the queue because in this case it is not fast enough to wait for run Would love testing on this patch (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (owner: Mepps) [06:39:03] (Merged) jenkins-bot: Move from clearCache which deletes everything under the key 'translate-groups' to recache, which just restores the definitions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) (owner: Mepps) [06:44:08] (CR) jenkins-bot: Move from clearCache which deletes everything under the key 'translate-groups' to recache, which just restores the definitions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459834 (https://phabricator.wikimedia.org/T203925) (owner: Mepps) [07:18:14] (PS2) Eileen: Import code tweak - Use headers property rather than passing headers variable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) [07:18:16] (PS1) Eileen: Extract the minor functions that mark the outcomes of the row processing. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467595 (https://phabricator.wikimedia.org/T204008) [07:18:18] (PS1) Eileen: Extract setMessages function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467596 [07:18:20] (PS1) Eileen: Handle NULL for url rather than expect a duff value [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467597 (https://phabricator.wikimedia.org/T204008) [07:20:39] (CR) jerkins-bot: [V: -1] Import code tweak - Use headers property rather than passing headers variable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [07:21:57] (CR) jerkins-bot: [V: -1] Handle NULL for url rather than expect a duff value [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467597 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [07:22:08] (CR) jerkins-bot: [V: -1] Extract setMessages function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467596 (owner: Eileen) [07:22:41] (PS5) Eileen: [alphaish] Functional import using batch api. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463898 (https://phabricator.wikimedia.org/T204008) [07:23:15] (CR) jerkins-bot: [V: -1] Extract the minor functions that mark the outcomes of the row processing. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467595 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [07:33:18] (CR) jerkins-bot: [V: -1] [alphaish] Functional import using batch api. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463898 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [11:22:55] (PS2) Jgleeson: Test for mangled SET_PAYMENT response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/458208 (https://phabricator.wikimedia.org/T203126) (owner: Ejegg) [11:25:53] (CR) jerkins-bot: [V: -1] Test for mangled SET_PAYMENT response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/458208 (https://phabricator.wikimedia.org/T203126) (owner: Ejegg) [12:50:23] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463195 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [13:07:16] PROBLEM - check_puppetrun on frbast1001 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 6 minutes ago with 2 failures. Failed resources (up to 3 shown): File[/usr/lib/nagios/plugins/check_strongswan_sudo],File[/usr/lib/nagios/plugins/check_puppetrun_sudo] [13:09:55] (PS3) Hashar: Use composer-merge-plugin 1.4.1 to prepend VCS repos [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) [13:12:16] RECOVERY - check_puppetrun on frbast1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [13:15:01] hey ejegg :) [13:15:11] hi jgleeson [13:15:16] how's it going? [13:16:13] good thanks, just working on the global collect 600 status ticket, been stepping through the gateway object setup stuff to get more familiar with the goings on. How was your day off? [13:17:57] heh, yesterday was mostly on a bus, but the two days before it were pretty spectaculat [13:18:23] visit to an interesting landscape, that is [13:18:29] the tatacoa desert [13:18:58] nice! [13:19:50] pictures look awesome [13:20:27] :) [13:30:03] ejegg, I added some notes to the locale patch you pushed. Looks like we've had the same problem with a new locale [13:30:11] 'vls_B' [13:30:18] West Flemish [13:41:43] (CR) Hashar: "check experimental" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [13:58:08] jgleeson: ooh, fun [13:58:24] (PS4) Hashar: Use composer-merge-plugin 1.4.1 to prepend VCS repos [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) [13:58:27] (PS1) Hashar: Augment precision of updatelist time [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/467685 [13:58:45] (CR) Hashar: "check experimental" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/467685 (owner: Hashar) [13:58:47] (CR) Hashar: "check experimental" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [14:18:56] (CR) Hashar: "check experimental" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) (owner: Hashar) [14:48:26] (PS2) Hashar: Augment precision of updatelist time [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/467685 [14:48:32] fundraising-tech-ops, Operations: add icinga1001 to send_nsca and pfw rules in FRACK - https://phabricator.wikimedia.org/T207175 (Dzahn) [14:48:43] fundraising-tech-ops, Operations: add icinga1001 to send_nsca and pfw rules in FRACK - https://phabricator.wikimedia.org/T207175 (Dzahn) [14:49:06] (CR) Hashar: [C: 1] "PS2: fix a PHP CodeSniffer issue." [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/467685 (owner: Hashar) [14:49:30] (PS5) Hashar: Use composer-merge-plugin 1.4.1 to prepend VCS repos [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/459762 (https://phabricator.wikimedia.org/T203084) [15:58:23] PROBLEM - check_rsyslog_backlog on americium is CRITICAL: CRITICAL frav1001=123 [critical = 10] [16:03:23] RECOVERY - check_rsyslog_backlog on americium is OK: OK [16:46:53] ejegg, you got a few minutes before tech-talk to talk through an idea for the global collect ticket I'm workin on? [16:47:12] shoot, i'm in another meeting till then [16:47:26] I'll ping you if it ends a couple minutes early [16:48:00] ah np, thanks! [16:57:37] jgleeson: ok, that's over. will hop into the tech talk chat early [16:58:35] also, fr-tech: any requests for topics? [16:59:02] heading over now [17:43:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 2736 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 13 keys, up 111 days - memory use is 4.09M (peak 15.51M, 0.11% of max, fragmentation 2.15%), connected_slaves is 2, donations is 158, jobs is 0, jobs-adyen is 17, jobs-paypal is 16, payments-antifraud is 105, payments-init is 7, pending is 1, refund is 1, unsubscribe is 12 [17:48:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 2737 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 13 keys, up 111 days 5 minutes - memory use is 3.89M (peak 15.51M, 0.09% of max, fragmentation 1.88%), connected_slaves is 2, donations is 24, jobs is 0, jobs-adyen is 4, jobs-paypal is 17, payments-antifraud is 84, payments-init is 76, pending is 36, refund is 1, unsubscribe is 12 [17:53:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 2737 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 12 keys, up 111 days 10 minutes - memory use is 3.98M (peak 15.51M, 0.09% of max, fragmentation 1.85%), connected_slaves is 2, donations is 161, jobs is 0, jobs-adyen is 17, jobs-paypal is 18, payments-antifraud is 32, payments-init is 38, pending is 43, refund is 0, unsubscribe is 12 [17:58:12] PROBLEM - check_redis on frqueue1001 is CRITICAL: CRITICAL: recurring is 2746 2000 - REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 111 days 15 minutes - memory use is 3.99M (peak 15.51M, 0.09% of max, fragmentation 1.86%), connected_slaves is 2, donations is 26, jobs is 0, jobs-adyen is 11, jobs-paypal is 15, payments-antifraud is 100, payments-init is 0, pending is 0, refund is 0, unsubscribe is 13 [17:58:31] fr-tech ^ [17:58:47] musta been a batch of recurring payments? [17:58:57] oh boy, is that another bad paypal audit file? [17:59:45] yeah, timing is right [18:02:16] fr-tech phew, I just found where we are indeed grouping by minute in FRUEC, as it's supposed to [18:02:37] AndyRussG: nice! [18:03:12] RECOVERY - check_redis on frqueue1001 is OK: OK: REDIS 2.8.17 on 127.0.0.1:6379 has 1 databases (db0) with 11 keys, up 111 days 20 minutes - memory use is 2.33M (peak 15.51M, 0.08% of max, fragmentation 2.68%), connected_slaves is 2, donations is 160, jobs is 0, jobs-adyen is 5, jobs-paypal is 22, payments-antifraud is 139, payments-init is 137, pending is 0, recurring is 14, refund is 0, unsubscribe is 1 [18:04:26] https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/fundraising/FRUEC/+/66c87389c6c4edc7dcaf87179ee1a61a6e647c31/fruec/db/cn_event_aggregator.py#170 [18:04:33] ^ [18:04:40] just where it's supposed to be [18:07:03] cwd: sent another email to paypal. I'll make another data-fix script [18:07:35] ejegg: they posted a junk file? [18:07:48] ah i see the email [18:08:37] weird [19:33:36] fr-tech: I'll be in the meeting in one more minute [19:44:47] Fundraising-Backlog: reboot the BE dashboard - https://phabricator.wikimedia.org/T207209 (DStrine) [20:00:40] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [20:04:19] (CR) jerkins-bot: [V: -1] Import code tweak - Use headers property rather than passing headers variable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [20:14:28] hmm I take it back about the thing of mine causing the probs - failing again & I didn’t touch it https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/467569/ [20:17:03] Fundraising Sprint They Live, Fundraising-Backlog, FR-Smashpig, Patch-For-Review: Retry Ingenico API calls on (some) 5xx status codes? - https://phabricator.wikimedia.org/T206492 (Ejegg) Open>Resolved a:Ejegg [20:17:45] Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint They Live, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Support Tracking endowment contributions in civi - https://phabricator.wikimedia.org/T203601 (Ejegg) Open>Resolved [20:17:54] Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint They Live, Fundraising-Backlog, and 4 others: Support Amazon payments initiated off paymentswiki - https://phabricator.wikimedia.org/T194317 (Ejegg) Open>Resolved [20:18:11] Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint They Live, Fundraising-Backlog, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review: custom payment support for endowment donation form - https://phabricator.wikimedia.org/T203603 (Ejegg) Open>R... [20:18:20] Fundraising Sprint They Live, Fundraising-Backlog: Jack needs to watch the movie "They Live" - https://phabricator.wikimedia.org/T206141 (Ejegg) Open>Resolved p:Triage>Low [20:29:15] Fundraising Sprint They Live, Fundraising Sprint U 2018, Fundraising-Backlog, FR-Paypal, Patch-For-Review: Undo bogus PayPal cancellations - https://phabricator.wikimedia.org/T206343 (DStrine) [20:29:17] Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint They Live, Fundraising Sprint U 2018, Fundraising-Backlog: Review emergency procedures for holidays - https://phabricator.wikimedia.org/T204763 (DStrine) [20:29:19] Fundraising Sprint They Live, Fundraising Sprint U 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Extend deletion to multiple silverpop databases - https://phabricator.wikimedia.org/T205332 (DStrine) [20:29:21] Fundraising Sprint They Live, Fundraising Sprint U 2018, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Validate CentralNotice translatable message names/fix errors on messages with spaces - https://phabricator.wikimedia.org/T205478 (DStrine) [20:29:27] Fundraising Sprint U 2018, Fundraising-Backlog: reboot the BE dashboard - https://phabricator.wikimedia.org/T207209 (DStrine) [20:29:31] Fundraising Sprint They Live, Fundraising Sprint U 2018, Fundraising-Backlog, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review: Payment form amount field improvements - https://phabricator.wikimedia.org/T206873 (DStrine) [20:29:33] Fundraising Sprint U 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Scheduled contact reminder didn't work - https://phabricator.wikimedia.org/T206053 (DStrine) [20:29:36] Fundraising Sprint They Live, Fundraising Sprint U 2018, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Delay in French mobile banners showing up in Banner Allocation - https://phabricator.wikimedia.org/T206562 (DStrine) [20:29:38] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 5 others: Import log files not including all skipped rows - https://phabricator.wikimedia.org/T200031 (DStrine) [20:29:41] Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Sasquatches can't find us either, and 4 others: Banner previews occasionally fail to load - https://phabricator.wikimedia.org/T200853 (DS... [20:29:43] Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint They Live, Fundraising Sprint U 2018, Fundraising-Backlog, and 2 others: Benevity import errors - https://phabricator.wikimedia.org/T204008 (DStrine) [20:29:45] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 6 others: slow anonymous save - https://phabricator.wikimedia.org/T199753 (DStrine) [20:29:48] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, and 2... - https://phabricator.wikimedia.org/T178930 [20:29:50] Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, and 9 others: New scripts to ingress data from K... - https://phabricator.wikimedia.org/T195594 [20:29:53] Fundraising Sprint They Live, Fundraising Sprint U 2018, Fundraising-Backlog, Fr-Ingenico-integration_2017-18, and 3 others: Invalid locale sent to new Ingenico API - https://phabricator.wikimedia.org/T206093 (DStrine) [20:29:55] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Owls, and 7 others: DB schemas (production changes and test DB) and SQL commands ... - https://phabricator.wikimedia.org/T196564 [20:29:57] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Naming Sprints Is Not Important, Fundraising Sprint Owls, and 7 others: Write a specification for mapping banner/landing page impressi... - https://phabricator.wikimedia.org/T196563 [20:29:59] Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint They Live, Fundraising Sprint U 2018, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix performance issue on activities where there are a lot of contacts connected - https://phabricator.wikimedia.org/T204908 (DStrine) [20:30:01] Fundraising Sprint Owls, Fundraising Sprint Pluto is still a planet, Fundraising Sprint Queue is pronounced GJif, Fundraising Sprint Raw data can give you salmonella, and 5 others: Queries and maybe scripts to verify equivalence of data in new-Kafka-pipelin... - https://phabricator.wikimedia.org/T198752 [20:30:07] Fundraising Sprint Raw data can give you salmonella, Fundraising Sprint Sasquatches can't find us either, Fundraising Sprint They Live, Fundraising Sprint U 2018, and 9 others: Save times for changes to translation variable text in centralnotice paralysingl... - https://phabricator.wikimedia.org/T203925 [20:35:02] Hi ejegg, just wanted to check on the status of T199733 and backporting T199682 for es-419 support? If it's super easy, it would be nice to do before the Latin America campaign launches. But if it's at all complicated, we don't want to hold things up [20:35:02] T199682: Localise most important DonationInterface messages to Latin American Spanish - https://phabricator.wikimedia.org/T199682 [20:35:03] T199733: Add es-419 as a supported 'preferred language' in Civi - https://phabricator.wikimedia.org/T199733 [20:38:37] Fundraising Sprint U 2018, Fundraising-Backlog, Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM: Add es-419 as a supported 'preferred language' in Civi - https://phabricator.wikimedia.org/T199733 (DStrine) [20:39:09] pcoombe: I /think/ it's a pretty simple one. It's in the sprint, so we'll find out this week or next! [20:44:16] ejegg: We're just trying to decide when to launch Latin America as it's been delayed a few times already. Personally I'm happy to launch without that if it's not something which can be done in the next couple of days. But Jessica wanted me to check if it was something easy. [20:47:49] Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising-Backlog: reboot the BE dashboard - https://phabricator.wikimedia.org/T207209 (Ejegg) @cwdent or @Jgreen, looks like there's an issue with the OAuth token request. Can you check if frdev is allowed to make the http request to pr... [20:49:12] I'll take it to email to loop Jessica in [20:52:22] ejegg: so my tests failed even without the loop patch so I guess it wasn’t that [20:52:31] https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/467569/ [20:52:50] eileen: ugh [20:52:55] let's see [20:53:52] ok, that looks like every DB test is busted, let's see what the disk space looks like on the 1001 CI box [20:54:44] yeah 98% of the tiny /var/lib/mysql partition used [20:56:20] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [20:56:34] cleared it out, but it'll fill up again [20:56:42] hmm [20:56:55] why is the partiion so small? [20:59:51] (CR) jerkins-bot: [V: -1] Import code tweak - Use headers property rather than passing headers variable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [21:00:02] eileen: no idea. I just asked again if we could get in increased [21:00:04] https://phabricator.wikimedia.org/T205950 [21:00:13] ^^^ ticket for the CI team [21:01:01] ejegg: that test failed again :-( & I think the reason is CI not the patch [21:01:32] eileen: ah, ran on a different box that time [21:02:14] which also had the partition full [21:02:28] I've just cleared it out on 1001, 1002, 1003, and 1004 [21:02:44] which might buy us a week of not-broken tests, if we're lucky [21:02:49] ejegg: I see in the ticket ibdata is pretty big - I feel like that is a reply log that get’s truncated if some action happens - just trying to recall [21:03:08] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [21:03:34] eileen: from what I saw, you need to clear it manually [21:03:44] but that might have been old docs [21:05:27] eileen: looks like /var/lib/mysql is tmpfs, so I guess it's sharing the RAM allocated to each of those machines [21:05:38] which I guess it why they limit the size [21:05:47] Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising-Backlog: reboot the BE dashboard - https://phabricator.wikimedia.org/T207209 (Jgreen) >>! In T207209#4672178, @Ejegg wrote: > @cwdent or @Jgreen, looks like there's an issue with the OAuth token request. Can you check if frdev... [21:06:28] ejegg: so I guess I’m a bt confused in that I thought the DB would be blown away between test runs [21:06:59] (CR) jerkins-bot: [V: -1] Import code tweak - Use headers property rather than passing headers variable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [21:07:26] ejegg: so I don't think we detected anything bad about LATAM test right? DS seems cool with it. [21:11:30] dstrine: no, not that I know of [21:11:49] eileen: yeah, so I guess the DB is blown away, but that ibdata1 file isn't [21:12:00] are we able to do that? [21:12:13] I think the file per table would help us not lose space [21:12:27] hmm, maybe! [21:14:31] oh weird, this last failure looks different: segmentation fault [21:14:36] https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/7484/console [21:15:01] Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising-Backlog: reboot the BE dashboard - https://phabricator.wikimedia.org/T207209 (Jgreen) apache2 on the civi server is logging this: 127.0.0.1 - - [16/Oct/2018:20:24:57 +0000] "POST /oauth/request_token HTTP/1.1" 401 409 "-" "Nod... [21:15:23] ejegg: yeah - I can do a recheck but if we can delete that ibdata first would be good [21:16:24] Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising-Backlog: reboot the BE dashboard - https://phabricator.wikimedia.org/T207209 (Ejegg) Ahh, OK, so it's getting through to the Civi server, it's just that Civi's responding with a 401. Thanks, I'll try to dig more from there. [21:17:48] Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising-Backlog: dash oauth stopped working - https://phabricator.wikimedia.org/T207209 (Jgreen) [21:18:24] Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising-Backlog: dash oauth stopped working - https://phabricator.wikimedia.org/T207209 (Jgreen) [21:18:28] eileen: I did delete ibdata on all of those servers [21:18:44] ejegg: I’ll do recheck again then [21:19:09] OK, but we did get a non-disk-space related weird test fail [21:19:45] that segmentation fault was with most of the mysql partition free [21:20:34] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [21:22:13] ejegg: on the import code - I’m weighing up whether I should replace the csv outputs with a table - which woudl need a cleanup job & then the csvs would be generated on demand. The downside is that if I used one table I’d either need to put the row data into a json format or figure out how to add new columns if an immport is wider than the table [21:23:00] eileen: I'd say we go with json blobs [21:23:28] we wouldn't be interacting with the busted rows except to dump them out later [21:23:34] ejegg: do you think it’s worth me doing the conversion or am I going down a rabbit hole ? [21:23:45] (CR) jerkins-bot: [V: -1] Import code tweak - Use headers property rather than passing headers variable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [21:24:15] ugh, another segmentation fault. WTF is up with that? [21:24:40] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/464166 (owner: Ejegg) [21:25:03] I’ll try it locally to make sure there isn’t something weird [21:26:10] eileen: would it make sense to get the batch API switch solid, then look again at the table for busted import rows? [21:26:24] or would it be a lot easier to tackle the table first? [21:26:47] yeah - I guess locally I’m only a test or 2 away from the batch api being sorted [21:28:14] (PS3) Eileen: Import code tweak - Use headers property rather than passing headers variable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) [21:28:53] ok - running tests locally, I also slightly simplified that commit [21:29:21] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463899 (owner: Eileen) [21:30:10] Just set this one to recheck - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/463899/ - it doesn’t change any tested lines of code or rely on anything so it’s a kind of ‘pure’ test [21:31:30] (CR) jerkins-bot: [V: -1] Import code tweak - Use headers property rather than passing headers variable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [21:34:50] (PS4) Eileen: Import code tweak - Use headers property rather than passing headers variable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467569 (https://phabricator.wikimedia.org/T204008) [21:36:58] ejegg: I think I found a php cause for the segfault - kinda surprising it manefested as a segfault but I think it was this https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/467569/4/sites/all/modules/offline2civicrm/WmfImportFile.php [21:37:10] (PS3) Jgleeson: Handled invalid SET_PAYMENT response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/458208 (https://phabricator.wikimedia.org/T203126) (owner: Ejegg) [21:37:41] fr-tech, anyone getting errors with phpcs when they run `composer test` on DonationInterface ? [21:38:10] I get path missing errors and then when i specify '.' as the path I get tons of failures [21:38:13] jgleeson: lemme check [21:39:22] (CR) jerkins-bot: [V: -1] Handled invalid SET_PAYMENT response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/458208 (https://phabricator.wikimedia.org/T203126) (owner: Ejegg) [21:39:49] jgleeson: it's working for me locally [21:40:30] ejegg, are you on PHP_CodeSniffer version 2.1.0 (stable) by Squiz (http://www.squiz.net) [21:40:31] any chance you're on the deploy branch, or using the deployed vendor submodule (which doesn't have any of the require-dev packages) [21:41:28] jgleeson: looks like it should be 3.2.3 [21:41:34] installed in vendor [21:41:47] try composer install first? [21:43:21] hmm yeah looks like something sup [21:46:22] actually [21:46:29] I'm on REL_127 [21:46:37] didn't we move up from that? [21:46:45] or did we hold off due to issues related [21:47:33] (PS2) Eileen: Handle NULL for url rather than expect a duff value [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467597 (https://phabricator.wikimedia.org/T204008) [21:47:35] (PS1) Eileen: Drupal code formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467827 [21:48:58] ejegg, looks like my vendor submodule was messed up. resetting that and composer installing looks to have fixed it [21:49:09] thanks for the tip! [21:49:44] yw! [21:50:15] jgleeson: still 1.27, till January [21:54:00] (CR) jerkins-bot: [V: -1] Handle NULL for url rather than expect a duff value [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467597 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [21:59:45] (PS2) Eileen: Extract the minor functions that mark the outcomes of the row processing. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467595 (https://phabricator.wikimedia.org/T204008) [22:00:47] (PS3) Eileen: Extract the minor functions that mark the outcomes of the row processing. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467595 (https://phabricator.wikimedia.org/T204008) [22:00:49] (PS3) Eileen: Handle NULL for url rather than expect a duff value [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467597 (https://phabricator.wikimedia.org/T204008) [22:01:13] ejegg: I seem to be getting green ticks on the patches that are good now [22:02:01] eileen: cool, looks like they're broken down into some bite-size CR morsels [22:02:03] I’ve been breaking up that big commit to smaller refactors [22:02:08] snap [22:03:01] just taking a peek at some dash-related settings, then I'll do some review [22:04:05] ejegg: cool - no pressure - I am still working through the bigger one [22:04:11] now tests are back on track [22:05:56] (PS4) Jgleeson: Handle invalid GC SET_PAYMENT response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/458208 (https://phabricator.wikimedia.org/T203126) (owner: Ejegg) [22:06:06] (PS4) Eileen: Handle NULL for url rather than expect a duff value [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467597 (https://phabricator.wikimedia.org/T204008) [22:07:27] (CR) jerkins-bot: [V: -1] Handle NULL for url rather than expect a duff value [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467597 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [22:08:13] (PS2) Eileen: Extract setMessages function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467596 [22:08:28] (CR) jerkins-bot: [V: -1] Handle invalid GC SET_PAYMENT response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/458208 (https://phabricator.wikimedia.org/T203126) (owner: Ejegg) [22:10:29] (PS6) Eileen: WIP [alphaish] Functional import using batch api. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463898 (https://phabricator.wikimedia.org/T204008) [22:14:24] (CR) jerkins-bot: [V: -1] WIP [alphaish] Functional import using batch api. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463898 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [22:16:15] interesting, my format checking for detecting valid xml seems to break some other global collect tests [22:16:33] something to dig into tomorrow [22:16:41] g'night fr-tech [22:16:50] jgleeson: cya! [22:24:58] (PS3) Eileen: Extract setMessages function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467596 (https://phabricator.wikimedia.org/T204008) [22:25:00] (PS1) Eileen: Instantiate all output files at the start. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467832 (https://phabricator.wikimedia.org/T204008) [22:30:42] (PS1) Eileen: Do our validation & header instantiation in construct, as long as we have the field uri [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467833 (https://phabricator.wikimedia.org/T204008) [22:32:16] (CR) jerkins-bot: [V: -1] Instantiate all output files at the start. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467832 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [22:50:13] (PS2) Eileen: Do our validation & header instantiation in construct, as long as we have the field uri [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467833 (https://phabricator.wikimedia.org/T204008) [22:50:15] (PS2) Eileen: Instantiate all output files at the start. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467832 (https://phabricator.wikimedia.org/T204008) [23:04:57] (PS2) Ejegg: Special fallback logic for IngenicoLocale [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/466930 (https://phabricator.wikimedia.org/T206093) [23:25:55] (PS7) Eileen: WIP [alphaish] Functional import using batch api. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463898 (https://phabricator.wikimedia.org/T204008) [23:27:09] (PS8) Eileen: WIP [alphaish] Functional import using batch api. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463898 (https://phabricator.wikimedia.org/T204008) [23:31:32] (CR) jerkins-bot: [V: -1] WIP [alphaish] Functional import using batch api. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463898 (https://phabricator.wikimedia.org/T204008) (owner: Eileen) [23:43:56] (PS1) Eileen: Use function to write csv rows. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/467845 (https://phabricator.wikimedia.org/T204008) [23:52:53] (PS9) Eileen: WIP [alphaish] Functional import using batch api. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463898 (https://phabricator.wikimedia.org/T204008) [23:56:39] (CR) jerkins-bot: [V: -1] WIP [alphaish] Functional import using batch api. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/463898 (https://phabricator.wikimedia.org/T204008) (owner: Eileen)