[20:25:22] (PS1) XenoRyet: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/472248 [20:29:19] (CR) XenoRyet: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/472248 (owner: XenoRyet) [20:31:49] ejegg|ish: I'm prepping a DI deploy that's got a couple of your patches in there. You cool with those going out now-ish? [20:34:44] XenoRyet: we should test those first! [20:35:19] They'll switch all the card processing for Peru and Uruguay over to a different processor [20:35:32] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/472248 (owner: XenoRyet) [20:35:41] Oh, have they not been? I assumed that happened before they merged [20:35:57] I'll hold off a bit then. [20:36:21] XenoRyet: not live. Now that I think of it, I should probably do a preliminary patch to make them not the default just yet [20:36:36] also, fr-tech, are we doing the -talk? [20:36:48] ejegg: can do - do you have a topic [20:37:08] I was in the middle of this deploy, but if I'm holding I can do it. [20:37:36] what subject do people want to cover? [20:37:51] Oh, I'm pretty open. [20:38:27] is there anything around failmail we should look at [20:39:35] folks want to puzzle out a better solution to the paypal id switch? [20:41:26] Could take a look I suppose [20:41:29] sure [20:42:26] Though I guess I've got my 1 on 1 with Erika in 15 mins [20:42:52] ok, let me just make a quick patch to demote the dlocal forms to not-default [20:48:52] (PS1) Ejegg: Make dlocal non-default for PE and UY [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472254 [20:53:00] (CR) XenoRyet: [C: 2] Make dlocal non-default for PE and UY [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472254 (owner: Ejegg) [21:00:59] (Merged) jenkins-bot: Make dlocal non-default for PE and UY [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472254 (owner: Ejegg) [21:20:40] (PS1) XenoRyet: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/472266 [21:24:24] (CR) XenoRyet: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/472266 (owner: XenoRyet) [21:42:54] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/472266 (owner: XenoRyet) [21:52:31] (PS1) XenoRyet: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/472338 [21:56:29] (CR) XenoRyet: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/472338 (owner: XenoRyet) [21:59:28] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/472338 (owner: XenoRyet) [22:06:32] !log updated payments-wiki from 34506ce636 to 983ce3af0f [22:06:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:15:40] I just did my own 2018 donation - process was good but the thank you page colours were pretty jarring [22:16:50] fb share form was a bit odd in terms of the size being full screen & button hard to spot as a result - but prob we don’t control that [22:17:12] Fundraising Sprint Vestigial tails shoot from the hip, Fundraising-Backlog, FR-Ingenico, MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review: Ingenico iframe sizing issue? - https://phabricator.wikimedia.org/T208351 (XenoRyet) This is deployed now, and the fix looks good in production. [22:22:55] Fundraising Sprint Vestigial tails shoot from the hip, Fundraising-Backlog, FR-Ingenico, MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review: Ingenico iframe sizing issue? - https://phabricator.wikimedia.org/T208351 (MBeat33) Thanks, @XenoRyet [22:56:28] Fundraising Sprint Vestigial tails shoot from the hip, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Leanne getting $500 + emails - stop it - https://phabricator.wikimedia.org/T208817 (Eileenmcnaughton) Open>Resolved talked with @LeanneS & seems good [22:56:44] Fundraising Sprint USB stands for underhanded socket bureaucracy, Fundraising Sprint Vestigial tails shoot from the hip, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: exclude endowment donations from large donation bot - https://phabricator.wikimedia.org/T207712 (Eileen... [23:07:03] Fundraising Sprint Vestigial tails shoot from the hip, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Paypal: Deal with PayPal subscr_payment messages with updated subscr_ids and no indication of the old ones. - https://phabricator.wikimedia.org/T209008 (Ejegg) [23:07:47] (PS1) Ejegg: PayPal susbscr_id swap fix v2 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472347 (https://phabricator.wikimedia.org/T209008) [23:09:12] eileen: OK, ^^^ is the way-more-specific fix for the PayPal subscr_id mutation issue [23:09:38] It was a big mistake to try to do a 'generic' solution [23:10:25] (CR) jerkins-bot: [V: -1] PayPal susbscr_id swap fix v2 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472347 (https://phabricator.wikimedia.org/T209008) (owner: Ejegg) [23:10:35] oops, let's see what's the matter there [23:11:47] (PS2) Ejegg: PayPal susbscr_id swap fix v2 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472347 (https://phabricator.wikimedia.org/T209008) [23:12:11] note to self: always run the tests again when you git commit --amend [23:15:53] OK, that's passing [23:17:58] XenoRyet: revised version of the paypal fix available for review if you wanna take a look: https://gerrit.wikimedia.org/r/472347 [23:18:18] yea sure. Let me check on a few things then I'll get on it. [23:18:26] tightens up the search criteria a bit [23:18:48] (only looks for legacy paypal subscriptions, and only when the incoming message is tagged paypal or paypal_ec) [23:19:06] but it also mutates both the message and the civicrm_contribution_recur record [23:19:35] It stashes the new id in the ccr.processor_id field, which we're not using for PayPal [23:19:49] Ok, cool [23:19:53] just in case we want to switch them over later [23:20:04] ejegg: just looking at that - my first thoughts are to get some more comments [23:20:07] in the code [23:20:21] eileen sure thing, will add more [23:20:23] there are some pretty convoluted reasons as to why you are making those changes [23:20:32] which won’t be any less opaque in 2 years :-) [23:20:43] Fair point there [23:39:53] (PS3) Ejegg: PayPal susbscr_id swap fix v2 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472347 (https://phabricator.wikimedia.org/T209008) [23:40:21] OK eileen and XenoRyet, elucidated! ^^ [23:40:35] 10-4 [23:42:50] yep great [23:43:10] I haven’t looked at the tests but I’m happy with the functional code changes [23:43:28] :) [23:47:45] Yea, looking pretty good to me too, so far. [23:50:24] Oh hey, that test file could use a whilespace fix, and more comments. [23:50:35] Well, I'll add the comments in PS4 [23:50:43] and follow up with a whitespace patch [23:54:35] (CR) Eileen: [C: 1] "still looking at the test" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472347 (https://phabricator.wikimedia.org/T209008) (owner: Ejegg) [23:56:16] (PS4) Ejegg: PayPal susbscr_id swap fix v2 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472347 (https://phabricator.wikimedia.org/T209008) [23:57:31] ooh, thanks for that tip eileen! We could use that in a bunch of places [23:57:54] (PS1) Ejegg: Reformate RecurringQueueTest to drupal style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472355 [23:58:22] ejegg: yeah - the position on whether that is ‘supported’ to use outside of core is a bit grey but a much lighter grey than the other function :-) [23:58:36] nice