[00:02:04] ffs my local test env is borked :-( [00:02:31] oh, boo [00:02:57] you didn't recently upgrade to PHP 7.3 by any chance? [00:04:03] ejegg: hmm - been trying to get latest ab running - but it’s something else [00:04:35] (PS5) Ejegg: PayPal susbscr_id swap fix v2 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472347 (https://phabricator.wikimedia.org/T209008) [00:04:50] I upgraded stuff locally - like mamo [00:04:52] mamp [00:05:01] hmm, the new fn makes me a *lil* bit uneasy passing the class name in as a string [00:06:01] but if it's less likely to go away than CRM_Contribute_PseudoConstant::contributionStatus, I'll put up a patch to migrate off that one [00:06:26] ok mysql is broken [00:06:45] well that'll make things difficult [00:06:45] I’ll just read the code huh [00:08:14] (PS2) Ejegg: Reformate RecurringQueueTest to drupal style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472355 [00:08:21] XenoRyet: any thoughts so far on the new, comment-ful version? [00:08:24] ejegg: ok I’m happy with it - were there any last minute things you want to do first [00:08:46] eileen nope, all settled on my end [00:08:48] I’m Ok to +2 it [00:08:54] based on my review [00:09:01] thanks! [00:09:02] Yea, it's looking good to me too [00:09:09] Go ahead and hit the +2 buttong [00:09:20] (CR) Eileen: [C: 2] Reformate RecurringQueueTest to drupal style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472355 (owner: Ejegg) [00:09:20] XenoRyet: are you currently able to run crm tests locally? [00:10:03] Not just at the moment, what with my recent vagrant troubles, but I'm not going to let that hold this patch back. [00:12:07] oh hey, phpstorm is careful enough not to mess with the tabs inside quotes when I hit the reformat key, even when it's just sql [00:12:21] gonna finish that whitespace fix [00:12:49] phpstorm is pretty clever these days [00:13:21] (PS3) Ejegg: Reformate RecurringQueueTest to drupal style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472355 [00:13:37] eileen: were you intending to +2 the parent patch? https://gerrit.wikimedia.org/r/472347 [00:14:04] sorry, I got a little twitchy when I was looking at the test diff and noticed the WS change [00:14:12] so I tacked that second patch on top [00:16:06] (CR) Eileen: [C: 2] PayPal susbscr_id swap fix v2 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472347 (https://phabricator.wikimedia.org/T209008) (owner: Ejegg) [00:16:11] :) :) [00:17:20] wow I almost got fooled by a phishing attempt - I should forward to OIT? [00:17:25] I know the most correct way is to put the ws patch first, so there's no commit with an inconsistent state [00:17:31] eileen: yes, definitely! [00:17:44] what email do I use -? [00:17:51] techsupport@ [00:18:01] ok [00:18:14] does security@ want to see those too, or am I thinking of something else? [00:18:19] it was an ‘apple id’ one FYI [00:19:54] (CR) Ejegg: [C: 2] Reformate RecurringQueueTest to drupal style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472355 (owner: Ejegg) [00:20:09] Yea, looks like I was thinking different. Techsupport@ is enough. [00:20:57] I think I did both in the end - they can ignore [00:21:20] (Merged) jenkins-bot: PayPal susbscr_id swap fix v2 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472347 (https://phabricator.wikimedia.org/T209008) (owner: Ejegg) [00:21:37] XenoRyet: did you end up doing that DonationInterface deploy? [00:21:51] Yea, I did. [00:21:51] I'll ask for in-country testers as soon as that stuff is up [00:21:59] ok, thanks [00:22:06] Looked stable, should be ready for in-country tests [00:26:05] (Merged) jenkins-bot: Reformate RecurringQueueTest to drupal style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472355 (owner: Ejegg) [00:27:19] Cool [00:27:41] OK, I'll deploy that PayPal bit, but I'll hold off pushing more damaged messages through till tomorrow morning [00:28:38] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/472360 [00:28:55] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/472360 (owner: Ejegg) [00:29:33] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/472360 (owner: Ejegg) [00:30:53] and I'll try tomorrow to undo the damage caused by the earlier patch [00:32:07] !log updated fundraising CiviCRM from 769dcf6456 to 07183ed7cc [00:32:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:32:14] good night, folks! [10:18:14] Wikimedia-Fundraising, Android-app-feature-Feeds, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, and 4 others: 2018 English campaign fundraising on apps - https://phabricator.wikimedia.org/T204821 (schoenbaechler) **Time frame** I suggest to run the campaign for the same amount of... [10:26:38] Wikimedia-Fundraising, Android-app-feature-Feeds, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, and 4 others: 2018 English campaign fundraising on apps - https://phabricator.wikimedia.org/T204821 (schoenbaechler) Thanks for the all the infos @Dbrant and @bearND. Some answers and qu... [10:50:00] (CR) Eileen: "jgleeson - you did see this didn't you?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/471907 (https://phabricator.wikimedia.org/T206540) (owner: Eileen) [12:43:53] (CR) Jgleeson: "yup!! thanks for the detailed starter guide!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/471907 (https://phabricator.wikimedia.org/T206540) (owner: Eileen) [14:24:30] dang, none of my local websites are working. php-fpm sure seems to be running on the same socket that nginx is trying to connect to [14:24:42] but it's all *5 recv() failed (104: Connection reset by peer) while reading response header from upstream [14:24:56] what the heck, it was working yesterday! [14:27:22] hmm, php7.3-fpm.log says children are dying: child 25452 exited on signal 11 (SIGSEGV) after 21.269275 seconds from start [14:29:08] think on the dying children! [14:29:59] tragic epidemic of segfaults [14:30:13] Code: Bad RIP value. [14:30:25] mortality everywhere in the logs [14:30:47] well, maybe I'll go back to PHP 7.2 for now [14:33:27] sounds like that would be better for the children... [14:45:02] Wikimedia-Fundraising, Android-app-feature-Feeds, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, and 4 others: 2018 English campaign fundraising on apps - https://phabricator.wikimedia.org/T204821 (Dbrant) > `$dayoftheweek` isn’t feasible for a possible campaign start on November 28... [14:54:08] (PS1) Ejegg: Bring debit card subtitle back into frame [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472463 (https://phabricator.wikimedia.org/T208963) [14:54:33] fr-tech here's a little CSS tweak to the cards with subtitle text ^^^ [14:55:11] So, we need to send DLocal a different code for Visa Debit cards than we do for Visa Credit [14:55:22] and they don't have a separate logo [14:55:29] hence this hack [15:11:31] (CR) Ejegg: [C: 1] "Logic looks good! Just one thing with the test data - let's change the AdditionalReference and ReferenceOriginalPayment tags to look more " [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/472051 (owner: Jgleeson) [15:23:14] (CR) Jgleeson: [C: 2] "Fix works for me. Testing with MX and PE." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472463 (https://phabricator.wikimedia.org/T208963) (owner: Ejegg) [15:23:31] (CR) Jgleeson: [C: 2] "Tested*" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472463 (https://phabricator.wikimedia.org/T208963) (owner: Ejegg) [15:35:24] (PS2) Jgleeson: Add ingenico connect support for Audit refund parsing [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/472051 [15:36:53] (CR) Jgleeson: "@ejegg I've updated the fields. I test indicates that we map this specific prefix to c_t_id, is this correct?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/472051 (owner: Jgleeson) [15:37:18] (CR) Jgleeson: "the test*" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/472051 (owner: Jgleeson) [15:37:57] gerrit needs an edit comment feature for typo offenders such as myself [15:51:30] hehe [16:00:49] (PS1) Ejegg: Add mappings for Uruguay cards [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/472488 (https://phabricator.wikimedia.org/T208963) [16:01:19] (Merged) jenkins-bot: Bring debit card subtitle back into frame [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472463 (https://phabricator.wikimedia.org/T208963) (owner: Ejegg) [16:05:29] jgleeson: sorry, I mean the part AFTER the period should be 1 or 2 digits! [16:05:37] the part before the period was good as it was [16:06:41] but if you look at the getGateway function in that audit class, you can see it falls back to checking for 5 digits after the dot to indicate an old-style payment [16:06:51] when we don't have the tell-tale new email fields [16:09:20] (CR) Ejegg: "It's ct_id.sequence_num, where sequence_num depends on how many times the donor has to retry before they get the payment completed. as not" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/472051 (owner: Jgleeson) [16:09:53] (PS2) Jgleeson: WIP: Add payment_token fields to forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/471907 (https://phabricator.wikimedia.org/T206540) (owner: Eileen) [16:10:15] ahh ok ejegg I'll update [16:10:22] thanks! [16:10:33] heading out for dinner now but will fix when I get back [16:14:15] (CR) jerkins-bot: [V: -1] WIP: Add payment_token fields to forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/471907 (https://phabricator.wikimedia.org/T206540) (owner: Eileen) [17:37:59] (PS1) Ejegg: Add payments instruments for Uruguay cards [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472501 (https://phabricator.wikimedia.org/T208963) [17:56:58] (PS1) Ejegg: Add settings and logos for two UY-specific cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472503 (https://phabricator.wikimedia.org/T208963) [19:46:54] whew, that was a long bus ride! [19:58:58] XenoRyet: got some easy review teed up if you're free [19:59:08] Yea, what's up? [19:59:52] https://gerrit.wikimedia.org/r/472488 would be a good start [20:00:05] just a couple more cards from https://dlocal.com/developers/documentation.php?sec=streamline [20:01:08] (CR) XenoRyet: [C: 2] Add mappings for Uruguay cards [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/472488 (https://phabricator.wikimedia.org/T208963) (owner: Ejegg) [20:01:35] (Merged) jenkins-bot: Add mappings for Uruguay cards [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/472488 (https://phabricator.wikimedia.org/T208963) (owner: Ejegg) [20:02:24] jgleeson|away: if it's not stepping on your tows, I can update that test data in smashpig [20:02:36] *toes [20:04:00] ehh, never mind me, I'm just procrastinating dealing with that data fix [20:04:14] back to the befuddling problem! [21:52:24] XenoRyet: can you help me look at the busted donations [21:52:47] I need to fix the ones that come back from this query before I can turn on the recurring payment processors again [21:52:59] https://phabricator.wikimedia.org/T144557#2673161 [21:54:38] cwd anything going on with mysql on frdev? [21:54:53] ejegg: what's the problem? [21:55:03] getting an error message saying the socket is missing [21:55:11] Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2 "No such file or directory") [21:55:53] huh, same here. [21:56:25] the server is stopped. Jeff_Green do you happen to know anything about that? [21:57:23] oh blarg, yeah I was doing package updates because the latest nginx vulnerability and the got the mysql package by accident, which restarted the server [21:57:37] ooh fun, nginx vuln [21:57:47] * ejegg updates personal site [21:58:11] yeah, unsuperduper [21:58:27] it looks like a DoS with possible memory exposure [21:58:40] mariadb looks like it's back to normal, look ok to you? [21:58:46] yep, connected! [21:58:53] man i hate how apt sometimes restarts mysql [21:58:56] sorry about that! [21:58:58] by surprise [21:59:06] because it makes me not want to update the most critical databases [21:59:19] yeah I don't really understand the logic of including a restart in the mysql package [21:59:35] it's the package itself I think, like a postinstall action or something [22:02:21] pretty optimistic to assume everyone is quite that HA [22:04:39] also argh this nginx vuln is bad [22:04:58] yeah, that's why I didn't let it sit [22:07:42] alright ejegg, that querry is returning about 20 rows for me. What are we looking at here? [22:08:28] so, I think some of those are attached to the wrong contribution_recur records [22:08:35] and some of them might have the wrong date [22:09:58] hmm [22:10:26] ok, some of them are paypal donations attached to a globalcollect recurring. Those should be easy enough to find and fix [22:10:49] I'll write up a patch for that one first [22:13:06] Yea, that should be fairly straightforward [22:18:30] can you see if you can figure out a pattern for the others? [22:18:42] Yea, let me see if I can see anything. [22:34:25] ejegg: I don't think I'm quite seeing why this querry is turning up our suspect donations [22:34:31] ok, so there are some mismatched ones that aren't on that list of 20 [22:35:19] XenoRyet: So, that query is just looking for recurring donations whose next scheduled contribution date is not around 30 days from the previous donation [22:35:58] and since some of the email-matched donations got attached to the wrong subscription, they threw that calculation off [22:41:16] So detecting ones with mismatched dates isn't as easy as just finding things who's recur is +30 days... [22:43:24] hmm... I forgot to eat. Let me go grab some food and mull this over a bit. [22:51:20] Wait, this looks for things that need their dates adjusted because they're close to the the end of the month. Does that mean all we need to do is see which of them aren't scheduled to recur within a day or two of the end of the month and those are our culprits? [22:51:29] Anyway, really making a sandwich now. [22:54:03] hmm, really? [22:54:42] (PS1) Ejegg: WIP: fix paypal donations associated with non-paypal recur [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472590 [22:54:51] This library is closing - gonna look for a new place to work [22:55:14] in the meantime, ^^^ should fix the paypal ones associated with non-paypal recurring records. [23:07:17] ok, back [23:07:39] so, those need some kind of note so we can find them again if needed [23:07:42] let's see [23:12:31] (PS2) Ejegg: Fix paypal donations associated with non-paypal recur [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472590 (https://phabricator.wikimedia.org/T209008) [23:12:42] OK, there's a 'note' text field on the donation [23:12:46] using that to tag it [23:12:54] XenoRyet: does that look right? ^^^ [23:13:15] it's actually 27 rows [23:13:54] I guess a bunch of them must have not been picked up by the recurring processor's gatekeeper query for whatever reason [23:14:19] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/472591 [23:14:31] but after we run that, we can retry the gatekeeper query and see what's left [23:14:44] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/472591 (owner: Ejegg) [23:16:17] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/472591 (owner: Ejegg) [23:17:24] shoot, why am I getting a DB error running that locally? [23:17:54] do I have to do it without a temp table? [23:18:33] (PS1) Ejegg: update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/472592 [23:18:45] (CR) Ejegg: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/472592 (owner: Ejegg) [23:25:57] freaky, there's a schema difference [23:26:07] note doesn't exist in my newer crm db [23:26:24] XenoRyet: what about yours? [23:26:45] well, it does exist on production [23:27:28] ok, gonna just push out that css fix [23:31:17] XenoRyet: wanna ping me when you're available again? [23:32:13] (PS3) Ejegg: Fix paypal donations associated with non-paypal recur [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472590 (https://phabricator.wikimedia.org/T209008) [23:34:16] (Merged) jenkins-bot: update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/472592 (owner: Ejegg) [23:43:07] ejegg: back now. Sorry about that, apparently IRC reconnected and took my afk flag off. [23:43:17] So where are we at? [23:46:26] there's the latest patch in crm to review [23:46:54] Ok, let me look at that. [23:47:00] does your local db have a 'note' field on the civicrm_contribution table? [23:47:15] one of my local dbs has it, the other doesn't [23:47:22] but production does [23:47:26] let me check [23:47:59] Though my local setup is still minorly borked anyway. Gonna spend some time tomorrow finishing sorting that out. [23:48:13] if you look at PS2 of that patch, it's a version with temp tables so you can try it on frdev [23:48:21] 10-4 [23:49:31] so i figure we can run that and see what's left to fix [23:58:23] (CR) XenoRyet: [C: 2] Fix paypal donations associated with non-paypal recur [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/472590 (https://phabricator.wikimedia.org/T209008) (owner: Ejegg) [23:58:32] Yea, that works [23:59:55] ok, I'll run that and see what happens