[00:05:46] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, FR-PayPal-ExpressCheckout: PayPal recurring audit 10/21/2018 duplicate - https://phabricator.wikimedia.org/T209294 (XenoRyet) Yea, found the one from 11/14 as well, so looks like we're not as done with this as I suspected.... [00:59:58] eileen: hiya, just getting a fire going and then i'll run those triggers [01:00:15] cwd lol - I misread that as a fire in our code [01:00:25] but you mean an ACTUAL fire [01:00:58] I love the technological dichotomy there. [01:01:33] anyway, gotta go get the kids. [01:01:37] hehe [01:01:43] putting out some fires, starting others [01:02:22] but we'll need more cpu cores if i'm going to use the code fires for warmth [01:07:26] eileen: jeff has requested we not do anything to the master db live anymore: https://phabricator.wikimedia.org/T210023 [01:07:33] except this one, cause i said i would [01:07:38] which he was not thrilled about [01:08:05] cwd - by ‘anymore’ do you mean for the rest of the year? until after thanksgiving? [01:08:28] i think he means "forever" [01:08:47] just to say we should schedule an outage [01:09:03] speaking of which, something i'd love to do would be reboot all the servers before next week [01:09:08] if it's feasible [01:09:21] cwd ah - we actually do have a diff on the triggers file [01:09:35] although I admit I didn’t generate it first this time [01:09:45] i do not have any material concerns except that it's been a long time and a few servers have updated packages that haven't gone live [01:09:49] but basically I normally commit a diff [01:10:16] it's a catch-22 because the most critical servers are the ones that are the most inconvenient to update and reboot [01:11:05] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: we need a failsafe deployment process for civicrm triggers/procedures - https://phabricator.wikimedia.org/T210023 (Eileenmcnaughton) Just a note that normally we do submit a patch to the stored triggers file which gives a diff of the change. I admi... [01:11:26] cwd so I guess no-one would be around to notice servers being down.... [01:11:29] re: triggers, it's just that even if the update is low risk, it's just a matter of me having some stupid shit in my paste buffer for things to go horribly bad [01:12:02] eileen: you mean cause the holiday? [01:12:05] yeah - I mean that stuff is in git I guess [01:12:10] yeah that holiday [01:12:17] yeah true [01:12:54] yep it's in git and theoretically we could rebuild the triggers if something was off, unless i have "drop database drupal" in my paste buffer for some reason [01:15:47] that would be a bad thing.... [01:16:11] heh yeah and i will do my best not to [01:16:19] just to say any change to the master db is potentially scary [01:16:27] yeah [01:17:10] The stall was always that the automated process didn’t work for us due to permissions [01:17:36] ah right this is usually something that could be done with drush? [01:20:46] cwd yep [01:21:03] eileen: what is the permissions problem exactly? [01:21:03] basically we do the drush part to generate the triggers [01:21:10] we don’t have ‘SUPER’ [01:21:23] which is needed to create triggers when replication exists [01:28:12] ah ok, well maybe we can hack something [01:33:48] eileen: ok, new triggers are live, can you confirm? [01:34:11] cwd ok looking [01:35:15] cwd - yep that worked [01:36:15] \o/ [04:34:56] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: See if we can improve save time for our top donors - https://phabricator.wikimedia.org/T208816 (Eileenmcnaughton) [04:36:07] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: See if we can improve save time for our top donors - https://phabricator.wikimedia.org/T208816 (Eileenmcnaughton) @LeanneS I deployed a fix today that should make a notice... [13:28:40] Jeff_Green, is tomorrow and friday classed as US wmf holidays? [13:28:57] jgleeson: yes [13:29:02] thanks [13:29:05] np [14:25:05] Fundraising-Backlog, fundraising-tech-ops: renew civicrm certificate - https://phabricator.wikimedia.org/T210017 (MNoorWMF) Found it! Sorry I missed it, it's been a hectic few months. I am stateside currently. Should I share my mobile number in IRC or email? [14:33:36] Wikimedia-Fundraising, Mobile-Content-Service, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Reading-Infrastructure-Team-Backlog (Kanban): Run English 2018 fundraising on apps - https://phabricator.wikimedia.org/T209801 (jrobell) Thank you @JoeWalsh for these clarifications. Just... [15:41:34] Wikimedia-Fundraising, Mobile-Content-Service, Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog, Reading-Infrastructure-Team-Backlog (Kanban): Run English 2018 fundraising on apps - https://phabricator.wikimedia.org/T209801 (JoeWalsh) @jrobell for iOS the user sees the banner at the t... [15:54:03] Fundraising-Backlog, fundraising-tech-ops: renew civicrm certificate - https://phabricator.wikimedia.org/T210017 (cwdent) @MNoorWMF I use what is listed on: https://collab.wikimedia.org/wiki/Fundraising#Contact_List Is that current? If not you should be able to update that wiki. [16:27:45] Kai_WMDE: you about sir? [16:29:19] howdy fr-tech :) [16:29:27] hi jgleeson ~ [16:29:29] ! [16:30:10] hey ejegg [16:30:31] having some luck with that phpunit test? [16:30:40] who's the best person to speak to to check if I have CN admin rights? [16:31:03] jgleeson: you can check on https://meta.wikimedia.org/wiki/Special:UserRights [16:31:55] jgleeson: I am almost certain that you do not :) [16:32:15] good good, I just wanted to make sure in the event I need to update anything [16:32:20] thanks Seddon ejegg [16:32:27] jgleeson: If you need them. Step 1) Enable 2FA on your account [16:32:38] wikitech account [16:32:39] ? [16:32:54] whatever account you access metawiki with [16:33:19] probably your central auth (cross-wiki) JGleeson (WMF) account [16:33:57] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/475112 [16:35:02] Wikimedia-Fundraising, Android-app-feature-Feeds, Mobile-Content-Service, Wikipedia-Android-App-Backlog, and 4 others: 2018 English campaign fundraising on apps - https://phabricator.wikimedia.org/T204821 (bearND) App devs/QA, please test the announcements. You'll have to ignore the date and may... [16:39:20] Seddon: yes, i'm here [16:41:22] cool thanks, I don't need access but wanted to confirm whether or not I had it not. Looks like my JGleeson (WMF) account isn't in any groups so that's fine [16:42:12] ejegg, re the tests, no not ironed that out yet. I did update the spec method but still complaining about a missing ID, I wonder if I need to clear some civi cache? [16:42:53] jgleeson: is it the $paymentTokenRecord that you get back from the API call? [16:43:05] That one didn't seem to have any 'id' property at the top level [16:43:24] (and by property I mean array key) [16:44:10] will rerun a debug session now and check [16:48:25] uggg, dash dependencies are all out of sync [16:48:56] trying to check in minified scripts and it's telling me i'm downgrading bootstrap from 3.3.7 to 3.2.0 [16:49:31] and I can't see any commit that actually upgraded to 3.3.7 [16:49:35] hrmph [16:50:09] also, bower itself is deprecated at this point [16:52:33] js in 2018 [16:52:37] * cwd shudders [16:52:43] blargh [16:52:49] :S [16:54:45] s/deprecated/shut down. OK then. [16:54:59] * ejegg downloads zip files like a cave man [17:06:20] (CR) AndyRussG: [V: 2 C: 2] Protect banner components in MW NS [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/475002 (https://phabricator.wikimedia.org/T208110) (owner: AndyRussG) [17:14:38] (Merged) jenkins-bot: Protect banner components in MW NS [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/475002 (https://phabricator.wikimedia.org/T208110) (owner: AndyRussG) [17:21:16] (CR) jenkins-bot: Protect banner components in MW NS [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/475002 (https://phabricator.wikimedia.org/T208110) (owner: AndyRussG) [17:40:12] Fundraising-Backlog, fundraising-tech-ops: renew civicrm certificate - https://phabricator.wikimedia.org/T210017 (MNoorWMF) yup that's current! the US number is perfect to send the SMS to. also, if you have the instructions for how to get that set up - I saved it in my bookmarks but can't seem to find it... [17:43:19] fr-tech, did the grafana admin urls change? I'm trying to hit https://grafana-admin.wikimedia.org/ and it's showing doesn't exist errors [17:58:44] good question, I haven't used it since about this time last year, spelunking SRE email [18:01:17] https://phabricator.wikimedia.org/T170150 [18:01:51] it looks like they did away with the separate grafana-admin@ after figuring out how to use ldap directly [18:02:03] jgleeson: ^^ [18:02:53] ah yep [18:10:51] thanks! [18:12:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Consider not displaying protection log entries in RecentChanges caused by CentralNotice actions - https://phabricator.wikimedia.org/T210101 (AndyRussG) [18:12:41] dstrine: Seddon: https://phabricator.wikimedia.org/T210101 [18:13:54] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: Right 'banner-protect' is missing i18n descriptions - https://phabricator.wikimedia.org/T209763 (MarcoAurelio) Pardon my ignorance but the more I look at the right banner-protect, the less I understand it. Banner codes hosted in the Media... [18:13:55] AndyRussG: thanks for noting that. that also probably can't get worked on for a little bit. [18:14:13] gotta keep things stable for thenext few weeks [18:17:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Consider not displaying protection log entries in RecentChanges caused by CentralNotice actions - https://phabricator.wikimedia.org/T210101 (MarcoAurelio) For clarity I am talking about this kind of entries: (Protection log); 17:32 . . Tim Eulit... [18:22:17] dstrine: got it... Yeah just thought it was worth noting :) [18:23:57] Fundraising-Backlog, fundraising-tech-ops: renew civicrm certificate - https://phabricator.wikimedia.org/T210017 (cwdent) @MNoorWMF ok, pw is sent, instructions are here: https://collab.wikimedia.org/wiki/Fundraising/Engineering/SSL_Client_Authentication Let me know how it goes [18:24:18] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: Make protection reason localizable, display on wiki content language - https://phabricator.wikimedia.org/T210102 (MarcoAurelio) [18:27:56] relocating... [18:28:42] (PS1) MarcoAurelio: WIP: Banner: make protection reason localisable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/475126 [18:33:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: Make protection reason localizable, display on wiki content language - https://phabricator.wikimedia.org/T210102 (Jseddon) Given that the protection reasons would only ever appear on meta wouldn't user language be better? [18:37:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: Make protection reason localizable, display on wiki content language - https://phabricator.wikimedia.org/T210102 (MarcoAurelio) Given that "Autoprotected by..." is displayed as the plain text reason in the Special:Log/protect log, using u... [18:38:23] (PS2) MarcoAurelio: WIP: Banner: make protection reason localisable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/475126 [18:39:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: Make protection reason localizable, display on wiki content language - https://phabricator.wikimedia.org/T210102 (MarcoAurelio) I'm attempting to do this at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/475126/... [19:08:39] (PS1) Ejegg: Update bootstrap to 3.3.7 (to match prod) [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/475132 [19:12:32] Fundraising-Backlog, fundraising-tech-ops: SSL cert - https://phabricator.wikimedia.org/T210032 (DStrine) a:cwdent [19:13:05] Fundraising-Backlog, fundraising-tech-ops: Need updated CiviCRM cert for new computer - https://phabricator.wikimedia.org/T210021 (DStrine) a:cwdent [19:17:06] (CR) Ejegg: [C: 2] Update bootstrap to 3.3.7 (to match prod) [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/475132 (owner: Ejegg) [19:20:29] (CR) Ejegg: [V: 2 C: 2] Update bootstrap to 3.3.7 (to match prod) [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/475132 (owner: Ejegg) [19:21:29] (PS2) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/475112 [19:22:55] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/475112 (owner: Ejegg) [19:24:25] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/475112 (owner: Ejegg) [19:25:20] Wikimedia-Fundraising-Banners, donate.wikimedia.org: Try adding inline errors instead of alerts for missing amount/opt-in - https://phabricator.wikimedia.org/T205701 (Pcoombe) We now have this for amount, payment method and email opt-in across all our banners: [example](https://en.wikipedia.org/wiki/NASA... [19:28:19] mepps: are you online today? not sure if there's much we need to cover for the mid-sprint checkin this time around [19:35:00] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: Make protection reason localizable, display on wiki content language - https://phabricator.wikimedia.org/T210102 (DStrine) [19:35:11] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: Right 'banner-protect' is missing i18n descriptions - https://phabricator.wikimedia.org/T209763 (DStrine) [19:38:16] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Consider not displaying protection log entries in RecentChanges caused by CentralNotice actions - https://phabricator.wikimedia.org/T210101 (DStrine) [19:43:16] !log updated fundraising internal dashboard from b01458b260 to 5e9fb9a3ef [19:43:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:47:32] (PS3) MarcoAurelio: Make autoprotection log reason localisable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/475126 (https://phabricator.wikimedia.org/T210102) [20:14:04] Fundraising-Backlog, fundraising-tech-ops: renew civicrm certificate - https://phabricator.wikimedia.org/T210017 (MNoorWMF) all works now, thank you! [20:29:53] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Consider not displaying protection log entries in RecentChanges caused by CentralNotice actions - https://phabricator.wikimedia.org/T210101 (Ejegg) Hi @MarcoAurelio! This might be a lot le... [20:32:52] fr-tech any suggestions for -talk? [20:34:28] ejegg: nothing I can think of right now [20:34:33] want to talk through any particular ticket for the sprint? [20:34:47] I need to look at your query index hint - but that just needs me to test it [20:39:24] (CR) Eileen: [C: 2] "yep agree - I got the same speed boost" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/474998 (owner: Ejegg) [20:39:57] ejegg: I lost you [20:40:59] (Merged) jenkins-bot: Index hint for fraud % query [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/474998 (owner: Ejegg) [21:31:59] Fundraising-Backlog, fundraising-tech-ops: renew civicrm certificate - https://phabricator.wikimedia.org/T210017 (cwdent) Open>Resolved a:cwdent [21:33:43] (PS1) Ejegg: Simple override to force redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/475221 (https://phabricator.wikimedia.org/T209413) [21:36:24] (CR) jerkins-bot: [V: -1] Simple override to force redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/475221 (https://phabricator.wikimedia.org/T209413) (owner: Ejegg) [21:39:00] (PS2) Ejegg: Simple override to force redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/475221 (https://phabricator.wikimedia.org/T209413) [21:50:13] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/475163 (owner: L10n-bot) [23:27:47] (PS1) Ejegg: variant config for full redirect [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/475244 [23:28:05] (PS10) Jgleeson: Add payment_token fields to forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/471907 (https://phabricator.wikimedia.org/T206540) (owner: Eileen) [23:32:55] (PS11) Jgleeson: Add payment_token fields to forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/471907 (https://phabricator.wikimedia.org/T206540) (owner: Eileen) [23:37:45] (PS1) Ejegg: Exclude 'Endowment Gift' financial type [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/475248 [23:38:22] jgleeson: get some sleep :) [23:38:41] also, sorry if you were planning to do the ingenico redirect variant work [23:38:57] I totally forgot you had claimed that one and started in on it [23:39:21] ah no problem, I was lagging behind anyway so good of you to jump on it :) [23:39:45] just writing my end of day, I was determined to fix the broken tests [23:40:10] it was littered with bugs... but looking better now [23:44:47] nice! I'll take a look first thing monday [23:44:51] have a good one [23:50:39] you too [23:59:28] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, FR-Ingenico, Patch-For-Review: Make an ingenicio variant with separate page instead of iframe - https://phabricator.wikimedia.org/T209413 (jgleeson) a:jgleeson>Ejegg