[00:08:53] Fundraising-Backlog, fundraising-tech-ops: Need updated CiviCRM cert for new computer - https://phabricator.wikimedia.org/T210021 (CCogdill_WMF) Phew, so I deleted and reinstalled the certificate. I reopened Chrome and went to dash, and if I clicked "Always allow" (not just "Allow") then I was able to ge... [00:09:21] Fundraising-Backlog, fundraising-tech-ops: Need updated CiviCRM cert for new computer - https://phabricator.wikimedia.org/T210021 (CCogdill_WMF) Open>Resolved [00:14:50] (PS5) Eileen: Thank you updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/476199 (https://phabricator.wikimedia.org/T209895) [00:35:49] (PS6) Eileen: Thank you updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/476199 (https://phabricator.wikimedia.org/T209895) [00:43:14] (PS7) Eileen: Thank you updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/476199 (https://phabricator.wikimedia.org/T209895) [00:56:37] (PS1) Ejegg: Send AU & NZ donors to old GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476436 [00:56:52] fr-tech here's one to just send AU & NZ donors to the old API ^^^ [00:56:58] XenoRyet: ^^^ [00:58:30] well, it lints [00:59:40] looks like he's gone... [00:59:42] self-merging [00:59:50] (CR) Ejegg: [C: 2] Send AU & NZ donors to old GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476436 (owner: Ejegg) [01:05:26] Fundraising-Backlog, fundraising-tech-ops: Renew jsamra's SSL cert - https://phabricator.wikimedia.org/T210536 (cwdent) @Jksamra there are now 2 files in your home directory on frdev1001, jsamra.p12 (the encrypted certificate) and jsamra.pw (the password to decrypt the cert). Let me know if you need a h... [01:14:21] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/476438 [01:14:27] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/476438 (owner: Ejegg) [01:38:58] relocating... [01:44:05] (Merged) jenkins-bot: Send AU & NZ donors to old GlobalCollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476436 (owner: Ejegg) [01:44:07] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/476438 (owner: Ejegg) [01:47:52] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: hand update civi thank you email with current text - https://phabricator.wikimedia.org/T209895 (Eileenmcnaughton) OK - I have a version working on staging & I've taken a s... [02:52:22] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/476441 [02:52:26] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/476441 (owner: Ejegg) [03:15:05] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/476441 (owner: Ejegg) [03:30:07] !log updated payments-wiki from 42283c73d0 to 34250e80b5 [03:30:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:04:15] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/476444 [04:04:24] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/476444 (owner: Ejegg) [04:06:46] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/476444 (owner: Ejegg) [04:08:17] !log updated fundraising internal dashboard from 5e9fb9a3ef to 1e4dd2a9ec [04:08:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:41:37] Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure (Slipway): Migrate wikimedia-fundraising-civicrm to a Docker container - https://phabricator.wikimedia.org/T210287 (greg) p:Triage>Normal [05:18:56] (CR) Eileen: "Jack this basically looks like you've nailed it - I made some comments - none of the things I've commented on are blocking & some are just" (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/471907 (https://phabricator.wikimedia.org/T206540) (owner: Eileen) [05:43:57] (PS1) Eileen: Doh [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/476448 (https://phabricator.wikimedia.org/T207991) [06:01:47] (PS1) Eileen: Add order_id as a filter on fraud reports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/476450 (https://phabricator.wikimedia.org/T199268) [14:34:36] Fundraising Sprint Vestigial tails shoot from the hip, Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review: Is the Peru form working? Nov 13th - https://phabricator.wikimedia.org/T209379 (Pcoombe) Can we reduc... [14:37:18] Fundraising Sprint Vestigial tails shoot from the hip, Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review: Is the Peru form working? Nov 13th - https://phabricator.wikimedia.org/T209379 (MBeat33) p:Unbreak... [14:44:20] Fundraising-Backlog, fundraising-tech-ops: Renew spatton's civicrm SSL cert - https://phabricator.wikimedia.org/T210526 (cwdent) Open>Resolved a:cwdent @spatton cleaning house, re-open if you are still having trouble [14:44:34] Fundraising-Backlog, fundraising-tech-ops: SSL cert - https://phabricator.wikimedia.org/T210032 (cwdent) Open>Resolved @tskaff cleaning house, re-open if you are still having trouble [14:53:46] fundraising-tech-ops: Backup script leaving zombie processes on log server - https://phabricator.wikimedia.org/T208287 (cwdent) Open>Resolved a:cwdent [16:28:45] Fundraising-Backlog, FR-PayPal-ExpressCheckout: PayPal subscription / Civi question - https://phabricator.wikimedia.org/T210746 (MBeat33) [16:29:34] Fundraising-Backlog, FR-PayPal-ExpressCheckout: PayPal subscription / Civi question - https://phabricator.wikimedia.org/T210746 (MBeat33) [16:55:06] Fundraising-Backlog, FR-PayPal-ExpressCheckout: PayPal subscription / Civi question - https://phabricator.wikimedia.org/T210746 (Ejegg) In the IPN logs for XWKN57071ELU in November I see a two recurring_payment_skipped notifications and one recurring_payment_failed. For ERDY25X3X3F3 I also see two _skipp... [16:57:45] Fundraising-Backlog, FR-PayPal-ExpressCheckout: PayPal subscription / Civi question - https://phabricator.wikimedia.org/T210746 (MBeat33) Open>Resolved a:MBeat33 Many thanks, @Ejegg we'll point them to their Paypal account status to see if updating it helps [17:11:14] (PS12) Jgleeson: Add payment_token fields to forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/471907 (https://phabricator.wikimedia.org/T206540) (owner: Eileen) [17:17:41] (CR) Jgleeson: Add payment_token fields to forgetme (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/471907 (https://phabricator.wikimedia.org/T206540) (owner: Eileen) [18:02:06] AndyRussG, I just realised why this hasn't been pushed [18:02:17] this = https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/476004/ [18:02:34] Patch Set 1: [18:02:34] Please verify the information here is correct and the ssh key corresponds to Jack Gleeson [18:44:21] (PS1) Ejegg: Switch GB, IE, US over to legacy Globalcollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476595 [18:44:34] fr-tech anyone care to review that? ^^^ [18:44:47] PPena just gave the all clear to switch over [18:49:19] On it [18:50:01] (CR) XenoRyet: [C: 2] Switch GB, IE, US over to legacy Globalcollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476595 (owner: Ejegg) [18:51:15] (Merged) jenkins-bot: Switch GB, IE, US over to legacy Globalcollect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476595 (owner: Ejegg) [18:57:18] thanks! [18:57:47] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/476597 [18:57:56] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/476597 (owner: Ejegg) [18:58:30] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/476598 [18:58:55] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/476597 (owner: Ejegg) [19:00:40] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/476598 (owner: Ejegg) [19:03:38] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/476598 (owner: Ejegg) [19:05:41] hey, that was nice and speedy! [19:09:30] !log updated payments-wiki from 34250e80b5 to 7403a196b4 [19:09:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:40:30] (CR) Eileen: [C: 2] Add payment_token fields to forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/471907 (https://phabricator.wikimedia.org/T206540) (owner: Eileen) [19:45:48] (Merged) jenkins-bot: Add payment_token fields to forgetme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/471907 (https://phabricator.wikimedia.org/T206540) (owner: Eileen) [20:09:41] XenoRyet: did you want to pick up the last bit of work for T209413? [20:09:42] T209413: Make an ingenicio variant with separate page instead of iframe - https://phabricator.wikimedia.org/T209413 [20:09:56] Yea, I was just digging into that now. [20:10:51] It's just going to be a change in https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/ingenico_gateway/forms/js/ingenico.js [20:11:43] so even if it's not iframe (but the payment method is still cc) [20:11:52] we call the API [20:12:08] and then if it's not iframe, we do a full redirect [20:12:25] or... you could do the change in the backend [20:12:43] so it's a full submit (which is what happens now when isIframe returns false) [20:12:57] and the full submit comes back with a redirect [20:13:12] whichever seems like it makes more sense long term [20:13:23] Yea, I'll see what looks better. [20:33:50] thanks eileen_ ! [21:02:15] jgleeson: well done on your visit to civiland :-) [21:03:35] fundraising-tech-ops: reenable mdadm checkarray on civi1001 after 20181202 - https://phabricator.wikimedia.org/T210786 (Jgreen) [21:06:41] ejegg, you were right about the globalcollect response. It's a raw http response with headers [21:11:31] oooh [21:11:43] Imma logic tomorrow to try and call getFormattedResponse() before that check [21:12:05] I figure that is the least fiddly way to make it work [21:12:16] update the logic* [21:13:21] although that method itself sort of acts like a response type validator [21:14:13] as it fails to complete if the response is not a completely serialised body [21:17:09] hmm it actually returns a DOM Document [21:18:08] so I can't really work with that. it might be a case of removing the new method to deal with that and just testing out if we can put the existing one in its place [21:18:38] and infer from the outcome of getFormattedResponse() whether it's valid or not [21:19:18] pick that up tomorrow. g'night fr-tech [21:28:32] https://usercontent.irccloud-cdn.com/file/w2h1vehu/IMG_1457.PNG [21:28:43] banner looking pretty weird on the dark theme of the iOS app [21:28:59] (hope this is the right place to put this?) [21:39:18] thanks tzatziki ! [21:39:41] spatton / Seddon / pcoombe want to take a look at that? ^^^ [21:39:59] ejegg: it's in phab already, I'm told :D [21:40:03] https://phabricator.wikimedia.org/T210768 [21:40:07] oh, cool [21:40:22] heh, that IS hard to read [21:42:00] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/476646 (owner: L10n-bot) [22:15:33] (PS1) XenoRyet: Ingenico Full Redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476766 [22:16:17] (PS2) XenoRyet: Ingenico Full Redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476766 (https://phabricator.wikimedia.org/T209413) [22:19:28] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, FR-Ingenico, Patch-For-Review: Make an ingenicio variant with separate page instead of iframe - https://phabricator.wikimedia.org/T209413 (XenoRyet) That change does a full redirect when isIframe returns false, but the r... [22:27:01] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, FR-Ingenico, Patch-For-Review: Make an ingenicio variant with separate page instead of iframe - https://phabricator.wikimedia.org/T209413 (XenoRyet) I'll look into making it possible to select different ingenico-side var... [22:27:50] (CR) Ejegg: [C: -1] "I think we need a check for card payment too" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476766 (https://phabricator.wikimedia.org/T209413) (owner: XenoRyet) [23:07:42] (CR) XenoRyet: Ingenico Full Redirect (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476766 (https://phabricator.wikimedia.org/T209413) (owner: XenoRyet) [23:08:10] (PS3) XenoRyet: Ingenico Full Redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476766 (https://phabricator.wikimedia.org/T209413) [23:08:36] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, FR-Ingenico, Patch-For-Review: Make an ingenicio variant with separate page instead of iframe - https://phabricator.wikimedia.org/T209413 (XenoRyet) a:Ejegg>XenoRyet