[00:07:36] (PS1) Ejegg: Add fallback from Kabyle to Arabic for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476786 [16:42:52] (CR) Ejegg: [C: 2] Doh [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/476448 (https://phabricator.wikimedia.org/T207991) (owner: Eileen) [16:43:01] (PS2) Ejegg: Doh [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/476448 (https://phabricator.wikimedia.org/T207991) (owner: Eileen) [17:03:24] (PS2) Ejegg: Add order_id as a filter on fraud reports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/476450 (https://phabricator.wikimedia.org/T199268) (owner: Eileen) [17:03:31] (CR) Ejegg: [C: 2] Add order_id as a filter on fraud reports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/476450 (https://phabricator.wikimedia.org/T199268) (owner: Eileen) [17:08:19] (CR) jerkins-bot: [V: -1] Add order_id as a filter on fraud reports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/476450 (https://phabricator.wikimedia.org/T199268) (owner: Eileen) [17:16:59] (CR) Ejegg: [C: 2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/476450 (https://phabricator.wikimedia.org/T199268) (owner: Eileen) [17:21:53] (Merged) jenkins-bot: Add order_id as a filter on fraud reports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/476450 (https://phabricator.wikimedia.org/T199268) (owner: Eileen) [17:49:47] (PS2) Ejegg: Allow overriding form settings in LocalSettings.php [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476418 [18:00:25] Fundraising Sprint Vestigial tails shoot from the hip, Fundraising-Backlog, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review: Is the Peru form working? Nov 13th - https://phabricator.wikimedia.org/T209379 (DStrine) [18:15:28] hey there chan. Jonathan from Research. Couldn't find any indication in listserves or blogposts of how long this fundraising banner campaign is intended (estimated) to last. Anyone have an answer or best guess? [18:16:16] ^ cwd and Jeff_Green perhaps? [18:16:28] j-mo: heya [18:16:33] o/ [18:16:52] pcoombe probably has a pretty good answer [18:17:17] j-mo: things will tick along to christmas with a bit a smaller period potentially focused on endowment between christmas and new year [18:17:45] j-mo: We wont be running at full whack for that whole period though [18:18:54] good to know. I'd like to run a quicksurvey before Christmas, but am concerned that doing that on the same page as a FR banner will be CTA overload and defeat both purposes. Survey only needs to run for 2 days. Any possibility of having advance notice if such a window opens up? [18:18:59] ^Seddon [18:21:07] j-mo: I'll let you know. Would this be on english wikipedia? [18:38:46] Seddon correct, EnWiki only. [19:50:51] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Bizarre result for 20000000 : PARAMETER PAYMENTPRODUCTID NOT FOUND IN REQUEST - https://phabricator.wikimedia.org/T210875 (Ejegg) [19:51:16] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Bizarre result for 20000000 : PARAMETER PAYMENTPRODUCTID NOT FOUND IN REQUEST - https://phabricator.wikimedia.org/T210875 (Ejegg) [20:18:23] XenoRyet: hmm, I can't get the full redirect variant working quite. I think the alwaysRedirect script doesn't necessarily load before the ingenico script [20:18:30] how were you making it work locally? [20:22:23] oh wait, it's loading the ingenico.js from the globalcollect dir! [20:23:13] ah, got it [20:25:00] (PS2) Ejegg: variant config for full redirect [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/475244 [20:27:04] (CR) Ejegg: [C: -1] "This doesn't work - that fn is running on form setup, so 'result' is undefined" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476766 (https://phabricator.wikimedia.org/T209413) (owner: XenoRyet) [20:27:38] XenoRyet: think we need a different way to test for method card [20:28:23] 10-4. O [20:28:34] I'll see if I can figure something else out. [20:28:57] XenoRyet: I updated my variant config too, in case you want to test how the whole thing comes together [20:29:12] cherry pick https://gerrit.wikimedia.org/r/475244 in the mediawiki directory [20:29:12] Yea, that'll be helpful [20:29:41] and then you'll need https://gerrit.wikimedia.org/r/475221 in the donationInterface directory [20:29:52] I'm still not sure that ordering is robust [21:51:21] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476942 (owner: L10n-bot) [21:54:02] (CR) Raimond Spekking: [C: 2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476942 (owner: L10n-bot) [21:59:46] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/476937 (owner: L10n-bot) [22:11:50] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect hosted checkouts - using broken URL? - https://phabricator.wikimedia.org/T210893 (Ejegg) [22:13:25] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: Ingenico Connect hosted checkouts - using broken URL? - https://phabricator.wikimedia.org/T210893 (DStrine) [22:29:49] hey ejegg, would it be much work to add a test or take an existing and test and modify to demonstrate the new behaviour in this patch? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/476418/ [22:30:11] -and [22:30:39] jgleeson_: hmm, actually that might be tricky [22:31:01] since the tests set their own settings at a different time than the LocalSetting is sourced [22:31:17] ah [22:32:01] what about a setting in isolation [22:32:02] I don't /think/ the whole extension setup is repeated each test, but let me check [22:32:07] so that the merge is confirmed at least [22:34:23] ah right, our tests ARE able to override those form settings in their setup, so they must fire after the extension load is already completed [22:35:01] While things set in LocalSettings take effect before the onRegistration hook fires [22:48:43] (PS1) Ejegg: Log an error on too-short Ingenico iframe url [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476984 (https://phabricator.wikimedia.org/T210893) [22:51:32] jgleeson_: so that code gets called during test bootstrapping [22:52:02] Hmm, maybe another bootstrap file would be able to get in before it? [22:52:15] we'd have to modify the core phpunit suite though [22:53:34] :/ [22:53:42] sounds like a lot of work [22:54:02] kinda :P [22:54:15] I was just stepping through GatewayFormChooser to see it in action [22:54:30] argh, that logic needs some paring down [22:54:32] I haven't digged into this one before [22:54:55] or dug [22:55:00] The longer term plan is to get rid of the separate formSettings file for most everything [22:55:17] since most of that info is duplicated in the individual gateway config files [22:55:31] (as to which methods are available, which countries are supported, etc) [22:56:01] ok makes sense to me [22:56:05] So the chooser should be able to gather all that from the gateways [22:56:24] and we'd just put some simple overrides in the localsettings [22:57:04] the existing settings are still optimized for the system that used a different HTML file to show each different set of card options [22:57:18] gonna head out for a bit, but I'll check in again later! [22:57:24] I'll +2 it and just spend a bit more time in general familiarising myself with this part of the extension. [22:57:33] thanks! [22:57:33] next week [22:57:37] have a good weekend! [22:57:41] have a good weekend! [22:58:03] (CR) Jgleeson: [C: 2] Allow overriding form settings in LocalSettings.php [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476418 (owner: Ejegg) [23:13:46] (Merged) jenkins-bot: Allow overriding form settings in LocalSettings.php [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476418 (owner: Ejegg)