[00:29:49] (CR) XenoRyet: "I can't seem to get this to work for me. isIframe is still returning true." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/475221 (https://phabricator.wikimedia.org/T209413) (owner: Ejegg) [14:26:04] Wikimedia-Fundraising-Banners: Mobile banner nag shows up when editing - https://phabricator.wikimedia.org/T211332 (schoenbaechler) Thanks @Pcoombe, just updated control with that fix. @iamjessklein: Please check if it still occurs here: https://en.m.wikipedia.org/wiki/Tristan_Harris?banner=B1819_0701_mlW... [16:34:19] Fundraising-Backlog, fundraising-tech-ops: Give jsamra access to /srv/br on frdev1001 - https://phabricator.wikimedia.org/T211435 (Pcoombe) [16:43:30] ejegg: any reason why a lot of USD traffic would route through Adyen past 24 hours? Endowment email maybe? [16:51:28] ah, looks like they are Endowment [17:04:21] aha, I guess they have the gateway in the link? [17:11:35] (PS1) Jgleeson: Handle invalid GC SET_PAYMENT response and fix some xml formatting issues in stub responses. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/478229 (https://phabricator.wikimedia.org/T203126) [17:15:30] (CR) jerkins-bot: [V: -1] Handle invalid GC SET_PAYMENT response and fix some xml formatting issues in stub responses. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/478229 (https://phabricator.wikimedia.org/T203126) (owner: Jgleeson) [17:28:54] (PS2) Jgleeson: Handle invalid GC SET_PAYMENT response and fix some xml formatting issues in stub responses. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/478229 (https://phabricator.wikimedia.org/T203126) [17:30:12] (CR) jerkins-bot: [V: -1] Handle invalid GC SET_PAYMENT response and fix some xml formatting issues in stub responses. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/478229 (https://phabricator.wikimedia.org/T203126) (owner: Jgleeson) [18:23:53] new bluejeans is pretty cool [18:24:05] hangoutjeans [18:40:59] (CR) XenoRyet: [C: 1] "Code looks good. Apparently my local civi is borked in a way that didn't let me test locally though. If someone wants to do that for the" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/478043 (https://phabricator.wikimedia.org/T211230) (owner: Ejegg) [20:08:58] (PS2) Umherirrender: Add method scope visibility [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/471085 [20:37:10] (PS1) Ejegg: Don't re-protect banner if it's already protected [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/478257 (https://phabricator.wikimedia.org/T210983) [20:39:23] (CR) jerkins-bot: [V: -1] Don't re-protect banner if it's already protected [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/478257 (https://phabricator.wikimedia.org/T210983) (owner: Ejegg) [20:42:12] (CR) jerkins-bot: [V: -1] Don't re-protect banner if it's already protected [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/478257 (https://phabricator.wikimedia.org/T210983) (owner: Ejegg) [20:42:30] ejegg, XenoRyet is this the patch https://gerrit.wikimedia.org/r/#/c/478043/ [20:42:47] (PS2) Ejegg: Don't re-protect banner if it's already protected [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/478257 (https://phabricator.wikimedia.org/T210983) [20:42:57] jgleeson: Yea, that's the one. [20:43:09] ah I seen you had some issues with vagrant [20:43:22] civi* [20:43:35] was it related to mailserver problems [20:43:43] sendmail/postfix [20:44:08] I think i ran into something like that the last time I was trying to review a thank_you page related patch [20:45:05] Yea, something like that. I'll sort it out later, my vagrant is in a little bit of a weird state right now anyway, but it's mostly working for DI stuff. [20:47:24] jgleeson: yep! [20:47:50] XenoRyet: want to troubleshoot live? [20:49:43] Na, I'll don't want to get into that just now, looking at some other stuff around the ingenico redirect first. [20:49:59] Since DI is working fine I don't want to poke the bear. [20:50:33] hopefully if I fix it for mine, it will patch XenoRyet's issue too [20:51:03] ejegg, I'll give the patch a whirl and if I run into issues we can jump on a call if that works! [20:51:19] thanks jgleeson ! [20:51:41] I'm pretty sure the lack of sendmail or something like that tripped me up last time [20:51:43] so, we should test both an Endowment Gift type and any other type [20:57:26] ejegg, how do I simulate an endowment donation? [20:57:40] Fundraising-Backlog: Changing Bitpay Logo - https://phabricator.wikimedia.org/T211452 (Ppena) [20:58:02] jgleeson: if you're using the test form there should be a new 'financial type' dropdown [20:58:03] ahh I see an ImportTestMessage [20:58:40] for a donation in the db, set the financial_type_id in the civicrm_contribution table to the corresponding id from civicrm_financial_type [20:59:37] hmm [20:59:54] so I'm best putting through a new local test donation [21:00:07] running qc [21:00:13] and then modifying the donation? [21:00:28] yep, that would work [21:00:51] or if you set the utm_medium to 'endowment' in the message you're importing [21:01:00] it'll set the financial_type_id for you [21:01:53] cool, I'll give that a go [21:04:08] (PS4) Umherirrender: Add method scope visibility [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472695 [21:05:22] AndyRussG: ooh, that one looks good to have ^^^ [21:05:26] I'll take a look [21:08:36] hmm, it does make a few things private, so not entirely trivial [21:09:08] did we remove globalcollect_audit [21:09:20] when trying to upgrade civi I'm seeing: [21:09:26] User warning: The following module is missing from the file system: globalcollect_audit. For information about how to fix this, see the documentation page. in _drupal_trigger_error_with_delayed_logging() (line 1143 of /vagrant/srv/org.wikimedia.civicrm/drupal/includes/bootstrap.inc). [21:09:51] but in `drush pmi-list` I don't see it to enable [21:10:02] jgleeson: oh shoot, yeah, it's been gone for a while [21:10:08] `drush pm-list`* [21:10:20] let's see, I think you can just delete the row in drupal.system [21:10:28] where name='globalcollect_audit' [21:10:29] ah... I wonder why I missed it [21:14:49] Fundraising-Backlog: Changing Bitpay Logo - https://phabricator.wikimedia.org/T211452 (DStrine) a:Pcoombe [21:15:44] Fundraising-Backlog: Changing Bitpay Logo - https://phabricator.wikimedia.org/T211452 (DStrine) Banner team makes a lot of these changes. I'm looping in @Pcoombe [21:26:08] (PS5) Ejegg: Add method scope visibility [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472695 (owner: Umherirrender) [21:26:55] (CR) Ejegg: [C: 2] "Thanks, Umherirrender!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472695 (owner: Umherirrender) [21:28:07] (PS3) Ejegg: Don't re-protect banner if it's already protected [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/478257 (https://phabricator.wikimedia.org/T210983) [21:31:11] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/478298 (owner: L10n-bot) [21:32:35] (CR) jerkins-bot: [V: -1] Add method scope visibility [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472695 (owner: Umherirrender) [21:35:06] (PS1) Ejegg: PHP 7.3 fix, merged upstream [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/478346 [21:37:52] cstone: how goes the setup? [21:47:21] good! vagrant is running with no errors [21:49:08] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: GatewayFormChooser should geolocate when country is not in URL - https://phabricator.wikimedia.org/T211454 (Ejegg) [21:50:27] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: GatewayFormChooser should geolocate when country is not in URL - https://phabricator.wikimedia.org/T211454 (Ejegg) @CCogdill_WMF This is why the links to the form chooser weren't working as expected and sent some USD donors to Adyen. [21:53:56] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: GatewayFormChooser should geolocate when country is not in URL - https://phabricator.wikimedia.org/T211454 (CCogdill_WMF) Ah cool. We prefer to not force country in emails, so this fix sounds great. [21:54:00] ejegg, so I'm seeing the thank you email [21:54:12] but I'm looking at it in the console and not html [21:54:25] jgleeson: ok, cool [21:54:39] you get the expected text for endowment / not endowment? [21:55:58] oops, library is closing, will head to a nearby cafe [22:03:44] (CR) Umherirrender: [C: 2] "Resubmit - T208570" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472695 (owner: Umherirrender) [22:09:44] (CR) jerkins-bot: [V: -1] Add method scope visibility [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472695 (owner: Umherirrender) [22:10:29] (CR) Umherirrender: [C: 2] "resubmit" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472695 (owner: Umherirrender) [22:16:07] (Merged) jenkins-bot: Add method scope visibility [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472695 (owner: Umherirrender) [22:18:22] all good ejegg! [22:18:33] jgleeson: great! [22:18:51] I see the endowment text and when setting the from name, I see the from name changing [22:19:03] also still working for normal donations, reverts back to katherine [22:19:08] and the tests are passing for me [22:19:22] ok, cool, it's working for two of us! [22:19:42] I kinda wish I could see the full html email in all its glory [22:19:56] I'll shut off the TY mailer for deploy and send a couple test TY mails to fr-tech@ [22:20:11] I wonder if I can point a mail client at my vagrant local mailqueue [22:20:25] hmm, that'd be a feat [22:20:29] hmm I could also just extract the html and save it locally i guess [22:21:08] it gets encoded kinda funny for emails I think [22:22:00] ah, I'll +2 and then have a play [22:22:08] thanks! [22:24:48] (CR) Jgleeson: [V: 2 C: 2] "Looks good to me. I see the new endowment text and footer when importing a donation passed with utm_medium=endowment. I can see the sender" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/478043 (https://phabricator.wikimedia.org/T211230) (owner: Ejegg) [22:27:41] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/478360 [22:27:56] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/478360 (owner: Ejegg) [22:28:57] (Merged) jenkins-bot: Send custom TY mails for Endowment Gift [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/478043 (https://phabricator.wikimedia.org/T211230) (owner: Ejegg) [22:28:59] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/478360 (owner: Ejegg) [22:29:54] !log Turned off Thank You mailing job for letter update [22:29:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:31:25] !log updated fundraising CiviCRM from 3e5d74f17e to 8e18485697 [22:31:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:31:32] ok, let's take a look... [22:36:12] (CR) jenkins-bot: Add method scope visibility [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472695 (owner: Umherirrender) [22:36:50] looks good to me ejegg [22:37:56] yep yep, no typos detected as far as I can tell [22:40:57] ok, gonna turn it on really slow [22:41:04] and look at the civimail records [22:41:47] XenoRyet|food, this blog post has a list of mail utilities that we can use to inspect local Drupal generated mail on the vagrant box. It's only in plain text, but it's good enough to see the contents of what gets sent https://www.jeffgeerling.com/blogs/jeff-geerling/viewing-email-linux-using [22:43:24] !log re-enabled Thank You mail sender [22:43:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:47:17] ok, those are still looking good [22:47:44] turning the rate back up [22:48:19] ah dang, failmail? [22:48:29] ...unrelated to the TY update [22:48:52] more of that weird empty POST :P [22:49:31] ok, we're back at 700 max per run [22:53:13] :) [22:53:28] I'm looking at this - https://mailcatcher.me/ [22:53:39] might be something we can use on vagrant to inspect our dev mail [22:57:18] hehe - serves it through a dream ? [22:58:41] nice, does look handy! [22:59:30] wondering how it works with phpmailer - that 'using mailcatcher with PHP' link is dead :( [23:00:29] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, Patch-For-Review: Send Endowment receipts through regular thank you email system - https://phabricator.wikimedia.org/T211230 (Ejegg) @CCogdill_WMF, @MNoorWMF, @kaythaney this was deployed at 2018-12-05 22:31 UTC. Any endowm... [23:01:05] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog, Patch-For-Review: Send Endowment receipts through regular thank you email system - https://phabricator.wikimedia.org/T211230 (Ejegg) Oops, wrong date - that should have been 2018-12-07 22:31 UTC [23:03:23] i was hoping I could wire it in at postfix level [23:03:29] to avoid backend specific setup [23:03:50] could then be a general vagrant role [23:03:55] maybe [23:08:14] ah, right on [23:40:39] (PS1) Ejegg: Restore country validation for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/478364 (https://phabricator.wikimedia.org/T211358) [23:41:43] (CR) Jgleeson: [C: 2] Restore country validation for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/478364 (https://phabricator.wikimedia.org/T211358) (owner: Ejegg) [23:42:52] (Merged) jenkins-bot: Restore country validation for Ingenico Connect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/478364 (https://phabricator.wikimedia.org/T211358) (owner: Ejegg) [23:44:03] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/478366 [23:45:46] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/478367 [23:45:58] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/478366 (owner: Ejegg) [23:47:14] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/478366 (owner: Ejegg) [23:48:16] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/478367 (owner: Ejegg) [23:50:24] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/478367 (owner: Ejegg) [23:50:48] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/478367 (owner: Ejegg) [23:51:15] (CR) Ejegg: [V: 2 C: 2] "whoops, that was weird" [core] (fundraising/REL1_27) - https://gerrit.wikimedia.org/r/478367 (owner: Ejegg) [23:54:32] !log updated payments-wiki from b99cd0816e to b8acb95a2a [23:54:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log