[00:19:07] <ejegg>	 OK, things are still looking good with TY mails and ingenico country validation
[00:19:16] <ejegg>	 gonna sign off for the night
[00:20:09] <wikibugs>	 (CR) Ejegg: [C: -1] "Just a couple style issues. Mostly looks good otherwise!" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/476766 (https://phabricator.wikimedia.org/T209413) (owner: XenoRyet)
[00:21:09] <ejegg>	 XenoRyet: what do you think about redefining the submit fn in all cases, and only calling isIframe on submit? That would get around the load order issue for at least that one gateway
[00:21:45] <ejegg>	 anyway, gonna take off for now
[00:28:31] <wikibugs>	 (CR) Krinkle: [C: 2] Remove obsolete aliases from closures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472167 (https://phabricator.wikimedia.org/T208951) (owner: Esanders)
[00:32:59] <wikibugs>	 (CR) jerkins-bot: [V: -1] Remove obsolete aliases from closures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472167 (https://phabricator.wikimedia.org/T208951) (owner: Esanders)
[09:13:21] <wikibugs>	 (CR) Umherirrender: [C: 2] "Resubmit - T208570" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472167 (https://phabricator.wikimedia.org/T208951) (owner: Esanders)
[09:18:18] <wikibugs>	 (Merged) jenkins-bot: Remove obsolete aliases from closures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472167 (https://phabricator.wikimedia.org/T208951) (owner: Esanders)
[09:24:09] <wikibugs>	 (CR) jenkins-bot: Remove obsolete aliases from closures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/472167 (https://phabricator.wikimedia.org/T208951) (owner: Esanders)
[14:31:31] <Hauskatze>	 hi
[14:31:52] <Hauskatze>	 Seddon: you around by chance?
[14:32:16] <Seddon>	 Hauskatze: here
[14:32:28] <Hauskatze>	 Thank the Lord you're here
[14:32:43] <Hauskatze>	 how's https://aa.wikibooks.org/wiki/Main_Page looking to you?
[14:33:08] <Hauskatze>	 I was thinking on maybe adding a little disclaimer below the text
[14:33:11] <Hauskatze>	 Something like:
[14:33:20] <Hauskatze>	 <div style="font-size: smaller">Organized by <a href="https://meta.wikimedia.org/wiki/Wikimedistas_de_Colombia">Wikimedistas de Colombia User Group</a>.</div>
[14:33:31] <Hauskatze>	 but I've failed each and every time
[14:33:37] <Seddon>	 Hauskatze: do I need to be logged in?
[14:33:37] <Hauskatze>	 maybe it is not even necessary
[14:33:53] <Hauskatze>	 Seddon: for the test campaign it should be visible for anon. too
[14:34:23] <Hauskatze>	 it displays okay to me but I'd prefer the expert review ;)
[14:34:42] <Hauskatze>	 + the _mobile banner, that I don't know where to pick it from
[14:34:46] <Seddon>	 Gimme 5 minutes and I'll get to my desktop and take a gander
[14:35:10] <Hauskatze>	 Sure, take all the time you need
[14:35:36] <Hauskatze>	 currently the banner is running in the 'test' campaign, only for aa.wikibooks
[14:35:41] <Hauskatze>	 for debugging, etc
[14:54:16] <Hauskatze>	 I've created a _mobile campaign as well and I'm testing it now
[15:01:57] <Hauskatze>	 mobile showing good BUY {{{WMCO_Wikivacaciones2018,text2}}} doesn't work
[15:02:04] <Hauskatze>	 text1 does though
[15:02:06] <Hauskatze>	 :/
[15:10:00] <Hauskatze>	 Seddon: both banners look okay to me now
[15:27:20] <Seddon>	 Hauskatze: Sorry, my computer died on me
[15:27:36] <Hauskatze>	 Seddon: np
[15:28:03] <Hauskatze>	 the banners looked okay to me, so I went ahead and enabled the campaign
[15:28:09] <Seddon>	 Hauskatze: Mainly cause I'd filled my main drive with multiple copies of the total collection of ST:TNG on bluray at 1080p
[15:28:24] <Hauskatze>	 feel free to make any adjustements you wish
[15:28:24] <Seddon>	 Don't ask why I had multiple copies
[15:28:29] <Seddon>	 Will do
[15:28:30] <Hauskatze>	 ST:TNG?
[15:28:44] <Seddon>	 Hauskatze: Star Trek The Next Generation
[15:28:47] <Hauskatze>	 ah
[15:29:05] <Hauskatze>	 Sorry, I don't watch much TV
[15:29:10] <Hauskatze>	 I prefer the radio
[15:30:22] <Hauskatze>	 Seddon: service: https://meta.wikimedia.org/wiki/CentralNotice/Request/Wikivacaciones_2018
[15:30:29] <Hauskatze>	 campaign and banner links are there
[15:30:36] <Hauskatze>	 I hope all is okay
[15:30:54] <Hauskatze>	 like I said, I find CN a bit complex and rough for me :)
[15:34:35] <Seddon>	 Hauskatze: Any time you want any training I'd be more than happy to provide
[15:35:52] <Hauskatze>	 Seddon: that'd be good, we should find a time slot that is okay for both of us. Until Christmas I won't have much time though, and even then family, etc...
[15:36:03] <Seddon>	 Hauskatze: Jan?
[15:36:30] <Hauskatze>	 Usually lot of work after the hollidays in Jan
[15:36:33] <Hauskatze>	 we'll see
[15:36:50] <Hauskatze>	 Each time I finish setting up a campaign I get nervous
[15:37:05] <Seddon>	 Hauskatze: That doesn't go away for a very long time
[15:37:08] <Hauskatze>	 Displaying banners to millions of people... still not very used :)
[15:37:12] <Seddon>	 Hauskatze: I still get nerves
[15:37:31] <Seddon>	 Hauskatze: and to be honest, its a good thing.
[15:38:05] <Hauskatze>	 Sure. I mean, otherwise it'd be a bit reckless I reckon
[15:38:41] <Hauskatze>	 got to leave
[15:38:45] <Hauskatze>	 need a little rest