[00:06:38] (CR) Jgleeson: "I can't recreate this issue locally :S" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/478257 (https://phabricator.wikimedia.org/T210983) (owner: Ejegg) [00:16:40] jgleeson_: So if the issue is just the double-protection on initial creation, I can fix that in a different way [00:17:00] ah ok [00:17:05] cool [00:17:42] There's already code in WikiPage::doUpdateRestrictions to short-circuit when the protections are already what they should be [00:18:00] which made me wonder why we had to do anything for this ticket [00:18:23] but I'm guessing it's because we're saving & protecting the same page twice in the same submit [00:18:44] the protections haven't made it down to the db yet or something by the time we try to protect it the second time [00:19:25] and that new patch is doing the same checks, so it wouldn't have helped. [00:20:02] I guess I'll keep some static state in the Banner class with a list of titles we've already protected [00:20:21] unless there's a better place in mediawiki to stash statics during a process [00:26:55] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice protects CentralNotice templates endlessly each time a template is e... - https://phabricator.wikimedia.org/T210983 [00:42:57] (PS4) Jgleeson: RESTORE Handle invalid GC SET_PAYMENT response and fix some xml formatting issues in stub responses. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/478229 (https://phabricator.wikimedia.org/T203126) [14:48:17] (PS5) Jgleeson: RESTORE Handle invalid GC SET_PAYMENT response and fix some xml formatting issues in stub responses. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/478229 (https://phabricator.wikimedia.org/T203126) [16:30:39] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, and 2... - https://phabricator.wikimedia.org/T178930 [16:35:57] Fundraising-Backlog, FR-PayPal-ExpressCheckout, FR-failmail: Is PayPal EC orphan rectifier unable to deal with recurring? - https://phabricator.wikimedia.org/T211988 (Ejegg) [16:57:26] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice protects CentralNotice templates endlessly each time a template is e... - https://phabricator.wikimedia.org/T210983 [16:58:09] ejegg: thanks for the review on the cn analytics! [16:58:28] AndyRussG: thanks for the work - super handy tool! [17:10:29] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice protects CentralNotice templates endlessly each time a template is e... - https://phabricator.wikimedia.org/T210983 [17:35:43] (CR) Ejegg: [C: -1] "Rethinking the problem, this probably won't solve it" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/478257 (https://phabricator.wikimedia.org/T210983) (owner: Ejegg) [17:42:05] (PS1) Esanders: build: Update eslint and stylelint configs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/479731 [17:45:21] (CR) jerkins-bot: [V: -1] build: Update eslint and stylelint configs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/479731 (owner: Esanders) [18:06:44] jgleeson: here's the beta cluster link for CN admin: https://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNotice [18:07:14] thanks AndyRussG! [18:11:12] ejegg, looks like my password reset email hasn't arrived either. I tried resetting with my email at first and it gives you the "if you have an account, you get will a link" test and then I figured out my account name and tried to reset with that and got the "A password reset email has already been sent, within the last 24 hours. To prevent abuse, only one password reset email will be sent per 24 hours." notice so I guess the [18:11:13] first attempt worked but nothing has arrived since doing it. [18:12:12] dang! I think we can run pw reset scripts via command-line, just got to remember how to do that [18:16:15] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: currency mismatch between Ingenico Connect & Civi - https://phabricator.wikimedia.org/T211024 (DStrine) [18:16:38] Fundraising-Backlog, Fr-Ingenico-integration_2017-18: currency mismatch between Ingenico Connect & Civi - https://phabricator.wikimedia.org/T211024 (Ejegg) Guessing this is linked to T210473 [18:18:53] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Fr-Ingenico-integration_2017-18: currency mismatch between Ingenico Connect & Civi - https://phabricator.wikimedia.org/T211024 (DStrine) [18:31:57] jgleeson: i guess you're probably not yet on the VM project that runs the beta cluster? we should add you too--also, anyone in fr-tech who might need it? [18:32:22] maybe not? I couldn't say for sure AndyRussG [18:32:54] https://tools.wmflabs.org/openstack-browser/project/deployment-prep [18:33:10] jgleeson: basically you need to be able to ssh into labs [18:33:14] you might have that by default [18:33:32] https://wikitech.wikimedia.org/wiki/Help:Labs_labs_labs#Beta_Cluster [18:44:39] jgleeson: for example, here is how you should ssh into the beta cluster: ssh deployment-mediawiki-07.deployment-prep.eqiad.wmflabs [18:46:12] Here are some relevant sections of ssh config: [18:46:14] Host *.eqiad.wmflabs [18:46:16] ProxyCommand ssh -a -W %h:%p username@primary.bastion.wmflabs.org [18:46:18] Host *.wmflabs [18:46:20] User username [18:46:31] where username is the lower-case version of your wikitech/gerrit username, I think [18:57:38] thanks AndyRussG, I've copied all that down and will dig into it first thing Monday as I'm heading off now [18:58:10] have a great weekend fr-tech! [18:58:21] You too [20:00:47] (CR) XenoRyet: [C: +2] RESTORE Handle invalid GC SET_PAYMENT response and fix some xml formatting issues in stub responses. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/478229 (https://phabricator.wikimedia.org/T203126) (owner: Jgleeson) [20:02:18] (Merged) jenkins-bot: RESTORE Handle invalid GC SET_PAYMENT response and fix some xml formatting issues in stub responses. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/478229 (https://phabricator.wikimedia.org/T203126) (owner: Jgleeson) [20:25:58] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice protects CentralNotice templates endlessly each time a template is e... - https://phabricator.wikimedia.org/T210983 [21:37:22] fundraising-tech-ops, Operations, Patch-For-Review: rack/setup/install Prometeuse/Grafana host frmon2001 for fr-tech - https://phabricator.wikimedia.org/T196476 (RobH) As this is no longer awaiting any onsite work from #ops-codfw, I've removed it from the projects.