[00:09:12] (Merged) jenkins-bot: Reformat queue consumers with Civi / Drupal style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480100 (https://phabricator.wikimedia.org/T211846) (owner: Ejegg) [00:11:08] Fundraising Sprint XML ate my homework, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: GatewayFormChooser should geolocate when country is not in URL - https://phabricator.wikimedia.org/T211454 (Ejegg) p:Triage→Normal a:Cstone [00:11:24] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice protects CentralNotice templates endlessly each time a template is e... - https://phabricator.wikimedia.org/T210983 [00:54:13] fundraising-tech-ops: Closing donation banner breaks scrolling - https://phabricator.wikimedia.org/T212177 (Pythoncoder) [01:10:01] (PS1) Eileen: CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480282 [01:10:48] (CR) Eileen: "ejegg that submodule commit seems wrong - this is what I get https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/480282/" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480101 (https://phabricator.wikimedia.org/T211846) (owner: Ejegg) [01:18:13] (CR) Eileen: [C: +2] CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480282 (owner: Eileen) [01:23:21] (Merged) jenkins-bot: CiviCRM submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480282 (owner: Eileen) [02:53:49] (PS1) Legoktm: build: Set "root": true, in .eslintrc.json [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/480308 (https://phabricator.wikimedia.org/T206485) [02:54:01] (PS1) Eileen: Update Civi thank you letter for Endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480311 (https://phabricator.wikimedia.org/T211797) [02:54:05] (PS1) Eileen: Update contribution receipt for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480312 (https://phabricator.wikimedia.org/T211797) [02:55:22] (CR) jerkins-bot: [V: -1] Update Civi thank you letter for Endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480311 (https://phabricator.wikimedia.org/T211797) (owner: Eileen) [02:55:51] (PS2) Eileen: Update Civi thank you letter (offline_receipt_message) for Endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480311 (https://phabricator.wikimedia.org/T211797) [02:56:09] (Abandoned) Eileen: Update contribution receipt for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480312 (https://phabricator.wikimedia.org/T211797) (owner: Eileen) [02:59:44] (CR) Eileen: Update Civi thank you letter (offline_receipt_message) for Endowment (5 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480311 (https://phabricator.wikimedia.org/T211797) (owner: Eileen) [03:22:43] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make a copy of endowment thank you email in civi - https://phabricator.wikimedia.org/T211797 (Eileenmcnaughton) I've deployed an updated version on staging. Note - The value I have to c... [10:28:36] (CR) Jforrester: [C: +2] build: Set "root": true, in .eslintrc.json [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/480308 (https://phabricator.wikimedia.org/T206485) (owner: Legoktm) [10:33:42] (Merged) jenkins-bot: build: Set "root": true, in .eslintrc.json [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/480308 (https://phabricator.wikimedia.org/T206485) (owner: Legoktm) [10:40:43] (CR) jenkins-bot: build: Set "root": true, in .eslintrc.json [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/480308 (https://phabricator.wikimedia.org/T206485) (owner: Legoktm) [12:07:22] (PS2) Esanders: build: Update eslint and stylelint configs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/479731 [14:58:42] (CR) Mepps: [C: +1] "This looks good to me but I'm finding the larger function hard to follow. It might be worth breaking up in the future for clarity. Jgleeso" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/480116 (https://phabricator.wikimedia.org/T209294) (owner: Ejegg) [15:07:40] (CR) Ejegg: "Good call - does breaking out those if clauses into an 'donation_exists' function sound good?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/480116 (https://phabricator.wikimedia.org/T209294) (owner: Ejegg) [15:15:10] (PS1) Ejegg: PayPal audit: break up giant function a bit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/480508 [15:15:37] ok mepps, there's a slight de-bloating of parse_line ^^^ [15:15:45] could still stand to slim down more [15:16:06] that was so fast ejegg! [15:16:29] heh, pretty trivial refactor [15:16:48] (CR) Mepps: [C: +2] "Definitely a good start! Now I understand what it's checking for :)." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/480508 (owner: Ejegg) [15:17:50] (CR) Mepps: [C: +1] "Question, if it doesn't send would the recurring contribution still be recorded? (That's what I'm assuming we're parsing here.)" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/480116 (https://phabricator.wikimedia.org/T209294) (owner: Ejegg) [15:19:35] ejegg did you see my question? sorry if it's obvious and i'm missing it [15:19:43] otherwise, i'm good to +2 [15:20:57] (CR) Ejegg: "Yes, that 'self.crm.transaction_exists' is querying the civicrm database to see if the donation already came in on the listener." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/480116 (https://phabricator.wikimedia.org/T209294) (owner: Ejegg) [15:24:45] (CR) Mepps: [C: +2] "Ah, duh, I was thinking about the subscription ID, and got it confused." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/480116 (https://phabricator.wikimedia.org/T209294) (owner: Ejegg) [15:26:17] self.crm = civicrm.civicrm.Civicrm(self.config.civicrm_db) [15:26:34] some repetition there :P [15:27:14] (Merged) jenkins-bot: PayPal audit: avoid duplicating I- legacy subscriptions [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/480116 (https://phabricator.wikimedia.org/T209294) (owner: Ejegg) [15:27:18] (Merged) jenkins-bot: PayPal audit: break up giant function a bit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/480508 (owner: Ejegg) [15:27:20] (PS2) Mepps: Guard for unset ip_address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480095 (owner: Ejegg) [15:27:22] (CR) Mepps: [C: +2] "Pretty straightforward." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480095 (owner: Ejegg) [15:27:51] mepps, I caught your comment and I also thought it looked good enough for the +2 [15:27:52] jgleeson, gotta confirm which crm it is, huh? [15:28:00] yup haha [15:28:12] you mean it's not sugarcrm, after all this time ?!?!?! [15:28:16] :~) [15:28:18] :P [15:28:20] mind blown [15:30:38] (Merged) jenkins-bot: Guard for unset ip_address [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480095 (owner: Ejegg) [15:32:48] (CR) Ejegg: [C: +1] "This looks great, just needs one tweak to the update SQL. Also, we should make sure DS knows they'll need to change the from name in the d" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480311 (https://phabricator.wikimedia.org/T211797) (owner: Eileen) [15:33:15] fr-tech ^^^ just needs a tiny tweak - if I upload a new PS can someone crosscheck for the +2 ? [15:33:42] sure ejegg [15:34:08] (PS3) Ejegg: Update Civi thank you letter (offline_receipt_message) for Endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480311 (https://phabricator.wikimedia.org/T211797) (owner: Eileen) [15:34:21] thanks mepps! there's the tweak ^^ [15:36:00] ok, I'mma deploy that paypal audit fix and look at which existing duplicates need deleting [15:36:41] oh, lemme rebase that eileen patch on top of the ip_address guard [15:37:01] (PS4) Ejegg: Update Civi thank you letter (offline_receipt_message) for Endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480311 (https://phabricator.wikimedia.org/T211797) (owner: Eileen) [15:38:50] ejegg how is this working exactly, we no longer have another offline receipt? i'm sorry i don't know the history of the offline receipt [15:39:22] oh sorry i see the logic now [15:40:15] ah yeah, like the automatic TY letter, they're both in the same template [15:42:03] (CR) Mepps: "Mostly looks okay, one question." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480311 (https://phabricator.wikimedia.org/T211797) (owner: Eileen) [15:55:49] ejegg i had one question ^^ [15:57:02] mepps see eileen's comment on PS2 [15:57:18] she explained a bunch on that PS [15:57:37] (CR) Mepps: [C: +2] "Okay I see that comment now." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480311 (https://phabricator.wikimedia.org/T211797) (owner: Eileen) [16:00:19] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/480528 [16:00:25] (CR) Ejegg: [C: +2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/480528 (owner: Ejegg) [16:00:49] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/480528 (owner: Ejegg) [16:02:21] (Merged) jenkins-bot: Update Civi thank you letter (offline_receipt_message) for Endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480311 (https://phabricator.wikimedia.org/T211797) (owner: Eileen) [16:05:51] !log updated fundraising python tools from af5dbee8eb to 5f44d9dd43 [16:05:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:07:20] gonna pop out for a bit, back soon [16:42:00] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make a copy of endowment thank you email in civi - https://phabricator.wikimedia.org/T211797 (DStrine) @kaythaney and @MBeat33 [16:44:19] Fundraising-Backlog, fundraising-tech-ops: Fundraising cluster access for Christine Stone - https://phabricator.wikimedia.org/T211060 (cwdent) c917cff add cstone mysql grants [16:44:56] Fundraising-Backlog, fundraising-tech-ops: Fundraising cluster access for Christine Stone - https://phabricator.wikimedia.org/T211060 (cwdent) Open→Resolved @cstone has logged in to everything [16:48:24] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make a copy of endowment thank you email in civi - https://phabricator.wikimedia.org/T211797 (kaythaney) These look good to go on my end. Big thanks, all! [16:59:52] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make a copy of endowment thank you email in civi - https://phabricator.wikimedia.org/T211797 (MBeat33) Can we modify the SL wording so that Endowment & non-Endowment TYs are distinguishab... [16:59:54] (PS1) Ejegg: PayPal audit: stop shadowing 'queue' from outer scope [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/480538 [17:10:00] (PS2) Ejegg: Unsub QC: guard against unset, throw WmfException [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480101 (https://phabricator.wikimedia.org/T211846) [17:11:37] (CR) Ejegg: "Oops, sorry bout that. Removed the submodule commit." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480101 (https://phabricator.wikimedia.org/T211846) (owner: Ejegg) [17:54:16] Fundraising-Backlog, Analytics, Analytics-Kanban, User-Elukey: Return to real time banner impressions in Druid - https://phabricator.wikimedia.org/T203669 (DStrine) [19:00:20] cstone we've been trying to document the most common failmail here: https://www.mediawiki.org/w/index.php?title=Fundraising_tech/Failmail_zoo [19:06:46] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make a copy of endowment thank you email in civi - https://phabricator.wikimedia.org/T211797 (CCogdill_WMF) Hey there! It looks to me like the original small dollar TY email subject line... [19:12:00] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make a copy of endowment thank you email in civi - https://phabricator.wikimedia.org/T211797 (Ejegg) Hi @CCogdill_WMF , @Eileenmcnaughton had a comment on the subject line in the latest p... [19:15:21] Fundraising Sprint XML ate my homework, Fundraising-Backlog, FR-Ingenico: possible text edit to new ingenico form error message - https://phabricator.wikimedia.org/T212168 (Ejegg) [19:15:57] Fundraising Sprint XML ate my homework, Fundraising-Backlog, FR-Ingenico: possible text edit to new ingenico form error message - https://phabricator.wikimedia.org/T212168 (Ejegg) Open→Resolved a:Ejegg [19:23:26] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make a copy of endowment thank you email in civi - https://phabricator.wikimedia.org/T211797 (CCogdill_WMF) Ah, sorry I missed that bit. Legal approved the following Endowment SL, which... [19:25:31] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make a copy of endowment thank you email in civi - https://phabricator.wikimedia.org/T211797 (MBeat33) forever = endowment only works! [19:42:57] (CR) XenoRyet: [C: +2] Unsub QC: guard against unset, throw WmfException [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480101 (https://phabricator.wikimedia.org/T211846) (owner: Ejegg) [19:47:50] (Merged) jenkins-bot: Unsub QC: guard against unset, throw WmfException [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480101 (https://phabricator.wikimedia.org/T211846) (owner: Ejegg) [20:04:27] relocating... [20:44:02] Fundraising-Backlog, fundraising-tech-ops: Create icinga alert for connectivity to Ingenico Connect endpoint - https://phabricator.wikimedia.org/T212252 (Ejegg) [20:45:29] Fundraising-Backlog, fundraising-tech-ops: Create icinga alert for connectivity to Ingenico Connect endpoint - https://phabricator.wikimedia.org/T212252 (cwdent) Does this mean fr-tech wants to get paged by icinga? [20:46:13] Fundraising-Backlog, fundraising-tech-ops: Create icinga alert for connectivity to Ingenico Connect endpoint - https://phabricator.wikimedia.org/T212252 (cwdent) There are a couple related tickets here: https://phabricator.wikimedia.org/T202419 [20:46:25] Fundraising-Backlog, fundraising-tech-ops: Create icinga alert for connectivity to Ingenico Connect endpoint - https://phabricator.wikimedia.org/T212252 (Ejegg) I just added the icinga pattern to the things that make a notification on my phone, at least! [20:47:38] Fundraising-Backlog, Analytics: Identify source of discrepancy between HUE query in Count of event.impression and druid queries via turnilo/superset - https://phabricator.wikimedia.org/T204396 (DStrine) Quick update here. We are still using the older pipeline for this season so this is not affecting us a... [20:47:46] Fundraising-Backlog, Analytics: Identify source of discrepancy between HUE query in Count of event.impression and druid queries via turnilo/superset - https://phabricator.wikimedia.org/T204396 (DStrine) p:High→Normal [20:47:56] Fundraising-Backlog, Analytics, Analytics-Kanban, User-Elukey: Return to real time banner impressions in Druid - https://phabricator.wikimedia.org/T203669 (DStrine) p:High→Normal [20:49:27] (PS1) Ejegg: Fix Exception in namespaced class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480586 [20:49:41] Fundraising-Backlog, fundraising-tech-ops: Create icinga alert for connectivity to Ingenico Connect endpoint - https://phabricator.wikimedia.org/T212252 (cwdent) While currently tech can see the alerts in IRC, Jeff and I get SMS about it, which means dropping what you are doing, getting out of bed, etc.... [20:49:53] Fundraising-Backlog, Analytics: Identify source of discrepancy between HUE query in Count of event.impression and druid queries via turnilo/superset - https://phabricator.wikimedia.org/T204396 (Nuria) @DStrine can you clarify what is the old pipeline? [20:52:41] Fundraising-Backlog, Analytics, Analytics-Kanban, User-Elukey: Return to real time banner impressions in Druid - https://phabricator.wikimedia.org/T203669 (DStrine) This has not been mission critical for us. Fr-tech will get back to this in the new year. [20:56:34] (CR) XenoRyet: [C: +2] Fix Exception in namespaced class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480586 (owner: Ejegg) [21:01:16] (Merged) jenkins-bot: Fix Exception in namespaced class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480586 (owner: Ejegg) [21:11:54] Fundraising-Backlog, Analytics: Identify source of discrepancy between HUE query in Count of event.impression and druid queries via turnilo/superset - https://phabricator.wikimedia.org/T204396 (DStrine) Kafkatee @AndyRussG assures us this would not have impacted our campaign stats. [21:50:08] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make a copy of endowment thank you email in civi - https://phabricator.wikimedia.org/T211797 (MBeat33) * Will there be an endowment@ option in the dropdown for sender? * Will Civi know to... [22:49:30] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make a copy of endowment thank you email in civi - https://phabricator.wikimedia.org/T211797 (Eileenmcnaughton) @MBeat33 1) I just added a from drop down option - please check 2) Yes, it... [22:52:54] (PS1) Eileen: Add 'forever' to subject line for endowment emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480667 (https://phabricator.wikimedia.org/T211797) [22:53:27] ejegg: adding ‘forever’ worked - the issue with $amount is that we do some in-template variable interpretaion for that & currency [22:53:34] ^^ [22:54:01] (CR) jerkins-bot: [V: -1] Add 'forever' to subject line for endowment emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480667 (https://phabricator.wikimedia.org/T211797) (owner: Eileen) [22:58:01] Fundraising Sprint XML ate my homework, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Make a copy of endowment thank you email in civi - https://phabricator.wikimedia.org/T211797 (Eileenmcnaughton) Ok - fix to subject in review [23:00:02] (PS2) Eileen: Add 'forever' to subject line for endowment emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/480667 (https://phabricator.wikimedia.org/T211797) [23:07:55] eileen: oho, nice! [23:37:14] Fundraising-Backlog, Analytics, Analytics-Kanban, User-Elukey: Return to real time banner impressions in Druid - https://phabricator.wikimedia.org/T203669 (Nuria) I see, @DStrine and @AndyRussG next time around let's please make clear on ticket this is not critical/important, we assumed it was... [23:45:47] Fundraising-Backlog, Analytics, Analytics-Kanban, User-Elukey: Return to real time banner impressions in Druid - https://phabricator.wikimedia.org/T203669 (Nuria) @JAllemandou can we keep the code to initiate the real time ingestion in the refinery repo? I think we just need a bit of documentatio... [23:51:32] Fundraising Sprint Ivory and eggshell white are the same color, Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, Patch-For-Review: Adapt Druid banenr_activity jobs to EventLogging-based impression recording - https://phabricator.wikimedia.org/T186048 (Nuria) Seems to me this work is...